- 05 Mar, 2015 10 commits
-
-
hubbe authored
This adds javascript bindings for the functions in cast_receiver_session, allowing a cast_receiver to be initiated from a whitelisted javascript extension. Also fixes a crashing bug in udp_transport.cc. Review URL: https://codereview.chromium.org/938903003 Cr-Commit-Position: refs/heads/master@{#319175}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/ceac7ed..ce370d0 TBR=samli@chromium.org,aboxhall@chromium.org,dpranke@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/981703003 Cr-Commit-Position: refs/heads/master@{#319174}
-
rkaplow authored
Followed a local Linux machine which was slower than expected to where the time was going. Stopped at the ExtensionManagement::Refresh level, and will measure if this is general slow. BUG=454789 Review URL: https://codereview.chromium.org/977673002 Cr-Commit-Position: refs/heads/master@{#319173}
-
lukasza authored
This verifies that we detect and report misspelled policy names regardless of whether "RemoteAccessHost" appears as a prefix, suffix or a substring. I felt adding this test is important to "document" the behavior asked about in https://codereview.chromium.org/966433002/diff/120001/remoting/host/policy_watcher.cc#newcode109 The new test verifies expected behavior via MockLog class moved to base/test in crrev.com/966423003. I feel that the benefit of documenting and automatically verifying the expected behavior outweights the small maintenence cost of an additional test and the slight ickyness of verifying the behavior by looking at log output. BUG= Review URL: https://codereview.chromium.org/979823004 Cr-Commit-Position: refs/heads/master@{#319172}
-
xhwang authored
Revert of Adding Maps page to page_sets for telemetry. (patchset #7 id:310001 of https://codereview.chromium.org/955653003/) Reason for revert: Failed tests in drag_unittest.py: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests&number=3803 Original issue's description: > Adding Maps page to page_sets for telemetry. > > This CL adds google maps page to telemetry, and runs a synthetic drag > gesture on the page. This helps testing of maps page in telemetry to > track the performance on desktop chrome. > > BUG=457148 > > Committed: https://crrev.com/f502701b2bcc43c05d82e5780b2d6cf2d326bc23 > Cr-Commit-Position: refs/heads/master@{#319135} TBR=skyostil@chromium.org,picksi@chromium.org,petrcermak@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457148 Review URL: https://codereview.chromium.org/982683003 Cr-Commit-Position: refs/heads/master@{#319171}
-
jvoung authored
Otherwise, after transferring ownership the old base_file will always be invalid and we get spurious error logs, which can be confusing. This started happening after the refactoring in r274783. https://codereview.chromium.org/307173002/diff/80001/components/nacl/renderer/pnacl_translation_resource_host.cc Alternatively, could have checked the file_handle variable that ends up owning the base_file at the later point, but might as well check it earlier. BUG=none (but it bugged ncbray =)) Review URL: https://codereview.chromium.org/982663002 Cr-Commit-Position: refs/heads/master@{#319170}
-
mostynb authored
PepperVideoCaptureHost::OnFrameReady makes use of kUnknownFrameRate which was previously only included in webrtc builds. Let's move these constants to the header file instead, since it can be included in both webrtc and non-webrtc builds. Followup to https://codereview.chromium.org/955253002. BUG=461116,463829 Review URL: https://codereview.chromium.org/973373002 Cr-Commit-Position: refs/heads/master@{#319169}
-
tnagel authored
BUG=none Review URL: https://codereview.chromium.org/948803004 Cr-Commit-Position: refs/heads/master@{#319168}
-
aconverse authored
VP9's tile encoding feature allows for multithreaded parallelism on both the encoder and decoder side. TEST=Run remoting_perftests under VTune and see that two logical CPUs are used BUG=134202 Review URL: https://codereview.chromium.org/977663004 Cr-Commit-Position: refs/heads/master@{#319167}
-
oshima authored
* Removed AdjustStringDirection() * Removed FORCE_XXXX_DIRECTIONALITY and replace with TEXT_ALIGN_TO_HEAD. This is necessary not to use Canvas::DefaultCanvasTextAlignment for labels. * Also removed the safe guard in SizeStringFloat because RenderTextWin has been removed. BUG=None TEST=No functional change. Removed LabelTest, DirectionalityFromText that no longer makes sense. R=msw@chromium.org Review URL: https://codereview.chromium.org/953093003 Cr-Commit-Position: refs/heads/master@{#319166}
-
- 04 Mar, 2015 30 commits
-
-
anandc authored
BUG= Review URL: https://codereview.chromium.org/963723003 Cr-Commit-Position: refs/heads/master@{#319165}
-
felt authored
This ensures that both infobars and bubbles are tested by creating both DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is forced with a switch. BUG=438758 Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 Cr-Commit-Position: refs/heads/master@{#318987} Review URL: https://codereview.chromium.org/976823002 Cr-Commit-Position: refs/heads/master@{#319164}
-
rpaquay authored
BUG=358315 NOTRY=true Review URL: https://codereview.chromium.org/978053002 Cr-Commit-Position: refs/heads/master@{#319163}
-
jdduke authored
When a Java-based WebContents instance is destroyed, it may yet have Java-based WebContentsObserver instances. Previously, these instances would always see a destroy (formerly detach) call, as they each had a native counterpart. With the introduction of the proxy WebContentsObserver, destroy was not always called, as the remaining observers were simply cleared from the observer list. Explicitly call WebContentsObserver.destroy for these dangling instances, ensuring proper cleanup. BUG=464076 Review URL: https://codereview.chromium.org/981703002 Cr-Commit-Position: refs/heads/master@{#319162}
-
erikchen authored
Previously, an intermediary exception InspectorException was generated. This was caught and then converted into a more common Telemetry exception. Now the connection failure throws a standard Telemetry exception directly. BUG=460625 Review URL: https://codereview.chromium.org/955263003 Cr-Commit-Position: refs/heads/master@{#319161}
-
dnicoara authored
Simplify code by removing an interface only used in testing. BUG=none Review URL: https://codereview.chromium.org/981583005 Cr-Commit-Position: refs/heads/master@{#319160}
-
jvoung authored
Remove a couple unused fwd declarations and make a Getter const while I'm messing with that file. BUG=none Review URL: https://codereview.chromium.org/977893003 Cr-Commit-Position: refs/heads/master@{#319159}
-
aurimas authored
- Suppress missing drawables in components/web_contents_delegate_android/ - Remove unused progress_bar.xml BUG=266140 Review URL: https://codereview.chromium.org/971223004 Cr-Commit-Position: refs/heads/master@{#319158}
-
erikchen authored
Each location that catches AppCrashException does not actually want to know if the app crashed. Rather, the code wants to know if there was an error performing an operation. I've updated teh code to catch the more general Exception. BUG=460625 Review URL: https://codereview.chromium.org/969503002 Cr-Commit-Position: refs/heads/master@{#319157}
-
rockot authored
Also adjusts cron runtime to 180 minutes. It's been at 240 on the live instance for a while but was never committed that way. Refresh cycles are taking less time now, so dropping down to 180. R=kalman@chromium.org NOTRY=True BUG=None Review URL: https://codereview.chromium.org/977213002 Cr-Commit-Position: refs/heads/master@{#319156}
-
eakuefner authored
This change adds a field called interaction_record to values, which will specify the label of the interaction_record with which the value is associated, if it was generated by TimelineBasedMeasurement. R=nednguyen,dtu BUG=461101 Review URL: https://codereview.chromium.org/963313002 Cr-Commit-Position: refs/heads/master@{#319155}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/4e644f5..82b33db CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/975353004 Cr-Commit-Position: refs/heads/master@{#319154}
-
jackhou authored
Test coverage is provided by native_app_window_cocoa_browsertest.mm which now uses whichever implementation of NativeAppWindow is instantiated. Added a new sources list to minimize having to change BUILD.gn when more files are added. BUG=459877 Review URL: https://codereview.chromium.org/975043003 Cr-Commit-Position: refs/heads/master@{#319153}
-
ppi authored
This patch uses the unified JNI_OnLoad mechanism introduced in http://crbug.com/447393 in mojo network service. BUG=447393 Review URL: https://codereview.chromium.org/977843003 Cr-Commit-Position: refs/heads/master@{#319152}
-
jamiewalch authored
BUG=464020 Review URL: https://codereview.chromium.org/968193006 Cr-Commit-Position: refs/heads/master@{#319151}
-
lfg authored
Review URL: https://codereview.chromium.org/921793004 Cr-Commit-Position: refs/heads/master@{#319150}
-
tommi authored
WebRTC 8573:8602 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/c9dfd1c..f30d5ec Libjingle 8571:8600 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3b22f07..8fe2b96 TBR=sergeyu@chromium.org,magjed@chromium.org Review URL: https://codereview.chromium.org/970513005 Cr-Commit-Position: refs/heads/master@{#319149}
-
dnicoara authored
ui::OzoneGpuTestHelper needs to be uninstantiated in TearDown() since it creates a base::Thread which wants to register with the AtExitManager. However the AtExitManager runs out of scope before the testing::Environment. BUG=447798 TEST=compile and run ./video_decode_accelerator_unittest (I had https://codereview.chromium.org/938873002/ applied as well to make sure tests succeed) Review URL: https://codereview.chromium.org/949183004 Cr-Commit-Position: refs/heads/master@{#319148}
-
michaelbai authored
content_app_browser and content_app_child are designed to be used for Windows DLL, for android we build browser and child process in same shared library, content_app_both should be used in Android. BUG=464008 TBR=jochen Review URL: https://codereview.chromium.org/970413002 Cr-Commit-Position: refs/heads/master@{#319147}
-
weiliangc authored
Take |draw_rect|'s coordinates and |BitmapData|'s point into consideration in |FakeContentClientLayerClient| paint into DisplayList. R=ajuma BUG= Review URL: https://codereview.chromium.org/984443002 Cr-Commit-Position: refs/heads/master@{#319146}
-
jrummell authored
WebMediaKeySystemConfiguration is changing to use enums for initDataTypes and sessionTypes, so update WebEncryptedMediaClientImpl to use the enums. BUG=418239 TEST=EME tests still pass Review URL: https://codereview.chromium.org/979463002 Cr-Commit-Position: refs/heads/master@{#319145}
-
limasdf authored
R=kalman@chromium.org BUG=354046 TEST=extensions_unittests Review URL: https://codereview.chromium.org/977763002 Cr-Commit-Position: refs/heads/master@{#319144}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/970943003 Cr-Commit-Position: refs/heads/master@{#319143}
-
andresantoso authored
EventFromNative() returns null when given a system defined event, so filter them out when monitoring the event stream. When running the experimental MacViews browser, I was seeing an event with type=SysDefined subtype=7 (apparently it means that a mouse button state has changed). BUG=425229 Review URL: https://codereview.chromium.org/981693002 Cr-Commit-Position: refs/heads/master@{#319142}
-
sigbjornf authored
For the select few times an overriding "operator new" is needed for a GC class, provide the GC_PLUGIN_IGNORE() escape hatch for these. The responsibility that the "new"'s allocation will be on the Oilpan heap, rests with the implementor of the class. R=haraken BUG=443854 Review URL: https://codereview.chromium.org/975393002 Cr-Commit-Position: refs/heads/master@{#319141}
-
slamm authored
Make discarding the first result possible through Benchmark.ValueCanBeAddedPredicate (add a "is_first_result" arg to it). The main motivation here is to eliminate special cases for PageTest methods/attributes in user_story_runner.Run. BUG=440101 Review URL: https://codereview.chromium.org/962793004 Cr-Commit-Position: refs/heads/master@{#319140}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/235b088..ceac7ed TBR=samli@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/980533003 Cr-Commit-Position: refs/heads/master@{#319139}
-
alemate authored
This CL adds CaptivePortalAuthenticationIgnoresProxy policy. BUG=456839 TEST=manual Review URL: https://codereview.chromium.org/818433003 Cr-Commit-Position: refs/heads/master@{#319138}
-
tfarina authored
This was generated using the following command line: $ tools/sort_sources.py tools/gn/gn.gyp BUG=None R=scottmg@chromium.org Review URL: https://codereview.chromium.org/977603002 Cr-Commit-Position: refs/heads/master@{#319137}
-
jbudorick authored
It doesn't build in gyp configurations, either: https://code.google.com/p/chromium/codesearch#chromium/src/build/all.gyp&l=342 TBR=brettw@chromium.org BUG=464031 Review URL: https://codereview.chromium.org/979973002 Cr-Commit-Position: refs/heads/master@{#319136}
-