- 27 Oct, 2020 40 commits
-
-
Collin Baker authored
Bug: 1133016 Change-Id: Ia40222beff775014959a6b52ce25ef36893d713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503816Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#821502}
-
Christopher Lam authored
Bug: None Change-Id: I231f11b9c2ac392473d6ef837fafdc12a8be7478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497902Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821501}
-
S. Ganesh authored
* Added support to prefix replacement guids with a fixed 'PLACEHOLDER-GUID-' string in the template file. This makes it easier to see the GUIDs that are being replaced. * Added support to regenerate the checked-in IDL files with the replaceable guids. This is needed when the IDL template changes and the checked-in IDL files need to be refreshed. Bug: 1109612 Change-Id: Ie113d2504c1a44f408641e34422bb081733a7458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495396Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821500}
-
Toni Barzic authored
The original cl was reverted due to test failures on dbg build (CL:2500688) - landed CL:2503628 to address the failures. Introduces a concept of partially initialized HoldingSpaceItem - this state will be used when loading items from persistent storage in case the item file system URL cannot immediately be resolved (e.g. if the associated mount point hasn't been loaded yet). HoldingSpacePersistenceDelegate will deserialize persisted items into partial state when they are first loaded from the storage, and "finalize" them when their file system URL can be resolved. Compared to an alternative approach where items whose initialization has to be deferred, this approach keeps the order in which items are added to the model. Updates holding space UI not to show partially initialized items. BUG=1140150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Original-Commit-Position: refs/heads/master@{#821024} Change-Id: I53bf0140a92e702a9baf59fd0a8be4739973a182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504070 Cr-Commit-Position: refs/heads/master@{#821499}
-
Isuru Pathirana authored
This CL updates the VideoCaptureDeviceMFWin/VideoCaptureDeviceFactoryWin implementations to use an NV12 output buffer format when MF D3D11 capture is enabled (for zero-copy capture). This requires ensuring that the input media type set on the Media Foundation CaptureEngine preview sink is NV12. In order to do this, we: 1. Expose PIXEL_FORMAT_NV12 as the sole supported capture pixel format from VideoCaptureDeviceFactoryWin::GetSupportedFormatsMediaFoundation when hardware capture is enabled. 2. Ensure that the VideoCaptureDeviceMFWin implementation sets an MF subtype of MFVideoFormat_NV12 on the video capture preview sink when the requested capture pixel format is PIXEL_FORMAT_NV12. This CL also makes some other minor changes to helpers in video_capture_system_impl.cc and capability_list_win.cc to prevent the NV12 pixel format from being filtered out before reaching the VideoCaptureDeviceMFWin implementation. Change-Id: Ie9bb7c9ef35281b4edecb3007f16faae2a892ac7 Bug: 1120900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434924 Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#821498}
-
Weiliang Chen authored
In order for OutputSurface and OverlayProcessor to work together, they need to share the same memory and task controller. This CL uses the same data structure for Android WebView to share these controls, so that WebView could use this to enable overlay in the future. R=boliu, rjkroege TBR=vollick@chromium.org Bug: 1093440 Change-Id: I2bcefe178906ede25dc0b962448e2ba6168128a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450494 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#821497}
-
Kartik Hegde authored
crrev.com/c/2490252 adds new portal states when the connection state is kPortal. Integrate these new states into this routine. BUG=chromium:956783 TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.* Change-Id: I181127d60179e1439a1fb39a9bc5994ee631c871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499623Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#821496}
-
Fergal Daly authored
Also fix 1 test to make it pass. I expect most of these were fixed by the proactive browsing instance swap work, although NavigationControllerBrowserTest.NoHistoryOnNavigationToSameUrl is a bit of a puzzle. There is still another reload failure remaining. Bug: 1102358,1100745,1068965,1064944 Change-Id: I0026f32f7f0ab6a3d75466b53a5815d8bff5facd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494244 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821495}
-
chinsenj authored
Currently overview can create overview items for transient children of the browser. This can cause bugs where if the transient child is destroyed, its respective overview item is as well. This leaves the transient root of this child without an overview item, resulting in this bug. This CL makes it so overview uses the transient roots of any transient child returned by BuildMruWindowList() to create overview items. It also prevents MessageBoxDialog from closing if it deactivates but is being shown in overview. Test: manual + added Bug: 972015 Change-Id: I90b2f94528a4a695a784fd5a1596111dc0103021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495642 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821494}
-
Regan Hsu authored
TetherControllerImpl will now mark the tether feature ineligible if it is notified by the PhoneModel that the SIM state has changed to anything other than kSimWithReception. Fixed: 1140812 Bug: 1106937 Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821493}
-
Karthika Pai authored
This CL moves two helper functions that extracts IDs and creates trials and associate IDs into their own file. Bug: 1134444 Change-Id: I056871f2245ba3e9c72a05ffd019f2e96499a45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500434 Commit-Queue: Karthika Pai <karthikapai@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#821492}
-
Jesse Schettler authored
Add support for passing in a progress callback to LorgnetteScannerManager::Scan(). This allows clients to receive progress updates for in-progress scan jobs. Bug: 1059779 Change-Id: Ib787c925fbd8033f85e349cb9387168306cd83e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503313Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
Context: RemoteFrame’s mojo interfaces should be associated with per-AgentSchedulingGroup task runners instead of per-thread task runners. What this CL does: Use per-AgentSchedulingGroup task runners for AgentSchedulingGroup’s mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: Ia4e2885163bb73a73e4a73d6459f37e68738e18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#821490}
-
Minoru Chikamune authored
Context: For MBI, per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for instead of per-thread task runners. Bug: 1105403, 1111231 Change-Id: I545fb445f2d52b85c49b01a9c160cc9050fa2cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501167Reviewed-by:
-
Minoru Chikamune authored
Context: Per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for BrowserInterfaceBrokerProxy’s mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I692cf7cc11af80e4b875f2d5b7492b44f58ef9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501170Reviewed-by:
-
Joel Riley authored
Also exposed in chrome://flags. Bug: 1142601 Change-Id: I0067a298e160510150dd793830a13837ccc083ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500261Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#821487}
-
Zhaoyang Li authored
Includes step by step instructions of writing a new test, talking with app from test, add new tests to suites, running tests. Bug: None Change-Id: I39124524fae4bc56c9f3fbe02bca7d9387bdfefb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503809 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Auto-Submit: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#821486}
-
Dana Fried authored
Modified behavior to avoid calling global function which changes arrow key behavior, rather than method which changes for current widget. Bug: 1140632 Original change's description: > Keyboard accessibility for extensions menu. > > This change switches the extensions menu to enable focus traversal at > the focus manager level, allowing both right/left and up/down key > traversal. > > It also removes > BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is > only used in one other place - in favor of > FocusManager::set_arrow_key_traversal_enabled(), which also supports > left/right arrows and pre-exists the bubble dialog method. > > These changes mean that when the scroll pane is active in either dialog, > up and down will scroll the pane but left and right arrow keys will > still allow the user to traverse the dialog (at least on Windows and > Linux; on Mac, up/down may still work within the pane). > > Bug: 1140632 > Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904 > Reviewed-by: Peter Bostrom <pbos@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820456} Change-Id: I3a877c6165f7c993f38ddcaee934ed7790888ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503988 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821485}
-
David Black authored
Previously showing holding space context menu via ChromeVox (which is performed via Search + M), we didn't update the holding space selection state. Now we do. Bug: 1142890 Change-Id: I65973be470cea22b582df4895d111eeab790ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504192Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821484}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia wasn't setting stream usage for the AudioRenderer. The usage is required by the system audio service to make correct audio policy decisions for the stream. This change updates AudioOutputStreamFuchsia to SetUsage() appropriately. Bug: 1065605 Change-Id: If96a9b0713b4acdff63035725b7322d1a5ad65a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500431 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821483}
-
Mikel Astiz authored
This addresses some leftovers of the old refactoring effort in https://codereview.chromium.org/2569333003. The unittest file is now renamed to match the name of the class under test, which is TitledUrlIndex. Some mechanical refactoring is included such that the unit-tests don't involve BookmarkModel, which is a higher-level layer. A few tests that actually do exercise the integration with BookmarkModel are now moved to BookmarkModelTest. Change-Id: Icf791ce0f88647c6305a4f460d2398cfb63bb155 Bug: 1129524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498544Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821482}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I24ce584ef282fdd31592d52e6131d381498b2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492668 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#821481}
-
Yulun Wu authored
Bug: 1142780 Change-Id: I853e483af89d2a4e20da42f7098bda54a842a745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503820Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821480}
-
Asanka Herath authored
I haven't touched this in a while and won't have the bandwidth to keep up with //net work. Bug: None Change-Id: If422a56713caa4ceb77ef28eb0c651061945813a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503584 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821479}
-
Eric Roman authored
Change-Id: I10db78da7491d05138e387f05f09789a5afe99a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503325Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821478}
-
Aaron Colwell authored
Unable to reproduce flakiness locally. Enabling tests and removing skip test logic for --site-per-process. Code was added to remove this flag in SetUpCommandLine() so the tests can run on all platforms. Bug: 1110497 Change-Id: I552f82d1fe4786e59cd624edf5504b713318d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500280Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes entires from manual-fields-to-ignore.txt that are already covered by the exclusions automatically generated by the rewriter tool. This CL was generated semi-automatically by running the rewriter and then: $ cat ~/scratch/automated-fields-to-ignore.txt | \ sed -e 's/#.*//g' | sed -e 's/ *$//g' | \ sort | uniq > ~/scratch/automated.txt $ ... same for ~/scratch/manual.txt $ comm -1 -2 ~/scratch/manual.txt ~/scratch/automated.txt \ > ~/scratch/redundant-fields-to-exclude.txt $ for i in `cat ~/scratch/redundant-fields-to-exclude.txt`; do \ cat tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt \ | grep -v "$i" > ~/scratch/tmp cp ~/scratch/tmp \ tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt done and then removing stranded comments. Bug: 1069567 Change-Id: Ifd976902da12637cb2698d39c72147135c0b6aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503324 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
Darren Shen authored
This reverts commit 31c7133d. Reason for revert: Suspecting as cause of failure in https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60360 Apologies if it's an incorrect revert, I will reland your CL if it's not the culprit. Original change's description: > Updater: Implement candidate self-uninstall. > > Bug: 1098934 > Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821372} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: Icaef3974d3fbc8325f92bda4df0220ab3f012bc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503529Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821475}
-
Jeffrey Kardatzke authored
This adds parsing of the VUI and methods for returning size and colorspace information based on the SPS. BUG=chromium:1141237,b:153111783 TEST=media_unitests, media_h265_parser_fuzzer Change-Id: I6959bf7706183f5239a91ea201effeed9a735dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495838Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#821474}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I427c70063f2d2e21038c3c050f5db34729392fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491994 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Make sure the holding space bubble's position is updated on tablet mode changes and screen orientation changes. Bug: 1142096, 1142046 Change-Id: I5bf4e77dec98ffaa99f7b5461d15ebd9ed8c0564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501781Reviewed-by:
-
Patrick To authored
This change adds tests to cover a using a WebGL2 XRWebGLLayer for WebXR Bug: 1087356 Change-Id: I26c262bdd4945a5067c14131ba5d32659f3ffc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460969 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821471}
-
Lukasz Anforowicz authored
The "const-char" filtering rule was a heuristic that was attempting to proxy/cover cases where a struct stored in a global variable would get one of its fields initialized with a non-nullptr value - such scenario could lead to a build error about user-defined constructors invoked when initializing global-scoped values Earlier patchset of this CL replaced "const-char" rule with a more accurate "global-var-init-with-custom-ctor" rule that was directly catching initialization of pointer fields with non-nullptr values. See: https://crrev.com/c/2490864/2 The final patchset of this CL removes the "const-char" rule without replacing it with a new rule, because of a realization that the "global-var-init-with-custom-ctor" rule would only fire in scenarios already cover by another existing rule: "global-scope" rule (formerly named "global-destructor" rule). See for example: https://crrev.com/c/2490864/2/tools/clang/rewrite_raw_ptr_fields/tests/gen-non-constexpr-initialization-expected.txt Bug: 1069567 Change-Id: I4f01b19d9e512db4a1031749eb5b4eb9a54d0ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490864Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=schwering@google.com Bug: 1142671 Change-Id: I1294602053f5e8c40831b7c0bb92633bb149c674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500553 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#821469}
-
Michael Hansen authored
This fixes an issue where a discovery session is never started on the HIDDetectionScreen, leaving the user unable to pair a Bluetooth input device through the automatic connection flow. Bug: b:168247012 Change-Id: I30f09ff661081afe0f71d8624d61cec10dc31093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495832Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1142671 Change-Id: Ida6f990ab48b6a1dbecb775db783ffe8b7f27f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500559 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821467}
-
John Chen authored
Disabling the following flaky tests on android-pixel2_webview-perf: * blink_perf.css/SelectorCountScaling.html * blink_perf.dom/custom-element-default-style-with-shadow.html * blink_perf.dom/custom-element-default-style.html * blink_perf.layout/ruby.html * blink_perf.layout/chapter-reflow-once.html * blink_perf.layout/flexbox-row-stretch-height-indefinite.html * blink_perf.layout/ArabicLineLayout.html * blink_perf.parser/innerHTML-setter-siblings.html TBR=wenbinzhang@google.com NOTRY=true Bug: 1142315 Change-Id: I88a598703b6d1e8bf0c8d96d380cb7b01ca685d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503823Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821466}
-
Nektarios Paisios authored
This patch modifies AXEventGenerator so that it will now generate any selection and value changed events that apply to text fields in the browser process. Until now, all such events are being fired by Blink. However, the browser process has all the information to fire these events without assistance from the renderer. This change has two benefits which are currently unused but which will be made readily apparent in a followup patch: 1. Will further reduce the number of events that would need to be fired by Blink. 2. Will drastically improve the performance of large content editables, e.g. those found in Google Docs. The latter would be possible because after this patch lands, we'll be able to stop computing the value attribute for text fields in the renderer and unnecessarily sending it over to the browser. Also took the opportunity to 1. Add STL container functionality to AXEventGenerator and improved some of the C++ comparison operators. 2. Split the value changed event into three separate and easier to understand events: A) RANGE_VALUE_CHANGED - for ARIA and native sliders, scroll bars, etc. B) SELECTED_VALUE_CHANGED - for <select> elements. C) VALUE_IN_TEXT_FIELD_CHANGED - for ARIA and native text fields, including content editables. For ARIA popup menus and combo boxes, there is the existing ACTIVE_DESCENDANT_CHANGED event. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I7f083ad69c47e7215fb83501ef0a3a4d06e5f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492301 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Sammie Quon authored
Add anti-aliasing to circles, makes more smooth, screenshot in bug. Damage a larger region on repaint to account for the shadows. Test: manual Change-Id: I4707fd057adcb4d5a0f6f4c412683203fa107ea3 Fixed: 1142935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503400Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821464}
-
Greg Thompson authored
In the component build, setup.exe requires its dependent DLLs to run. In support of this, mini_installer contains all of those DLLs as extra (uncompressed) resources. These are extracted and placed next to setup.exe in the work directory. This CL adds a titch of cleanup code to delete these extracted resources. BUG=127233 R=gab@chromium.org Change-Id: Icf41e3c2535d07dd1ba1888e4d2e5fbcc8f1c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501746 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
