- 12 Oct, 2020 40 commits
-
-
Jiewei Qian authored
This is a reland of de6bbcbc The reland deletes EXPECT_DCHECK_DEATH to all launch tests, because death tests aren't reliable in browsertest. And manually test LaunchSystemWebApp behaves correctly in debug / DCHECK builds. Test=Manually verified debug build and release build behaves correctly. - When DCHECK is on: DCHECKs when launching with a wrong profile - When DCHECK is off: launches into an appropriate profile Original change's description: > system-web-apps: better handle incognito in LaunchSystemWebApp > > LaunchSystemWebApp used whatever profile is provided in the parameter to > create SWA windows and launching SWAs, even if the profile may not > suitable to host a SWA window. > > This CL adds logic to determine the appropriate profile if the provided > one is unsuitable. This serves as a mid-term solution for launching > SWAs, and acts as a safety net to prevent chrome crashing if unsuitable > profiles are provided. > > Specifically, it catches these two types of profiles: > - Guest session "original" profile: launch into guest session's > primary off the record profile (which is used for guest session > browsing and SWAs). > - Normal session incognito profile: launch into the original profile, > because we don't support incognito SWAs. > > Fixed: 1109594 > Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814602} Change-Id: I5766a26c5376c7e59180e4d9dd2befe015c13e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459010 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#816104}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I61cdb2b1909662f048832e85cedffbe9dbaca18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463266 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816103}
-
Jérôme Lebel authored
ForceStartupSigninPromo flag should should not present the promo when being signed in. The flag test is moved after authentication test. Change-Id: Ib4cf710988b39726b9f4dbef80d44eb8f16fde98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462133 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#816102}
-
Francois Beaufort authored
This CL moves some image capture web platform tests to secure contexts as getUserMedia is required to get access to photo-related settings and capabilities. It also removes a test in MediaStreamTrack-applyConstraints-fast.html as applyConstraints handles properly non-ImageCapture constraints. Bug: 1134569 Change-Id: I0b9e3e824bccc8f056c68735f8c04a94d0fc0c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445209 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#816101}
-
Koji Ishii authored
This patch changes |CSSParserFastPaths| so that `hyphens: auto` is accepted as a valid CSS when |USE_MINIKIN_HYPHENATION| is on, rather than only on Android. This patch has no behavior changes. Bug: 652964 Change-Id: Id5c4c92798a6b10292e7a2505515bb7efd48d1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465412 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#816100}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602460024-2af6533fe6c4354707f21413721100fe04991470.profdata to chrome-linux-master-1602482293-c39f07959f0e29f7d514a51869e00b511fbb2f8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I74de475988eb83739aecbf57a72659f116ef8cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465503 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816099}
-
Rakina Zata Amni authored
These tests do not intend to have failed navigations, but they actually failed silently, mostly due to 404s because of bad URLs. Soon (after crrev.com/c/2437714 lands) these tests will actually fail because of the failed navigations. This CL ensures that these navigations uses the correct URL, or disables the test in cases where that's not possible. Bug: 1133115 Change-Id: I4db7c06cfdd08ab8a4ccac3ca8fa51bc4b5917d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438550 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816098}
-
Kenichi Ishibashi authored
These test classes use ServiceWorkerRegistration. Move these classes and tests to service_worker_registry_unittest.cc so that service_worker_storage_unittest.cc can be moved to the Storage Service. ServiceWorkerRegistration can't be used from the Storage Service. The reason we had two classes was that one provided a way to simulate browser restart and the other didn't. Since there is no specific reason to keep that separation this CL merges these classes into one class (ServiceWorkerRegistryResourceTest). Bug: 1016064 Change-Id: I21367ebf817a81d9ccdf0b5e2042673e5093c553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463041Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816097}
-
Monica Basta authored
Bug: 1063856 Change-Id: Ic1a10a9fd1924166f8c855ff0421df855b26122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441407 Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#816096}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/20186d1be641..82d331556ce7 2020-10-12 apodtele@gmail.com Unnest markdown. 2020-10-10 wl@gnu.org * Version 2.10.3 released. 2020-10-10 wl@gnu.org Document changes to last release. 2020-09-25 wl@gnu.org [autofit] Synchronize with ttfautohint. 2020-09-25 wl@gnu.org Move `scripts/make_distribution_archives.py` to `src/tools`. 2020-09-24 wl@gnu.org * src/cff/cffgload.c (cff_slot_load): Scale `vertBearingY`. 2020-09-24 wl@gnu.org * src/base/ftobjs.c (FT_Load_Glyph): Trace glyph metrics. 2020-09-22 wl@gnu.org [meson] Move auxiliary scripts to `builds/meson`. 2020-09-21 david.turner.dev@gmail.com Add python script for building tarballs. 2020-09-21 wl@gnu.org * scripts/extract_freetype_version.py: Fix regex typos. 2020-09-21 david.turner.dev@gmail.com Add Meson build project file. 2020-09-19 apodtele@gmail.com Documentation updates. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I8e84ef063c07f9e89934f7566048f3e18b90d4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465225Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#816095}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. Browser tests no longer need to be parameterized. Builds on https://chromium-review.googlesource.com/c/chromium/src/+/2454774 https://chromium-review.googlesource.com/c/chromium/src/+/2462343 Retire /BookmarkApps entries from testing/buildbot/filters/lacros.browser_tests.filter and rename /WebApps entries. Bug: 1065748 Change-Id: I0a6cc2f0b11303a5d3a2c75c7447e720d051e06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456466Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#816094}
-
Ilya Nikolaevskiy authored
Bug: chromium:1132299 Change-Id: Id47f3c4167a5ab0cf40e9ce7c63174377b075ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461374Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#816093}
-
dpapad authored
This is in preparation of eventually auto-generating webui_resources.grd, which will produce IDs derived from a file's path. Currently this naming convention is used inconsistently. Bug: 1132403 Change-Id: I59673142f6dc1f1bd320f9185d9cfe0942270594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461989Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Rahul Goyal authored
Before this CL, overlay images were always retrieved from a target URL. This CL allows the backend to specify the image from a variety of sources, as used in other places of the system. This will make overlay images more versatile. The old way of fetching images from URLs is still supported by specifying a BitmapDrawable as input. Bug: b/168023114 Change-Id: I994dc10cda30e04f77cb8acbe10563575417d1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410067 Commit-Queue: Rahul Goyal <goyalrahul@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#816091}
-
Colin Blundell authored
In preparation for componentization of several core classes for sharing with WebLayer, this CL removes a dependency on Profile from these classes by threading through the actual dependencies required. There is no behavioral change. Bug: 1116095 Change-Id: I8c6302be75e215e75ca2b83d605ff896a69ae8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463305Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#816090}
-
Martin Robinson authored
VoiceOver requires each row to have in index in order to announce it. We expose this property for rows which either have role=row or role=treeitem. AX-Relnotes: Fix an issue where ARIA TreeGrid and Tree rows were not announced. Bug: 1115267 Change-Id: Ia8917044a510b2467aa2480dff54fe226b90c391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426569 Auto-Submit: Martin Robinson <mrobinson@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#816089}
-
Anton Bikineev authored
This is needed to prevent ADL to pick up the candidates from the internal namespace when an argument is from the internal namespace as well, which otherwise results in overload resolution ambiguity. Change-Id: I2866d738d3ad16a528e05bac93d1b0c4153b2013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463606Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#816088}
-
Victor Hugo Vianna Silva authored
This test was disabled in 2013 due to flakiness. Remaining disabled for so long caused the test logic to break, as other parts of Chromium changed: 1) Nowadays if an ExtensionFunction is created but not run, a DCHECK will be hit [1]. We fix this by calling ignore_did_respond_for_testing(). 2) In order for ExtensionsActivityMonitor to correctly identify the notifying function via histogram_value() [2], set_histogram_value() must be called, as explained in crbug.com/1136908. [1] https://source.chromium.org/chromium/chromium/src/+/master:extensions/browser/extension_function.cc;l=396;drc=8d739b8c2d6b98b5c77b1852923ab2ae1b9fdabf [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/sync/glue/extensions_activity_monitor.cc;l=54;drc=8d739b8c2d6b98b5c77b1852923ab2ae1b9fdabf Bug: 172002 Change-Id: If559550706f3f1b0c382a1d28582ad4072da2212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460743Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816087}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ib1b1eda38e1b8b9e59176743c0a7faf2e2782915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463224Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#816086}
-
Rune Lillesveen authored
For tree-scoped references, we need to know which tree-scope the cascaded CSSValue came from, and we need to know if Resolve() changed the origin because of revert, in which case the original origin and the tree_order member of MatchedProperties are no longer valid. Let the origin parameter to Resolve() be a reference so that the resolved origin is updated as an in-out parameter. Bug: 336876 Change-Id: I53850f3f72652299d5fe35bf0261bda90a358b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455686 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#816085}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602460024-4b69636ab7ebaae5b3fa848321845968d50cbe86.profdata to chrome-mac-master-1602482293-da1e028d2d7af7f0b3fa08c67c62f39283c5fc49.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2e827b30b67ab0d67c37f7b3f81a02bb5b02fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465238Reviewed-by:
-
Kenichi Ishibashi authored
It was used to simulate earlier version of Chrome. If we want to keep the helper function it needs to be exposed as a mojo method just for tests. To avoid exposing such low-level operation just for tests, this CL replaces it with StoreRegistrationData(). Bug: 1016064 Change-Id: I19204b760ae2781431c7ad9db4af8993dc6a77f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462896Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816083}
-
Peter Kasting authored
Bug: 772945 Change-Id: I4ec3554e89de3467b96766fc0d3c14f14086e99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454351 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#816082}
-
Kenichi Ishibashi authored
There seems a situation where ServiceWorkerInstalledScriptsSender tries to delete a service worker registration more than once. Ideally it shouldn't happen, but looks like it happens when a client (page etc) requests service worker scripts to start a service worker which already became redundant. To prevent the browser from hitting DCHECKs(), This CL adds a check to avoid calling ForceDelete() twice. Bug: 1133135 Change-Id: I27a3d75780a23feebef2945575cfbaecb5a34ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444755 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80292b0234ce..9024c3764962 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I3782634efe7c25532d82a76558306f0d226a6121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465236Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816080}
-
Alan Cutter authored
This removes the requirement for "callsites" of queued WebAppInstallTasks to have to load about:blank in the web contents. Now loading about:blank is part of all queued WebAppInstallTasks. This removes the web_contents_ready_ bool which is now semantically merged into current_queued_task_. This also changes the task_start callbacks to hold weakptrs to the tasks because the task_start may outlive the WebAppInstallManager (unlikely but being safe here). Bug: 1086778 Change-Id: I7cb83212d47753abf68bd8af7850034502c635c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246044 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/06e3f9cc6739..ec23cfada4cd 2020-10-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If09ee759b38477d669ba465044781cb63a5add75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465235Reviewed-by:
-
Koji Ishii authored
The file compiles on Linux, but this cast is needed to on Windows. This patch has no behavior changes. Bug: 652964 Change-Id: Ib4cfd4f0e89a6c9b8c1ca3c0dcb3ca991002fdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465603 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. Tests no longer need to check the flag. Bug: 1065748 Change-Id: I43715dcec87cc523b247a5fc27e6f2a7f9e0bc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463048 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Kent Tamura authored
This doesn't change rendering behavior, but changes |getComputedStyle(element)['appearance']| results. The new behavior matches to Firefox. Bug: 965432 Change-Id: I4ac0e91ebb9abfa5509b4429c62126cdf91a5acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462990 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL updates the option.enable_sharesheet default value to be true to run all tests with sharesheet enabled. This is because we turn on the sharesheet flags by default. BUG=1097623 Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816074}
-
Keren Zhu authored
The Chinese Pinyin IME on Mac uses arrow keys to select candidate words. Because -[NSView interpretKeyEvents:] silently consumes the arrow key without notifying NSTextInputClient, currently MacViews textfield will handle arrow keys as accelerators and dismiss the IME even in the presence of composition text. This CL fixes this bug by omitting arrow keys as accelerators when the composition text exists. This bug has the same root cause as seen in crbug/883952 Bug: 915924 Change-Id: I408fbb637e635c2e048a83dfbc1847820019827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464078 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#816073}
-
Ramin Halavati authored
Updates ntp_tiles_internals_ui.cc and history_ui.cc for compatibility with ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ib538a3df1d3c547817f57473bd1d3cce85df0299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461337Reviewed-by:
-
Maggie Cai authored
This CL turns on the kIntentHandlingSharing and kSharesheet flags to enable sharesheet feature by default. BUG=1097623 Change-Id: Idff4e37934fb730b7f83b86206d555a8c049f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460206 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816071}
-
Ben Reich authored
Adds #include's that were missing from the initial patch, and FAIL the test if the DevToolsAgentHost attached to crashes during the test. Fix HostString() helper to *actually* take an optional prefix: use C++ c++17 {} style initializer. Test: browser_test --gtest_filter="*DevToolsListener*" Bug: 1113941 Change-Id: I5901019add9fea92b6e3a8b5b881b8d3d197b6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465456 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816070}
-
Giovanni Ortuño Urquidi authored
This reverts commit f79b1513. Reason for revert: Breaks WebKit Linux MSAN The following tests started failing since this landed: * http/tests/devtools/tracing.js * http/tests/devtools/tracing/decode-resize.js * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js * http/tests/devtools/tracing/tracing-record-input-events.js * http/tests/devtools/tracing/user-timing.js * http/tests/devtools/tracing/worker-events.js * http/tests/devtools/tracing/worker-js-frames.js * inspector-protocol/sessions/tracing-start.js * inspector-protocol/timeline/tracing-proto-format.js First run that failed, also the run where the CL landed: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830 Original change's description: > [tracing] Remove special handling of task execution and log events > > The task execution and log events are handled specially for writing > proto arguments because we did not have the support for typed events in > base and interning support for the event macros. Now these events can > use the new client library API. > The events have to be migrated together because the source location > interning index is common for all events in the API and does not > account for the special handling in event sink. > > BUG=1136635 > TBR=chirantan@chromium.org > > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636 > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815911} TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1136635 Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e21911cc1c77..aa7048b18b2f 2020-10-12 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from 2d8a12dca47a to f6bc2a9be76e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibfc9b0d665a2c4d76a4624c2739ff4aee966f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465562Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18d648b5376b..80292b0234ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113941 Tbr: ortuno@google.com Change-Id: I386d26630c2210b6134a8593aee31cd341a0e769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465231Reviewed-by:
-
Takashi Sakamoto authored
MTECheckedPtr requires 16-bytes aligned size when initializing or uninitializing tags. PartitionBucket<thread_safe> uses GetNewPartitionTag. The method should be public. Bug: 1092288 Change-Id: If238b881af351ec89b6b89ba6283dfc0830272e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348233 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#816066}
-
Ramin Halavati authored
WebApps popout is disabled for Guest sessions. Same restriction is added for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ic6bde4313a5107f165eb00ac5d8c0e3ff1c9496f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461383Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
