- 17 Oct, 2017 40 commits
-
-
Reilly Grant authored
This reverts commit fd493b4b. Reason for revert: Broken build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/114259 Original change's description: > Stop building SkCodec > > Bug: 768878 > > Building SkCodec seems to have caused a paint regression on a webpage > without any images. This leads us to suspect "some minor compiler > optimization tickling". Stop building it to confirm. Two CLs rely on > SkCodec: > > "Use SkCodec internally in GIFImageDecoder" > 4fed3346. This introduced building > SkCodec. > > "Enable Skia's SkImageGenerator implementation" > f5eb27c2. This used SkCodec to fix > crbug.com/758459, but that seems to have been fixed in another way. > > In addition, this corrects some formatting in the old code (as > commanded by presubmit), and makes some other minor changes (no more > PassRefPtr, FrameDurationAtIndex now returns a TimeDelta). > > Change-Id: Ic2bdd87740da0232c9c07e27eed6049efc26d76c > Reviewed-on: https://chromium-review.googlesource.com/718918 > Commit-Queue: Leon Scroggins <scroggo@chromium.org> > Reviewed-by: Chris Blume <cblume@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Leon Scroggins <scroggo@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509570} TBR=scroggo@chromium.org,pdr@chromium.org,fs@opera.com,cblume@chromium.org Change-Id: Ib4c5be2e885f483d881ca65689cb5e9f3dc755df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768878 Reviewed-on: https://chromium-review.googlesource.com/724359Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509577}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/733ecb1825d0..75257303afa9 $ git log 733ecb182..75257303a --date=short --no-merges --format='%ad %ae %s' 2017-10-17 nednguyen Make the log of dependency_manager less spammy 2017-10-16 nednguyen Remove dead TBMv1 metrics code 2017-10-16 nednguyen Remove deadcode related to TimelineBasedMeasurement 2017-10-16 dnj [external_modules] Warn on optional import misses. 2017-10-16 nednguyen Revert "Increase the timeout for collecting Chrome trace" 2017-10-16 charliea Remove documentation for the "after_load" power metric 2017-10-07 benjhayden Make breakdown-span cross-reference RelatedNameMaps. 2017-10-16 rnephew [Telemetry] Remove benchmark.ShouldDisable from telemetry. 2017-10-16 benjhayden Allow results.html to use either location.search or location.hash. 2017-10-16 benjhayden Sort results.html by Name by default. 2017-10-11 benjhayden Automatically focus test-picker. 2017-10-16 johnchen Fix when seek times are calculated in media metrics 2017-10-12 benjhayden Simplify histogram-span API. 2017-10-13 benjhayden Add python implementation of RelatedNameMap. Created with: roll-dep src/third_party/catapult BUG=762005 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibca32f9b7d7b6ba7513fd9bb99ba6b46fbc83dcd Reviewed-on: https://chromium-review.googlesource.com/724100 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509576}
-
Bill Budge authored
- Adds a 'initial_seed' parameter to GetRandomPageBase, which defaults to 0. If non-zero, generates a predictable sequence, using the value as the initial seed. - Adds a unit test for the predictable sequence. Bug: chromium:756050 Change-Id: Iaf718baa2b7d49dc8eda7b0f97aa12b576ddca28 Reviewed-on: https://chromium-review.googlesource.com/703509 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#509575}
-
Jiaquan He authored
The Play Store app discovery on ChromeOS depends on Phonesky, which get updated automatically or manually in ARC. This CL catches and records bad behaviors of the Phonesky app discovery service in runtime to make them visible from metrics, so that we can discover issues and report them to Phonesky. Bug: 763590 Change-Id: I6a6221f072a52b5fa916071a7fa891a2d61c44db Reviewed-on: https://chromium-review.googlesource.com/719696 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#509574}
-
Wez authored
These targets depend on third_party/opus, which did not build for Fuchsia-ARM64. Bug: 772031, 775272 Change-Id: I0ec4bcadc63b5e250b0b2363b7efdcfb52762382 Reviewed-on: https://chromium-review.googlesource.com/723853 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#509573}
-
Joshua Bell authored
When asked by chrome://settings/siteData to delete an origin, the sandboxed file system code enumerates the types (temporary, persistent, syncable) and tries to delete each (origin, type) pair. This would create "last modified" entries for pair even if there was no such file system in use, and those entries would confuse later cleanup attempts by chrome://settings/clearBrowserData The fix is simple: don't notify the quota system if deleting the directory resulted in a zero-byte change. This prevents the creation of bogus entries. Cleanup of bogus entries was hindered by two additional subtle bugs: * When asked to delete an origin which didn't exist, the File System quota client would try to 'rm -rf' an empty path, which (fortunately) fails. Detect that case and early-exit with success (since there's nothing to delete). * When asked to delete an unsupported type the IndexedDB quota client would report failure; it should report success instead like the other quota clients. With those changes in place, chrome://settings/clearBrowserData cleans up any bogus entries left behind by the first part of the bug. Bug: 774666 Change-Id: Ie49810ef0408b1ae3ad3e2e7546929f1177c5963 Reviewed-on: https://chromium-review.googlesource.com/719390 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#509572}
-
Alexander Timin authored
Make TaskQueueThrottler to insert a delayed fence to allow task queue run tasks in the wake-up window. Rename HasFence to HasActiveFence and check if the delayed fence is ready to be activated. R=alexclarke@chromium.org,skyostil@chromium.org Change-Id: I5a7c5ebc70682514ede260c9149b7ea209902d76 Reviewed-on: https://chromium-review.googlesource.com/716380 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#509571}
-
Leon Scroggins III authored
Bug: 768878 Building SkCodec seems to have caused a paint regression on a webpage without any images. This leads us to suspect "some minor compiler optimization tickling". Stop building it to confirm. Two CLs rely on SkCodec: "Use SkCodec internally in GIFImageDecoder" 4fed3346. This introduced building SkCodec. "Enable Skia's SkImageGenerator implementation" f5eb27c2. This used SkCodec to fix crbug.com/758459, but that seems to have been fixed in another way. In addition, this corrects some formatting in the old code (as commanded by presubmit), and makes some other minor changes (no more PassRefPtr, FrameDurationAtIndex now returns a TimeDelta). Change-Id: Ic2bdd87740da0232c9c07e27eed6049efc26d76c Reviewed-on: https://chromium-review.googlesource.com/718918 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#509570}
-
Khushal authored
The PlaybackImageProvider uses the same frame index for all PaintImages on a tile during playback. Since updating of offscreen animated images is throttled in blink, this can lead to cases where an instance of the PaintImage in the recording may not have the data to decode the requested frame index. In such cases, clamp the frame index to last index available in that PaintImage. Also remove CHECKs added for debugging this issue. R=vmpstr@chromium.org Bug: 768975 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff9dd9b918aaf26731853d96c4762b2da864b58f Reviewed-on: https://chromium-review.googlesource.com/723765 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#509569}
-
xdai authored
Bug: 725683 Change-Id: I5f2203fc2879abc4e26dbcae386f0b663a4b779b Reviewed-on: https://chromium-review.googlesource.com/716977 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#509568}
-
Hiroshige Hayashizaki authored
After https://chromium-review.googlesource.com/720640, |document_| is WeakPersistent and thus it should be null-checked before use. Bug: 773571, 775090 Change-Id: I914b57071fa07288997162d8645bab4ded440032 Reviewed-on: https://chromium-review.googlesource.com/721681 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509567}
-
Fabio Tirelo authored
Bug: 773856 Change-Id: I1523381b4492b74b379ca1bd1801a59b2d447324 Reviewed-on: https://chromium-review.googlesource.com/714216 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#509566}
-
Kyle Horimoto authored
This will be used to aid testing in a follow-up CL. Bug: 761532, 672263 Change-Id: Icd54139447b13f6a8ec1feb6f4345701ff4e115d Reviewed-on: https://chromium-review.googlesource.com/724080Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#509565}
-
Harald Alvestrand authored
There seems to be a race on whether the count of datachannels is incremented before a session goes to "connected". This CL allows both 0 and 1. The test would fail ~1/4000 times on a Linux workstation. Bug: 771540 Change-Id: Ic250443c2addef995dbb26e7cd021a516dcd023b Reviewed-on: https://chromium-review.googlesource.com/721379Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#509564}
-
Zijie He authored
According to a very old bug, (https://bugs.chromium.org/p/chromium/issues/detail?id=339678), we should LoadLibrary(), i.e. MediaFoundationVideoEncodeAccelerator::PreSandboxInitialization() before calling MFStartup(), i.e. InitializeMediaFoundation() to avoid crashes within DelayLoad. See the bug for details. Bug: chromium:775563 Change-Id: I7c54569304b8806095a32b009bed5bec287e91f1 Reviewed-on: https://chromium-review.googlesource.com/723774 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#509563}
-
Toni Barzic authored
The dialog will be shown for each new note taking app when it's launched from the lock screen. The dialog will not be shown for the same app again if the user closes it. This adds a user pref to track note taking apps for which toast dialog has been shown (and dismissed). The dialog is implemented as a sysmte modal bubble dialog in ToastDialogView. The cl introduces FirstAppRunToastManager, which is used by lock_screen_apps::StateController to delegate showing of the toast dialog - the FirstAppRunToastManager, if the toast hasn't been shown before, observe a created app window's visibility, and show the toast dialog when the app window is shown. Once the dialog is dismissed by the user, the FirstAppRunToastManager will update the user preferences accordingly, to prevent dialog shows on subsequent app launches. BUG=767717 Change-Id: I87032afb099b7ef027d82bcaa06d16a5957c3527 Reviewed-on: https://chromium-review.googlesource.com/720099Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509562}
-
Andrew Moylan authored
This CL changes the return type of LocationProvider::StartProvider (and related functions) from bool to void. Currently, no-one inspects the value returned from this function, except to pass it through to other places that don't inspect it. Most impls always return true. The situation where an impl doesn't always return true (LocationArbitrator) are responded-to by other means. Specifically, LocationArbitrator provides an Error geoposition in the case that it couldn't create any location providers. I also opportunistically removed the unused MockLocationProvider in this CL. Bug: 748921 Change-Id: Iaa7903b3eecaacc0076b3c1f1cce3be86187285d Reviewed-on: https://chromium-review.googlesource.com/722139Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509561}
-
Erik Luo authored
Error and warning counters show up by default, even when console has no messages of those types. The counter logic already calls _update() initially, but it results in a no-op when error/warningCount are up-to-date by default. This CL initializes error/warningCount differently to ensure the first _update() will not be a no-op. Bug: 775239 Change-Id: I98f3c1aa0838baf70c3372c4a07781011878f8f0 Reviewed-on: https://chromium-review.googlesource.com/722077Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#509560}
-
Matt Falkenhagen authored
This reverts commit 24e5c55f. Revert "[ServiceWorker] Fix the warning for comparison of unsigned expression" This reverts commit 4d47a13e. Reverting due to crashes, see bug. Bug: 774681, 755861 Change-Id: Ib90a143dec1ca9f378a487e330a98a1bb3d7d50c TBR: xiaofeng.zhang, shimazu, tsepez, kinuko Reviewed-on: https://chromium-review.googlesource.com/722840Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#509559}
-
Robert Sesek authored
The linker's -dead_strip was removing the fuzzer initializer because it was unreachable and not exported. This adds a new libfuzzer_exports.h header that fuzzers can include to ensure the symbols have the proper visibility. Bug: 687076 Change-Id: I8fe5c523ade491a48cd7abbf85c69edb872c97db Reviewed-on: https://chromium-review.googlesource.com/721340Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#509558}
-
Jacob Dufault authored
Bug: 719015 Change-Id: Ifd689698b09d51596330b2d7d07681e9e28eb68a Reviewed-on: https://chromium-review.googlesource.com/717543 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509557}
-
Nathan Bruer authored
Adds the ability to create folders when createing a file in Workspace.Projects. R=lushnikov,pfeldman BUG=None Change-Id: I46f57ca6523bc63142854c7a9af506aae005c04b Reviewed-on: https://chromium-review.googlesource.com/720137 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509556}
-
Elliot Glaysher authored
Observing the TabletModeClient shouldn't send an immediate notification about the current value, as this leads to an order of operations problem in the BrowserNonClientFrameViewAsh code which tries to access a Browser object while it's under construction. Change the one place which actually needs the data immediately. Bug: 775117 Change-Id: I7bcb65a9b281545a621460675c36b57f1a0de8f5 Reviewed-on: https://chromium-review.googlesource.com/722040Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509555}
-
Erik Luo authored
This CL pivots the log management UI to use a tree instead of a list. - Introduces SidebarLevelByUrlGroups, which contain SidebarItems - Adding a single message will let groups create SidebarItem children - Sidebar's applyFilter lets Groups choose which children to apply to Some messages have no 'url' such as evaluations, and will be addressed in a future CL. Counters and styles will be introduced in a followup. Bug: 685283 Change-Id: I0335138c89ba3d4ff81dcbb3a88787e8ac0fa395 Reviewed-on: https://chromium-review.googlesource.com/719389 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509554}
-
Sidney San Martín authored
Bug: 764816 Change-Id: If4737e1f144dab5134d91623ec5dc60fc98270b5 Reviewed-on: https://chromium-review.googlesource.com/723900Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509553}
-
MinChen authored
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/721801 Bug: 774617 Change-Id: I047740cedf056198743eb439b183ecb3b0ce3158 Reviewed-on: https://chromium-review.googlesource.com/723671Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509552}
-
Victor Costan authored
Bug: Change-Id: Ibeb576ba0d6d4edfbda8dd369682f8c08c494248 Reviewed-on: https://chromium-review.googlesource.com/722288 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509551}
-
Wez authored
The builder was brought up with just base_unittests, but we now have most of our current set of targets compiling for ARM64 as well. headless_shell, content_unittests, media_unittests and skia_unittests are not yet built, due to a dependency on third_party/opus, which is currently broken. Bug: 772031, 775272 Change-Id: I67996585207793243e1bcc900ad89ae4014d5385 Reviewed-on: https://chromium-review.googlesource.com/723582Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#509550}
-
Nico Weber authored
Bug: 774209 Change-Id: Ia95ff7b9bb74d4b69067c121d0a95af96331199e Reviewed-on: https://chromium-review.googlesource.com/723941 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509549}
-
Tibor Goldschwendt authored
Bug: 774636 Change-Id: Id4a7f00be204ef90fab2c9f365ec546d37d5baa2 Reviewed-on: https://chromium-review.googlesource.com/721578 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#509548}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 TBR=reillyg@chromium.org, kbr@chromium.org, rsleevi@chromium.org, thestig@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I160373c241f64d73e12ca6421d849a23a90f9fff Reviewed-on: https://chromium-review.googlesource.com/723786Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#509547}
-
Findit authored
This reverts commit f3f5e27d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 509533 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YzZjVlMjdkYjE2YmU1NWNhZjY0MmIyMjc0ZjhjZmU2ZWIzOGU0ZjQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder%20%28dbg%29/218396 Original change's description: > Allow Chrome on Mac to recognize multiple MFi gamepads > > Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated > by the GameController framework. When multiple such devices are > connected at once, Chrome fails to properly distinguish them. > > GCController exposes a playerIndex field that defaults to the value > GCControllerPlayerIndexUnset (-1). The application may set this field > to a value between 0 and 3 to signal which LEDs should be lit on the > gamepad. Chrome also uses this field to distinguish gamepads, but does > not set the index to a unique value. This causes the first-connected > gamepad to shadow any other connected gamepads. > > This CL ensures each connected MFi gamepad is assigned a unique player > index up to the OS-defined limit of four. > > BUG=775270 > > Change-Id: Ieb852cadc5ff36f94aa1003de3f2e13538114661 > Reviewed-on: https://chromium-review.googlesource.com/723852 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509533} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=775270 Change-Id: Ie8a0af7a186753a385d138080ddb70815d992ae5 Reviewed-on: https://chromium-review.googlesource.com/724165 Cr-Commit-Position: refs/heads/master@{#509546}
-
Scott Graham authored
Fix comment typo in https://chromium-review.googlesource.com/c/chromium/src/+/721570/, and also enable IndexedDBFactoryTest.DataFormatVersion which should now not flake on Fuchsia. Bug: 771701 Change-Id: I7a67bf762cbf171965cb1f2810100945f685327e Reviewed-on: https://chromium-review.googlesource.com/723562 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#509545}
-
Miao-chen Chou authored
This adds the following histograms and their definitions. [Histograms] - BlueZ.AdapterLost - BlueZ.NumberOfExistingAdvertisements BUG=chromium:724720 Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b Reviewed-on: https://chromium-review.googlesource.com/722076 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#509544}
-
Mike Wasserman authored
Ash is no longer built on Windows. Also cleanup DragDropControllerTest. Bug: NONE Change-Id: I73b3ce606aca98abc6248f7cf8356c6307a785b6 Reviewed-on: https://chromium-review.googlesource.com/723866Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509543}
-
Jamie Walch authored
Bug: 775582 Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c Reviewed-on: https://chromium-review.googlesource.com/723750 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#509542}
-
Scott Graham authored
Currently fails to compile when using neon opts on Fuchsia. Disable for now, since the ARM64 port is just trying to get to the linking/prototype stage. Bug: 768411, 775272 Change-Id: I7adfa8dd97badb1f20ba38b36b5e438e9a7b1ede Reviewed-on: https://chromium-review.googlesource.com/722262Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509541}
-
Kouhei Ueno authored
This CL introduces "V8.CompileHeuristicsDecision" which records which of the script compilation function got picked, providing more insights about how often V8 {code,parser} cache is {produced,consumed,bypassed}. Bug: 769203 Change-Id: I7b27a1634ee5b1623330acae1ef27bc78f39742e Reviewed-on: https://chromium-review.googlesource.com/720660Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#509540}
-
Nathan Bruer authored
This patch is for code health and to make it eassier for followup patches. Simply makes createFile() in Workspace.Project return a promise instead of a callback. R=lushnikov BUG=None Change-Id: If9e0a8d1e24cb01e3a1cba8188d31d4e2b9f61c5 Reviewed-on: https://chromium-review.googlesource.com/720078 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509539}
-
Sammie Quon authored
Bug: 772201 Test: ash_unittests SplitViewWindowSelectorTest.* Change-Id: I2bd02c4cde73247e1260064035401bf5069150ac Reviewed-on: https://chromium-review.googlesource.com/717264 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#509538}
-