- 27 Nov, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGLineElement> and DynamicTo<SVGLineElement> as new downcast helper 2. Use IsA<SVGLineElement>(element) in place of IsSVGLineElement(element) Bug: 891908 Change-Id: Ife53d32d1e56485fa9021cf801be799825da1fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936608 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719681}
-
David Van Cleve authored
We're flipping a flag (ReducedReferrerGranularity) to change the default referrer policy to strict-origin-when-cross-origin. This CL adds a short-term enterprise policy to revert the change in case some administrators need some time to adjust to the change. The enterprise policy works by registering a handler that toggles a global in //content. (See dependent CL crrev.com/c/1904231.) It would have been possible with some indirection to add a pref that is in turn checked to update this value, but the pref would not have been used for any other purpose and, consequently, directly toggling the global requires less new code. In either case, toggling a runtime-modifiable global makes the policy dynamically updatable, but not per-profile. Bug: 1016541 Change-Id: I0ee47a6d5a16d195dc39735516b1db300c9ca705 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872808Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719680}
-
John Chen authored
It isn't clear why these tests were flaky. Re-enabling tests to see if the flakiness persists, and collect additional logs for debugging if necessary. Bug: 946704 Change-Id: I10ac88285d0ff57582ca8293aaf17a3449d16fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939960 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719679}
-
Matthew Jones authored
TBR: wuwang@chromium.org Bug: 1029059 Change-Id: I9831a37b19ec6accf6e570ab6515593d9cda2307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940539Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#719678}
-
Michael Spang authored
This adds a new debian build method, since xkbcommon has switched to meson. This method has several advantages: it is agnostic to underlying build system, doesn't require determining which configure options to set, and automatically detects missing build dependencies. Bug: 1027853 Change-Id: I4faaaa91be8ed032b2cf15d29a6bbca008c9db36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938837Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719677}
-
Abhijeet Kandalkar authored
This CL has goal to use DynamicTo<SVGMPathElement> as new downcast helper Bug: 891908 Change-Id: I65766f82e3d2834b5bad1c76397380cdfee12479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936610Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719676}
-
Greg Thompson authored
Prior to r716134, Chrome would create an empty Google/Chrome/User Data directory within a user's AppData directory if the user had a signed-in profile. This CL here deletes that directory and its parent directories (up to, but not including, the AppData directory itself) if they are empty. The results of this are reported via UMA so that we know when to delete the code. BUG=980487 Change-Id: I7170477ce8116066332a21bb5a414c3b2325b03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930824Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719675}
-
Dave Tapuska authored
Convert the FrameMsg_EnableViewSourceMode over to blink::LocalFrame. The tests are changed to stub out the LocalFrame on the browser side so we can capture the mojo call. BUG=1008432 Change-Id: I9b28b084a88d917a0433f0dff4fdde6c534d5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927035 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719674}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f9e20a3dc68..8861d02f89f7 git log 9f9e20a3dc68..8861d02f89f7 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 titovartem@webrtc.org Restore tests that were accidently deleted during refactoring Created with: gclient setdep -r src/third_party/webrtc@8861d02f89f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2af87b1cdb6db7a6a7e4732860bb550fe2ad42f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940587Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719673}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d4133ef0171..51bd3fe58ca0 git log 5d4133ef0171..51bd3fe58ca0 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tvanderlippe@chromium.org Migrate timeline_model/ to ESM 2019-11-27 tvanderlippe@chromium.org Add instructions for adding third_party packages as part of the DevTools bundle 2019-11-27 tvanderlippe@chromium.org Fix duplicate skip_compilation files 2019-11-27 aerotwist@chromium.org Migrates snippets to esm/ Created with: gclient setdep -r src/third_party/devtools-frontend/src@51bd3fe58ca0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1006759,chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I61ea6002c45be3a5588a823b5bb043a31be63ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940533Reviewed-by:
-
Herb Derby authored
Change-Id: Id7e99c8c05013e9d97ca68cdb5477468fcc8788f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940667 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Herb Derby <herb@google.com> Reviewed-by:
Ben Wagner <bungeman@google.com> Cr-Commit-Position: refs/heads/master@{#719671}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/552673083f4a..4cd5a5469ffe Created with: gclient setdep -r src-internal@4cd5a5469ffe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I11d58e68450f588095d885c48a5220da20048e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940535Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719670}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/663dcefa22ea..2613cb5e3a21 git log 663dcefa22ea..2613cb5e3a21 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Fix ICD build when using multiple toolchains. 2019-11-27 chrisforbes@google.com gles: Only clamp default block uniform indexes Created with: gclient setdep -r src/third_party/swiftshader@2613cb5e3a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/145227408 Tbr: swiftshader-team+autoroll@google.com Change-Id: I77293649307a6ae287c92f61bfb85b74c8bad43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940084Reviewed-by:
-
Thomas Tellier authored
Bug: 884764 Change-Id: Icb86058dfd67b8ae5e16c97835e89bca903e1430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926771Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#719668}
-
Andrey Kosyakov authored
This removes old copy of browser_protocol.pdl and build rule remaining under blink/renderer/core/inspector for compatibility with devtools-frontend, following the latter being rolled to include http://crrev.com/c/1938351. See also: http://crrev.com/c/1937860. TBR: dgozman@chromium.org, yangguo@chromium.org Bug: 1018108 Change-Id: Ib1162959761d700b502e63b165a5e190af8ef688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939961Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719667}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34267f83deb7..f31cb801f2cd git log 34267f83deb7..f31cb801f2cd --date=short --first-parent --format='%ad %ae %s' 2019-11-27 iannucci@chromium.org [recipe_modules/osx_sdk] Better default XCode versions depending on host OS. Created with: gclient setdep -r src/third_party/depot_tools@f31cb801f2cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026340 Tbr: agable@chromium.org Change-Id: I327b14d1090813a01e13c12acad21c142dfc0089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940534Reviewed-by:
-
Gordon Guan authored
Add detection code for a field trial comparing different implementations of discardable memory, targeting a very specific subset of devices and platforms which possess required capabilities. Further details in bug if required. Bug: 1014513 Change-Id: Id81a19b06e0c94fa6090ef1d5f6d2cd7fdd80e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922749 Commit-Queue: Gordon Guan <gordonguan@google.com> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#719665}
-
Fredrik Söderquist authored
After d663ac73, this test should no longer be timing out. Re-enable for Android. Bug: 1000473 Change-Id: I3bf1ee681f2c4bae614b94b3b3b2da712e55a65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924472Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/861ac61cb1a9..126d7a263625 git log 861ac61cb1a9..126d7a263625 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 herb@google.com Cleanup unit test output 2019-11-27 bsalomon@google.com Fix final-dtor-non-final-class warning on GrDDLContext 2019-11-27 brianosman@google.com Use ResourceProvider in particles 2019-11-27 bungeman@google.com Fix housekeeper bot with some gn format. Created with: gclient setdep -r src/third_party/skia@126d7a263625 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Iddfc896cefe49ec8973a9d43509699e03d89c5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939831Reviewed-by:
-
Christopher Cameron authored
Ensure that uninstalling an app will only cause the shim to go away if this is the last profile for which that app is installed. Make this distinction in web_app::internals::DeletePlatformShortcuts vs web_app::internals::DeleteMultiProfileShortcutsForApp (single vs multi profile). Add tests for this behavior. Update ShortcutManager to - Use a helper function UseAppShimRegistry to determine if an extension should be in the registry (only bookmark apps should). - Register apps in OnExtensionLoaded. This is needed because we are introducing the AppShimRegistry after users may have already installed apps (so we need to register them sometime). - Add hooks to call DeleteMultiProfileShortcutsForApp as needed. Update WebAppShortcutCreator to - Move a bunch of code into static helper functions (e.g, bundle id construction, using LaunchServices to look up apps, etc). - Add tests for new behaviors TBR=dominickn Bug: 1029048 Change-Id: I85807fc2cedbe4fbbd297179a5e59c781794e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938452Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#719662}
-
Dominique Fauteux-Chapleau authored
Bug: 1020267 Change-Id: Id53a6fa1f371a5488cf15a2224fb370c338a60b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934727Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719661}
-
John Abd-El-Malek authored
Remove IsMostRecentDownloadItemAtFilePath from DownloadManagerDelegate since it's not called by content. See content/public/README.md Change-Id: I8e9415a264f0764c92d7650f014adb822b51d8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937857 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719660}
-
Ken MacKay authored
Bug: internal b/138682004 Change-Id: I2d3e732e952fe1690b9dca5f170c8d2df3428e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938451 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719659}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGGElement> as new downcast helper 2. Use IsA<SVGGElement>(element) in place of IsSVGGElement(element) Bug: 891908 Change-Id: I4419560c748ceefc31fccc6e9b44185bcc757b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936586 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d27d96fff72..fe0c8c03fd49 git log 9d27d96fff72..fe0c8c03fd49 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 lalitm@google.com Merge "trace_processor: improve testing of cost estimation" 2019-11-27 lalitm@google.com Merge "trace_processor: prepare for distribution" 2019-11-27 treehugger-gerrit@google.com Merge "Define LMK reason metric" Created with: gclient setdep -r src/third_party/perfetto@fe0c8c03fd49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I227fedaf4913a6db145be480fa0bb4b7602f5eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940085Reviewed-by:
-
Xiaohui Chen authored
Bug: None Test: None Change-Id: Ia0a87528e94620c6952292d04a2f849a07ac07f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937909Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I89bc78186f282f08d5b5316f9c9f9f51ca8f984a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940510Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719655}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/24536bdd3cff..1d6155d8679a git log 24536bdd3cff..1d6155d8679a --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@google.com Moving spirv-cross dep from Dawn into shaderc (#911) Created with: gclient setdep -r src/third_party/shaderc/src@1d6155d8679a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I075dab5d7f48e757145b24ddad6c17e394afd0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940295Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/66a99b6dabab..c9d4943dc832 git log 66a99b6dabab..c9d4943dc832 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 dberris@chromium.org Update the review URL for the commit queue Created with: gclient setdep -r src/third_party/catapult@c9d4943dc832 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:985223 Tbr: rmhasan@google.com Change-Id: I8b0beb181f39d7f512771b245117fb9e75d525f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939950Reviewed-by:
-
Tomasz Wiszkowski authored
The code uses value 0 to report empty omnibox, but dashboard identifies this as an invalid state: Source Proto file: http://shortn/_2QkQqt4yB2 Bug: 1029044 Change-Id: I8d9816a3009b14467632bc2b9cd4d74c20b3ccad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940532Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719652}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e0e0a78..40fb0777 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I382de889f0f245e6f61637e0bf7fa71560c9249c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940435Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719651}
-
Aaron Krajeski authored
2d contexts may or may not be composited, the 2d layer bridge is the source of truth on this. Bug: 1019212 Change-Id: Iaf1649ee828214c0131c6357f4bd178872c660c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918695Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719650}
-
Christopher Cameron authored
It has been observed by crash reports that calls to -[MTLDevice newLibraryWithSource:options:completionHandler:] will hang in the function call itself (while trying to access the filesystem). This function is supposed to be completely asynchronous. Add metrics Browser.Metal.TestShaderMethodTime and Gpu.Metal.TestShaderMethodTime. This data is being gathered to paint a complete picture to give to Apple. Also fix a bug that cause Browser.Metal.TestShader and Gpu.Metal.TestShader to not be comparable. The browser version was issued after the run loop became idle, while the gpu version was issued inline during initialization (and so its callback could be delayed). Change both versions to run off-thread after 90 seconds (somewhat arbitrarily chosen). Also remove the "seed" parameter used to defeat persistent caches, and use a random value instead. TBR=avi (content/, chrome/), ericrk (components/) Bug: 974219 Change-Id: Iedfdc02267782e50cec8ef7a0272c61388f2938c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936111 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719649}
-
Mike Wittman authored
This grd file wasn't committed and is unnecessary, so remove the reference to it. Bug: 1027654 Change-Id: I1edd484695b6213b0b7799e0d57e6afb5f17eec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940356 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#719648}
-
Andrew Grieve authored
Was missing forward_variables_from() for these. Change-Id: Iacdbe5b00ffd39bb425f488a7604b86f522f57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937512 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719647}
-
Miyoung Shin authored
This CL converts SharedWorkerConnector mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ica85b49fa128fe6a6a15e0fd01b0189f7c8b1d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935780 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719646}
-
Javier Ernesto Flores Robles authored
Updates the way more info is presented to be in a popover. Which looks better and takes less space. See attached bug for screenshots. Bug: 1028095 Change-Id: I633a3e7ec614a4ec87d93bce1d02e8b50f015bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940169Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#719645}
-
Chris Sharp authored
Disable GooglePasswordManagerNavigationThrottleTestWithPasswordManager.PasswordsWithGPMAndSyncUserClickedLink This test is flaky on ChromeOS, so disable it there. TBR=vasilii Bug: 1029034 Change-Id: I0b67a7885d6e35951a5392c1c432adfa1efdb3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939910Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719644}
-
Chris Sharp authored
This reverts commit 26ae2ec0. Reason for revert: WebUITabStripInteractiveTest.CanTypeInOmniboxAfterTabStripClose is often failing on Linux ChromiumOS MSan Tests. Original change's description: > Re-focus View on tab strip close > > When the WebUI tab strip's WebContents gains focus, the focused > TextInputClient changes while the focused View does not. This causes > text input to stop working in the omnibox despite it having Views-focus. > > This blurs and re-focuses the currently focused View. For the Omnibox, > this makes it re-install itself as the focused TextInputClient. > > This is a workaround and should be removed once bug 994350 is fixed. > > Bug: 1027375, 994350 > Change-Id: I2be055110535dc6164a7d31a64a3cf503fae7a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935729 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719473} TBR=dfried@chromium.org,collinbaker@chromium.org Change-Id: Ie42b57d5e4b40f28fc77eb48c36c9ecddf5caba7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027375, 994350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940451Reviewed-by:
-
Michael Spang authored
This needs to run autoreconf. Bug: 1026476 Change-Id: Ibe0c0553258dd6d05c43715e32b24e11b2c4cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938838 Auto-Submit: Michael Spang <spang@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
