- 24 Jan, 2020 40 commits
-
-
https://crbug.com/1028577Marc Grimme authored
This adds an integration test that covers a bug that was observed when default_policy_allowed/blocked_hosts were specified but should be different per browser profile. It turned out they were global. This was fixed and the CL:1978680 introduces the test to cover this. R=marcgrimme Bug: 1031179 Change-Id: I6a5a0b10109ed4b358bd4344a56eeac705949198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978737 Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#734909}
-
Alex Ilin authored
The last step of the browser resolution flow is to make another call to IssueToken with the consent result. This call should actually generate and return the token. If this call fails, an error will be returned to the extension. Bug: 1026237 Change-Id: If350d325492d7d88f0583cc1687da7e5f7474d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017486 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#734908}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: Ia8563047cf077d4f7037d79cbdcd3e0c7c23cce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015093Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734907}
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: I1ab2b3292da012580977a9c39d1684bb167b4905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014405 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734906}
-
Benoît Lizé authored
Remove a switch statement used to record a metric, following a suggestion from alexilin@. Also update the enum to an enum class, following the latest best practices regarding metrics recording. Update the code in resource_fetcher.cc accordingly. Bug: 1043679 Change-Id: I04a31ca15e9c56442b3aaa4e57207e9b3481e252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016638 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#734905}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f809ec69. With Chromium commits locally applied on WPT: 4119fca8 "Remove outdated css grid-align tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing domenic@chromium.org, ricea@chromium.org: external/wpt/streams drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI hbos@chromium.org, hta@chromium.org: external/wpt/webrtc iclelland@chromium.org: external/wpt/feature-policy igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/IndexedDB kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/trusted-types msisov@igalia.com: external/wpt/webvtt rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I8d28eb4674fbdd3093c1e90d572756b9acb6acbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018768Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734904}
-
Lucas Gadani authored
This is a reland of 4ba80e19 Original change's description: > CSP: Enable out of blink enforcement of frame-ancestors. > > Bug: 1032139 > Change-Id: Iac59a5e6c8452da0cf7e7ebc549a10d8970cc8c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988684 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729823} Tbr: nasko@chromium.org, jam@chromium.org Bug: 1032139 Change-Id: I2694dfc496d8bbb4750182ad0cbddb3cf1855ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017669Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec1d3d8d903c..241fe49617e2 Created with: gclient setdep -r src-internal@241fe49617e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I2db3830c7316cdf4f608f7645bec7f2888993d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019065Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734902}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I0b86d018f5f218232271e29445b513ab70c82dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017326Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1042208 Change-Id: I4cbb82c391462dc8ff5cdbb4f2e7df33a35811d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017464Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1938fac7fc0d..6f088c0566ed git log 1938fac7fc0d..6f088c0566ed --date=short --first-parent --format='%ad %ae %s' 2020-01-24 tvanderlippe@chromium.org Migrate formatter/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate browser_sdk/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate help/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate input/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate color_picker/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate components/ to import cross-module 2020-01-24 tvanderlippe@chromium.org Migrate bindings/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@6f088c0566ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iafeb42787ac62810328bb166eb904d1a4f5bf1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734899}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab7ac60f14ae..b97057e7f747 git log ab7ac60f14ae..b97057e7f747 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 syoussefi@google.com Use spirv-headers' BUILD.gn (#3148) 2020-01-23 syoussefi@google.com Roll external/spirv-headers/ af64a9e82..dc77030ac (4 commits) (#3147) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b97057e7f747 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,syoussefi@google.com Change-Id: I9adcf5232efdd0e0ff5cadddc706598e2be09727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017652Reviewed-by:
-
Javier Fernandez authored
When the overflow-wrap: 'break-word' feature is used, items overflowing don't have an associated ShapeResult instance, since we deliberately set the kNoResultIfOverflow to ignore it because it will be rewound in any case. However, in the RewindOverflow function, we incorrectly assumed that when an item has no associated ShapeResult, it shouldn't be a trailable text item. Additionally, this CL removes the clause that implied that items formed with all trailable spaces should be ignored. Such logic prevented such kind of items to hang, which is what the spec mandates when pre-wrap is being used. Bug: 1003184 Change-Id: Iab930be3ecc8e4dc814be25d902ecedabc70a944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919351 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734897}
-
vitaliii authored
This simplifies passing it around both on the client and on the server. Bug: 1043929 Change-Id: If04978a2757d6bdda3366f1882b85978b3aa3b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017355 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734896}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/760fd5249488..9bac68c0cc44 git log 760fd5249488..9bac68c0cc44 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 kron@webrtc.org Reland "Reland "Distinguish between send and receive codecs"" Created with: gclient setdep -r src/third_party/webrtc@9bac68c0cc44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia45c015c7d76de3c5fb72044f26a6c1457d9c74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018041Reviewed-by:
-
Anton Bikineev authored
Bug: 1029379 Change-Id: If12fdae01e9c8cabcc1cb6466e2f7201b17da464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012943Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#734894}
-
arthursonzogni authored
Change https://chromium.googlesource.com/chromium/src/+/35a95c7a58d49987f577b72bdb2285f7ea6d1c5a introduced a bug. When parsing a group of CSP policy, it was storing for each parsed policy the whole header instead of just the header for the policy itself. It means when parsing "n" policies, it ends up storing O(n²) bytes. Clusterfuzz used it to trigger an OOM. Well done ;-) Bug: 1042706 Change-Id: I6b8b448de0103bc3d1cedb7d01154f46728fed9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017434 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Pavol Marko authored
The --disable-signin-frame-client-cert-user-selection switch was only necessary during rollout of the client certificates on the Chrome OS sign-in screen feature. Remove it. Bug: 1011602 Test: browser_tests still pass Change-Id: I79f7f8babe128d55bfc76c27272a1c020f230dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014446Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#734892}
-
Marc Treib authored
In practice, CoreAccountId is a GAIA ID anyway on all relevant platforms, so this doesn't actually change anything. But CoreAccountId is not guaranteed to be a stable identifier and so shouldn't be used for this purpose. Bug: 1035407 Change-Id: Ic10529ece6bb3c580eb03baee5b2a307f68bf768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016637 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#734891}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2232f78616d..ec1d3d8d903c Created with: gclient setdep -r src-internal@ec1d3d8d903c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I585ec26ccf0f1af244ae1bae567bb527d6e94171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018964Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I32f46257a703c2c3b1f3e7798e3a8ed7c28f864a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018985Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734889}
-
Colin Blundell authored
As part of the ongoing effort to componentize SSLErrorHandler for sharing with WebLayer, this CL passes CaptivePortalService into SSLErrorHandler from the embedder rather than having SSLErrorHandler fetch it internally from the Profile. As that fetch was the last usage of Profile in SSLErrorHandler, this CL also enables changing SSLErrorHandler's dependence on Profile to instead be a dependence on BrowserContext. Note that this CL does not attempt to remove th dependency on the factory from the SSLErrorHandler unittest; that will come when we clean the //chrome deps from the unittest after cleaning them from the production code. Bug: 1030692 Change-Id: I711cf726977980dcadb9c6b00d7b9b245628db0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016636 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734888}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I51aeff3e5b715214c0a1b912a035c1bf762fb030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014972 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734887}
-
Marc Treib authored
This CL removes prefs::kIsAccountStoreDefault, and instead adds an entry in prefs::kAccountStoragePerAccountSettings. Since the old pref was never launched, no migration code is necessary. Bug: 1035407 Change-Id: I7d47fbaf663a7f07c2747d05633a0efb51d03587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014926Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: Id5fa0845ad499bb3d2922b23d7e9a9d6ad3f5920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017483Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734885}
-
Roman Sorokin authored
Also increased expiration date Fixed: 1043693 Change-Id: I6fdcd67ec27e7252025947a3b214d9e8fa0d8247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014401Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734884}
-
Andrew Solovey authored
Add tests to check output format of the |WriteAscii| and |WriteHTMLGraph| methods. Tests check that all components of the graph graphical representation are on there places: graph header, newline symbols, graph pillars with value description. R=dcheng@chromium.org Bug: 1006447 Test: browser_tests --gtest_filter="HistogramTest" Change-Id: I37406b094d81171d27f7fe372424ef43ccdf20e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980609 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#734883}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95d34a042140..1938fac7fc0d git log 95d34a042140..1938fac7fc0d --date=short --first-parent --format='%ad %ae %s' 2020-01-24 mathias@chromium.org Remove String.escapeInvalidUnicodeCharacters Created with: gclient setdep -r src/third_party/devtools-frontend/src@1938fac7fc0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042269,chromium:848823 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia484775b61920a1a570c3e34594903746d1f4bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018741Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: Ifcc19a9aeaa6243cc166e72ee85b6c73e5f00594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017283Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3b4e6c3030f..4e98dfeaf092 git log f3b4e6c3030f..4e98dfeaf092 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src aaba1e4e6aec..93ab50fc27de (2 commits) 2020-01-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader c514ab001bb0..5ef91b82cbed (4 commits) Created with: gclient setdep -r src/third_party/angle@4e98dfeaf092 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ibae944456437d74162a44807aca88fab81b48284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018739Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=dvadym@chromium.org Bug: 1042208 Change-Id: I31fa8b793a8752c53a300920d338459f0f93afb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014970Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ce872b758f4..612949e9d25e git log 6ce872b758f4..612949e9d25e --date=short --first-parent --format='%ad %ae %s' 2020-01-24 eseckler@google.com processor: TrackEvents: fix passthrough utid, tid/pid names 2020-01-24 eseckler@google.com Merge "processor: Also save legacy_passthrough_utid for track-based instants" 2020-01-23 fmayer@google.com Fix debug build. 2020-01-23 fmayer@google.com Roll to new libunwindstack. 2020-01-23 lalitm@google.com Merge "trace_processor: add benchmark for sorted + other column" 2020-01-23 cferris@google.com Merge "Update for changed MapInfo constructor." 2020-01-23 fmayer@google.com Merge "Demangle C++ names in flamegraphs." 2020-01-23 ddrone@google.com Merge "Clarify assert error message" 2020-01-23 fmayer@google.com Merge "Fix assertion." 2020-01-23 fmayer@google.com Add some docs about java heap profiling. 2020-01-23 fmayer@google.com Merge "Truncate tree depth." Created with: gclient setdep -r src/third_party/perfetto@612949e9d25e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If8192f8496de37477f414dfa1b6a4ddd0390b2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018963Reviewed-by:
-
Colin Blundell authored
This CL componentizes ssl_error_assistant.asciipb and the infrastructure that is used to generate a binary proto from the ascii file at build time. The motivation is to support componentization of ssl_error_assistant.*, which will itself be needed for componentization and sharing of //chrome's SSLErrorHandler with WebLayer. As far as I could ascertain from examination of the Python scripts, nothing on the cloud storage side is impacted by where the binary proto sits on the client side; thus, this change should be safe to make without requiring any coordination with the operation of the component updater for this data. Bug: 1030692 Change-Id: I474b1a56c91d98e930047e9b122c9a3aa39dd84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011808 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734877}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d90bc187e8db..f2232f78616d Created with: gclient setdep -r src-internal@f2232f78616d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6b414579f717106f2744f16b988e79e4b9769e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018962Reviewed-by:
-
Huanzhong Huang authored
Change HatsService so it can hold multiple survey configs, and so it is able to launch different surveys in different contexts. Bug: 1045348 Change-Id: I811b22499e8c970b3bd8a89af361fe161fec1c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904076 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#734875}
-
Olga Sharonova authored
Slow/fails. TBR=lambroslambrou@chromium.org Bug: 1045344 Change-Id: Ic71ed6fb9b6be847de36375077a545d8d51ceaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017409Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734874}
-
Fabian Sommer authored
Add textfield for PINs with unknown length to ParentAccessView as alternative to current field that needs to know pin length in advance. Add option to hide entered pin. Add binding of Escape key to closing the view. These (independent) changes are part of a larger refactoring with the aim to make the UI in this class reuseable, in particular for smartcard login. Bug: 1001288 Change-Id: Ib0d3879780affe5a09c5ea4f1b8864120ca210c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007717Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#734873}
-
Martin Šrámek authored
These have been consistently failing for a long time now. https://ci.chromium.org/p/chromium/builders/ci/android-asan?limit=200 Bug: 1045356 Change-Id: I84940ed6dd4f9eae0f4dae4523660c38c796ad14 TBR: nuskos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017529 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#734872}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: Ie3c5d3607b588a916c3dd2345e0d0705106e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017509 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734871}
-
Takashi Toyoshima authored
virtual/omt-worker-fetch/external/wpt/fetch/api/basic/keepalive.html failing as the original is. NOTRY=true TBR=yhirano@chromium.org, nhiroki@chromium.org Change-Id: I0afa8d0c819691dbb5dc1b8ca7bd0472e704a2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016696Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#734870}
-
