- 30 Jul, 2018 40 commits
-
-
Ryan Hamilton authored
Add a new QUIC platform API class ScopedEnvironmentForThreads which needs to be instantiated in tests which use threads. Merge internal change: 206067592 Change-Id: Id873cbe6dbd6d515571f36454375129c85ff5eba Reviewed-on: https://chromium-review.googlesource.com/1150811 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579195}
-
Dale Curtis authored
When EME is attached, if playback is ongoing, we will attempt to recreate the WatchTimeReporter without triggering play on it again -- losing that watch time. It's unclear if this is actually a real possibility though... is EME required to be attached to start playback of even a non-encrypted stream? Or just by the time the encrypted portion needs to play? Previously this also happened for property changes, but since those have all moved into secondary property updates that don't restart the reporter, there is no issue there anymore. BUG=none TEST=none. Change-Id: Ib2c021418eb63634c59b450bf9c80810ca2dc835 Reviewed-on: https://chromium-review.googlesource.com/1148951Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579194}
-
Amy Qiu authored
It's been a week since simple_mobile_sites was refreshed, remove the old pages and corresponding expectation Bug: 852530 Change-Id: I8f18f80794ae711f36215ee50b50d8bb40e7dbf9 Reviewed-on: https://chromium-review.googlesource.com/1154997Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#579193}
-
Zhenyao Mo authored
BUG=867155 TEST=manual R=crouleau@chromium.org,sunnyps@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id5bc22f7e8452e46397dd1a47fe7b1c8d50ff915 Reviewed-on: https://chromium-review.googlesource.com/1112771Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579192}
-
Matt Menke authored
This way, they don't need chrome OWNERS approval to modify them. Bug: None Change-Id: Ie4e658999973224e31fb562a14f688dd6d682fea Reviewed-on: https://chromium-review.googlesource.com/1155094 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#579191}
-
Peter Wen authored
Bug: 620034 Change-Id: I4f128cfea59bb38615adc71cd8081a74c60cc39c Reviewed-on: https://chromium-review.googlesource.com/1155731 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579190}
-
Antoine Labour authored
This path seems to be causing problems on some Android phones, so disable for now. Bug: 854298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifeba070c6c7805217c76b59e7f0328f188bc5615 Reviewed-on: https://chromium-review.googlesource.com/1155472Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579189}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8584902d81ff..d718d634b7aa git log 8584902d81ff..d718d634b7aa --date=short --no-merges --format='%ad %ae %s' 2018-07-30 tsepez@chromium.org Type-safe iteration over CXFA_ContentLayoutItems. 2018-07-30 thestig@chromium.org Fix a misspelling of "locale". 2018-07-30 thestig@chromium.org Remove a NOTREACHED() in FormValueNode_SetChildContent(). 2018-07-30 hnakashima@chromium.org Remove CFGAS_PDFFontMgr::m_FDE2PDFFont font cache. 2018-07-30 art-snake@yandex-team.ru Check maximum bit count of shared group object numbers. Created with: gclient setdep -r src/third_party/pdfium@d718d634b7aa The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868477 TBR=dsinclair@chromium.org Change-Id: I1c8753d90baf966d4c51eb20fec35a26ca8d2778 Reviewed-on: https://chromium-review.googlesource.com/1155429Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579188}
-
Robbie McElrath authored
This migrates AutoEnrollmentClientImpl and AppInstallEventLoCollector from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 821009 Change-Id: I33dbd4ab0102d5a55bf34affdb7366b444e842ac Reviewed-on: https://chromium-review.googlesource.com/1147602 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579187}
-
James Cook authored
The number of shards for browser_tests on "Linux Chromium OS ASan LSan Tests (1)" was increased to 30 a while back, but not viz_browser_tests. This means viz_browser_tests often timeout on the bot. I'm upping the number of shards to be the same for the two. (sky@ recently did something similar for mash_browser_tests) BUG=794372 TEST=none Change-Id: Ibbdb086bc37e8a4722a0e5ab0eeb6312a8db4741 Reviewed-on: https://chromium-review.googlesource.com/1155634Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#579186}
-
Sahel Sharify authored
Bug: 868584 Change-Id: Ifa831ebeb3c7b2b86dc9cb5d56d122085eabfec1 Reviewed-on: https://chromium-review.googlesource.com/1155148 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#579185}
-
Katie D authored
Has to make callbacks optional too in order to continue to pass closure compilation. Bug: 866161 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie911461b0e575771708897bca30483fa9cc9f038 Reviewed-on: https://chromium-review.googlesource.com/1155643Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579184}
-
Joanmarie Diggs authored
The missing states already exist in the platform-independent accessibility code and are already used in the platform-specific accessibility code. They just need to be exposed via ATK. R=dmazzoni@chromium.org Bug: 868735 Test: AXPlatformNodeAuraLinuxTest.TestAtkObjectState Change-Id: I098c5e53d4a1f5cf44331847ef5790c46e1d59d7 Reviewed-on: https://chromium-review.googlesource.com/1154358 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#579183}
-
Mustafa Emre Acer authored
This CL adds a new presubmit check to verify that new or modified translation strings have associated screenshots. It does this by parsing the modified grd/grdp file, loading the messages and comparing them with old messages. It then checks whether the corresponding screenshot file exists. See go/chrome-translation-screenshots for design details. Change-Id: I981b3a95b66e2df8eee1d2b48223251fa0ff03a7 Bug: 814899 Reviewed-on: https://chromium-review.googlesource.com/872199Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
This reverts commit 748ac91e. Reason for revert: Broke orderfile generation. Original change's description: > Reland "build: Enable ThinLTO in official Android builds." > > This relands commit 1ba5d611. > > Fixes chromeos build issue by checking whether we have a secondary > toolchain before comparing it with the current toolchain. > > Original change's description: > > build: Enable ThinLTO in official Android builds. > > > > With this change we start building Chromium with ThinLTO when targeting > > Android. In 64-bit Monochrome builds, the 32-bit binary is also built > > with ThinLTO. This change is expected to reduce code size significantly > > (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB) > > and is a prerequisite for enabling control flow integrity in official > > builds. > > > > Note that although this change enables ThinLTO, it does not enable > > the cross-TU optimizations normally associated with LTO. Enabling > > cross-TU optimizations is a separate project. > > > > On my local machine (a Lenovo P920) libmonochrome.so link times increase > > as follows: > > > > before after (first link) after (incremental links) > > 32-bit 18s 140s 50s > > 64-bit 13s 107s 41s > > > > All known blockers have now been fixed. This CL is likely to uncover > > unknown blockers. > > > > Bug: 469376 > > Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749 > > Reviewed-on: https://chromium-review.googlesource.com/1150870 > > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578195} > > Bug: 469376, 868426 > Change-Id: Ie46ba0db0ac68130bc600415777de5c813b28ebd > Reviewed-on: https://chromium-review.googlesource.com/1153612 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578854} TBR=thakis@chromium.org,dpranke@chromium.org,pcc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 469376, 867878 Change-Id: Ie25a3cb8ca94cc4e9ba3edf53833f5e495654c92 Reviewed-on: https://chromium-review.googlesource.com/1155054Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579181}
-
Weilun Shi authored
When Building the ThemeInfo, we consider both default theme and system theme(GTK on Linux) as "default" theme. Because we can only apply custom background on the "default" theme, after applying the change we can now observe presence of gear icon on the GTK theme. Before: https://screenshot.googleplex.com/824PuvixCXA.png After: https://screenshot.googleplex.com/opmnGbv2xPx.png Bug: 851035 Change-Id: I14dd9019db665c084731bec374f0ce357afd9f45 Reviewed-on: https://chromium-review.googlesource.com/1150606Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#579180}
-
Kyle Milka authored
Adjust scrim from 20% opacity flat to, 0% (top) – 30% (bottom) Bug: 867753 Change-Id: I9b99f511c0656b352ca0c2840e6cd829b6d27576 Reviewed-on: https://chromium-review.googlesource.com/1155256 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Tommy C. Li authored
The suggestions indent was updated from 48dp to 47dp in a previous CL. This CL updates the jog length from 12dp to 11dp to match that. Bug: 868157 Change-Id: Ief7e64861e2a35fa2711209728c6078cb249c61d Reviewed-on: https://chromium-review.googlesource.com/1155386Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#579178}
-
Dan Sanders authored
If the parent thread is the same as the gpu thread, these tests were incorrect, allowing work to be done after Destroy(). Now that Windows is running the media InterfaceFactory on the GPU main thread, this causes use-after-free of |media_log_|. Bug: 868760 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I70dbeafe6744f721ef0eb407f43481095b7df3a5 Reviewed-on: https://chromium-review.googlesource.com/1155469Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#579177}
-
Peter Kasting authored
This was supposed to have been in https://chromium-review.googlesource.com/c/chromium/src/+/1152522 . Bug: 866672 Change-Id: I4b2076e13b1dc0ae2db0eec51775fb80790b90d7 TBR: estade Reviewed-on: https://chromium-review.googlesource.com/1155486Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#579176}
-
Erik Luo authored
Simplify visible index calculation and tests by - Remove padding on viewport container - Remove negative margin (was on error/warning logs) Improve visible index / scrollItemIntoView() precision by - Rebuild cumulative heights even if each message is slightly off - No need to scroll last item into view if it is fully visible - Perform extra scroll on scroll into view in case items above were larger than expected - Message height measurements now include wrapper's border Bug: 865674 Change-Id: Id4abad0e40a971dff9accbc7b904427ea02f728c Reviewed-on: https://chromium-review.googlesource.com/1144254 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579175}
-
Peter Boström authored
virtual/gpu-rasterization/images/color-profile-image-filter-all.html is flaky and times out occasionally. Bug: chromium:866166 Change-Id: Ib966574467cdb6e34ffef4f8f3323f11228b0a2c Reviewed-on: https://chromium-review.googlesource.com/1155638 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#579174}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e452382a61a1..67c388e6c04e git log e452382a61a1..67c388e6c04e --date=short --no-merges --format='%ad %ae %s' 2018-07-30 fjhenigman@chromium.org Vulkan: support GL_FIXED vertex data. Created with: gclient setdep -r src/third_party/angle@67c388e6c04e The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I119b51f30ea0e12db5dd4264b2bfa1d5be121043 Reviewed-on: https://chromium-review.googlesource.com/1155074Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579173}
-
Weilun Shi authored
Setting all the attributions to empty string for all the images in the 'Solid Colors' collection. Therefore, attributions will no longer show for the them. Notice that, this change will not affect the 'Solid Color' image that already applied. To make it work, one should either open a new profile or change the background image and then change it back. Before: https://screenshot.googleplex.com/AQbWxLqi7UD.png After: https://screenshot.googleplex.com/0PFpVvCU4QC.png Bug: 868164 Change-Id: Ie5b8b416ba6ed0fedbc9ce5d19e18b67f410f0f4 Reviewed-on: https://chromium-review.googlesource.com/1152534 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Penny MacNeil authored
Change-Id: Ia94594d1970b8bbe7ff669bd51fd3c9842392ced Reviewed-on: https://chromium-review.googlesource.com/1155161Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#579171}
-
Nasko Oskov authored
This reverts commit 461c6510. Reason for revert: <INSERT REASONING HERE> Original change's description: > Eanble WebNavigationApiTest.Failures test. > > This test was likely flaky due to a race condition in navigation code, > which has now been fixed. Let's try to enable it and see if the fix has > helped deflake this test. > > Bug: 477840, 746407 > Change-Id: Ib1d449dd34c2d6044a60da38f03ac548179d475c > Reviewed-on: https://chromium-review.googlesource.com/1153221 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578836} TBR=nasko@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 477840, 746407 Change-Id: I553fa362ace34616cc34c496190e5b0c57bfd846 Reviewed-on: https://chromium-review.googlesource.com/1155490Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579170}
-
Moe Ahmadi authored
Exisitng behavior is inconsistent with the Sync Settings switches and can caused confusion in the redesigned Autofill Settings where turning the master on/off enables/disables the addresses and credit cards toggles. Bug:865476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6d2afcb0a24de95b4eb1141ec42699f18733bfe3 Reviewed-on: https://chromium-review.googlesource.com/1143591 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#579169}
-
Jordy Greenblatt authored
The new unified setup project for multi device features involved consolidating the infrastructure for all the existing features (Instant Tethering, SmartLock) as well as the infrastructure for features that are not fully built (Android Messages). ------- This is a screenshot of the console showing the pref https://drive.google.com/open?id=0B1-cJJPK-cu6OGxTQnNLMEFHWDhibXJOSVJwclBoVGlFRF84 Change-Id: I7cedd5c9b7608ddea4f3914b1c0eb11f1ea1c7d3 Bug: 824568 Reviewed-on: https://chromium-review.googlesource.com/1154032Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#579168}
-
Stephen Martinis authored
This allows for a smoother rename. The previous attempt at this (https://chromium-review.googlesource.com/c/chromium/src/+/1153616) caused the bot to show some errors. This is because the services which rely on the configs in //infra/config have a ~10 minute lag, so while those services were picking up the new configs, the existing builder configs (with old names), couldn't find themselves in any config files. This CL adds the new names, which will coexist alongside the old names. This means the 10 minute lag doesn't matter anymore, since both names are valid everywhere. Bug: 867725 Change-Id: Ic61f81c40c40d3c150bb53c39c88bcc2ee3f98c1 Reviewed-on: https://chromium-review.googlesource.com/1155263 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579167}
-
Sahel Sharify authored
This reverts commit 7cb247dd. Reason for revert: Check to see if the crash report in crbug.com/868849 goes away or not. Original change's description: > Clean up DidStopFlinging IPC > > This cl also removes TouchscreenFlingInProgress function that is no > longer needed. > > Bug: 249063 > Change-Id: Icc939d654cdfe0cf38c843933f2fd469f843b74c > Reviewed-on: https://chromium-review.googlesource.com/1145784 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578410} TBR=kenrb@chromium.org,pdr@chromium.org,dtapuska@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 249063 Change-Id: Iee7200d3c4e388fccbc2dc6b86997a07a3a03f0a Reviewed-on: https://chromium-review.googlesource.com/1155169Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579166}
-
Ahmed Fakhry authored
Currently, the Command key on external Apple keyboard are always mapped to Ctrl, and users have no way of changing this, and as long as they don't remap other keys to Search they won't be able to trigger any Search-based shortcuts which are heavily used for OS-type actions. This CL implements a solution for this problem based on discussion and agreement with UI review: - Add a new preference for the remapping of the Command key on Apple keyboards that is by default set to Ctrl. - Add a new preference for the remapping of the Meta key (Search or Windows keys) on external non-Apple keyboards. This is mapped by default to Search. - The above two prefernces are independent from each other and they don't affect the preference to remap the internal Search key. - The two new preferences are surfaced to the user in the keyboard settings as drop downs which show up only when the external keyboards are connected. - Group external keyboard settings together, which means move the setting to remap Caps Lock to the end near the newly added settings. Screenshots: - Apple keyboard connected: https://screenshot.googleplex.com/QtSAsGoPeLY.png - Non-Apple keyboard connected: https://screenshot.googleplex.com/S9szhUberNL.png - Both keyboard types connected: https://screenshot.googleplex.com/zJkRTamxHN5.png BUG=692424 TEST=Manually TEST=Modified and added new tests. Change-Id: Ibf0f3dba21b32e13f6bbcb5e7500903a1c412f04 Reviewed-on: https://chromium-review.googlesource.com/1074336 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579165}
-
Theresa authored
BUG=842692 Change-Id: I7b8b2b6b259c9b18706f294e99a4530729a21d13 Reviewed-on: https://chromium-review.googlesource.com/1155367 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579164}
-
Nick Burris authored
Similar to the engine sandbox and Chrome prompt IPCs, this result code indicates the sandbox connection was closed while it was still needed. Bug: b/111108241 Change-Id: I8b231c5921e51b57932ce8d5054f9dd0484be46f Reviewed-on: https://chromium-review.googlesource.com/1154995Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Nick Burris <nburris@google.com> Cr-Commit-Position: refs/heads/master@{#579163}
-
Gina Ko authored
1. Reboot source is used for logging and metrics when the next reboot happens. Changing the name to better reflect the purpose. 2. Remove *SetGetLastRebootSource tests. These tests only ensure when SetLastRebootSource() returns true, it indeed sets the reboot source correctly. Other than that, there's no extra value. Bug: internal b/111883075 Change-Id: Iffab2ef32d93306590914d7133080c4d8278feed Reviewed-on: https://chromium-review.googlesource.com/1152526Reviewed-by:
Bailey Forrest <bcf@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yi-Chun Gina Ko <yichunko@google.com> Cr-Commit-Position: refs/heads/master@{#579162}
-
Reid Kleckner authored
On Windows, the linker is invoked directly, so we can't add -finstr-profile-generate to ldflags and expect things to work. Instead, explicitly link against the appropriate library. Update clang's package.py script to include clang_rt.profile-*.lib. After this, base_unittests links, but crashes during shutdown when writing the profile. BUG=846918 R=thakis@chromium.org,mmoroz@chromium.org Change-Id: I337e587b83750c86546a9673daeb593d4125bbd9 Reviewed-on: https://chromium-review.googlesource.com/1153625 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579161}
-
Dan Harrington authored
The motivation here is that I hit this invalid cast in a test, and it resulted in an empty callstack which was painful to debug. Profile::FromBrowserContext DCHECKs in a more friendly way. Change-Id: I5e1f423c66abbdce0604a6cfdbf8d4c988dde2af Reviewed-on: https://chromium-review.googlesource.com/1155259Reviewed-by:
-
Matt Menke authored
With the advent of the NetworkService, we're not going to have any URLRequestContext in-process, so we have to migrate the code to get the value from another API. This CL gets the accept-language string from the ContentBrowserClient on creation, rather than the current live value. Unlike the old code, if the value changes during the lifetime of the SpeechRecognitionEngine, the SpeechRecognitionEngine won't switch languages. Bug: 841445 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I014f971b1162dae0f93df84055ceac0b01fa7d71 Reviewed-on: https://chromium-review.googlesource.com/1151650Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The media long constraints work on the WebIDL definition of long which is equivalent to int32_t. The WebMediaPlayer interface would cause a narrowing of values on 32bit platforms which was unnecessary because WebMediaPlayerImpl keeps its stats in 64 bit values. BUG=596846 Change-Id: I687d1baf8fa5214d082adacce4e854b09c215819 Reviewed-on: https://chromium-review.googlesource.com/1145550Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#579158}
-
Jonathan Metzman authored
TBR=mbarbella@chromium.org Change-Id: Ia6780a4776c1745a622f365bcd35c5adf622ba91 Reviewed-on: https://chromium-review.googlesource.com/1155706Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579157}
-
Scott Violet authored
Renames AuraTestHelper::Mode::MUS to MUS_DONT_CREATE_WINDOW_TREE_CLIENT. Also updates some comments. BUG=none TEST=test only changes Change-Id: I967fa9119afac042f24273842ba6ef78c9f8a036 Reviewed-on: https://chromium-review.googlesource.com/1153299 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#579156}
-
