GitLab

This includes a new URL path /_/contextualsearch and a /search parameter specifying the contextual search version, if any.
BUG=379196

Review URL: https://codereview.chromium.org/308053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276874 0039d316-1c4b-4281-b951-d872f2087c98

The check for CanProcessEventsWithinSubtree() needs
to be made on |this| before the loop (along with
HitTestRect()) instead of inside the loop on the
children. Otherwise it would be possible to return
a view for which CanProcessEventsWithinSubtree()
returns false.

BUG=382873, 378530
TEST=Added coverage in ViewTest.CanProcessEventsWithinSubtree

Review URL: https://codereview.chromium.org/327843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/330053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276723

Review URL: https://codereview.chromium.org/317993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342983
R=ben@chromium.org

Review URL: https://codereview.chromium.org/247903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367677

Review URL: https://codereview.chromium.org/270203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276869 0039d316-1c4b-4281-b951-d872f2087c98

There's a rare crash in ChromeLauncherController that looks
like a user is switching into Ash with no profile and a
read-only profile directory. Add a CHECK to figure out how
common this problem is.

BUG=383019
TEST=none

Review URL: https://codereview.chromium.org/336603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276868 0039d316-1c4b-4281-b951-d872f2087c98

Currently a URLRequestJobFactory is optional, as the global
URLRequestJobManager passes jobs on to the URLRequestFilter and
global http/https/ws/wss factories.  In order to be able to
eliminate the global URLRequestJobManager object, first have to
give all contexts their own URLRequestJobFactory.

BUG=81979
TBR=ajwong@chromium.org (Who actually signed off on this, but Rietveld ignored his email).

Review URL: https://codereview.chromium.org/311393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276867 0039d316-1c4b-4281-b951-d872f2087c98

Also remove the option -w to only wipe without provisioning. This was temporary
functionality to recover from INSUFFICIENT_STORAGE on device error. With the
default wiping, this should be unnecessary. For bots that skip wiping, we can
still manually fix by manually running without --skip-wipe.

BUG=383106
TBR=craigdh@chromium.org

Review URL: https://codereview.chromium.org/334503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376562
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/332843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276865 0039d316-1c4b-4281-b951-d872f2087c98

Hit testing is done directly on the layer tree, it doesn't use the
render surface layer list, but it does require draw properties. So,
remove EnsureRenderSurfaceLayerList and have the FindLayer* public
methods on LayerTreeImpl just do UpdateDrawProperties() if it is needed.

Since we update draw properties there, we only need to update them in
PrepareToDraw when they are dirty as well.

R=enne, vollick@chromium.org

Review URL: https://codereview.chromium.org/332433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276864 0039d316-1c4b-4281-b951-d872f2087c98

The color needs to come from the menu's own native theme.

BUG=347832

Review URL: https://codereview.chromium.org/245863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276862 0039d316-1c4b-4281-b951-d872f2087c98

content_area_in_dpi send to browser process should cover entire page. This fixed shifting of content for system dialog printing.

BUG=379961
NOTRY=true

Review URL: https://codereview.chromium.org/327393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276861 0039d316-1c4b-4281-b951-d872f2087c98

This is to get ready to split ServiceProvider into Shell and Application. It makes the existing Application no longer subclass internal::ServiceConnectorBase::Owner. Instead it puts that functionality in the new class internal::ServiceRegistry and Application uses that by composition.

The validation in this cl is meant to be consistent with what's currently in the tree. I'll redo the cl that adds the ability to add a service with a specific validator after the split is done.

BUG=

Review URL: https://codereview.chromium.org/337533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276859 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add tests for session cache and false start behavior. (https://codereview.chromium.org/301283004/)

Reason for revert:
This patch may have broken http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/24391, but we're not confident. The failure is in libjingle_unittests, e.g. ChromeAsyncSocketTest.DoubleSSLConnect. Sorry for the inconvenience. 

Original issue's description:
> Add tests for session cache and false start behavior.
> 
> False start should not disable the session cache, but if we never process the
> server Finished message, the session cannot be resumed.
> 
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276815

TBR=davidben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276857 0039d316-1c4b-4281-b951-d872f2087c98

This can be used to construct nested CFRunLoops that are restricted to
the MessageLoop tasks.

BUG=314190

Review URL: https://codereview.chromium.org/333473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380229
TEST=as in bug

Review URL: https://codereview.chromium.org/329793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276855 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org
BUG=378916

Review URL: https://codereview.chromium.org/327853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276854 0039d316-1c4b-4281-b951-d872f2087c98

r232828 removed the touch device check in the delegate execute handler.
It should be removed from the "You're almost done" dialog and the
process singleton as well.

BUG=314818,374360

Review URL: https://codereview.chromium.org/329393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276853 0039d316-1c4b-4281-b951-d872f2087c98

Committed https://src.chromium.org/viewvc/chrome?view=rev&revision=276728.
Broke gn build.
Reverted: https://codereview.chromium.org/330613003

Ensure the screenPosition of touches is never truncated to an integer.

Check if the unified gesture detector is enabled before disabling
the inclusive slop region.

BUG=381174
TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/334753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276852 0039d316-1c4b-4281-b951-d872f2087c98

The change to combine NetworkState and FavoriteState broke
FirstNetworkByType for VPN since it doesn't appear with the "visible"
networks. We don't use that method a lot, so the easy fix is to remove
the early exit and continue instead of break.

BUG=375955
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/332713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276851 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276850 0039d316-1c4b-4281-b951-d872f2087c98

$ git log ae8085b09..aea50658a --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-06-12 maruel Remove --working-dir, it's not supported anymore.
2014-06-04 maruel Update swarming.py query for the new Bot attributes.
2014-06-03 maruel Update swarming_load_test_bot.py for new server code.
2014-05-29 maruel Add load test regexp to new key format.
2014-05-15 vadimsh Make 'swarming.py collect' return exit code 1 on task failure.
2014-05-14 vadimsh Collect output files only when child processes terminate (Windows only).
2014-05-14 vadimsh Correctly handle negative process exit codes.
2014-05-12 vadimsh Manage test sharding on a client side.
2014-05-08 maruel Make swarming_load_test_client.py more versatile.
2014-05-07 vadimsh Fix directory_to_metadata on Windows.
2014-05-07 maruel Fix swarming_load_test_client.py after ae8085b09e.
2014-05-07 maruel Update examples.

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/335463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276849 0039d316-1c4b-4281-b951-d872f2087c98

The PasswordAutofillAgent::SendPasswordForms method is called
both when HTML forms are just parsed, and also when they are rendered.
The former is the moment when the password manager first hears about
forms, and notes their presence not only for autofill, but also
for matching against credentials submitted later.

However, I missed the second use-case (matching submitted credentials)
when I put logging there for the internals page, and so currently
the progress is only logged when the forms are rendered.

This CL should change this: logs are now also sent when the forms have just been parsed.

I already saw issues (e.g., http://crbug.com/367768) where such additional logging would have sped up the investigation.

There are no tests, because we don't which logs are generated when.

BUG=347927

Review URL: https://codereview.chromium.org/323423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276848 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=342848

Review URL: https://codereview.chromium.org/338453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276847 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault (https://codereview.chromium.org/331513002/)

Reason for revert:
Broke Jingle unit tests on the bots.

Original issue's description:
> [Mac] Use a native MessagePump instead of a MessagePumpDefault
> 
> Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX.
> 
> In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win).  The current change achieves this and should provide a way to gauge the effect of timer coalescing.
> 
> An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing.
> 
> Local performance tests didn't uncover any regressions from this change.
> 
> BUG=356804
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276808

TBR=darin@chromium.org,mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356804

Review URL: https://codereview.chromium.org/336603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276846 0039d316-1c4b-4281-b951-d872f2087c98

Bubbles should not use the anchor rect of minimized windows.

BUG=372713
TEST=Minimizing and restoring Chrome with a session restore bubble should leave the bubble anchored as it was.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/332593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276845 0039d316-1c4b-4281-b951-d872f2087c98

Invoke the error_callback directly from OnSingleDatatypeUnrecoverableError.  We'll still double-upload certain stacks, see referenced bug.

BUG=383480

Review URL: https://codereview.chromium.org/319553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276843 0039d316-1c4b-4281-b951-d872f2087c98

Adds tests for code in https://codereview.chromium.org/322553005/
Also, update stylesheet to restrict max video size.
BUG=376107
TBR=blundell

Review URL: https://codereview.chromium.org/318723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276842 0039d316-1c4b-4281-b951-d872f2087c98

When the mime_type_handler key is available in an extension, this creates a
BrowserPlugin and gives the ID of it to the background page.

BUG=368514

Review URL: https://codereview.chromium.org/263513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276841 0039d316-1c4b-4281-b951-d872f2087c98

Add the about_page key to the manifest for shared modules. This will
later be used to display the license information for shared module apps.

BUG=364681

Review URL: https://codereview.chromium.org/311193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/303043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276839 0039d316-1c4b-4281-b951-d872f2087c98

Moves gcm_invalidation_bridge and ticl_invalidation_service files from
chrome/browser/sync to components/invalidation.

Refactors TiclInvalidationService so it no longer depends on
chrome/common/chrome_content_client.h.  Its only dependency on this file
was a call to GetUserAgent().  It was removed by changing the class so
that the user agent is specified at construction time.

Moves some related tests and test framework classes into
components/invalidation.

Updates the gyp files to prevent much of the TICL invalidation service
code from being built on Android.  This is the same setup as before the
move, though it does fix a bug where one of the previously componentized
files was accidentally enabled for building on Android.

BUG=336571

Review URL: https://codereview.chromium.org/319223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276838 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to do this in r276708.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/334663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276837 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Telemetry: Build symfs for Android VTune profiler (https://codereview.chromium.org/308123002/)

Reason for revert:
This breaks ChromeOS build at
http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29...

16:09:25 INFO | autoserv|
FAIL	login_Cryptohome	login_Cryptohome	timestamp=1402607364	localtime=Jun 12
14:09:24	Unhandled ImportError: No module named sqlite3
16:09:25 INFO | autoserv| AUTOTEST_STATUS::  Traceback (most recent call last):
16:09:25 INFO | autoserv| AUTOTEST_STATUS::    File
"/usr/local/autotest/common_lib/test.py", line 725, in _call_test_function
16:09:25 INFO | autoserv| AUTOTEST_STATUS::      return func(*args, **dargs)
...
16:09:25 INFO | autoserv| AUTOTEST_STATUS::    File
"/usr/local/telemetry/src/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py",
line 12, in <module>
16:09:25 INFO | autoserv| AUTOTEST_STATUS::      import sqlite3
16:09:25 INFO | autoserv| AUTOTEST_STATUS::  ImportError: No module named
sqlite3

ChromeOS image does not have sqlite3. Please either file a bug (cc vapier@) to
add sqlite3. Or skip the sqlite3 logic for chromeos.

I suggest to revert this for now so that it does not shadow other failures.

Please use 

cbuildbot --remote -G <rietveld_id> x86-generic-tot-chrome-pfq-informational
amd64-generic-tot-chrome-pfq-informational daisy-tot-chrome-pfq-informational

to ensure the CL runs fine on ChromeOS when landing the new version.

Original issue's description:
> Telemetry: Build symfs for Android VTune profiler
> 
> Extend and use android_profiling_helper.py to set up a symfs for VTune.
> Queries the required libraries from the profiler's output and pulls them from
> the device. This allows VTune to resolve all symbols in the profiling output.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276740

TBR=skyostil@chromium.org,simonhatch@chromium.org,tonyg@chromium.org,xiyuan@chromium.org,dominikg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/337603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276836 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/333443002 has landed, reactivate building
browser_tests.exe for official Windows builds.

BUG=379986

Review URL: https://codereview.chromium.org/328423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276835 0039d316-1c4b-4281-b951-d872f2087c98

This change caused the sole push_messaging layout test to fail :(.

> Hook PushMessagingMessageFilter up to GCMDriver
>
> Add plumbing for registration from push service-agnostic content layer
> to GCMDriver in chrome layer.
>
> To achieve this, GCMProfileService owns an implementation of a new
> PushMessagingService class, which can be used from the content layer.
>
> Based on mvanouwerkerk's prototype in https://codereview.chromium.org/186023002, but significantly refactored.
>
> BUG=350384
> TBR=benm@chromium.org

TBR=johnme@chromium.org
BUG=350384

Review URL: https://codereview.chromium.org/327423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276834 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276833 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke compile step on http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/12011

Compile error message:

Export includes file: external/chromium_org/GypAndroid.linux-arm.mk -- out/target/product/generic/obj/STATIC_LIBRARIES/third_party_webrtc_modules_PCM16B_gyp_intermediates/export_includes
make: *** No rule to make target `/mnt/data/b/build/slave/Android_Webview_AOSP_Builder/build/android-src/out/target/product/generic/obj/STATIC_LIBRARIES/libvpx_asm_offsets_vp8_intermediates/libvpx_asm_offsets_vp8.a', needed by `out/target/product/generic/obj/GYP/third_party_libvpx_gen_asm_offsets_vp8_gyp_intermediates/vp8_asm_enc_offsets.o'.  Stop.


Original issue's description:
> Roll libvpx 269083:275816 webrtc 6352:6415
> 
> libvpx:
> See https://codereview.chromium.org/295313002/
> https://codereview.chromium.org/298063002/
> https://codereview.chromium.org/305533008/
> https://codereview.chromium.org/305703002/
> https://codereview.chromium.org/298383003/
> https://codereview.chromium.org/302863004/
> https://codereview.chromium.org/320923003/
> for the actual changes.
> 
> webrtc:
> See https://codereview.chromium.org/313243004/
> for the actual changes.
> 
> BUG=377062
> R=ajm@chromium.org, tomfinegan@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276820

TBR=fgalligan
NOTRY=true

Review URL: https://codereview.chromium.org/330193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276832 0039d316-1c4b-4281-b951-d872f2087c98

Moves some test support classes out of the NonBlockingTypeProcessor's
unit test .cc files and into their own files.

Rearranges some responsibilities between the test harness and the mock
classes.  Much of the functionality related to mocking out server
behavior has been moved into the MockNonBlockingTypeProcessor.  This
makes it possible to share that code with other test harnesses.

This is one of several follow-ups to the commits that introduced the
NonBlockingTypeProcessor and NonBlockingTypeProcessorCore.

BUG=351005

Review URL: https://codereview.chromium.org/318193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276830 0039d316-1c4b-4281-b951-d872f2087c98