GitLab

Bug: 881364
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I99131d73c52118b1baa7dee460d91b0f9d7d8521
Reviewed-on: https://chromium-review.googlesource.com/1203997
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590273}

BUG=823254

Change-Id: Ibfa232b39e7003565ac68dba0e4e1aab9170c6fd
Reviewed-on: https://chromium-review.googlesource.com/1216845
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590272}

https://pdfium.googlesource.com/pdfium.git/+log/8550a2d1e037..9039169b64e1


git log 8550a2d1e037..9039169b64e1 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 thestig@chromium.org Do not copy data in DecodeAllScanlines().
2018-09-11 thestig@chromium.org Make flate decode functions' buffer out parameter unique_ptrs.
2018-09-11 thestig@chromium.org Make RunLengthDecode()'s buffer out parameter a unique_ptr.
2018-09-11 thestig@chromium.org Make HexDecode()'s buffer out parameter a unique_ptr.


Created with:
  gclient setdep -r src/third_party/pdfium@9039169b64e1

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I37b51823b66ded7a2c8c8f0d968c3ebdf5cbe0ab
Reviewed-on: https://chromium-review.googlesource.com/1218962Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590271}

This reverts commit 3ca917bd.

Reason for revert: The CL caused crashes on Chrome canary on Mac: crbug.com/882787

Original change's description:
> [OSCrypt] Add feature for preventing key overwrites in Keychain on Mac
>
> This Cl includes:
> - Add a feature flag which is disabled by default.
> - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
> - Add tests for the above changes.
> - Register the local state early from the main thread in os_crypt.
>
> Bug: 791541
> Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
> Reviewed-on: https://chromium-review.googlesource.com/1188318
> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589898}

TBR=battre@chromium.org,vasilii@chromium.org,rsesek@chromium.org,cfroussios@chromium.org,tsabolcec@google.com

Change-Id: I1be5c8294985e81115a8856f4105fbff8a3a28a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 791541
Reviewed-on: https://chromium-review.googlesource.com/1219086Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Cr-Commit-Position: refs/heads/master@{#590270}

Turns out we'll need it afterall since some ios code
uses NonNestable tasks, e.g. indirectly via DeleteSoon.

Bug: 867421, 878356
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I77c0161b083c987f48b0f3270490e8feee241b18
Reviewed-on: https://chromium-review.googlesource.com/1216564Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590269}

This CL only handles a difficult case in //net. The easy cases were
tackled by mechanical CLs, such as https://crrev.com/c/1188959 for
//net. Parallel CLs will tackle other difficult cases.

ability to reason about instance ownership locally, creating instances
via base::MakeRefCounted makes it possible to use 1-based ref-counting
in the future (see base/memory/ref_counted.h).

net: :IOBuffer is (thread-safe) ref-counted. Asides from improving the
Change-Id: I9925444170fcb8ab3740c1a1223c10c5d4060775
Reviewed-on: https://chromium-review.googlesource.com/1215465Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590268}

This was added recently for testing purposes, but I wasn't aware of
FRIEND_TEST_ALL_PREFIXES at the time. PropertyRegistration instances must
never exist unless CSSVariables2 is enabled, and I've been worried this
might accidentally happen ever since ::Create was added.

Added bonus DCHECK for even more inner peace.

R=futhark@chromium.org

Bug: 641877
Change-Id: I61780ec25fb09673a0f3325775ce1b891b0867cb
Reviewed-on: https://chromium-review.googlesource.com/1218702Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590267}

In http://crbug.com/881384#c2 I saw some more evidence that the page cache is
not fully flushed when benchmarking. On Linux/Android calling sync(2) syscall
before evicting individual files should help because the later pagecache
dropping operations become a lot cheaper for the kernel. I could not find good
documentation about sync(2) guarantees on MacOS.

The page cache flushing for individual files is still asynchronous, with no
cheap way to check that it happened. The plan is to sleep for one second after
such operations. Since we would prefer to sleep only once per bulk of
operations, the sleeping will be done on higher levels.

The Windows story is not covered - the operation requires administrator
privileges.

Bug: 811244
Change-Id: Ib71f4f934a0eb4b438bfedbbb50462e07ff64308
Reviewed-on: https://chromium-review.googlesource.com/1211602
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590266}

Use the "META: global=" annotation to run the web-locks/ tests in
shared and service workers, as appropriate.

Change-Id: I1d6acd9b4e2932bf3a60b1e41285cbe74e3cb8ff
Reviewed-on: https://chromium-review.googlesource.com/1208447
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590265}

InfoBarContainer is now managed by Tab's UserDataHost,
and accessed through new static methods |from()| and |get()| defined
in the container class. Tab still a reference to a container.
It will be removed when all the callsites of |Tab.getInfoBatContainer|
are updated in a follow-up CL.

Bug: 877878
Change-Id: If59bf7e750bcaf7f0988925ab06f94eb8974cddc
Reviewed-on: https://chromium-review.googlesource.com/1212378
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590264}

https://skia.googlesource.com/skia.git/+log/82bf31003c66..2bf7a7bcc67f


git log 82bf31003c66..2bf7a7bcc67f --date=short --no-merges --format='%ad %ae %s'
2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 63aa0e5b7001..0d0fb43f34ee (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@2bf7a7bcc67f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I76ea9dc652739a0e176a7f9f82f74f913dd92811
Reviewed-on: https://chromium-review.googlesource.com/1218963Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590263}

This is a reland of 061ac2e7

Original change's description:
> Add method to rewrite a LevelDB instance
>
> Add the infrastructure to remove expired data by rewriting LevelDB
> instances.
> The integration with actual storage implementation will be added in
> followup Cls.
>
> Bug: 823071
> Change-Id: Iff1b93481468423d292266f16a45f6ef4ac6e7f2
> Reviewed-on: https://chromium-review.googlesource.com/1152917
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587980}

Tbr: pwnall@chromium.org
Bug: 823071
Change-Id: I9f01dd376166879b89650619692a33cef48d19ae
Reviewed-on: https://chromium-review.googlesource.com/1201856Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590262}

Remove obsolete commentary about media constraint name sources.
They don't matter any more.

Bug: chromium:543997
Change-Id: Ib37fd318c5a03f9cb94acb9f68bb443f7d0d06bd
Reviewed-on: https://chromium-review.googlesource.com/1218723Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590261}

This patch adds a new class called ServiceWorkerUpdateChecker and
makes ServiceWorkerRegisterJob use this class. The new class has a
method called Start(), which takes a callback as an argument and
triggers it only when the scripts had any changes to update. Currently
this method runs the callback unconditionally, but following patches
will implement script loading and comparison with the stored resources.

Bug: 648295
Change-Id: Iebbe85b6d5e5cdab27c23873b04811626b5abad0
Reviewed-on: https://chromium-review.googlesource.com/1215458
Commit-Queue: Momoko Hattori <momohatt@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590260}

The button catching the taps when the toolbar is collapsed doesn't catch
the taps on the status bar.
This CL makes sure the toolbar is expanded when the status bar is
tapped.

Bug: 878382
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I71dd7af9ca7d2e47687887d69f11661c71e3d86c
Reviewed-on: https://chromium-review.googlesource.com/1199162Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590259}

The stack returned from _get_stack_from_dump can be None. This hardens
against this case, and hopefully another other unforseen issues around
the stack encoding, by transforming the stack to ascii inside a try
block.

Bug: 880246
Change-Id: I498b5929dab811a2ccc5e69bb51b930c8547179c
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1218842
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590258}

A commit just introduced two GetIdMap functions in ui/views/cocoa,
which broke jumbo builds because in jumbo builds they end up in
the same translation unit. This patch renames them
GetIdToWidgetImplMap and GetIdToWidgetHostImplMap

Bug: 859152

TBR=ccameron@chromium.org,ellyjones@chromium.org

Change-Id: I55b4a48d3d4f97c30450fd89bb8f52f46c2cedd7
Reviewed-on: https://chromium-review.googlesource.com/1219127Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#590257}

TBR=schenney@chromium.org

Bug: 880983, 882649
Change-Id: I5d75f448106ad20adf8e9e02ab33883b7eaa54a8
Reviewed-on: https://chromium-review.googlesource.com/1219247Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#590256}

Some crashes in CloseAndLockAndDisturb may be caused by early collection
of the stream referenced by BodyStreamBuffer. Keep an extra reference to
the stream on the stack as a speculative workaround.

BUG=882599

Change-Id: I798a175cbac6414a7a70cfcb1e924624232a0a19
Reviewed-on: https://chromium-review.googlesource.com/1218123Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590255}

This reverts commit 88924f03.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 590251 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4OTI0ZjAzOWQwYjk2NjI2YzMzYzIxODNiZDE3Nzk1MmIwMGEyYTYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/16046

Sample Failed Step: compile

Original change's description:
> blink/bindings: ASAN checks to ensure proper ParkableString accesses.
> 
> A ParkableString underlying string memory should not be cached.
> Following a suggestion by pasko@, add ASAN instrumentation to make sure
> this is actually the case.
> 
> Bug: 877044
> Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7
> Reviewed-on: https://chromium-review.googlesource.com/1216422
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590251}

Change-Id: I3ce53830604e42a6bef13da80a420c44b9d5df11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877044
Reviewed-on: https://chromium-review.googlesource.com/1218548
Cr-Commit-Position: refs/heads/master@{#590254}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1bfa8980a363..a2ceb19a3a9a


git log 1bfa8980a363..a2ceb19a3a9a --date=short --no-merges --format='%ad %ae %s'
2018-09-11 saklein@chromium.org Port cros_choose_profile to a chromite python script.


Created with:
  gclient setdep -r src/third_party/chromite@a2ceb19a3a9a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifdcffd368a45120135306a15b3a364df55f97929
Reviewed-on: https://chromium-review.googlesource.com/1218545Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590253}

The benchmark cannot report metrics correctly for WebView. Also WebView
cares about different startup scenarios and has its own stories for
that.

Bug: 880091
Change-Id: I76bec3c24843a5429bfeec45a53439b19b3d7ef6
Reviewed-on: https://chromium-review.googlesource.com/1217103Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590252}

A ParkableString underlying string memory should not be cached.
Following a suggestion by pasko@, add ASAN instrumentation to make sure
this is actually the case.

Bug: 877044
Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7
Reviewed-on: https://chromium-review.googlesource.com/1216422Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590251}

The bottom toolbar tip doesn't use the isUserEngaged variable.
This allows us to display the tip multiple time during the isUserEngaged
period, for example during test.

Bug: 881829
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia4559353aaf831abeb34fd01bf4f4911d1a3267e
Reviewed-on: https://chromium-review.googlesource.com/1215208Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590250}

This reverts commit 87036e9b.

Reason for revert: Compile failure: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/146603

Original change's description:
> [Android] Use a delegate for all keyboard visibility functions
> 
> This CL extends the use of the visibility delegate from affecting
> only the isKeyboardShown() function to all keyboard-related methods.
> 
> Using a delegate is also the first step to move towards binding
> the keyboard detection to WindowAndroid. This enables other
> components like the keyboard accessory to affect the visibility on
> an activity-specific level (instead of global and static).
> 
> These changes require more work and will follow in further CLs.
> 
> TBR=joedow@chromium.org
> TBR Reason: Renamed an interface which doesn't change any behavior.
> 
> Bug: 857460
> Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf
> Reviewed-on: https://chromium-review.googlesource.com/1190523
> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590243}

TBR=tedchoc@chromium.org,joedow@chromium.org,mdjones@chromium.org,fhorschig@chromium.org

Change-Id: I328fee1ed53a9e32a5ce3fb3092c5b3a6dd36887
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857460
Reviewed-on: https://chromium-review.googlesource.com/1219126Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590249}

Using wpt-import in Chromium f45d4eb1.
With Chromium commits locally applied on WPT:
d7762551 "Consistently use single quotes in Background Fetch WPTs."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24527

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I66911887a8cd388ca3e2b6fc49f518308d2e817c
Reviewed-on: https://chromium-review.googlesource.com/1218448
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590248}

This adds some first integration tests for secondary account support in
Sync: Signing in to a secondary account starts Sync in transport-only
mode, and making the account primary triggers full Sync.

Bug: 871221
Change-Id: I8ce74f3a8a7f819c1fea28347dd6ee4c6c917074
Reviewed-on: https://chromium-review.googlesource.com/1213507
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590247}

At the moment, none of the callbacks use it.
This support will be added in future CL feature by feature.
sender_frame will be non null if
- kWebFrameMessaging feature is enabled
- the page is secure (URL is https without error or whitelisted by
  the user, iframe URL is https without error or whitelisted by the
  user)
- the frame is available (between FrameDidBecomeAvailable and
  FrameWillBecomeUnavailable messages).

On any other case, the sender_frame will be nullptr.

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic91d685fed2f28aa65b7846999f538aa0991d4c3
Reviewed-on: https://chromium-review.googlesource.com/1146721
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590246}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I397f7201fd7c7f40574d443cbe58c82178a66e9b
Reviewed-on: https://chromium-review.googlesource.com/1218547
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590245}

This adds a search header for all passwords in manual fallback.

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8b9516c42d491aed7a8a008a154b999102f11d1a
Reviewed-on: https://chromium-review.googlesource.com/1210504
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590244}

This CL extends the use of the visibility delegate from affecting
only the isKeyboardShown() function to all keyboard-related methods.

Using a delegate is also the first step to move towards binding
the keyboard detection to WindowAndroid. This enables other
components like the keyboard accessory to affect the visibility on
an activity-specific level (instead of global and static).

These changes require more work and will follow in further CLs.

TBR=joedow@chromium.org
TBR Reason: Renamed an interface which doesn't change any behavior.

Bug: 857460
Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf
Reviewed-on: https://chromium-review.googlesource.com/1190523
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590243}

VideoFrameLayout should have information about offset per plane, not only
stride. The number of stride should be the same as the number of offsets. To
guarantee this, they are stored in the vector of struct, Plane.

BUG=chromium:876986, chromium:856562
TEST=VDA unittest and media_unittest

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie9d9afa5db7dabaee2f48fbcd355c13d29be8035
Reviewed-on: https://chromium-review.googlesource.com/1188730
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590242}

https://webrtc.googlesource.com/src.git/+log/f2582da04e4d..49b2c3c4c433


git log f2582da04e4d..49b2c3c4c433 --date=short --no-merges --format='%ad %ae %s'
2018-09-11 perkj@webrtc.org Revert "Decrease complexity of RtpPacketHistory::GetBestFittingPacket."
2018-09-10 steveanton@webrtc.org Use C++11 for range loop in pc/mediasession.cc (and test)


Created with:
  gclient setdep -r src/third_party/webrtc@49b2c3c4c433

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9fa98d53cd1c43d054b668efa98f72af4ec72307
Reviewed-on: https://chromium-review.googlesource.com/1218544Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590241}

This CL adds some debug output to investigate why we are observing failing
navigations on the Windows 10 bots.

TBR=sky@chromium.org

Bug: 882545
Change-Id: I4ec3fd453eb7641f79f717c1a48993985ef99681
Reviewed-on: https://chromium-review.googlesource.com/1218902
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590240}

This CL adds test code for more worker/worklet-related cases
to mixed-content/ WPT tests:
- module-worker-top-level (outsideSettings of https: module script)
- module-data-worker-import (outsideSettings of data: worker)
- classic-data-worker-fetch (insideSettings of data: worker)
- worklet-*-top-level (outsideSettings of https: worklets)
- worklet-*-data-import (outsideSettings of data: worklets)

Actual generated tests is added in a separate CL
https://chromium-review.googlesource.com/1212746
for easier code review.

These tests are for
https://chromium-review.googlesource.com/1208390.

Bug: 880986, 880023, 880015
Change-Id: I07eb96cffec889103bf437813180127644466af8
Reviewed-on: https://chromium-review.googlesource.com/1212744
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590239}

use install_static in InitChannelInfo, SetEULAConsent, and
{Get,Set}ExperimentLables.

Also:
- changed EULA -> Eula in symbol names in chrome/installer.
- added support for testing both per-user and per-machine installs in
  GCAPIOmahaExperimentTest.

BUG=879568

Change-Id: I7676c7b75a9cb4cd3a85d1ba609d66a71581f05e
Reviewed-on: https://chromium-review.googlesource.com/1215024
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590238}

This patch ensures that the currently set zoom level is sent to the
wayland client.

Bug: 881492
Change-Id: I516ff73e73753cb0fc5fdec1f7f5216c0608a401
Component: wayland
Reviewed-on: https://chromium-review.googlesource.com/1211725Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590237}

This reverts commit f8d8a935.

Reason for revert: NetInfoNetworkQualityEstimatorHoldbackBrowserTest.EffectiveConnectionTypeChangeNotified/1 is flaky.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NetInfoNetworkQualityEstimatorHoldbackBrowserTest.EffectiveConnectionTypeChangeNotified

Original change's description:
> Add logic for holdback experiment for network quality estimator Web APIs.
> 
> When the holdback experiment is enabled, the NetInfo
> network quality related Web APIs (https://wicg.github.io/netinfo/)
> would report network quality corresponding to the experiment
> params.
> 
> This CL only affects the NetInfo JavaScript APIs. A subsequent CL
> will use the framework in this CL to also override the values
> of network quality reported in network quality related client hints
> headers.
> 
> Change-Id: Iab9d4ecfe7c14eb5d3cee26dbf209fd943156333
> Bug: 880545
> Reviewed-on: https://chromium-review.googlesource.com/1201343
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590212}

TBR=kinuko@chromium.org,jkarlin@chromium.org,tbansal@chromium.org,ryansturm@chromium.org

Change-Id: I4e098f91606613d446f373775ef0649876532f40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880545
Reviewed-on: https://chromium-review.googlesource.com/1218387Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590236}

This patch means rearrange module file name in alphabetical order.

Change-Id: Ia2697a2d2dfeb3576677b0732d64f7b7bc21cce3
Reviewed-on: https://chromium-review.googlesource.com/1215153Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#590235}

When flag #new-password-form-parsing is on, PasswordFormManager is used for
saving and NewPasswordFormManager for filling. Now they have separate metric
recorders. Metric PasswordManager.ActionsTakenV3 (and others) is inconsistent
because filling and saving parts of this metric written with different recorders.

This CL implements usage of the same metric recorder for PasswordFormManager
and NewPasswordFormManager that corresponds for the same form.

Bug: 882432, 831123

Change-Id: I84b480c86ec8172fb9d055cd8189529c5e4f42fb
Reviewed-on: https://chromium-review.googlesource.com/1215965
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590234}