GitLab

Route the per resource request is_ad_resource flag to the
SubresourceFilterAgent so it can be used in creating per-page ad
metrics. The request ids are necessary to associate the
network PLM updates with the resource.

Requires that the subresource request id be returned from the
WebUrLoader in blink::ResourceResponse.

Bug: 851543
Change-Id: I2ca0ed887cfa8a2c8dddf99613a29f8654bf9ed5
Reviewed-on: https://chromium-review.googlesource.com/1165823
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588195}

https://chromium.googlesource.com/angle/angle.git/+log/89e829793028..253038d8d13b


git log 89e829793028..253038d8d13b --date=short --no-merges --format='%ad %ae %s'
2018-08-31 jmadill@chromium.org Vulkan: Refactor VertexArrayVk::streamIndexData.
2018-08-31 ynovikov@chromium.org Fix EGLImage pixel format validation
2018-08-31 ianelliott@google.com Add stubs for A4A opt-in library.
2018-08-31 yunchao.he@intel.com Add specification for ANGLE_texture_multisample.
2018-08-31 tobine@google.com Roll VK deps forward as of 8/31/2018


Created with:
  gclient setdep -r src/third_party/angle@253038d8d13b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: If04b4adb8fc865286d7f9b5b5b76f1f61686adb2
Reviewed-on: https://chromium-review.googlesource.com/1200322Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588194}

After fetching objects from a span, reset the previous field of the first
remaining object in the span.
Debug builds perform extra sanity checks on the state of the tcmalloc
metadata, which is causing them to fail without this fix.

BUG=724399,b:70905156

Change-Id: I33ad3097d13756d36032edde538ee87b09a1a4ee
Reviewed-on: https://chromium-review.googlesource.com/1195092Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588193}

Bug: 878529
Change-Id: I01f8c6cb8fab2785f6eaf258c91edd6f3ef58736
Reviewed-on: https://chromium-review.googlesource.com/1195160
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588192}

Chrome v70 is branched.
Adding support for Chrome v70 and dropping support for Chrome v67.

Change-Id: Ic26fc2e011f38cfc0ae34f9f19770a5d15b22f05
Reviewed-on: https://chromium-review.googlesource.com/1199776Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588191}

We were moving onto to checking ContextGL if binding failed. This is bad,
because we should not touch ContextGL if we haven't been bound.

Bug: 879438
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7898adf7af963216c388adaa35c5c2c287802fed
Reviewed-on: https://chromium-review.googlesource.com/1200363Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588190}

This reverts commit 069a1be1.

Reason for revert: Clang roll with the upstream bug fix has landed.

Original change's description:
> android: Disable thinLTO for 32-bit ARM builds.
> 
> This is done to avoid a runtime crash at startup when
> Chrome starts up on devices with a very old Linux kernel.
> 
> This is only one way to address the problem, but probably
> the simplest patch to fix it. See bug entry for all details
> and alternatives considered.
> 
> BUG=871722
> R=​agrieve@chromium.org, pcc@chromium.org, thakis@chromium.org
> 
> Change-Id: I9a197a347538ae9cf9ce6de7b243f522cb425043
> Reviewed-on: https://chromium-review.googlesource.com/1167502
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: David Turner <digit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581627}

TBR=digit@chromium.org,thakis@chromium.org,pcc@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871722, 872611
Change-Id: I02d8b5519b978fd61b8cd2ead8718ff77846b402
Reviewed-on: https://chromium-review.googlesource.com/1199937Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588189}

As requested by UI review.

TBR=rockot@chromium.org

Bug: 862419
Change-Id: I10091941b92113f747b4969265ebcd212efe12ad
Reviewed-on: https://chromium-review.googlesource.com/1199861Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588188}

https://pdfium.googlesource.com/pdfium.git/+log/a6325f8ab7ec..ca3a100e7dcf


git log a6325f8ab7ec..ca3a100e7dcf --date=short --no-merges --format='%ad %ae %s'
2018-08-31 hnakashima@chromium.org Simplify radial shading.
2018-08-31 thestig@chromium.org Use more UnownedPtrs in CFXJSE_Engine.
2018-08-31 npm@chromium.org Roll third_party/freetype/src/ 96b5e5009..2c8e6279a7b (38 commits)


Created with:
  gclient setdep -r src/third_party/pdfium@ca3a100e7dcf

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If384b85777f8f0e8cb5a98c41917c3ad563b150a
Reviewed-on: https://chromium-review.googlesource.com/1199695Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588187}

This CL adds the user's e-mail address and profile photo to the password
prompt page at the beginning of the setup flow. This is a security
requirement as it makes it clear to users what password that they should
enter.

Additionally, this CL adds a "cancel" button to this page.

Note that there are various styling/CSS changes which still need to be
made so that this page matches the mocks.

Bug: 878643, 824568
Change-Id: I59e75f73c310ea5f275b844268b70fa2e47af72f
Reviewed-on: https://chromium-review.googlesource.com/1198564Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588186}

This reverts commit 16cca0d5.

Reason for revert: Branch has happened, bring back Feed.

Original change's description:
> [Feed] Temporarily compile out Feed for branching.
> 
> Feed component adds a significant amount of code that's not used yet
> for users. See Feed DEPS rolls for current size impact.
> 
> Change-Id: I2c77f9f8d640b46c58602b29a3f79357f7cb1140
> Reviewed-on: https://chromium-review.googlesource.com/1188596
> Reviewed-by: Filip Gorski <fgorski@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587620}

TBR=fgorski@chromium.org,skym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icf2d1b8f2501a71436efd47d296deb0a072e9db0
Reviewed-on: https://chromium-review.googlesource.com/1199701Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588185}

These baselines are unused and only serve to confuse.

Found with this script:
find * -name '*.any*-expected.txt' | while read baseline; do
  file="$(echo $baseline | sed 's/\.any.*/.any.js/')";
  [[ -f $file ]] || git rm $baseline;
done

Change-Id: Ibee6505895e91c68e43a452a002af9601a9adbfc
Reviewed-on: https://chromium-review.googlesource.com/1200022Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588184}

Previously we did not consider the possibility of a typographic unit
containing multiple surrogate pairs, and could as an effect "lose" part
of the width.

Distribute the width evenly among code points instead to at least get
some sort of consistency.

Bug: 879361
Change-Id: I51a4e6c574926215a087b0bc824ac90d580ff169
Reviewed-on: https://chromium-review.googlesource.com/1199423Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588183}

gyp is no longer needed on sys.path after
https://chromium-review.googlesource.com/c/chromium/src/+/1063611

Bug: 826218
Change-Id: I5ee268cab2f75b4fd6bddd62685f14dee4669626
Reviewed-on: https://chromium-review.googlesource.com/1199572Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588182}

TBR=dullweber@chromium.org (for tools/traffic_annotation/summary/annotations.xml)

BUG=773295

Change-Id: I5ee6e7ea8cd48c18f7e51487f974a7cde1ec49d2
Reviewed-on: https://chromium-review.googlesource.com/1199484
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588181}

TBR=foolip@chromium.org,robertma@chromium.org

Bug: 879728
Change-Id: I961914c7ccffa3842d2a27ee489611278e88f01c
Reviewed-on: https://chromium-review.googlesource.com/1199968Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588180}

This CL is turning on the CPU sampler category.
  see: https://chromium-review.googlesource.com/c/chromium/src/+/1191745/

It's also turning on the task scheduler info. Which is adding the
task_priority to the trace and will ease finding priority inversion.

  Title          TaskTracker::RunTask
  Category       task_scheduler
  Args
    task_info    {execution_mode: "parallel", task_priority: "USER_BLOCKING"}


R=etiennep@chromium.org, oysteine@chromium.org

Bug: 867931
Change-Id: I8f6e4772816cc446a25c04ce0cda4b9d45c44232
Reviewed-on: https://chromium-review.googlesource.com/1199567
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588179}

These keyboard shortcuts trigger focus changes that cause
InputMethodMus to ack all in-flight keystrokes as unhandled.
This causes ash to try to process the keystroke as an
accelerator, resulting in the new-tab command running
twice.

Instead, ack the key events as handled during focus change.

Bug: 874098
Test: updated aura_unittests
Change-Id: Idda91cbcc7f5d9ad328f7bfb7d6dc0367d85817d
Reviewed-on: https://chromium-review.googlesource.com/1195085Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588178}

. Add ExternalMediaMetadata to the external input source and state.
. Add ExternalMediaMetadataChangeObserver for the external pipeline to report media state change.
. Report external pipeline state to the Assistant Server via MediaParams.

Design doc: internal http://go/voice-control-for-external-audio-pipeline

Bug: internal b/80156336
Change-Id: I68ec11cc6fe4f368c34fe705c05a0f50ee9011cc
Reviewed-on: https://chromium-review.googlesource.com/1192116Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588177}

This CL changes the behavior of the splash icon for WebAPKs to match that of
non-WebAPK homescreen shortcuts. The splash icon for
non-WebAPK-homescreen-shortcuts is downsampled to 128x128dp by
ManifestIconDownloader::OnIconFetched()

The WebAPK Minting server generates a single WebAPK per start URL. That single
WebAPK needs to work with all screen densities, thus the downsampling needs to
occur on the client side.

BUG=879255

Change-Id: I5822e1c8bf3cf02d7d3935989ae4d786cc9d9bb8
Reviewed-on: https://chromium-review.googlesource.com/1197623Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588176}

Normal task window shouldn't be in the system modal container,
but can happen due to a bug in Android side. (ex. b/111767668)

This is a safe guard not to show the frame even if it happens.

Bug: 878426
Test: Covered by unittest
Change-Id: Ib6344acf0ff9ec86b1e40238a8c8e60828948cee
Reviewed-on: https://chromium-review.googlesource.com/1194287Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588175}

Change-Id: I64832492a8019a24a4420d1a2dfdd65d69b503ee
Reviewed-on: https://chromium-review.googlesource.com/1199769Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588174}

Bug: 875088
Change-Id: I5c09daa610bba32c8be8b411e1a9e333697e64f9
Reviewed-on: https://chromium-review.googlesource.com/1196163
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588173}

TEST=N/A
BUG=879413

Change-Id: I6e55415d41e8833a972a29e92ae26882d5c94912
Reviewed-on: https://chromium-review.googlesource.com/1199859Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588172}

WebDialogDelegate should mirror DialogDelegate and provide an
implementation of WidgetDelegate::GetAccessibleWindowTitle. This also
adds an accessible title to the Print dialog.

Bug: 868179
Change-Id: I8e1c4b7262130b1a68f861bae9822ee191b0a06c
Reviewed-on: https://chromium-review.googlesource.com/1187623
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588171}

For context, when a change occurs in the a phone to which the
Chromebook is tethered, the MultiDevice tethering item is alerted and
updates accordingly. The bug was caused by the fact that the default
value for the deviceState property was null when there is an update and
no phone is found. In particular, this is exactly the situation that
occurs immediately following a successful request to forget the
tethering phone. Because the network-summary-item (the element directly
responsible for deplaying the tethering data) has an A11y string that
depends on a property (i.e. deviceState.Type) of deviceState, this
triggers the error described in the bug when the binding is updated.

The solutions was simply to change the default value for deviceState on
updates where no device is found from null to
{Type: 'Tether', State: 'Disabled'}
(this is the minimal definition satisfying the TypeDef so that the
binding can update safely.

Bug: 878972
Change-Id: I1850e5c613a935b2fade129a1466638756d4af13
Reviewed-on: https://chromium-review.googlesource.com/1197350Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588170}

This patch makes ContextualSearchObserver package protected since its
use is specific to the feature itself.

Bug: 878006
Change-Id: If2e2a660199baf4600caf28729e7b2af3f41d8a1
Reviewed-on: https://chromium-review.googlesource.com/1198005Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588169}

Change-Id: Id6bb42a68175888f286f6529529039785cb0753e
Reviewed-on: https://chromium-review.googlesource.com/1199608Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588168}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c47cd43..fe5861b

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I61552f908249afc978aa24f43714ed49ff953714
Reviewed-on: https://chromium-review.googlesource.com/1199935Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588167}

This CL adds the implementation to open a new OffscreenTab to support
OffscreenTab mirroring through the mirroring service.

Bug: 734672
Change-Id: I560e39d74b0e1a147ffee2dfccf0b38ae8ed7fae
Reviewed-on: https://chromium-review.googlesource.com/1195820
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588166}

Bug: 755630
Change-Id: Ia5940e7be3821200a38a2405c2676ef37326bcf7
Reviewed-on: https://chromium-review.googlesource.com/1199485Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588165}

onNativeSignOut() triggers a call to signOut() -> nativeSignOut()

Parts of signOut() are needed, but the call to nativeSignOut() should
be avoided for flows that originated at the native side (native signout
is already done).

Change-Id: Ib205cfd61e94b49838e738b87c5cdb43b2d9f563
Bug: 873116
Reviewed-on: https://chromium-review.googlesource.com/1169462
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588164}

Remove padding from modern_toolbar_background and update/simplify the
location bar layout logic to better match the UX spec.

BUG=815343

Change-Id: I24e0239f3763c6c2fd7bd1f8c5f286ebf4f0b78c
Reviewed-on: https://chromium-review.googlesource.com/1197902Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588163}

This CL adds observable settings to MediaStreamTrack objects returned by
getDisplayMedia() calls. These constrainable properties are set before
the stream is returned based on user choice.

Information about these settings are stored in DisplayMediaInformation
struct. It is set in the low level device selection and then parsed by
UserMediaProcessor before passing it to blink.

Bug: 326740
Change-Id: I81d5f2eb24d2c1a37df0fbe2d34bc469fa575bf1
Reviewed-on: https://chromium-review.googlesource.com/1185875Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588162}

The API has been proposed by crbug.com/876800

Bug: 877238
Change-Id: Ic3ad7466d4bff95d8626e8339e13799545bf3f50
Reviewed-on: https://chromium-review.googlesource.com/1187514
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588161}

Bug: None
Test: le_scan_result_fuzzer
Change-Id: I38a27cf7edfe1624a71f0a33850185c03312a299
Reviewed-on: https://chromium-review.googlesource.com/1189125Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588160}

This allows for the optional disabling of the default LoadIfNecessary()
behavior that previously occurred in TabModelWebUsageEnabledObserver.
This can be used when restoring a large number of Tabs to prevent the
creation of many WKWebViews at once.

Bug: 864478
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie80722aa178e260e6c6841de8e4cad8bb1e7ada4
Reviewed-on: https://chromium-review.googlesource.com/1148596
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588159}

It should be required that users enter their password to enable
SmartLock, since it is a security-sensitive feature. As a corollary, it
should also be required that users enter their password to enable the
Better Together suite if doing so would implicitly cause SmartLock to
become enabled.

Previously, entering a password was required for enabling the Better
Together suite under any circumstances, but this was unnecessary, since
no password should be required if SmartLock were turned off.

This CL fixes this issue; additionally, it updates the authentication
code here, which was previously not as robust.

Bug: 876436, 824568
Change-Id: Ia61dd112675485972361a51b406482a0bb0a1f05
Reviewed-on: https://chromium-review.googlesource.com/1200148Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588158}

Bug: 879248
Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5

TBR=mastiz@chromium.org

Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5
Reviewed-on: https://chromium-review.googlesource.com/1199696
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588157}

The feature has been enabled in stable releases for a number of
versions by now, hence the flag can be safely removed.

Bug: 838789
Change-Id: I172df59564d881c8c7b6b5cad3b49d0971fc0251
Reviewed-on: https://chromium-review.googlesource.com/1195489
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588156}