GitLab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Iebe500d5e8ca864a8ac8c8a693a23b30e7509dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884526Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710074}

Currently, all VA-API related unit tests are executed via
chromeos_camera's jpeg_decode_accelerator_unittest test binary.

This CL adds a test target for VA-API unit tests to set the ground for
the separation of VA-API related unit tests from chromeos_camera.

I am also using this opportunity to remove code duplication that exists
in vaapi_*_decoder_unittest.cc by introducing
vaapi_image_decoter_test_common.*. However this change is not crucial
for the separation mentioned above.

Bug: 986074
Test: Run and passes locally on an Eve board.
Change-Id: I17a27ad7f57b22dd7704293b798531d38fc72bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881631
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710073}

If XGetWindowAttributes() fails in X11SoftwareBitmapPresenter(), |shm_pool_|
will never be constructed. However, we assumed in several places that
|shm_pool_| was non-null, which can cause a crash. For example
~X11SoftwareBitmapPresenter() calls shm_pool_->Teardown() without a check.

This CL adds null checks in the appropriate places.

BUG=1015124
R=rjkroege

Change-Id: I19eabf89961632f5573a4f0020748012aa0d6c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879502
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710072}

Bug: 997813
Change-Id: I88dfa13db52d2968f846d72015e99c84e9808c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815543
Commit-Queue: Evan Liu <evliu@google.com>
Auto-Submit: Evan Liu <evliu@google.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710071}

Android Webview Safe Browsing interstitials will require the same logic
desktop and android use for showing interstitials triggered by a bad
subresource. This CL moves that logic to //components.

Bug: 1016581
Change-Id: Ia1f5fd52cdff3c7bf7ea7d38b6329b8adf316718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884811
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710070}

While the runtime is stopping if the current sensor presence state is
anything other than "NotPresent", a visibility state change event comes
in.  This event gets unsubscribed in StopRuntime, but it's possible that
the change comes in before the render loop knows that it needs to tear
down the runtime, so simply unsubscribing earlier is insufficient to fix
this. The fix is to just simply check whether or not holographic_space_
is valid before running the rest of the logic.

Fixed: 1018822
Change-Id: I05298c6f20419cbad30cda3107924d0e207aaa2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884288
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710069}

The "initialization done" callbacks for both
media::remoting::StreamProvider and media::remoting::MediaStream
both used implicitly repeating closures, but only ever ran the
callbacks once. Switching to base::OnceClosure.

Bug: 1007810
Change-Id: I9431a6cca138e3e095b98d625bc94fcf97f7ce19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881985Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#710068}

This change switches from using testing::CreateFunctor
when calling testing::Invoke() to a C++ lambda. This
improves test readibility and makes easier an upcoming
changes to gmock_mutant.h (switch away from base::Bind()).

Bug: 1007833, 806952
Change-Id: I267d0681e833a36c245a4529a2a7c0faef6f9693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874485
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710067}

LoopbackServer doesn't need to deal with strings in its API, since it
deals with protos. It can be trivially refactored without behavioral
changes (relevant for local sync, i.e. enterprise).

This allows various simplifications in FakeServer.

Bug: None
Change-Id: Iffebffae9af844d27df53fe46a6b5f61c4016ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883516
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710066}

The font fallback is returning a specific typeface. The
specific typeface should be used when available to avoid
a font family match (which may leads to a different font
being used).

As an example, on Fuchsia the script Bengali is using the
'Mukti Narrow' which is not getting match correctly. That
makes the script being broken. We are not seeing a
regression since the expensive fallbacks algorithm is
catching the broken cases.

see:
  https://chromium-review.googlesource.com/c/chromium/src/+/1824104
  http://crbug.com/1003829

Bug: 1008407, 1018321
Change-Id: I668382707e24ecc267a82531ad2a77c23283b2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884657Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710065}

On the settings page, if user opts-in, then opts-out through the toggle switch,
the browser crashes because a non-existing dialog is being attempted to close.

Bug: 949269
Change-Id: I10d50695db65976799510960ae3230b355b3f698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884829
Commit-Queue: Manas Verma <manasverma@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#710064}

Using wpt-import in Chromium 4f3e0042.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Id9c81fd050db3919f9a6a9392d684422a790a921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884481Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710063}

Fixed: 1015632
Change-Id: I657fb15a63132ce53e2f64e7e4a5b2d1c1302074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881808
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710062}

https://webrtc.googlesource.com/src.git/+log/70770accb3e4..77b752951550

git log 70770accb3e4..77b752951550 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 sprang@webrtc.org Reland "Use RtpSenderEgress directly instead of via RTPSender"
2019-10-28 ivoc@webrtc.org Apply bitrate boosting depending on field-trial.
2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d68d92fb..9109135d (709806:709913)

Created with:
  gclient setdep -r src/third_party/webrtc@77b752951550

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ia4337f9562c415711f2ad0f3ec63b790594bc8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884514Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710061}

This aims to determine if the search engine is null or
some actual value.

BUG=944767

Change-Id: I7145903f77c0722fe1846f4b17a0ea9ea36f3a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881969Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710060}

Fix a regression that sends primary user session too early,
which breaks the assumption for callers of IsActiveUserSessionStarted
and causes SessionObserver::OnActiveUserPrefServiceChanged not
fired.


Bug: 968825, 848230
Change-Id: I18b042a2ee5801b66e175897c0704d8dde989113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660772Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710059}

The binary_upload_service_ pointer can sometimes hold uninitialized
data, which leads to calling IsAuthorized() on an invalid object. In
my case this was due to a turned-off feature flag.

Change-Id: I1db50db3350c43f48b45b0b7a310ac83608147b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884994
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710058}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=estade@chromium.org

Bug: 1018887
Change-Id: I29b84b7807d2d1b87cea6db9967986ac3aba900a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884998
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710057}

This adds a use counter for calls to
PublicKeyCredential.isUserVerifyingPlatformAuthenticatorAvailable(). The
counter's name is prefixed with `kCredentialManager` for consistency
with other WebAuthn related metrics.

Fixed: 1018318
Change-Id: I2ba0e96a37405b7774259c09eb34c534ee43f640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880319
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710056}

R=vadimsh

No-Try: True
Change-Id: If4d921cc6ca9ca35128c0b4e44771bf8e0ed94b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885091
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710055}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=garykac@chromium.org

Bug: 1018887
Change-Id: I4b920ec60b5a24237396d7cf14a47c8fcac7d786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884954
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710054}

This creates the lib build file, adds any missing dependencies, and
moves a crashpad dependency that that was incorrectly placed in the old
lib rule.

Test: gn check out/aw 'android_webview/*'
Bug: 934152
Change-Id: Ic9a03e5a8f105364f9c61e08b35a5889cabfea3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880070Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710053}

When running unit_tests there is no system_network_context_manager
available, so provisioning can't take place. If that is the case then
don't attempt to provision an origin ID.

Tested this with an Android emulator. Without this change 9 of the
OptimizationGuideHintsManagerTest unit_tests failed, and all pass after
this change applied.

Bug: 1018052
Test: see above
Change-Id: Ic3733014c00fc48d1b6860142f08daffcf3d8391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881950Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710052}

Convert the implementation and all users of the
ui::ozone::mojom::DrmDevice interface.

Bug: 955171
Change-Id: I330afef5a15856e9632ee441e95d255bd6d7b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862455
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710051}

This reverts commit 959cddb1.

Reason for revert: The just enabled testKeyboardHideState test keeps failing:
https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403589
https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403581

Original change's description:
> [iOS][MF][EG2] Migrate keyboard observer test
> 
> Remove deprecate test that would require new code to be migrated.
> Update and enable keyboard disappear test.
> Create app interface to interact with a shared instance of the observer
> in the app.
> Remove OCMock usage in the test.
> 
> TBR=eugenebut@chromium.org
> 
> Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709939}

TBR=eugenebut@chromium.org,stkhapugin@chromium.org,javierrobles@chromium.org

Change-Id: I40a1bfece2a1b3eb03aec11d58c1ab0496b420d9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885252Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710050}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=nharper@chromium.org

Bug: 1018887
Change-Id: Id2d23759b383b43fea02bfba279ec96286da5eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884997
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710049}

This fixes a flaky test crash in PageInfoBubbleViewTest where
content::BrowserSideNavigationSetUp() was called but we weren't calling
the corresponding content::BrowserSideNavigationTearDown(). This can
cause a DCHECK to trigger [1] under certain orderings of test
invocations. The flakiness isn't bad enough to be problematic yet [2]
(especially since it only triggers on Debug bots), but it's better to
preemptively fix it.

[1] https://cs.chromium.org/chromium/src/content/browser/loader/navigation_url_loader.cc?l=55&rcl=42b97a68450fe6fb772120b6767d5687af3a52df
[2] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PageInfoBubbleViewTest

All other callers of content::BrowserSideNavigationSetUp() correctly
call the TearDown() function during test fixture tear down.

To reproduce the flaky crash, you can run:

unit_tests --gtest_filter="PageInfoBubbleViewTest.*" --gtest_shuffle \
    --gtest_repeat=-1

This can also be used to verify that the crash no longer triggers with
this CL.

Change-Id: I031e3de8a4b46bb58fcb20d752a83289f1372bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885077Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710048}

The two classes have very similar codes, and should be updated together
for many cases moving forward.

Part 1 basically makes a copy of the current CaptionContainerView and
deletes overview specific code from CaptionContainerView and predicted
to be shared code from the new OverviewItemView. To keep the only
deletions in this patch, left some duplicate code.

Test: manual, unit tests
Bug: 1017912
Change-Id: Id1e54b681201a528be69f1f95e2860d1ba02c892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880148
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710047}

Factored out the browser dependency present in browser_view_layout by
moving the required functionality to its delegate, allowing for
simplified testing of the layout component.

Bug: 871419
Change-Id: If4d738677ad1e6666cda245e64aa62a2e2d103ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877613
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710046}

Future OpenXR runtimes are more stringent on validating correct usage
of APIs. The structure type of XrCompositionLayerProjectionViewobjects passed into XrEndFrame
are not currently set. The current version of the WMR OpenXR runtime
from the Windows store does not do this validation, but future versions
will.

Bug: 1015223
Change-Id: I76c02cc5ad9443947f1a5480ebc4a4f5b1e29608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879864
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710045}

Class cannot be used as NSDictionary key.

Bug: 1017213
Change-Id: I1f660792ccf7ab648cf4fcde3be3b5b8a1b8d745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884671
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710044}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/32c0b43e..054ab2be

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I648cd9102c82481f1ac1d3efb0a8994b6aef83f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884476Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710043}

https://android.googlesource.com/platform/external/perfetto.git/+log/a78528cc1f2b..5a19effaca7e

git log a78528cc1f2b..5a19effaca7e --date=short --no-merges --format='%ad %ae %s'
2019-10-28 tneda@google.com Merge "perfetto-ui: Adding symbol names to callsites in flamegraph"
2019-10-28 fmayer@google.com Merge "Disable HeapprofdJavaCtsTest."
2019-10-28 eseckler@google.com processor: Remove unnecessary includes & fix incomplete rename

Created with:
  gclient setdep -r src/third_party/perfetto@5a19effaca7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3f798b19f7873053bbeae3eb3a9d96d5d3765ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884438Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710042}

Change-Id: I46134d1283708ae8dd79c28cc65d4a180e9baef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884970Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710041}

Used the size and weight from:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/typography/

Bug: 989761
Change-Id: Ife83bf55ab112ec61fccab329be5c908d83df3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884363Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710040}

Bug: 1018640
Change-Id: Ia71ad149c92d8d125efecc1a285db4548ddf8f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883268Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710039}

They seem to be fixed long time ago according to the comments in the
linked bugs.

Bug: 614418, 627525, 757097
Change-Id: I7ed1734ee895e5594de18a518f4727f47ada00c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878167
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Jiajie Hu <jiajie.hu@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710038}

This CL adds a new placeholder view to contain the dismiss button and
reserve space in the header so that nothing needs to shift when the
dismiss button shows or hides.

Bug: 1016369
Change-Id: Iaeb4f2735df814e5b8e29c79b28434f2aea1bb17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883622Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710037}

SVGAnimateElement::CalculateAnimatedValue already does this reassignment
generally.

Bug: 1017723
Change-Id: I91917719a10f7d0edab9a7396283c86e8fac1a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884551Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#710036}

This is a followup to this patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1830360

There's sort of a mismatch between whether code uses uint8_t or
char for bytes.  I think uint8_t is a little bit better of a
representation and matches what BigBuffer does.  This cleans up
a bit of storage code and apis to use that in more places.

Bug: 1012869

Change-Id: I7b1e8eb7d9b967f451b19f9c1c6d86c0d89d3ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857648
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710035}