GitLab

https://chromium.googlesource.com/catapult.git/+log/38f98ead10af..59c3eac20665

git log 38f98ead10af..59c3eac20665 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 bsheedy@chromium.org Fix newer system VrCore removal

Created with:
  gclient setdep -r src/third_party/catapult@59c3eac20665

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: None
Change-Id: Id71915e85320f8d8008da8943b958e96a5876f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880456Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709520}

https://webrtc.googlesource.com/src.git/+log/16cec3be2c96..67ac9e8ecb89

git log 16cec3be2c96..67ac9e8ecb89 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 sprang@webrtc.org Prepares RTPSender for extracting RtpSenderEgress
2019-10-25 saza@webrtc.org Make rtc_json poisonous in WebRTC
2019-10-25 terelius@webrtc.org Fix MemoryLogWriter so that it always writes the full data.
2019-10-25 ivoc@webrtc.org Introduce injectable NetEqController interface.

Created with:
  gclient setdep -r src/third_party/webrtc@67ac9e8ecb89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:895814
Change-Id: I73150892148ac28c445598d6701b634b8fbd892d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709519}

Static analysis will have already run on non-official bots, so
these checks don't need to be run again on official bots. Both
steps are a bit slow, so they are meaningful to disable.

Change-Id: I8d56c0046f88c0746e1e8129721e49b0325419f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880157Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709518}

This was because the label was previous parented to AlwaysOnTop
container. This was fine before when there was no scrolling, but now
with scrolling, the label should be parented to the same container
as the regular windows, so that it snapped window can be stacked
ontop of it as well.

Test: added test, manual
Bug: 1017882
Change-Id: I8b3d2d50f814e1b1c631372478d6ddd16bcc5608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880177Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709517}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/008243fd..2ab3f107

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4700096e2b16a7ac5c705da5b4376aea40efc3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881188Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709516}

Add a generic getInteger method to PrefServiceBridge, making use of the
prefs.h enums.

Migrate usages of the Prompt for Download pref to use the generic
methods, and move wrapper function with feature-specific type
annotations to DownloadUtils.

Bug: 1016957
Change-Id: I46f9f33f14467aa628767f722c099a39b813dee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879552Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709515}

Change-Id: Ibf2479334f25f993c8b683144d766ccd07291714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860520Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709514}

https://quiche.googlesource.com/quiche.git/+log/b38e63550203..91ae3918387e

$ git log b38e63550..91ae39183 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 fkastenholz Remove empty if statement
2019-10-24 rch gfe-relnote: n/a - Rephrase obsolete TODO which was left over from when v40 was added.
2019-10-24 rch Remove an obsolete TODO from quic_framer.cc about changing the public packet header format for post v32 versions. This todo was adding in the fallout from the PAN drama. But I think it's not worth the risk of touching the header format again so let's just leave it alone and it'll be moot once v43 is removed.
2019-10-24 rch gfe-relnote: n/a - Remove useless DVLOG from quic_crypto_server_config.cc
2019-10-24 renjietang Fix Reset logic in PendingStream.
2019-10-24 fayang gfe-relnote: Add QuicPacketCreator::SerializeCoalescedPacket function. Not used yet. Not protected.
2019-10-24 wub Fix 26 ClangTidy - Readability findings in //depot/google3/third_party/quic/.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I83cb08ce6451c90222ed40536fd29fa9a60d8ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879198
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709513}

This change adjusts the call to
ArcAppLaunchThrottleObserver::OnLaunchedOrRequestExpired so that it always runs
in the current thread. This prevents crashes resulting from
SetArcCpuRestriction being called on different thread.

and build/flash/run. Ensure no crashes when a launch request expires.

Bug: 1017211
Test: Test launch request expiration by setting kAppLaunchTimeout to 0
Change-Id: I2430471aa5d69344a879a2c312764d810a03aa55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879332Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Willie Koomson <wvk@google.com>
Auto-Submit: Willie Koomson <wvk@google.com>
Cr-Commit-Position: refs/heads/master@{#709512}

Bug: 953371
Change-Id: Ib274517dc70df08c84e6d12d1a87cf329b678a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789227Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709511}

This CL takes the Google Update/Omaha UI (https://github.com/google/omaha/tree/master/omaha/ui)
and rewrites to work for this updater.

Several original data structures are kept mostly as they were. The code will need to be
further cleaned up as several edge cases and related TODOs are going to be addressed.

The purpose of this CL includes:
* bringing in most of the UI that is going to be necessary to have for a drop in
replacement of Google Update/Omaha
* figure out what update_client features are needed
* understanding the threading and message loop issues
* understanding some of the i18n issues
* understanding dependencies, including WTL dependencies.

Bug: 1017307
Change-Id: I10a7a103cdad86c049a08b3546df404a6d2e01b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876874Reviewed-by: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709510}

This patch keep track of whether the logical bounding box of an
object was empty in fragmentainer iterator. If it was, then it is
likely to be placed in the first column (since typically empty rects
are 0,0 0x0). The first column doesn't have the top edge clip so
we might end up painting contents outside of the container
(see testcase).

By using the portion rect, we ensure that the fragment clip we put
in place is bounded on all sides.

R=pdr@chromium.org, wangxianzhu@chromium.org

Bug: 1017599
Change-Id: I436802f7410124ab2251bfff13ce7dcff49b335b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879564
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709509}

This patch makes pdr and wangxianzhu owners of the blink paint tests.

Benchmark owner list: go/chrome-benchmarks
How to update benchmark owners: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark/benchmark_ownership.md

Change-Id: I38a588ade93d2a3181691df920d7ba168a218717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879149
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709508}

Observed that sometimes a VS2017 and a VS2019 directory are present, but
the VS2019 directory is empty (probably because VS2019 was installed then
uninstalled). In this case we should not identify VS2019 as a valid
installation.

Bug: None
Change-Id: I517cf3debc430e949529d06cd5cb281477d5281a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871990Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709507}

To unused feature_list_ variable (remaining from former clean ups) are
removed.

Change-Id: Id2213500f45bfd1a2907516281a4962ce3f15f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881152Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709506}

Bug: 952034, 1016608
Change-Id: I45335ca96f0c33b4b553663ba796aced1f216767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863851Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#709505}

This CL converts AudioInputStreamObserverPtr and Binding<T> in
content to the new Mojo type.

Bug: 955171
Change-Id: I8dae882be3afbe37ed2a4ff25e6c876b42ac2b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866749
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709504}

Instead, use SetExtraView. The create method is renamed to avoid conflict with
the deprecated parent method it used to override, but left as a method on the
clsas because it sets up some of the class's internal state.

The tests for this class were calling CreateExtraView manually, which is
not allowed by the contract of DialogDelegate::CreateExtraView, but
happened to work on this class. This change therefore introduces an
accessor DialogDelegate::GetExtraView() that pulls the extra view out of
the DialogClientView and uses that in these tests to access the existing
extra view.

Bug: 1011446
Change-Id: I8ad2f3d20d94b461d78b02f3b2a671b2a15a6a31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876789
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709503}

In CL:1847698, the ShowInSearchChecking is removed because the
recommendable Internal/Built-in apps should be involved in the search
result. However, it causes the issue that more apps are list in search
result for the guest user.

Actually, only the two suggested apps should be search out for the
recommend searching result, other apps, if should not shown in search,
should still be filled out. So the ShowInSearch checking is added back
and add !IsSuggestionChip(update.AppId()) checking.


BUG=1017631

Change-Id: I1397e11ba5b8162e0d2986705b990fb054855c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880493Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709502}

We should not have to call AppListView::SetState with the current state
in ParentWindowBoundsChanged if the app list window bounds remained the
same. This avoids unnecessary work when display metrics change without
affecting app list window bounds (e.g. when work area is changed due
to a change in shelf height).

Change-Id: Ic9555d95ae4479a8310ecbe7a9ba6431d60c2503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880450Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709501}

Also, move time zone-related code to a single location and ensure it is
called by all InitializeICU* paths.

Change-Id: Ibd3f129a098e9610ed8fb5152d84e7de200b246c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869231Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709500}

We are going to be asking cookies accessible in 3rd party contexts to be
secure.

Bug: 1006816
Change-Id: Ibdbd145e52b5ee03acbe730ffd1814c9236c71bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863634
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709499}

Replaces kInsecure with kInsecureBroken so that styling for
non-secure connections can later be downgraded from kNeutral
to kInsecure.

This is a follow-up to crrev.com/c/1874787 (protocol change)
and crrev.com/c/1880092 (frontend change).

Bug: 1008218
Change-Id: Iacfb79b94c1c7622749e95cd204d598b6e3c81b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879498Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709498}

Introduces a temporary interface connecting the Scene and the Main
controllers, and exposes a bunch of internals of MainController through
a MainControllerGuts protocol (obviously temporary).

Uses this interface to implement ApplicationCommands in SceneController
and updates the use of the commands endpoint to be SceneController.

Note also:
- Updates a bunch of ivar use in MainController to properties.
- Moves a Deferred Initialization constant to a shared file as it's
used in both SceneCtrl and MainCtrl. It seems like this is semantically
correct for it to be used in both places, so it probably is a permanent
change.
- Removes a DCHECK(_localStatePrefObserverBridge) in
showSettingsFromViewController, as keeping it would mean exposing MainController->_localStatePrefObserverBridge to SceneController.

Bug: None
Change-Id: Idd45bc0850eaabca068e59e3843d901c9a0c780b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845976
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709497}

This CL removes |uses_post| from OpenURLParams and NavigateParams and
replaces reads of that field with checks if |post_body| is non-null.
Similarily, |uses_post| is removed from FrameHostMsg_OpenURL_Params.

FWIW, |uses_post| and |browser_initiated_post_data| were introduced
together in https://chromiumcodereview.appspot.com/21378002/.  I don't
understand why two fields (rather than one) were used (one hypothesis is
that for renderer-initiated navigations only |uses_post| was preserved
while dropping |post_data|).  |browser_initiated_post_data| was renamed
to |post_data| (and support for renderer-side POST navigations was
added) in https://codereview.chromium.org/2038233002/.

Bug: 1007041
Change-Id: I6d0bbfc683d2e2e9d3de425d7895e6ef0c2f84b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873156
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709496}

MediaSessionAction sets are guaranteed to be small.
So we are using base::flat_set instead of std::set for
MediaSessionAction sets.

Bug: 1003847
Signed-off-by: Imranur Rahman <i.rahman@samsung.com>
Change-Id: I2672cd26443c62940da2c168e4563a341ea74158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824723
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709495}

This CL removes a structure that was missed while removing
the respective flag. No behavior change is possible since
it's not referenced.

Change-Id: I3e735126d1d1439b10b00049a1a01bfcd8656f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879203Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709494}

Hotseat is placed differently in overview and out overview, thus can
cause jumping when overview is opened behind the dragged window. Make
sure it's not jumping during dragging.

Bug: 997885
Change-Id: Idc9d96cda431b6a1a3a0e039a918bcfb2f493776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879823Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709493}

Have ExtensionWebRequestApiTest.WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed better represent task ordering in production.

Work done in the context of crbug.com/661143 uncovered a problem in this test
that should be fixed before going forward. The problem is present regardless of
HistoryService's task runner behavior but is currently hidden by the fact that
HistoryService joins its backend_task_runner on destruction.

Like explained in the comment there should not be any tasks pending when we
reach Profile destruction because otherwise it does not represent the shutdown
sequence present in the browser.

In this particular case this presented itself in the form of a use after free
of the profile object by callbacks of tasks still running on the ThreadPool.

This test is the only test in the codebase that destroys a profile using
DestroyProfileWhenAppropriate directly (apart from tests testing the function
itself). We will be able to fix other tests seamlessly by improving

as it uses a function that is not only for tests to achieve a similar purpose.

KeyedServiceFactory: :SetTestingFactory but this test has to be fixed directly
Change-Id: Iab7020b9c33091b2c997acce6bcbe2ac225da0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879202Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709492}

There should be a 4-pixel padding between hotseat's end and edging
app icon. The padding is implemented via shelf view's
|app_icons_layout_offset_|. However, update on
|app_icons_layout_offset_| does not change the shelf view's layout
directly. As a result, the padding may be missing. This CL fixes such
an issue by refreshing the shelf view's layout right after value update.

Bug: 1017979
Change-Id: I0aceaf6a20331cfca410ad1b418b461ac9d60e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809063Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709491}

This unblocks https://webrtc-review.googlesource.com/c/src/+/158403

Bug: chromium:1018077
Change-Id: I7b660766daeabe1d3bdd8d25d98bcb78d8045091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879253Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709490}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug: 891670
Change-Id: I3fb93bf9474d1d021bb8d023166d0301429d6240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878073Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#709489}

Bug: 1011152
Change-Id: I056c3d611cc8e439397eafb8e0a343a4bf49f3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872060
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709488}

This CL is used to reland the CL:1864496 and fix the browser_tests.

CL:1864496 is reverted because it breaks the browser_tests:
AppListClientImplBrowserTest.UninstallApp

The reason is a NativeWindowTracker should be created to track whether
|parent_window_| got destroyed. If destroyed, or load icon failed,
call OnDialogClosed to notify AppServiceProxy to remove the
UninstallDialog from set, and destroy UninstallDialog.

BUG=1009248

Change-Id: I1a2fe6f087a5cc2f723ac0256510a385555e9347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875865Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709487}

The roledescription accessibility attribute was being set on kLinks
and kRootWebArea. This can cause screen readers to announce the item
as "unlabled image" which is misleading when it's not an image. This
removes adding that attribute on anything but images to avoid
confusion.

Bug: 998232
Change-Id: Ic11c3f02a7f439eabcf727f4d4fb08181e196ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834345Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709486}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0f4b5423da2..ba6346fe507c

git log e0f4b5423da2..ba6346fe507c --date=short --no-merges --format='%ad %ae %s'
2019-10-25 jrosenth@chromium.org run_tests: add --clear-pycache flag

Created with:
  gclient setdep -r src/third_party/chromite@ba6346fe507c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I32ace43040e679bebefe8dc1b904e2e870043494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880155Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709485}

Usage:
1. Install emscripten locally (so that em++ works)
2. Apply the patch file
3. run build_html_viewer.py

Bug: 1011921
Change-Id: I7216f57bdf76da163bff358f6c52953cd36d76da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873284
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709484}

https://skia.googlesource.com/skia.git/+log/a7f3157ac012..60e7962ee93f

git log a7f3157ac012..60e7962ee93f --date=short --no-merges --format='%ad %ae %s'
2019-10-25 halcanary@google.com Upload text blob traces as assets for the bots
2019-10-25 rmistry@google.com Remove Perf LottieWeb_Canvas CPU/GPU bots
2019-10-25 rmistry@google.com Move SkottieWASM/LottieWeb* GPU bots to Golo
2019-10-25 halcanary@google.com nanobench: option to execute directory of TextBlobTraces as benches

Created with:
  gclient setdep -r src/third_party/skia@60e7962ee93f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: None
Change-Id: I5210ffaf73afc8d9dcf6be47746cdee83b768725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880156Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709483}

This function name collides with the one in deep_scanning_dialog_delegate.cc when using use_jumbo_build=true, this rename is to fix this.

Change-Id: I44d3b91e5a7a0f1df22ed243e3f985ca3799c2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879197Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709482}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52d33c48770b..28bdba9493b9


Created with:
  gclient setdep -r src-internal@28bdba9493b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I4cdefe3f73522d3b8879e9ed989c2cd70d4598a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880154Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709481}