GitLab

The app launcher will now display an app's short name (the new
short_name property in the manifest file). If an app's short name
and full name differ, the tooltip will show the full name. If an
app's short name and full name are identical, a tooltip will only
be shown if the title is truncated.

BUG=226848
TEST=If an app has a short name and it differs from its full name,
a tooltip should always be shown, displaying the full name. If an
app does not have a short name override, there should be no change
in behavior, i.e. a tooltip will only be shown if the title is
truncated.

Review URL: https://chromiumcodereview.appspot.com/23709003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221205 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221204 0039d316-1c4b-4281-b951-d872f2087c98

R=siggi@chromium.org

NOTRY=True

BUG=

Review URL: https://chromiumcodereview.appspot.com/23620011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221203 0039d316-1c4b-4281-b951-d872f2087c98

The page background color is only restricted to the inside of the content tab while it should be the entire page minus the title bar. Also we should be able to drag by clicking anywhere on the title bar except the buttons. This CL fixes both the issues.

R=xiyuan@chromium.org
BUG=279635

Review URL: https://chromiumcodereview.appspot.com/23503032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221202 0039d316-1c4b-4281-b951-d872f2087c98

The page cyclers run with Telemetry now. They should not be baked into the chrome
binary itself. This causes unwanted dependencies on test code and bloats the
binary.

BUG=280157

Review URL: https://chromiumcodereview.appspot.com/23498004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221201 0039d316-1c4b-4281-b951-d872f2087c98

Chrome on Android's overscroll effect is created on-demand, the first time a
user overscrolls.  Rather than wait for an update from the compositor to give
the effect a valid size, provide the created effect the last valid content size.
This prevents the initial overscroll hitch that may occur if the compositor is
otherwise inactive when the first overscroll update is received.

BUG=284523
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23494021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221200 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up after http://crrev.com/217968 per comments on
https://chromiumcodereview.appspot.com/23235002/

R=jam@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/23452016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221199 0039d316-1c4b-4281-b951-d872f2087c98

The reload button is a circular arrow the same size as the spinner graphic.
While the list is being reloaded, the latter is displayed instead.

BUG=273137

Review URL: https://chromiumcodereview.appspot.com/23441022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221198 0039d316-1c4b-4281-b951-d872f2087c98

This involves exposing the app list model to a BrowserTest, and ensuring
that changes in the model are properly observed by the UI.

BUG=277897,169114
TEST=AppListControllerSearchResultsBrowserTest.UninstallSearchResult

Review URL: https://chromiumcodereview.appspot.com/23072036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221197 0039d316-1c4b-4281-b951-d872f2087c98

Due to performance reason, we need to keep using GData WAPI for FastFetch
even if Drive API v2 is enabled.

BUG=283622
TEST=Ran unit_tests and tested manually.
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23684012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221196 0039d316-1c4b-4281-b951-d872f2087c98

It's replaced by a version which takes an isolate. The default ctor will be removed soon.

BUG=
R=jamesr@chromium.org, sky@chromium.org, szym@chromium.org

Review URL: https://codereview.chromium.org/23861002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221193 0039d316-1c4b-4281-b951-d872f2087c98

This change reverts r199185 ("Disable SSL3 fallback restriction on Google
properties") and pokes a whole in the HSTS tables to account for
crbug.com/237055.

BUG=237055
R=palmer@chromium.org, rsleevi@chromium.org, wtc@chromium.org

Review URL: https://codereview.chromium.org/23523016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221192 0039d316-1c4b-4281-b951-d872f2087c98

A copy of media/test/sfx.mp3 with an Icecast header prepended to it.

BUG=280550
TBR=scherkus

Review URL: https://codereview.chromium.org/23902005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221191 0039d316-1c4b-4281-b951-d872f2087c98

Reintroduce the delay to adb_profile_chrome before it attempts to download a trace file. This reduces the chances that a partially written trace file gets downloaded.

NOTRY=true
R=tomhudson@google.com

Review URL: https://codereview.chromium.org/23464029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221190 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org
BUG=275931
TEST=none

Review URL: https://codereview.chromium.org/23460016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221188 0039d316-1c4b-4281-b951-d872f2087c98

We have temporarily disabled all WebRTC content_browsertests on Linux. This causes our custom build steps to hang because they no longer select any test cases on Linux, triggering bug 285051. This works around that bug so we don't have to disable the step and restart all our masters.

BUG=285051
TBR=tommi@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/23513014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221185 0039d316-1c4b-4281-b951-d872f2087c98

Re-land https://codereview.chromium.org/23602005: Use nobarrier atomics for lossy counters in base::HistogramSamples and base::SampleVector

This should not affect the performance, but will make it explicit that the counter values are expected to be read and written atomically.
This will also suppress the ThreadSanitizer v2 reports on these counters.

BUG=46840
TBR=jar@chromium.org

Review URL: https://codereview.chromium.org/23450016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221183 0039d316-1c4b-4281-b951-d872f2087c98

- GetOutputStreamParameters(device_id). Does the same thing as GetDefaultOutputStreamParameters except that it allows the caller to choose the device.
- GetAssociatedOutputDeviceID(input_device_id): Does a best effort dig to match an output device to an input device (both devices belong to the same audio card). This is useful for heuristic algorithms to distinguish headphones from webcams (w/mic).

GetOutputStreamParameters is fully implemented on Windows but works only for the default device on other platforms (same as GetDefaultOutputStreamParameters).
- This is OK for now since we don't rely on GetOutputStreamParameters yet.

Added implementation of GetAssociatedOutputDeviceID on Windows.
Default implementation of GetAssociatedOutputDeviceID just returns an empty string (i.e. assume the default output device).

Did a little bit of a cleanup in the WASAPI/CoreAudio implementation on Windows where we were doing the same operation unnecessarily often.

BUG=276894
R=henrika@chromium.org

Review URL: https://codereview.chromium.org/23523023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221182 0039d316-1c4b-4281-b951-d872f2087c98

This CL just adds the first version of PreviewPanel class, which manages only
the visibility of PreviewPanel.  The following CL will add more functionarity to
PreviewPanel class and replace the exisiting code by using PreviewPanel class.

BUG=284215
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23455026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221181 0039d316-1c4b-4281-b951-d872f2087c98

This is clean up CL about GetRemainingXxx family of DriveServiceInterface.
1) Removes ContinueGetResourceList().
2) Replace page_token by next_link.

BUG=277253
TEST=Ran unit_tests
R=kinaba@chromium.org, nhiroki@chromium.org

Review URL: https://codereview.chromium.org/23441038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221179 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding upstream bug (https://code.google.com/p/address-sanitizer/issues/detail?id=171)
has been fixed by Bill Wendling in LLVM r187827

BUG=196561
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/23684013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248101
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/23710015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221177 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221176 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/23788008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221175 0039d316-1c4b-4281-b951-d872f2087c98

> Use nobarrier atomics for platform-size lossy counters in base::HistogramSamples and base::SampleVector
> This should not affect the performance, but will make it explicit that the counter values are expected to be read and written atomically.
> This will also suppress the ThreadSanitizer v2 reports on these counters.
> 
> BUG=46840
> R=jar@chromium.org
> 
> Review URL: https://codereview.chromium.org/23602005

TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/23888004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221170 0039d316-1c4b-4281-b951-d872f2087c98

Use nobarrier atomics for platform-size lossy counters in base::HistogramSamples and base::SampleVector
This should not affect the performance, but will make it explicit that the counter values are expected to be read and written atomically.
This will also suppress the ThreadSanitizer v2 reports on these counters.

BUG=46840
R=jar@chromium.org

Review URL: https://codereview.chromium.org/23602005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/23483037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221166 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
BUG=None

Review URL: https://codereview.chromium.org/23530022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221165 0039d316-1c4b-4281-b951-d872f2087c98

> Reland after fix: Improve <webview> autosize:
> a. Expand/shrink <webview> element when 'sizechange' event fires, to
> match with the new view size (in shim).
> b. For SW mode, fix a bug where damage buffer would remain smaller than
> the view size and would result in crash. Added test for this case.
> 
> BUG=173238, 282116
> Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize
> webview container within the constraints
> (minwidth/maxwidth/minheight/maxheight).
> 
> Review URL: https://chromiumcodereview.appspot.com/23503023

Best guess that this caused flakiness of WebViewTest.Shim_TestAutosizeRemoveAttributes.
See here
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebViewTest.Shim_TestAutosizeRemoveAttributes

TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/23833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221164 0039d316-1c4b-4281-b951-d872f2087c98

> Convert OneClickSigninBubbleViewTest to interactive_ui_tests.
> 
> When a blur event occured during the execution of OneClickSigninBubbleViewTest, the bubble was dismissed and some assertions failed. The test has been converted to interactive_ui_tests, which is the right executable for tests that care about focus.
> 
> TEST=Run interactive_ui_tests:OneClickSigninBubbleViewTest.*
> BUG=266972
> 
> Review URL: https://chromiumcodereview.appspot.com/22743002

Best guess that this broke http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/7638

TBR=fdoray@chromium.org

Review URL: https://codereview.chromium.org/23882005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285040
TBR=clamy@chromium.org

Review URL: https://codereview.chromium.org/23606015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284959
TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/23731005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221156 0039d316-1c4b-4281-b951-d872f2087c98

Missing includes broke Files app's media players after recent change in the volume manager.

NOTRY=true
TEST=Check if videos and music are playing.
BUG=284666

Review URL: https://chromiumcodereview.appspot.com/23791003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221155 0039d316-1c4b-4281-b951-d872f2087c98

Remove the IDs from OrderedCommitSet in order to add a new member,
AddCommitItems().

Removing the IDs from this class would have been a good idea on its own.
There hasn't been any need to track both IDs and metahandles for quite
some time, and storing redundant information always carries the risk
that the two copies will disagree with each other. It is particularly
risky in this case because the entries' IDs will be changed when a
commit response is successful.

The AddCommitItems() function would have needed to have an inconvenient
signature if it had to pass in both the handles and IDs of all the
entries being added to the set.  It's much easier to implement now that
we only need to pass in the entries' metahandles.

The new member function is not used in this commit.  It will be used in
a future commit that allows us to run GetCommitIdsCommand on a single
model type at a time.

BUG=278484

Review URL: https://chromiumcodereview.appspot.com/23694004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221154 0039d316-1c4b-4281-b951-d872f2087c98

Based on feedback from UX, this shows all items in the Edit
menu when an app window is focused.
This copies the entire Edit menu instead of select items.

Some of the menu items don't work yet, we want to see how this feels on canary
and will iterate from there.

BUG=168080, 276052

Review URL: https://chromiumcodereview.appspot.com/23477029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22911032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221152 0039d316-1c4b-4281-b951-d872f2087c98

This is only interface part. Implementation will be in another CL.

R=binji@chromium.org, dalecurtis@chromium.org, ddorwin@chromium.org, dmichael@chromium.org
BUG=256538

Review URL: https://chromiumcodereview.appspot.com/23621019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221149 0039d316-1c4b-4281-b951-d872f2087c98

this matches Android somewhat. A good first pass, which can be followed up if need be.

BUG=260951

Review URL: https://chromiumcodereview.appspot.com/23512003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281587

Review URL: https://chromiumcodereview.appspot.com/23499005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221147 0039d316-1c4b-4281-b951-d872f2087c98

This test fails for dynamic size setting in NavigatePending. Following is comment in the code as reference.
// If WebContentsView is resized after RenderWidgetHostView is created but
// before pending navigation entry is committed, both RenderWidgetHostView and
// WebContentsView use the new size of WebContentsView.

BUG=281726
R=gab,kuan
TBR=jochen

Review URL: https://chromiumcodereview.appspot.com/23461020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221146 0039d316-1c4b-4281-b951-d872f2087c98