- 30 Jan, 2020 40 commits
-
-
Nazerke authored
This CL modernizes the ActivityOverlayCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates unit tests for Activity Overlay Coordinator. Bug: 1029346 Change-Id: I3e16373e7096355c7be9b1a7b1df53f1de4cb0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019030 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736921}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5dca3f1336a6..c31a4ec66af2 git log 5dca3f1336a6..c31a4ec66af2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 ivoc@webrtc.org Disable opus tests to allow upgrade to opus 1.3 2020-01-30 srte@webrtc.org Default disables legacy overhead calculation. Created with: gclient setdep -r src/third_party/webrtc@c31a4ec66af2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id95f4d958bb6315e0b42686f69d6a425a93e1f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736920}
-
Dominic Mazzoni authored
To repro, create a page with: <iframe src="..." aria-hidden="true"></iframe> When swiping left/right, TalkBack shouldn't navigate to any elements inside the iframe. The fix is to mark those nodes as not "interesting" internally, that means we won't navigate to those elements. Bug: 1046491 Change-Id: I48ba337829035cc6cd1508df8e78f6d460e36536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023482Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736919}
-
David Tseng authored
This is the continuing work to modernize accessibility extension js and make them uniform. The test js in Chrome is somewhat complicated because it needs to run through V8 shell in a first pass and in a real Chrome renderer when actually running the test. The first pass does not have access to the bulk of the test-only modules. Steps for conversion: - run automated conversion script - change classes from class Foo to Foo = class (assumes global scope) - move 'first pass' data onto prototype; unfortunately, we cannot instantiate the test object class in the V8 shell - remove all empty super() constructors (since default super constructors are automatically called) Test: all tests pass. Enforce object-shorthand in c/b/r/c/accessibility Change-Id: I7cf69c4bdcaf7c71d7d0355e802a2e48086fd9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025631 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736918}
-
Nazerke authored
This CL removes public properties for WebStateList and dispatcher values and updates the coordinator implementation to get the WebStateList and dispatcher from self.browser. Bug: 1029346 Change-Id: I613a9ad5a6b9048c4cab1f874eda7474cd3ee538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010946 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736917}
-
Sophie Chang authored
This also migrates subresource redirect to use the new API Bug: 1036490 Change-Id: Ia8b68f9fd46f93b4e01ea1d3e1140490e83d7837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026901Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736916}
-
Joe Downing authored
This CL adds conditions to the create/remove symlink rules for the Windows installer which will cause the symlink to be created on install and removed when either the MSI is being removed or being upgraded, but not when the same version is re-run. Change-Id: I7d9bbb24312ab9ad42c18d87528f1cdb9e4b5735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031136Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#736915}
-
sandromaggi authored
Before this change, there was already a boolean attribute to let the layout know it has an edit button. It has not been in use however. This CL reads the attribute (defaulting to true, for backwards compatibility) and disables the third column in the layout if necessary. This CL also removes the |can_add_items| attribute that seems to have been replaced with |add_button_text|. Screenshot (after): https://screenshot.googleplex.com/eKQcLrJBey9 Bug: b/146041576 Change-Id: I5865b71c7e9a726d1793b3a0016b42bebb4c45fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027454Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736914}
-
Yue Zhang authored
Bug: None Change-Id: I936e72faad21a0bb707c9f9e545dfa78cce87eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029233 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736913}
-
Joe DeBlasio authored
Fixed: 1039315 Change-Id: I18f7dbb06242ab5ccfedffb8035790ce359051c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031245 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#736912}
-
Yusuke Sato authored
Some ARC browser tests such as ArcAuthServiceTest.ChildTransition instantiates a profile and an ArcSessionManager object associated with the profile twice on purpose. On the other hand, ArcAppListPrefs object can be _asynchronously_ created while the first profile is in use. As a result, if the following happens, the DCHECK_EQ in the class fails, making such browser tests flaky: 1. The first profile is created. 2. The first ArcSessionManager is created. The first profile is associated with the manager. 3. A unrelated class e.g. ArcDefaultAppList does some PostTask operations. 4. The second profile is created. 5. The second ArcSessionManager is created. The second profile is associated with the (second) manager. 6. The PostTask operation finishes, and an ArcAppListPrefs object is created with the first profile. 7. The DCHECK_EQ fails. This CL changes the DCHECK_EQ to LOG(ERROR) to remove the race. BUG=b:144199481 TEST=try Change-Id: I0153a2ceba87c5a292b7b34f257e18868dc1f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030002 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736911}
-
Andy Paicu authored
Records the amount of times the infobar is shown and how many it times it does not need to be shown. Records the action that was taken as a result (granted/dismissed/denied) This helps us prepare some data for when the Android-level ephemerality changes will land and give us a baseline to compare to as we expect the number of times this infobar is shown to increase significantly. Bug: 1047184 Change-Id: If9dbec366d8c57b37585b990531432f5a1235ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030865 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736910}
-
Sylvain Defresne authored
As ChromeBrowserState has been moved to the global namespace and all client code fixed, the code added to support the incremental migration can be removed. Bug: 1042208 Change-Id: I35a69dfcf6256f0990ec3b3deeb847fa3a7c4ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026976Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736909}
-
Garrett Beaty authored
There's no reason to have a noop job triggered by a trigger: it is known that it will not do any work and doesn't simplify any other code. The 2 noop jobs that were being triggered by a trigger are not set as children of any builders in chromium_tests code, the fake builders exist only as the builder for trybot mirrors. Bug: 819899 Change-Id: Icfded342fc7c379e790f453fe3fe0196a1d3a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031045 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736908}
-
Owen Min authored
Change-Id: Ia417d2d3c4eb49b0fca84eeeaf0bcd0f3ca79b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031205Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736907}
-
Boris Sazonov authored
Reconcile CoreAccountInfo with its C++ counterpart by removing Android-specific Account object and using email as a string instead. This improves consistency and simplifies creating CoreAccountInfo in tests. CoreAccountInfo.getName() will be renamed to getEmail() in the subsequent CL. Bug: 1042197, 1046412 Change-Id: I99d721771841ca361df63c17f1d77be8cb450abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027531 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736906}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ef0942f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I71b39572018fd02b1619a12596b0d9f4d2e65e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031084Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736905}
-
Miguel Casas-Sanchez authored
This reverts commit 72037f82. Reason for revert: M80 Stable blocker bug 1046501 Original change's description: > media: use VEA SupportedProfile |min_resolution| for PeerConnection > > crrev.com/c/1828078 added and wired the video encode acceleration > minimum resolution; this CL uses this information from peerconnection's > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a > hw accelerator for resolutions below the given one. > > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241 > are encoded using libvpx while larger ones are encoded using "ExternalEncoder", > i.e. the video encode accelerator in Chrome, in this case VA-API. > > Bug: 1008491 > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720981} TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008491 Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#736904}
-
Ella Ge authored
Whe recording WebAPK UKM, we use manifest url as the source_url. But UKM has a mechanism that filter out the url that are not whitelisted. Manifest url does not matches the navigation url or other whitelisted url, so the record is drop with DropDataReason::NOT_MATCHED. This CL adds another SourceIdType WEBAPK_ID for the WebAPK manifests, so that these url are whitelisted. Bug: 1044706 Change-Id: I988473f52afcf5b25cc5fafd43934e866f628f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018086 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736903}
-
Raphael Kubo da Costa authored
This follows what Sensor::OnSensorReadingChanged() already does, but which we were missing in the AmbientLightSensor override. Platform sensor initialization happens before the sensor infrastructure on the Blink side transitions reaches Sensor::NotifyActivated() and transitions to the SensorState::kActivated state. In practice, this means we can start receiving readings too early, and in the Ambient Light Sensor case it meant setting |latest_reading_| to an actual value but never emitting a "reading" event, so users would never get notified of the first reading after starting the sensor (which also contradicts the spec). To make it worse, we have privacy measures in place that require illuminance readings to differ by a certain threshold before we emit a reading event, so if the user's surroundings did not change no reading event would ever be emitted at all, even though accessing the "illuminance" attribute in JS would actually return a rounded version of the first reading the platform sensor sent during initialization. Bug: 606766, 1046902 Change-Id: Id9e8844b5e4a199686024795befaa3539530cf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030889 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736902}
-
Scott Violet authored
Adds two assertion to BrowserFragmentImpl.OnCreate. 1. that mBrowser is null, otherwise we're creating a new one. I believe this is valid as onCreate() is only called once. 2. that mContext is not-null. My understanding is onCreate() is always called after onAttach(), so that mContext should not be null. BUG=none TEST=covered by tests Change-Id: Ic863a8a63406357a867453690be706e55039cb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030049Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#736901}
-
Mike Reed authored
SkCreateTypefaceFromCTFont is deprecated Change-Id: Iefebf57aeb18b18e71fe5b7c0d8d0d644b86b1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028969Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#736900}
-
Raymond Toy authored
The channelCount and channelCountMode for a convolver node is no longer fixed. The count can be 1 or 2 and the mode can be set to any valid value other than "max". This is basically the same constraints as for a StereoPannerNode. Also see https://github.com/WebAudio/web-audio-api/issues/2050 Feature: https://www.chromestatus.com/feature/6248507407073280 Bug: 1021552 Change-Id: I1cd814376d88ff4a525bae1f5e608ca4b989ac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988714 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736899}
-
Alex Clarke authored
A subsequent patch will add Finch so I've added FeatureListCreator to encapsulate UMA & Finch setup. Bug: 1025781 Change-Id: I6c2a71e714733caf94cddc9d8dcf3875789a8298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932543Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736898}
-
Tomasz Moniuszko authored
Bug: 1046312 Change-Id: Id5e00d4a829ed9425188c5afb0b1e47c98a3f64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023492Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#736897}
-
Sam Maier authored
The current downstream manifest merger has a bug. This is a temporary workaround, once the downstream manifest merger is fixed, we should revert this change. Bug: 1045352 Change-Id: I0cded150604888443fadc53b458426525d200894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028853 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#736896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ec7b8485455..3e98c0e1d115 git log 0ec7b8485455..3e98c0e1d115 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 brianosman@google.com Use separate SKSHAPER_DLL define to activate shared library logic 2020-01-30 rmistry@google.com Turn off failure comments from G3 bot 2020-01-30 bsalomon@google.com Avoid using kClamp domain in GrMatrixConvolutionEffect::MakeGaussian. 2020-01-30 brianosman@google.com Fix skshaper in component builds 2020-01-30 mtklein@google.com finish up 2pt conicals 2020-01-30 benwright@google.com [fuchsia] Replace system-temp with isolated-temp. Created with: gclient setdep -r src/third_party/skia@3e98c0e1d115 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I941d0cfd80559e0c9c337c70929395cd88856eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736895}
-
Kazuki Takise authored
As Android doesn't know about Chrome OS System UI, it can place the PIP window at an incorrect position. There were CTS concerns that disallow Chrome to adjust PIP initial bounds, but we decided to workaround this on the Android side. BUG=b:147790853 BUG=b:147791406 TEST=Manually confirmed PIP windows were located at the correct position TEST=with hotseat on TEST=android.server.am.ActivityManagerPinnedStackTests TEST=#testEnterPictureInPictureSavePosition Change-Id: Ibe962fc105584a1d457a3e3075e2dcabc23db129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022582 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima (slow in TOK) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736894}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d2b593996f3..65080795f53f git log 8d2b593996f3..65080795f53f --date=short --first-parent --format='%ad %ae %s' 2020-01-30 eseckler@google.com startup writers: Release unique_ptr/lock correctly in ReturnTraceWriter 2020-01-30 eseckler@google.com startup writers: Add missing weak_ptr check 2020-01-30 eseckler@google.com Merge "startup writers: Make sure ReturnToRegistry() runs on right thread" 2020-01-30 taylori@google.com Merge "perfetto-ui: Mark an area selection" 2020-01-30 taylori@google.com Merge "perfetto-ui: Draw area selection as a box" 2020-01-30 fmayer@google.com Merge "Make heap_graph_missing_packet kError." Created with: gclient setdep -r src/third_party/perfetto@65080795f53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I591724c1457650c837cffe1a62efe08b7bf568a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736893}
-
Elly Fong-Jones authored
These are all straightforward. Bug: 1011446 Change-Id: I6dacfff7d45b9f344be7c5533e1d810cb8332b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007888 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736892}
-
Clemens Arbesser authored
Before this CL, date/time sections showed a combined date/time label and popup. To address UX feedback, this CL splits the UI into dedicated date and time sections, each with their own popup. This also addresses a feature request where the granularity of the time section needed to be configured, a feature not supported by the standard android time picker. Finally, this CL moves date/time logic to native, i.e., native code now ensures that start > end, etc. Bug: b/147577012 Change-Id: Id0eb0661ce3351dc8b8536fca96354752f523375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013053 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736891}
-
Maksim Ivanov authored
This reverts commit 4b79ed37. Reason for revert: Causes crashes on Chrome OS - see https://crbug.com/1047222. Original change's description: > Reland "[Structured metrics] Add metric collection and upload logic." > > This is a reland of 2fe77415 > > Original change's description: > > [Structured metrics] Add metric collection and upload logic. > > > > This is the final CL for the core of the structured metrics system. It > > ties together the KeyData class (for managing keys and computing hashes) > > with the metrics provider, and implements logic to: > > > > 1. Hash and store incoming structured metrics events. > > 2. Provide stored metrics events for upload. > > > > It also adds integration tests for the system, checking that an event > > created through the public API is correctly prepared for upload. > > > > Other misc changes: > > > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > > to events_template.py, to fix some bad style. > > - Added a missing RemoveObserver call to the metrics provider dtor. > > > > Bug: 1016655 > > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > > Commit-Queue: Tony Yeoman <tby@chromium.org> > > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735748} > > Bug: 1016655 > Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736590} TBR=amoylan@chromium.org,tby@chromium.org Change-Id: I06ea1c7935600f26a7afbd2ec81a4c0f11277a70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030968Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736890}
-
Elly Fong-Jones authored
This change: 1) Removes the can_close parameter to chrome::ShowWarningMessageBox() 2) Removes the code supporting that parameter, making close always possible on message boxes 3) Renames SimpleMessageBoxViews to MessageBoxDialog, to indicate that it is a dialog rather than a View Bug: 1011446 Change-Id: Ia4e0ba79ad170bc7837d48eb380ff752236c05ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028667Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#736889}
-
Sylvain Defresne authored
This code is not build and not used. The README.txt says this is a proof-of-concept, but as far as I can tell this has never been used and is not maintained (since it is not build). Bug: none Change-Id: I42217423cd0e83189c8f59097ea876df036ca0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027529Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736888}
-
Peng Huang authored
With AMD GPU, vulkan cannot submit a command buffer with waiting on a semaphore which is signaled by GL. It is a driver bug reported at https://gitlab.freedesktop.org/mesa/mesa/issues/2433 . So disable GL_EXT_memory_object_fd and GL_EXT_semaphore_fd extensions. Without those extensions, chrome will fallback to copy pixels from vkimage and gl texture instead of sharing the same backing memory object. Bug: 1046462 Change-Id: I231af9a626d692dbde89d9cd2f8a4bdc5ddf6eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027889Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736887}
-
Charlie Hu authored
Previously if a http response has both Document-Policy and Require-Document-Policy header and they are incompatible, the document will be blocked, which is not the correct behavior. This CL corrects the behavior of document policy under such condition. Bug: 993790 Change-Id: I5fc6b5c213fa7d56d473a8ea7e10235dd418ba42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015443 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#736886}
-
Benoît Lizé authored
Reason: failing, see linked bug. Bug: 599650 TBR: mcasas Change-Id: Iec795ad764a0a2d78dfb77e3b5f752b857da6bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030171 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736885}
-
Omer Katz authored
This is part of an ongoing effort to simplify heap collections and limit the types they can support (specifically, this CL removes the only existing non-member usage of HeapListHashSet). Bug: 1047147 Change-Id: I1c5de9f3a97588c22946eed03048159fd720b502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024896Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736884}
-
Guido Urdaneta authored
Bug: 1045381 Change-Id: I285a44d32d47522786b1676b708b0723f336295b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031144Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736883}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d69935c114aa..5dca3f1336a6 git log d69935c114aa..5dca3f1336a6 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 peah@webrtc.org Add floating point support for writing and reading wav files 2020-01-30 philipel@webrtc.org Remove unused NextFrame function from FrameBuffer. Created with: gclient setdep -r src/third_party/webrtc@5dca3f1336a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae37805d25be988d08bcebd60fc954b7d7dd2e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736882}
-