- 21 Nov, 2018 40 commits
-
-
Olivier Robin authored
The files used for FormStructureBrowserTest are snapshots of real web sites. They can have link to online resources but should not need them for the test to pass. But if the network is really bad, the page can wait for the resource loading to finish and timeout. Preventing the resource loading will make the test faster and more robust. Bug: 896173 Change-Id: I78f180aca959c50996b1af932cc31c1690795038 Reviewed-on: https://chromium-review.googlesource.com/c/1343089 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610079}
-
Anders Hartvoll Ruud authored
TBR=hbos@chromium.org Bug: 907481 Change-Id: Ia9ba831079b39c374664dd4e9d847c6a69073268 Reviewed-on: https://chromium-review.googlesource.com/c/1346395 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#610078}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Bug: 850504 Change-Id: I617a48c931a6acf3bb7ca560d59b1136eea59d44 Reviewed-on: https://chromium-review.googlesource.com/c/1346457Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ace67b95f5c..ae57ced21615 git log 9ace67b95f5c..ae57ced21615 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 dhanyaganesh@chromium.org cidb: Delete unused functions Created with: gclient setdep -r src/third_party/chromite@ae57ced21615 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ice52c26b23ffa653aa5799f4571d5710b44542d7 Reviewed-on: https://chromium-review.googlesource.com/c/1346349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610076}
-
sangseok.jang authored
If drop_down_menu is shown at least twice(e.g repeating right-click), Inkdrop's state is still although hover drop_down_menu is closed. Bug: https://www.crbug.com/907358 Change-Id: Ie6ff9f4cfd09711a9b9af95cc0645e3c24778bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1345694Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610075}
-
Guido Urdaneta authored
This CL updates the constraints processing algorithm to take into account the resizeMode constrainable property. This effectively adds spec-compliant support for this property in getUserMedia() and applyConstraints() for device capture and capture-from-element tracks. Bug: 854980 Change-Id: I6c2022aac121fee240b4d6a8f631beff35d89fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1310813 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610074}
-
Sean Gilhuly authored
Stop recreating the current ui element in BuildTreeForUIElement, and fix some other errors that were causing DCHECKs. Node reparenting should be streamlined in the future; currently, the whole subtree is destroyed and recreated in the new location. This fixes all of the known crashes in the Viz DevTools server. Bug: 816802 Change-Id: Ied786d3e244fd62c3482602e5b7067494822c2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1330298Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#610073}
-
John Lin authored
This is guarded by the CCTModuleCustomHeader Finch feature. Bug: 882404 Change-Id: I873acffd037660ab4d4ced908cce4c8b7e8aad6e Reviewed-on: https://chromium-review.googlesource.com/c/1326009Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#610072}
-
Armando Miraglia authored
The refactoring aims at making more explicit the relationship between the various level of aggregations and the properties. The various levels of aggregation for audio constraints now abide a general implicit interface, by implementing ApplyConstraintSet, IsEmpty, and SelectSettingsAndScore. Such interface expresses the general functionalities implemented by the various levels of aggregation. The first level of aggregation is represented by CandidatesContainer, which owns all the candidates and by looping over all determines the best fitting. The second level of aggregation is represented by the DeviceContainer, representing a single candidate. The container is responsible to determine the best fitting setting for each single setting. Finally, the third level of aggregation is represented by BooleanContainer, StringContainer, and EchoCancellationContainer. Here each container abstracts, per-type, the relationship between constraints and settings. The echo cancellation, in this case, requires special treatment due to the relationship between 3 constraints and one output setting. BUG=731170 TESTED=./out/Default/content_unittests R=guidou@chromium.org Change-Id: I70df75d4aa0a4c825dc4a34bdc62a5580ba1993c Reviewed-on: https://chromium-review.googlesource.com/c/1326489Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#610071}
-
Anders Ruud authored
This reverts commit fa8a5d39. Reason for revert: Regressed FileManagerUITest.CheckSelect, see https://crbug.com/907510 Original change's description: > Fix selection jumping around when removing multiple items in cr-list. > > Previously, when the selected item is removed, the selection is changed > to the index after where the old lead index was. When multiple items are > removed, the logical next item may move multiple positions. Avoid this > by moving to the item that hasn't been removed from prior to the > permutation - using its position after the permutation. > > Bug: 708299 > Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1345709 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610019} TBR=calamity@chromium.org,sammc@chromium.org Change-Id: Ic44793da74f4fa26243962bf0fa1b0aa17cd8546 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 708299 Reviewed-on: https://chromium-review.googlesource.com/c/1346829Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f16788e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie7e8f2be3a33655543ebc8699cd446b34b7b2feb Reviewed-on: https://chromium-review.googlesource.com/c/1346470 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610069}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/101c113f649b..3adb7977dae0 git log 101c113f649b..3adb7977dae0 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 zoddicus@users.noreply.github.com Check forbidden Annotation instructions for WebGPU env (#2090) 2018-11-20 zoddicus@users.noreply.github.com Validate that debugging instructions are not present for WebGPU (#2089) 2018-11-20 33432579+alan-baker@users.noreply.github.com Add support for VK_EXT_Transform_feedback capabilities (#2088) 2018-11-20 hevrard@users.noreply.github.com Update build instructions: add effcee, re2 (#2085) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3adb7977dae0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd7aaa49ddab7d80cf6d89e57260294d261fe9cf Reviewed-on: https://chromium-review.googlesource.com/c/1345311Reviewed-by:
-
Mario Sanchez Prada authored
Move this utility method's declaration & definition to identity_utils.[h|cc] and provide a specific test suite to check its functionality, in preparation for the future removal of the SigninManager class and its relocation to the Identity service. Bug: 906084 Change-Id: Ie3fd26501ea95266d35d6e3640935a8e07b45afa Reviewed-on: https://chromium-review.googlesource.com/c/1346093Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#610067}
-
Dominic Battre authored
If you enable chrome://flags/#show-autofill-type-predictions, Chrome will put information about the autofill state for a specific <input> field into the field's titel attribute. This is convenient for debugging because you can hover over the field to read the information. Unfortunately, this is brittle if you also use Google Translate for the site as Translate will try to translate the titel value. This breaks automated processing of the data. This CL replicates the annotations into a second attribute 'autofill-information' that should not be touched by Google Translate. Bug: 773186 Change-Id: I1716b8d78e360ec67f20578cf07444018b989653 Reviewed-on: https://chromium-review.googlesource.com/c/1346050 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610066}
-
Marc Treib authored
Bug: 851439 Change-Id: Id955ccd91aa234c9a81566c0c76568e30d9d54ac Reviewed-on: https://chromium-review.googlesource.com/c/1346396Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610065}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=skau@chromium.org Bug: 903957 Change-Id: Icd6f4bf53daa45bf540611ededc97b941f09da88 Reviewed-on: https://chromium-review.googlesource.com/c/1338407Reviewed-by:Sean Kau <skau@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#610064}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef3f9bef8660..9a370396f131 git log ef3f9bef8660..9a370396f131 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 reed@google.com default behavior for onNewImageSnapshot 2018-11-21 reed@google.com Revert "add rect-parameter to makeImageSnapshot" 2018-11-21 mtklein@google.com streamline some of the _matrixProcs 2018-11-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-21 reed@google.com add rect-parameter to makeImageSnapshot Created with: gclient setdep -r src/third_party/skia@9a370396f131 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I4f59dddd35dea68a45e9475ca923c0327419dabe Reviewed-on: https://chromium-review.googlesource.com/c/1346353Reviewed-by:
-
Mike Reed authored
TBR=fmalita Change-Id: I0450b8c8a708f3418c12dbc6671e20f8e1c5c3e7 Reviewed-on: https://chromium-review.googlesource.com/c/1346669Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#610062}
-
Ioana Pandele authored
Bug: 904821, 903249 Change-Id: I26d763f62086d866ced1e8ef669314901cf3c8b5 Reviewed-on: https://chromium-review.googlesource.com/c/1345630Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#610061}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d23e71a1714..bbe98fbac5e1 Created with: gclient setdep -r src-internal@bbe98fbac5e1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892301 TBR=mmoss@chromium.org Change-Id: Ibcea2f441e29436711e5efe90f550fe2aff69158 Reviewed-on: https://chromium-review.googlesource.com/c/1346352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610060}
-
Manuel Rego Casasnovas authored
The spec is quite clear (https://drafts.csswg.org/css-sizing/#valdef-width-min-content): "min-content If specified for the inline axis, use the min-content inline size; otherwise behaves as the property’s initial value." So if a grid container has "height: min-content" it should behave the same than with "height: auto". The patch removes ComputeIntrinsicLogicalContentHeightUsing() in LayoutGrid as we don't need a custom one anymore. We can also get rid of min_content_height_ and max_content_height_ attributes that were only used for this logic. BUG=906039 TEST=fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html TEST=fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html Change-Id: Ia67d1dac16fbb04e3225115c3f34c67975dc6f94 Reviewed-on: https://chromium-review.googlesource.com/c/1340311Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#610059}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83a041b5da87..76499cd866b6 git log 83a041b5da87..76499cd866b6 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 primiano@google.com Extract base::Pipe Created with: gclient setdep -r src/third_party/perfetto@76499cd866b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia5bb833cb04a6606ea6164f8f81abc20b25a487e Reviewed-on: https://chromium-review.googlesource.com/c/1346354Reviewed-by:
-
Stephen McGruer authored
This is a follow up from https://chromium-review.googlesource.com/c/chromium/src/+/1297172 Bug: None Change-Id: I9db0d1a3bb233a49938ab9be4813fe3cbf0505af Reviewed-on: https://chromium-review.googlesource.com/c/1340871 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610057}
-
Eric Seckler authored
Also fixes the ordering of entries in the NotificationPreferences. TBR=twellington@chromium.org Bug: 898512 Change-Id: I2ad01d04a517100b3b0629c053dcd215cd2f838a Reviewed-on: https://chromium-review.googlesource.com/c/1346071Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610056}
-
Marc Treib authored
Previously it just checked GetPreferredDataTypes. This was probably okay in practice (the check was anyway more of a "has the user not disabled history sync" rather than "is history sync enabled"), but still better to be correct. While we're here, also move to SyncUserSettings, which is the new way to query any user-configurable bits of Sync. This also includes a bunch of test cleanup: Removing a Mock class that isn't used, and using NiceMock to avoid unnecessary chattiness. Bug: 907027, 884159 Change-Id: I2a3d0f8ef13a74b51f4b4a2edc19976a61c6c430 Reviewed-on: https://chromium-review.googlesource.com/c/1343087Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610055}
-
Peter E Conn authored
Not the biggest of changes, but every little helps! Bug: 887926 Change-Id: I150e13fd221f0ac31597e984d044066bb02adf3f Reviewed-on: https://chromium-review.googlesource.com/c/1343115Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#610054}
-
Vladislav Kuzkokov authored
Bug: 891174 Change-Id: Icd1be1b4d9eec699223757cd5da846a5a705e0ef Reviewed-on: https://chromium-review.googlesource.com/c/1344060 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610053}
-
Robert Sesek authored
Bug: 832676 Change-Id: I2e7c0352514c3ba46b44f17b65dce370b945ac15 Reviewed-on: https://chromium-review.googlesource.com/c/1344995Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#610052}
-
Nico Weber authored
compare_build_artifacts.py: Add workaround for .isolated files containing the name of the build dir. Bug: 899438,907488 Change-Id: Ic958d09e1fd4fc8a34f4f33fc9bfb9e3bc5d6a54 Reviewed-on: https://chromium-review.googlesource.com/c/1346670 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610051}
-
Henrik Boström authored
CallSetupState simplifies the OffererState/AnswererState to: - kNotStarted - kStarted - kFailed - kSucceeded This is allows an RTCPeerConnection to be given a single label, instead of one label per role (offerer, answerer) and will make it easier to estimate % success/failure. (This is roughly what the Alternative proposal from the CallSetupStateTracker design doc is). Bug: 906029 Change-Id: I8d0c673d4fa70403e6a552e9f76f9b4b3c10e5d4 Reviewed-on: https://chromium-review.googlesource.com/c/1344051 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610050}
-
Jinho Bang authored
The test is not working because invalid enum value is passed to the complete() method. Bug: 861704 Change-Id: I93d54e34a79428fdc88a2c52f12c80ae29c18221 Reviewed-on: https://chromium-review.googlesource.com/c/1346429Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610049}
-
Egor Pasko authored
TBR=peconn@chromium.org,dtrainor@chromium.org NOTRY=true Bug: 906840 Change-Id: I3a9627c2095e71ffccc4f4b0a2e0371d73dc670a Reviewed-on: https://chromium-review.googlesource.com/c/1346304 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610048}
-
Leon Han authored
This CL removes typemapping of (blink.mojom.FetchAPIRequest, blink::WebServiceWorkerRequest), instead, we use blink::mojom::FetchAPIRequest struct directly. This reduces lots of usages of blink::WebServiceWorkerRequest, now its only usage is to carry the request data of a fetch event dispatched towards a service worker, from //content across the boundary into Blink. BUG=789854 Change-Id: Ife644a71941ea8db9f7798d414d49f2a0c61cf61 Reviewed-on: https://chromium-review.googlesource.com/c/1322360 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610047}
-
Juan Antonio Navarro Perez authored
Using --browser=android-webview-google should make these bots install Monochrome.apk and use it as webview provider. Bug: 817842 Change-Id: I6cc9f685cb06467ae31b34c5627ce2b8b9bceedc Reviewed-on: https://chromium-review.googlesource.com/c/1344429Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#610046}
-
Anders Hartvoll Ruud authored
TBR=dcheng@chromium.org Bug: 907412 Change-Id: I903923a922f8116841e9260aa715eeaaf896549b Reviewed-on: https://chromium-review.googlesource.com/c/1346450 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Eric Seckler authored
Adds functionality to share a recorded trace to the mobile tracing feature. Bug: 898512 Change-Id: I85107017abdad5ad508b18aecbba58607a004657 Reviewed-on: https://chromium-review.googlesource.com/c/1346070Reviewed-by:
-
Tom Tan authored
Bug: 893460 Change-Id: I1ebf06dd022defaaa6b06a27455059d9724f0fa5 Reviewed-on: https://chromium-review.googlesource.com/c/1344870 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#610043}
-
Sergey Ulanov authored
Previously base::LaunchProcess didn't allow paths_to_transfer to be used with the FDIO_SPAWN_CLONE_NAMESPACE flag. This meant that to override directories the test launcher had to avoid FDIO_SPAWN_CLONE_NAMESPACE flag. This is not ideal because of the added complexity in the test launcher and also because the launcher was changing test environment by not cloning all entries in the namespace (i.e. some tests would behave differently when started with --single-process-tests flag). This change updates LaunchProcess() to allow individual dirs transfer while cloning the rest of the namespace. Also updated test launcher to use this new feature. This CL should unbreak the tests currently broken in https://crrev.com/c/1341243 Change-Id: I3c30497222ffd33d6240f478523d3e767fad90f5 Reviewed-on: https://chromium-review.googlesource.com/c/1345236Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Tom Tan authored
Bug: 893460 Change-Id: Iad812763c50045ffd9b18b73e0233cbeb4062bf2 Reviewed-on: https://chromium-review.googlesource.com/c/1343567 Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Reviewed-by:
-
Sylvain Defresne authored
SigninManager::Observer::GoogleSigninSucceeded had two overload one taking a AccountInfo, and one taking two std::string. The latter is deprecated in favor of the former. As all overrides of the latter version are in components/signin or services/identity, convert them in one CL and remove the old method (that is now unused). Bug: none Change-Id: I5e2d56187b60e0a84dc6c3b6fae100f7b1d0467f Reviewed-on: https://chromium-review.googlesource.com/c/1344052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#610040}
-
