- 25 Nov, 2020 40 commits
-
-
Charlene Yan authored
This reverts commit 2c73aa66. Reason for revert: Disabling test on linux Original change's description: > Revert "[Tab Scrolling] Add test for tabstrip resizing when dragging." > > This reverts commit a4b670d5. > > Reason for revert: Test is flaky/failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95514? > > ../../chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2470: Failure > Expected equality of these values: > tab_strip_width + TabStyle::GetStandardWidth() > Which is: 751 > tab_strip->width() > Which is: 761 > > Original change's description: > > [Tab Scrolling] Add test for tabstrip resizing when dragging. > > > > When the browser window is large enough, the tabstrip should expand to > > accommodate tabs dragging past the last tab. This is a test for > > crrev.com/c/2472577 > > > > Bug: 1141674 > > Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068 > > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827998} > > TBR=tbergquist@chromium.org,cyan@chromium.org > > Change-Id: Iaee8c99d3a53eb4f1031d969b01e39d86febe6a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1141674 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545744 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828425} TBR=mek@chromium.org,tbergquist@chromium.org,cyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1141674 Change-Id: If7b71337950554f49dc9d635dbb2a2a35f0c280c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559577Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831141}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3c2d8c6c5a356af367d84304a7ca7c3d72b9621e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560307 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831140}
-
Moe Ahmadi authored
Whitespaces are removed from the beginning of the input string returned in the AutocompleteResult. This should be taken into account when deciding whether the results are fresh when they arrive as well as when navigating to them. This CL accounts for that subtlety in the latter. Fixed: 1102345 Change-Id: I2f34805dfd2cb02aed6659f497347c93771e5666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560070Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#831139}
-
Aaron Leventhal authored
1. Add DCHECKs that prevent an AXObject from being detached during serialization. This prevents situations where an object is detached at an unexpected time such as during UpdateCachedAttributesIfNeeded(). That causes crashes because the detached object is still running its own code attempts to use private variables such ax ax_object_cache_, which is now null. 2. Get() is now safe to call at any time, and never detaches nor creates AXObjects. However, it will check whether an object is not the correct type (AXNodeObject vs AXLayoutObject) and, if necessary, mark the object as invalid to be refreshed when layout is clean.. These changes ensure the following cases do not lead to crashes due to suddenly needing to change from an AXLayoutObject to an AXNodeObject or vice versa. * Changing CSS display, e.g. to table cell or toggling display:none * Changing CSS appearance / -webkit-appearance on a control * Reparenting node into or out of a <canvas> * Display lock changes (CSS content-visibility) Also removes 8 TODOs, but adds 2. This is a cleaner, more long term fix for these types of crashes and the content-visibility-auto-crash.html test than the fix in CL:2553695. TBR=kinuko@chromium.org Bug: 1138861,1138837 Change-Id: I8c7ac9617e27b9eeb725c9c794ffdfd570bd6f13 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485519 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831138}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3642900e6d46..81585eced14b 2020-11-25 raphael.kubo.da.costa@intel.com Rewrite some UI.Geometry.EulerAngles layout tests as unittests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie9ec09621be99f352b7d426b74ebd443d58dcecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831137}
-
Karandeep Bhatia authored
This was disabled in crrev.com/c/1688731 due to failures in linking of filter_list_converter target. This has now been fixed. BUG=981112 Change-Id: I3e4f5947d345c2c96dac6c3c2fe531309e7b827d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561442Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831136}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9d4c07d6d0f..04353ebb2005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com,etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ramyan@google.com,etiennep@google.com Change-Id: Id059451412e2e7488a735e83d4e0bc7489b827af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/732dc2952044..bc82325e3445 2020-11-25 syoussefi@chromium.org Fix RedGreenGradient to not output 0 for half the image 2020-11-25 geofflang@google.com Add test coverage of sampling YUV AHBs without API 29. 2020-11-25 geofflang@google.com GL: Treat RGBA+HALF_FLOAT IOSurfaces as sized formats. 2020-11-25 jmadill@chromium.org EGL: Auto-generate Windows .def file. 2020-11-25 jmadill@chromium.org EGL: Auto-generate "libEGL" export cpp file. 2020-11-25 jmadill@chromium.org Skip Occlusion query tests on Metal. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1148599 Tbr: jmadill@google.com Change-Id: I913b0430da972c8ed46ed2bd15d0e87fe00fe86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560543Reviewed-by:
-
Kelvin Jiang authored
Reloading an unpacked extension is functionally identical to uninstalling it, then installing again from its unpacked directory. Rule allocation should be updated in case the unpacked directory's rule count changes. Bug: 983299 Change-Id: I8c73847ff025bed62c4adbf0810b1c29878f4f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556759 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL removes two unused UMA. These two UMA were added here: https://chromium-review.googlesource.com/c/chromium/src/+/1715906 The UMAs were added to see the potential brakage when we change the viewport style propagation logic for scroll snap props. We have already landed the logic change here: https://chromium-review.googlesource.com/c/chromium/src/+/1704859 The logic change were landed over one year ago, so this CL removes the associated UMAs. Bug: 952711 Change-Id: Iaac4c62236b1555b42ab6676b107db121279a13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561039Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#831132}
-
John Lee authored
Bug: 1142076 Change-Id: I81cee8a975a7d289fd4272475f9010aa87c909c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559289Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#831131}
-
Yusuke Sato authored
BUG=None TEST=components_unittests Change-Id: I19b8e34eb35d33f768ee2e7ad8b3a01f8d11da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559693Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#831130}
-
David Maunder authored
The price formatting was originally hard coded for USD. It is now internationalized. UX/PM requirements are not yet available for exact formatting (e.g. commas, decimal places) so this change does not finalize our price formatting but rather gives us the ability to do some initial experimentation in other locales. TBR=yusufo@chromium.org Bug: 1130068 Change-Id: I075b035a560ad651ad166bc47a94031fc44859e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556454 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#831129}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08ac8ee5..12af0f03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I338497c22db4defb7496800032e94b893080d4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561119Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831128}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a66263753a9f..2b606e9297e0 2020-11-25 enga@chromium.org Unify WGSL syntax to put stage decoration on same line 2020-11-25 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 12ed862c7ef2 to 4e91325bf0c4 (3 revisions) 2020-11-25 senorblanco@chromium.org Enable testing on GLES backend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I3c6b33f184e3e70d2b8e20e36527883b62e6ee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561283Reviewed-by:
-
Dominic Mazzoni authored
The regression test is odd but it's the smallest repro I could come up with based on ClusterFuzz. Bug: 1149132 Change-Id: I09fbb35c7cbdd47a14d9f68a6268285d193844cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559806 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#831126}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9a5e21da681d..0db3396646aa 2020-11-25 eshr@google.com Log VideoSendStreamImpl::Stop in logs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I48ed7b8910bf49e5697ddd5be763c8ca5913ae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561281Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606305050-ea6ce0091e94442cf03fb928da3568602c7b69e6.profdata to chrome-mac-master-1606327120-e32add9932b9917c7d02c6e60e2518fc762f03e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98bd6738364f0910fdd7a388261f1ac8c03af951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561103Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606305050-8edbd758527486c76db2fc42225801a21c253468.profdata to chrome-linux-master-1606327120-481ff93b7112a13bdcf1248f3441d3a11742a301.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I565b73a35253c7d81985b1f1cbf3e82270a55c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561104Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e5079a280ed..51b74afb84d4 2020-11-25 michaelludwig@google.com Reland "Move conservative bounds tracking from SkCanvas to SkNoPixelsDevice" 2020-11-25 jvanverth@google.com Hide binaryArchive use in Viewer behind a flag. 2020-11-25 nifong@google.com update buildbot repo 2020-11-25 johnstiles@google.com Add support for boolean ^^ operator in SPIR-V. 2020-11-25 johnstiles@google.com Disallow unary minus on boolean vectors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I36f9f32400e1273062ff7903b83c58ae3402ea90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561101Reviewed-by:
-
Eric Seckler authored
This can lead to deadlocks, because of lock order inversions of mojo and tracing locks, e.g. when mojo emits an event under lock while EmitTrackDescriptor() calls TraceWriter::Flush(). Bug: 1136294 Change-Id: Ib1ff2f10f9fb7da1a41ce6172cc781eca26b6c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560303 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#831121}
-
Juanmi Huertas authored
This reverts commit 49fa3eb5. Reason for revert: Fixing Pixel test. Original change's description: > Revert "Not disable acceleration in getImage if its Desynchronized" > > This reverts commit edce90d5. > > Reason for revert: crbug.com/1151440 Pixel_CanvasLowLatency2DImageData > test consistently fails on Android FYI Release builders, e.g.: > > https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%205%29/b8863094711783933776 > > Original change's description: > > Not disable acceleration in getImage if its Desynchronized > > > > This is a temporary fix for this issue, that will totally be fixed > > after we land the new 2d canvas api (that will completely remove the > > path of code causing this regression in base_rendering_context_2d.cc: > > if (!RuntimeEnabledFeatures::NewCanvas2DAPIEnabled()) { > > // GetImagedata is faster in Unaccelerated canvases > > // Do not disaccelerate if Desync2d Canvas on android. > > // Issue 1112060: putImageData() does not work for desynchronized 2D canvas > > // on Android > > if (IsAccelerated()) { > > DisableAcceleration(); > > base::UmaHistogramEnumeration("Blink.Canvas.GPUFallbackToCPU", > > GPUFallbackToCPUScenario::kGetImageData); > > } > > } > > > > This CL specifically disables that path if the canvas is Desynchronized. > > To do so this CL adds some infrastructural elements to be able to access > > to the desynchronization setting inside getImage. > > > > This issue is only happening in a very specific corner case, which > > proves hard to be tested. This code will be deleted once we enable > > the new canvas api - so this is a temporary fix. > > > > Bug: 1112060 > > Change-Id: I60b90f716332b3969c82dfef3431e4cbd66e6500 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541063 > > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829679} > > TBR=fserb@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org > > Change-Id: I35417b2a319a610b7aec7123112db153cff3a806 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112060 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552924 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Mingjing Zhang <mjzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829801} TBR=fserb@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org,mjzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112060, 1151440 Change-Id: Ic2dae93db31fd8d6ae107db21373468b3ae7cfe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553699Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#831120}
-
Megan Jablonski authored
Bug: 1140050, 1140011, 1140010 Change-Id: I92672d4d15822c259f0614cd3521910fd18bc16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559210Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#831119}
-
rbpotter authored
Change-Id: I6e07592c64d8e936e2289b87caf79ee4e8067fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558951 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#831118}
-
rbpotter authored
preprocess_grit takes the same path as preprocess="true" for a grd file entry. This includes inlining <include>s, which is no longer supported (see styleguide at [1]). Add a new preprocess_if_expr rule, which is copied from preprocess_grit, with the following modifications: (1) Runs only the preprocessing of <if expr>s ("Conditional Elements") and not the rest of the preprocess="true" HTML inlining path (2) Depends on fewer pieces of grit, by no longer using the full DoInline method and inlining/simplifying some logic for parsing defines. This new rule shares the same inputs as preprocess_grit. In followup CLs, users of preprocess_grit can be migrated by simply importing the new rule and replacing all usages of preprocess_grit with preprocess_if_expr. Once all usages have been migrated, preprocess_grit will be deleted. [1] https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/web/web.md#Preprocessing Change-Id: Iccb00ea036b336a2ad16cb74e75fbfe0264c751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557262 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Jamie Madill authored
ANGLE does not support D3D11 on ES 3.1, but we maintain it on Win10 in case we need it in the future or as a useful tool for external developers. We also do not support the GL back-end on Windows in a shipping config. The GLES 3.1 tests on NV/Win7 D3D11 were quite flaky, so this CL disables them. Also we remove the GL back-end testing on dEQP NVIDIA Win7 because they were slightly flaky. Win10 testing is unchanged. Bug: angleproject:5391 Change-Id: I278ef42993e1b945ca7b79850a99dcbdaa474e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561021 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#831116}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Change-Id: Ic54f6e6e3935ec0e562da95eb76fd2d49c1b7b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560808Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#831115}
-
Bailey Berro authored
This change adds support for a GetRoutineUpdateParams to FakeCrosHealthdService. This enables te verification of the parameters passed to GetRoutineUpdate from unittests. Bug: 1128204 Change-Id: Iba54a416272b59c34ce5356a35736ac26f312681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558764 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#831114}
-
Yashar Dabiran authored
Bug: 1152163 Change-Id: Ie1cb98b837b11646c76ee33298ce75d2b258f216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561219 Commit-Queue: Yashar Dabiran <yashard@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#831113}
-
Peter Kotwicz authored
This CL removes RecyclerView#setHasFixedSize() call in order to make InvalidSetHasFixedSizeDetector lint check https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/recyclerview/recyclerview-lint/src/main/java/androidx/recyclerview/lint/InvalidSetHasFixedSizeDetector.kt pass. The lint check was introduced in RecyclerView version 1.2.0 This purpose of this CL is to prepare for rolling the Chromium RecyclerView dependency to version 1.2.0 BUG=1064277 Change-Id: Ife3d2d688b97826749c2a640b789374e4ed5649e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559556Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831112}
-
Geoff Lang authored
Android API 29 is required to test YUV AHardwareBuffer formats. Bug: angleproject:4852 Change-Id: I7a9da29964119a8ffc99d2773b6a35042f51c9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560802Reviewed-by:
-
Anupam Snigdha authored
When caret is moved by line,|SelectionModifier::PreviousLinePosition| and |SelectionModifier::NextLinePosition| both return the positions that could be crossing editing boundaries as there is no editability check in those APIs. In this patch we are matching other browsers in caret movement when user presses up/down arrow keys to navigate across editable boundaries to next/previous line and position the caret inside an editable region so it is rendered properly. Test: web_tests/editing/selection/select-line-up-down.html Bug: 964504 Change-Id: I596e006f4dcc42db3b74d0f2ed577f8e0b27f96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556007 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831110}
-
Ian Kilpatrick authored
As above. This patch uses the ComputeInlineSizeForFragment within ComputeAssignableTableInlineSize. This has the effect of correctly computing the "stretched" inline-size when the table is a grid-item. Bug: 958381 Change-Id: Id8d684fb70e9f9d5fcba8ac0c541b709bc9d9420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557228 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#831109}
-
Philipp Hancke authored
when used together with rtcp-mux Change-Id: I87e07d8dc74d58e69463a3a24a95c7b291b21804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546684 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#831108}
-
James Vecore authored
Due to some subtle C++ rules, BluetoothProfileManagerClient::Options' role field was not being initialized to the default value. This ended up working correctly most of the time by chance, but we have see the role of CLIENT go over d-bus when there is no reference to ever setting in the code. See this article for the subtle details: https://abseil.io/tips/146 Specifically section "A Digression Discerning Defaulted Default Constructor Declarations". Because the ctor was defined in the .cc file it is considered a "user-defined" ctor (even though it is defaulted) and thus scalar members are not explicitly initialized. Bug: b:173832484 Change-Id: Iaf518d903f219128e5832b2a793ce092b02733ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561261 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#831107}
-
Yann Dago authored
Bug: 1128264 Change-Id: I841de5c4aa05b1010b276c937f39f8337d6856db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560994 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#831106}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74900845. With Chromium commits locally applied on WPT: 19c42992 "Add a WPT test to verify the mouse click count in infrastructure/" bcff0ea8 "[CLS] Don't count layout shifts due to content-visibility:auto unskipping" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing npm@chromium.org: external/wpt/element-timing NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ifb268ca923c2bde606f2d7fa217dbb9b7cccf60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561218Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831105}
-
Moe Ahmadi authored
Hiding the placeholder via CSS does not play nicely with "find in page" Fixed: 1130457 Change-Id: Ia46f0fe9d62cf9f714abe6c340e334a1c768ae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555882 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#831104}
-
Lan Wei authored
Use testdriver Action API to simulate key actions in css/selectors/focus-visible-001.html. Bug: 1145677 Change-Id: I5f39a03b41624e2a12c523dc9b1a0a509925621a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546602Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#831103}
-
Yann Dago authored
Bug: 1128264 Change-Id: Ibce9e5bc6cb86a88a6b5b1ce8365494e4d6d4f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561258 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
-
