GitLab

Popover now needs a sourceView or sourceRect.

Bug: 1023619
Change-Id: Ifcc65cf83c9afb26080c9baeb22dd9030b06ec9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036065
Commit-Queue: David Jean <djean@chromium.org>
Auto-Submit: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738501}

This should prevent flakiness even further once asynchronous source
mapping lands.

R=petermarshall@chromium.org

Bug: chromium:1032016
Change-Id: I65797584b8ab539d61421e06928cb4b6780823ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037991
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738500}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22c450dfeb2..0335e6749943

git log e22c450dfeb2..0335e6749943 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 szuend@chromium.org Prepare DebuggerPlugin for source map asyncification

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0335e6749943

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ia9bd06fdd8a63f6d92616fdc6842bc67eebe7b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038124Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738499}

Functions which take an SmbUrl should also return an SmbUrl instead of
std::string. This allows strong typing to be maintained, and helps avoid
conversions between SmbUrl and std::string.

Bug: 939235
Change-Id: If52ccc58d3bff62902179c1c9999fbf8bff64964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035827Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738498}

This reverts commit a98ef426.

Reason for revert: causes failures in ChromeVoxBackgroundTest,
see crbug.com/1049012.

Bug: 1049012

Original change's description:
> Change the anonymous block in LayoutMenuList to a shadow element
> 
> Enable rendering of the shadow element of <select>, and remove anonymous
> block in LayoutMenuList.
> 
> * HTMLOptionElement::ParseAttribute():
>   Update the shadow element content on option[label] change.
> 
> * HTMLSelectElement::UpdateFromElement():
>   Fold LayoutMenuList::UpdateFromElement() into here. If option_style_
>   and InnerElemnet's style are inconsistent, update InnerElement's
>   style.
> 
> * HTMLSelectElement::UpdateMenuListLabel()
>   Move the code in LayoutMenuList::UpdateInnerStyle() here.
>   Also, kick TextChanged ax notification which LayoutText::ForceSetText
>   did.
> 
> * MenuListInnerElement::CustomStyleForLayoutObject():
>   Set "display: block"
>   Add custom style which the anonymous block used.
> 
> * layout_menu_list.{h,cc}:
>   Remove a lot of code.
> 
> * ax_layout_object_test.cc:
>   Add tests to check if AXLayoutObject::StringValue() respects to
>   text-transform and -webkit-text-security.
> 
> * web_tests/accessibility/notification-listeners.html:
>   Remove TextChanged notification expectation. After this CL, <select>
>   won't notify TextChanged in this test scenario. The text is changed
>   before creating LayoutObject and AXLayoutObject.
> 
> 
> 
> Bug: 1040828
> Change-Id: Ia0c19f0897ab2d1461e457c83adceda2c0739f9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024250
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738416}

TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org

Change-Id: I804ec3898b907ff79531dbc6390c99e24b66965f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036187
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738497}

This reverts commit 882f5709.

Reason for revert: dependency in order to revert
crrev.com/c/2024250.

Bug: 1049012

Original change's description:
> Remove GetText(), ClientPaddingLeft(), and ClientPaddingRight() of LayoutMenuList
> 
> Fold them into their callsites.
> This CL has no behavior changes.
> 
> Bug: 1040828
> Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738490}

TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org

Change-Id: I76d98f6f0ce474ca2cd64b94f8d3b36cb0878b71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037992Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738496}

https://skia.googlesource.com/skia.git/+log/6c9b1fd6663e..bc3307c395e2

git log 6c9b1fd6663e..bc3307c395e2 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 csmartdalton@google.com Don't do clear or round rect optimizations when a rect has stencil

Created with:
  gclient setdep -r src/third_party/skia@bc3307c395e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: scroggo@google.com
Change-Id: Ic0d40bfb754ed34ca6717680d9b172fbbc205504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038177Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738495}

With this CL, the manual filling UI listens to the bottom sheet
controller and suppresses any keyboard accessory or accessory sheet as
soon as a BottomSheet of any kind is opened.

This solution has the following constraints:
* _Any_ bottomsheet will suppress the filling UI, always.
* If the bottomsheet is closed, the filling UI will require another
  interaction (an opened keyboard, focusing a field, rotation) to reopen
  the filling UI.
* The autofill dropdown is not affected in any way. Only if the keyboard
  accessory V2 is active (i.e. flag \#autofill-keyboard-accessory-view),
  the popup will be replaced by chips in the suppressed accessory.
  Launch of V2 has an uncertain target as of this writing.

Bug: 1033849
Change-Id: I55fffa1bb7dd62a08af95705085c4884d38d9877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036103
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738494}

Hit-testing should never enter a child that establishes a self-painting
layer.

Also added a couple of local variables to make it slightly easier to
read.

Change-Id: I2854cb1b677f8eb164befe1577e7de2740735538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036104Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738493}

Change-Id: I4c97da02e2106e2214e4a978f4c5a037365ebee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035551Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738492}

Add a test that tab-index key focus works correctly (only the elements
inside the delete-confirm-dialog are tab-indexable). Elements outside
of the delete-confirm-dialog should not be tab-indexable.

Bug: 803259
Change-Id: I70f22dbd25220589157ade74016a7939aef03509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035476
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738491}

Fold them into their callsites.
This CL has no behavior changes.

Bug: 1040828
Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738490}

Two mixed content (http+https) desktop PWA tests have been ported
to no longer have any dependency on Extensions code, so they are
ready to run with BMO, when WebAppLaunchManager is complete.

See https://chromium-review.googlesource.com/c/chromium/src/+/2035819/
for remaining work.

Bug: 1026080
Change-Id: Ibcd690e44cc1949d352e16a11af5084a0abd2127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038195Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738489}

This patch gets rid of unused functions in ElementInnerText for improving code
health.

Change-Id: I61692011375770b2c263c9a82499d7d02c340ca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037304
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738488}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be70f94fa57b..166b478fa620


Created with:
  gclient setdep -r src-internal@166b478fa620

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ieef89875ec85eac093f47cbbd5852694a84e4dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038119Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738487}

R=aboxhall,dmazzoni

Change-Id: I82c4687fd9923bf2669248419c7ed8616f1a7406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010227
Commit-Queue: Chris Hall <chrishall@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738486}

Bug: 924929
Change-Id: I29afe6b8e36c1101d81a3f2c02171662907f4057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035482Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738485}

There's a CSSParserContext ctor that allows implicit conversion from a
|const CSSParserContext*| to |const CSSParserContext&|, where the latter
is actually a new object constructed on stack with different member
values.

So this patch stops the conversion.

Change-Id: Ibf98e8b0012122d2fc42e3fc4b4b38e8fe9b797a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037854Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738484}

This should have been included in https://crrev.com/c/2030951 already.
I missed that both "android_webview" and "ios" were missing.
The set of "android", "android_webview" and "ios" hopefully covers all
mobile platforms.

R=bcwhite@chromium.org

Bug: 1040061, 1040030
Change-Id: I8aa87b15c849be9d62c88df0a9f7eb7615eb6ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036056Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738483}

https://skia.googlesource.com/skia.git/+log/25cf469a112f..6c9b1fd6663e

git log 25cf469a112f..6c9b1fd6663e --date=short --first-parent --format='%ad %ae %s'
2020-02-05 jvanverth@google.com Update Viewer docs for Android and iOS.
2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 41a7302e9c62..8e8e1d0dd729 (4 commits)
2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 aa6dd50de0c5..58fc8b11cf3a (7 commits)
2020-02-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-04 egdaniel@google.com Make sure we invalidate mapped memory from vk transfer buffers before reading.
2020-02-04 tdenniston@google.com Revert "Initial checkin of GM verifier framework"
2020-02-04 tdenniston@google.com Initial checkin of GM verifier framework
2020-02-04 jvanverth@google.com Update iOS build instructions.

Created with:
  gclient setdep -r src/third_party/skia@6c9b1fd6663e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: scroggo@google.com
Change-Id: Ieeaf17a5514f142e6a145bc025f9fba4512d2265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738482}

https://chromium.googlesource.com/angle/angle.git/+log/d8c4b5fb80d4..f764fc02e94c

git log d8c4b5fb80d4..f764fc02e94c --date=short --first-parent --format='%ad %ae %s'
2020-02-05 syoussefi@chromium.org Fix varying linking by location
2020-02-04 lexa.knyazev@gmail.com Implement RGTC (BC4, BC5) compressed texture formats
2020-02-04 cnorthrop@google.com Capture/Replay: Track compressed texture data
2020-02-04 jmadill@chromium.org Vulkan: Count active renderpasses in overlay.

Created with:
  gclient setdep -r src/third_party/angle@f764fc02e94c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9bfe5267a5088f96823a8528585e690647277a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738481}

Add Polymer 3 closure compiler targets for the files in settings_page/.

Bug: 1026426
Change-Id: Ia672c0edbf05ef8779dcde296bcd704ff4c7b427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036524
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738480}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6a299ca2..30fcb3eb

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9d4065de8a55f0931d8758928f0ed974f00ab0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038372Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738479}

https://pdfium.googlesource.com/pdfium.git/+log/e06acb7de1b8..d28c5fe2b8b8

git log e06acb7de1b8..d28c5fe2b8b8 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 thestig@chromium.org Roll third_party/freetype/src/ e5038be70..4a19a53d5 (1 commit)
2020-02-04 tsepez@chromium.org Remove stray CFXJSE_Value forward declaration from ijs_runtime.h
2020-02-04 tsepez@chromium.org Add dumpTree() testing helper JS function.

Created with:
  gclient setdep -r src/third_party/pdfium@d28c5fe2b8b8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I3fdc6a748845ab58cedb8bb39058e6d9684ed1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738478}

Results from RecentModel are cached for 10 seconds.
However, if the requested file type is different from previous one, the
cache should be invalidated and not reused.

Bug: 1040049
Test: Run browser_tests
Change-Id: I0e9a90d6faeb612531ebdd64ff5b152bd9989755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035509
Auto-Submit: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738477}

Bug: 1026426
Change-Id: Ib0f10d3267899069c53794e4ae42db23b4f8b98d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037026
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738476}

https://chromium.googlesource.com/catapult.git/+log/0165beed0829..f72ef2db9462

git log 0165beed0829..f72ef2db9462 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 dberris@chromium.org E-Divisive: Reduce permutation testing iterations
2020-02-05 dberris@chromium.org Raise ceiling for upload-processing

Created with:
  gclient setdep -r src/third_party/catapult@f72ef2db9462

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: rmhasan@google.com
Change-Id: I9c1a4398f2fd0d2e81b83bde5d661e3d23684344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038116Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738475}

This CL adds shared-worker-import-referrer.html for web-platform-test.

Bug: 824646
Change-Id: I3031e34f1181303f7a0455974b3c614340d939f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037275
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738474}

After crrev.com/c/2028408, keyboard input handling has been broken in
Ozone/X11 desktop builds (CrOS on Linux is not affected), when IBus IME
is setup, among other cases which depend on KeyEvents::Properties being
properly set. This fixes it as well as adds a unit test to prevent
future similar regressions.

Bug: 1047999
Change-Id: If67b78eb795b8d5efabf987a25ebf68de733948e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034810
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738473}

Still used in EasyUnlockAuthAttempt

Fixed: 927498
Change-Id: Ice2c8c791d808349b508b6af79e684ca203644d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035972Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738472}

This getter will be needed for WebAppMigrationManager to convert
downloaded icon sizes info.

Bug: 1020037
Change-Id: I6d3fcb2e878671f9af455c3555aa4cf99053ea85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037302Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738471}

We're planning to introduce a non-copyable request body to
blink::ResourceRequest and blink::WebURLRequest in order to support
streaming upload.

WebURLLoader::LoadAsynchronously and WebURLLoader::LoadSynchronously
take a const reference to WebURLRequest, but we'll need to modify the
request when a non-copyable request body is introduced.

Here we stop using WebURLRequest and pass
std::unique_ptr<network::ResourceRequest> instead. This is better than
using a mutable reference to WebURLRequest because it is hard to
distinguish whether an argument is const reference or mutable reference.
Moreover, WebURLRequest is planned to be deprecated and we are planning
to use network::ResourceRequest or network::mojom::URLRequest for the
"request" struct for IPC. This change is also a step of that larger
refactoring effort.

third_party/blink/PRESUBMIT.py is updated to reflect the discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/ntSzerId4gw .

Bug: 860403, 688906
Change-Id: Ieb42432e30495d03f8cfb924a41a1327070c7aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032688Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738470}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I8db12eacd2838ebf00b3094d744a0fde4dc28bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038371Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738469}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cecc4d627631..be70f94fa57b


Created with:
  gclient setdep -r src-internal@be70f94fa57b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024586,chromium:1048438
Tbr: jbudorick@google.com
Change-Id: I19d45e54ef9d7a1846cac21a4b41afcc6eb316ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038117Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738468}

Ozone/X11 unit tests are kept separately so that non-X11 tests don't depend on
X server to be performed. Having x11 event translation tests in
events_unittests currently depends on GN config ozone_platform_x11 being set
(more precisely after crrev.com/c/1895399), which breaks the aforementioned
rule, when running unit tests within a ssh session, where DISPLAY env var is
not set, among other scenarios.

This fixes such regression by keeping such tests in events_unittests binary
only for Aura/X11, while for ozone they are added to ozone_x11_unittests
instead. This must be cleaned up once X11 is fully migrated to Ozone/X11, by
moving x11 event translation impl and its tests into ozone/platform/x11 dir.

R=spang@chromium.org

        --gtest_filter=XEventTranslationTest.KeyEventDomKeyExtraction

Bug: 1029365
Test: DISPLAY= ./out/linux_ozone_rel/events_unittests \
Change-Id: I053d8dc9e2a1a26a844479c0fb503351053b12a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036995
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738467}

This CL checks if an ARC app is "sticky" and classifies it as a system
installed app if it is.

Fixed: 1010821, 1048874
Change-Id: I1c6fdf752a0437cf012a0051c01c4e1600f0353e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038191
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738466}

map() returns a list in Python 2. Python 3 returns an iterator.
Wrapping in a list() results in the same behaviour on both.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 283, in <module>
    main()
  File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 262, in main
    cpp_file.write(cpp_template.render(template_context))
  File "C:\Google\chromium\src\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 129, in <module>
    void {{probe.name}}Impl({{ params_list(probe) }}) {
  File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 579, in _invoke
    rv = self._func(*arguments)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 91, in <module>
    {%- for param in probe.params %}
  File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 435, in __init__
    self._after = self._safe_next()
  File "C:\Google\chromium\src\third_party\jinja2\runtime.py", line 455, in _safe_next
    return next(self._iterator)
  File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 148, in __init__
    self.default_value = parts[1] if len(parts) != 1 else None
TypeError: object of type 'map' has no len()

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 283, in <module>
    main()
  File "../../third_party/blink/renderer/build/scripts/make_instrumenting_probes.py", line 262, in main
    cpp_file.write(cpp_template.render(template_context))
  File "C:\Google\chromium\src\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\templates\instrumenting_probes_impl.cc.tmpl", line 130, in <module>
    {{sink_class}}* probe_sink = To{{sink_class}}({{probe.params[0].name}});
  File "C:\Google\chromium\src\third_party\jinja2\environment.py", line 430, in getattr
    return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: map object has no element 0

Bug: 941669
Change-Id: Ie584b13c8b3e54ee9f06faffd57d93917c88ccfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033510
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#738465}

The UI tweak is based on the mock [1] and spec [2].

[1] https://docs.google.com/presentation/d/1BrYiEWolfwVwX1Z-4W7c1BgJNjnn7DZZ5lJTs-mFcxI/edit?ts=5e0ebd8b#slide=id.g7c663e3687_0_12
[2] https://drive.google.com/file/d/1323cL3Bv-H-R1L_u50wNezGhFWTbP5rE/view

Bug: 1016195
Change-Id: Ic6f4094e567825dbd6223e271483abaa748bb284
Test: manually with crostini-username flag on
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032760
Commit-Queue: Jason Lin <lxj@google.com>
Auto-Submit: Jason Lin <lxj@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738464}

This reverts commit 7eefdcbf.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 738454 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdlZWZkY2JmNjNjZDNjOGMzYmNhZTZkNmQ4OTQ2ODM4OWFmOGRiNWMM

Sample Failed Build: https://ci.chromium.org/b/8889318408391750976

Sample Failed Step: compile

Original change's description:
> Grit: Avoid rebuilding all pak files when ID ranges do not change
> 
> We are now generating ID ranges for .grd files as part of the build. The
> tool was already smart enough to leave padding for each range so that
> the ranges would not change for every single resource added / removed.
> However, since it was unconditinoally writing the resource_ids file,
> ninja was considering all grit targets as stale even when ID ranges did
> not change.
> 
> We now write the file only when it is changing so that ninja will not
> consider grit targets stale in the did-not-change case.
> 
> Bug: 979886
> Change-Id: Ib38620e1be097b31ec876be9b07172a7ff945c07
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036528
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738454}


Change-Id: I5e0e2bc30ae2a10d5fafb74aef9575c6991573c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038068
Cr-Commit-Position: refs/heads/master@{#738463}

Unsharing a crostini folder can fail if a user has a file
open in some application.  When this happens, we will show
a dialog to the user to inform them that unsharing has
failed and allow them to retry the unsharing presumably
after they have closed associated files.

Bug: 920416
Change-Id: I303200f7e0e40fe8c7e1382bf19878d7ed2b31fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037276Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738462}