- 20 Nov, 2020 40 commits
-
-
Liquan (Max) Gu authored
WebLayer needs to bind payments::mojom::PaymentRequest to allow for the blink payment_request to connect with WebLayerPaymentRequestFactory. This CL adds the binding. Bug: 1150564 Change-Id: I7dc093036dab2abae4306e5598f4f153c72d1d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546974 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829819}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605862616-5037a5c6c628a5354743fcf375cbc392b8b36b5b.profdata to chrome-win64-master-1605884021-38c8ae5c2e6706d9e606dfe2bcddc4d1100361a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie55fa2b99fcf02a717a9e992930aed52ff9b226a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829818}
-
Dale Curtis authored
Stop() may be called from both the render and media threads. We can use a simple std::atomic here since fulfilling a read after Stop() is called is harmless (lifetime of all involved is guaranteed until all activity stops). R=cassew Fixed: 1151300 Change-Id: I3c5058ecf47b9b8faa3b546f363632e1f6099793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551667 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829817}
-
Curt Clemens authored
After the third element in the share target list, clicking would not select properly. The problem was the transparent ripple animation being higher in the z-order and capturing the click events. The share target list wasn't scrolling because its height wasn't fixed. Setting its flexbox alignment to stretch allows it to fill its parent div without overflowing. A number of small adjustments to layout included, mostly to bring margins closer to spec. The page template title and subtitle font sizes and line heights have been adjusted. Some minor changes to colors. A white background has been added to the share target list items so that the ripple animation doesn't show through. The gradient at the bottom of the discovery page is simplified. Hard-coded colors have been replaced with variables in several places. Fix: 1151374 Change-Id: Ie405cd046559c3b7c82bfb86a226c77aba2283df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551590Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#829816}
-
Andrew Grieve authored
This reverts commit 6134a131. Reason for reland: Underlying issue fixed in cbdf4c2e TBR=agrieve # Reland with no changes. Bug: 1120190 Bug: 1145570 Change-Id: I64a8d982453f7deae45b24ec079dae8346303592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528622Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829815}
-
Ahmed Fakhry authored
Let the VideoFileHandler detect a low disk space condition, and notify the CaptureModeController with this. We then end the video recording and tell the user about the reason why recording ended. BUG=1142994 TEST=Manually, Added a unittest. Change-Id: I5e007693c90424491f8300d61fb3d424658c2b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551938Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829814}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605268075-3755a079b65652d38832c53840c8030bab959806.profdata to chrome-mac-master-1605895128-00d55e6bb356ebbc13be21f27095ad3409f51b0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3acba67eeb88d7575fa2bc02b3abe9f73c247f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551516Reviewed-by:
-
Sophey Dong authored
Change-Id: I2631f53a7c49c0fa7f2dd4c747c50fa205193e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548403Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829812}
-
Nate Chapin authored
All former Supplements of WorkerNavigator have been moved to NavigatorBase. Bug: 1147612 Change-Id: I854e0392fe411f1ca2f5278cb6b1c63ee48faf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552745 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829811}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/196fb8cb97ad..108b4ee97ef9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com,waffles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tbansal@google.com,waffles@google.com Change-Id: I7e029926ba25e81f0acd0ae6e0aa91de35ffdec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552670Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829810}
-
Dale Curtis authored
GpuMemoryBuffer frames may be passed to the hardware encoders without conversion to a software frame. This enables more performant encoding on low end devices. This defers encoder configuration until the first frame is available so that we can properly configure the VideoPixelFormat and StorageType for ChromeOS zero copy mode. R=eugene Bug: 1150069 Test: https://storage.googleapis.com/dalecurtis/wc-camera-test.html Change-Id: I18799d536c8e8e53b7d61233c699dd374b3de9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545031 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829809}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f47910c9ce3..8f8e2dc7d50f 2020-11-20 fmayer@google.com Merge "Add unit test for ProfilerMemoryGuardrails." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ida2f543772ad01cbe58854a3cde31aac36134966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552805Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I620c8093f9d161081e1f7abcce1fd4a939fe4c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552674Reviewed-by:
-
Carlos Knippschild authored
Note that most of contents from the single merged commit had already been addes as part of 402ea42d. Import commit 77405b1370937094ae69af4933f3e06109dd53ba Author: Feed Team <no-reply@google.com> AuthorDate: Fri Nov 13 12:15:07 2020 -0800 Commit: Copybara-Service <copybara-worker@google.com> CommitDate: Fri Nov 13 12:15:34 2020 -0800 Acknowledgement notice card bit in Feed V1 feed query. PiperOrigin-RevId: 342313135 Change-Id: I8757791437ee872f024ee4f29f2e573a483f3d7d Change-Id: I83d2cd64e611a3e9b2934e2417cf3bba7f3f3605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552578 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#829806}
-
David Van Cleve authored
We've rolled out the new default referrer policy of strict-origin-when-cross-origin to 100% and are in the process of cleaning up the corresponding configuration. This change removes the base::Feature that allowed switching the referrer policy to the new default, switching the Blink method returning the default net::ReferrerPolicy object to deterministically return the new default. It leaves the accessor method (blink::GetDefaultNetReferrerPolicy) in place, since the method helps let callsites clarify whether they care about referring to "the default, whatever it is" (in which case they can call blink::GetDefaultNetReferrerPolicy) or whether they want to refer to the specific policy that just happens to be the default (in which case they can use the actual policy value). Bug: 1150018 Change-Id: I9f246a9cc35877e009f1e79bd822266db620fcb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545444 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829805}
-
Steven Bingler authored
This CL adds several new UMA histograms for cookies: What port a cookie is set by, in local/remote host flavors. What port a cookie is sent to, in local/remote host flavors. When a cookie is sent to the same port that set it, in local/remote host flavors. How often `Domain` is set on a cookie. Bug: 1141135 Change-Id: I2640070f708edd3c0d744e0801e6b5e9e8e76ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550295Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#829804}
-
Nate Fischer authored
No change to logic, only updates OWNERS. I'm adding myself to //android_webview/ OWNERS and removing the remaining per-file rules explicitly listing my LDAP. I'm leaving my LDAP in finer-grained OWNERS files to indicate I have particular familiarity with that code. Test: N/A Change-Id: If0e02470a8124ce93bbb2b198d88e5104a884334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548764 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829803}
-
Christopher Cameron authored
When an AVCaptureOutput produces a CMSampleBuffer with a CVPixelBuffer, that CVPixelBuffer will usually, but not always, have an IOSurface. One way to trigger this is to start a call in Chrome, and then open PhotoBooth. This will reliably cause Chrome's capture to start producing CVPixelBuffers with no IOSurfaces. When the input CVPixelBuffer to SampleBufferTransformer::Transform is of the correct format, it should only be returned directly if it also has an underlying IOSurface. Add CHECKs (also known as "comments that explode when not true") to ensure this before passing the IOSurface on to the receiver. Bug: 1148964 Change-Id: I973cf5244c18ce9cd75cd9694d3ddf997156a1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551665 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#829802}
-
Mingjing Zhang authored
This reverts commit edce90d5. Reason for revert: crbug.com/1151440 Pixel_CanvasLowLatency2DImageData test consistently fails on Android FYI Release builders, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%205%29/b8863094711783933776 Original change's description: > Not disable acceleration in getImage if its Desynchronized > > This is a temporary fix for this issue, that will totally be fixed > after we land the new 2d canvas api (that will completely remove the > path of code causing this regression in base_rendering_context_2d.cc: > if (!RuntimeEnabledFeatures::NewCanvas2DAPIEnabled()) { > // GetImagedata is faster in Unaccelerated canvases > // Do not disaccelerate if Desync2d Canvas on android. > // Issue 1112060: putImageData() does not work for desynchronized 2D canvas > // on Android > if (IsAccelerated()) { > DisableAcceleration(); > base::UmaHistogramEnumeration("Blink.Canvas.GPUFallbackToCPU", > GPUFallbackToCPUScenario::kGetImageData); > } > } > > This CL specifically disables that path if the canvas is Desynchronized. > To do so this CL adds some infrastructural elements to be able to access > to the desynchronization setting inside getImage. > > This issue is only happening in a very specific corner case, which > proves hard to be tested. This code will be deleted once we enable > the new canvas api - so this is a temporary fix. > > Bug: 1112060 > Change-Id: I60b90f716332b3969c82dfef3431e4cbd66e6500 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541063 > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829679} TBR=fserb@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org Change-Id: I35417b2a319a610b7aec7123112db153cff3a806 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552924 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829801}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/627732c40839..4c13659a2a39 2020-11-20 kainino@chromium.org Fix includes and BUILD.gn deps for gn check 2020-11-20 dneto@google.com Avoid floating point equality checks in tests 2020-11-20 sarahmashay@google.com [validation] add implementation and unit test for v-0031 2020-11-20 bclayton@google.com reader/wsgl: Improve error message for missing 'var' 2020-11-20 bclayton@google.com writer/hlsl: Emit texture builtin functions 2020-11-20 bclayton@google.com ast: Fix vector constructors in ValidCases() 2020-11-20 bclayton@google.com writer: Simplify floats when printed 2020-11-20 bclayton@google.com writer/hlsl: Clean up matrix type emission 2020-11-19 dsinclair@chromium.org [wgsl-writer] Emit access control type. 2020-11-19 dsinclair@chromium.org [wgsl-reader] Add support for read only storage buffers. 2020-11-19 dsinclair@chromium.org [hlsl-writer] Use `mul` method where required. 2020-11-19 bclayton@google.com writer/hlsl: Clean up vector type emission 2020-11-19 dneto@google.com spirv-reader: Rename a test class 2020-11-19 dneto@google.com spirv-reader: Convert handle types 2020-11-19 bclayton@google.com reader/wgsl: Improve errors for statements outside functions 2020-11-19 bclayton@google.com writer/spriv: Move IntrinsicTextureTest to its own file 2020-11-19 sarahmashay@google.com [validation] v-0015: runtime arrays cannot be declared in a function body. 2020-11-18 sarahmashay@google.com [validation] impl v-0015: runtime array may only appear last 2020-11-18 bclayton@google.com Implement textureSample builtins 2020-11-18 bclayton@google.com Move the ast node ownership from Context to Module If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I7d77b96492c3307a21628b0cd17822a183be2df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552677Reviewed-by:
-
Robert Sesek authored
This is a reland of d5f35679 > mojo: Remove ScopedProcessHandle in favor of base::Process. > > This adds a process_stubs.cc implementation for iOS and NaCl > to have an implementation of process.h. > > Bug: 1008512 > Change-Id: I44a478a790bfe8c3aabc17298a2ddb99efb2bf5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517924 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#826494} Bug: 1008512 Change-Id: Idea0752dc012c664b4920d308df0d81917e96ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549462 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#829799}
-
Christopher Cameron authored
Change this function to take an SkPixmap rather than a raw pointer. This allows us to remove a lot of the pointer math and complexity in the function. This function still does an extra unneeded copy, by calling ImageData::ImageDataInCanvasColorSettings to convert to the canvas color space. This should be done on the fly, and will be addressed in a follow-on patch. TBR=yiyix Bug: 1150969 Change-Id: Icd9a2a966ac3a94b75cc20974811946b2388f776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552243Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#829798}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibb759918d772d11e30a4114afdbd5658627f3d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552632Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829797}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605754194-4e76916f5340c97913d651fe425b3570e2df369d.profdata to chrome-win32-master-1605873573-36e181f5df5da0c9aa7b43458275355d6ec5a576.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I900c92a58f557bbebf758389053c8017d3b1a89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552565Reviewed-by:
-
Sara Tang authored
Renamed wall_clock_time_in_us to wall_clock_duration_in_us. Bug: v8:11109 Change-Id: Ia8ccdf6eb2df7f1c2c89126444bca5fc879b1c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530193Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/876a780b5210..ab436aebc566 2020-11-20 tsepez@chromium.org CFXJSE_Value removal CL, part 7. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie17269560eb88c67593d51a7d764edd3c4031327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552802Reviewed-by:
-
Martin Kreichgauer authored
This is a reland of ee2f8113 Changes: - renamed virtualAuthenticatorTest to virtualAuthenticatorPromiseTest - made virtualAuthenticatorPromise test return |testCb()| which fixes the race that caused the original change to be reverted. Original change's description: > webauthn: move create credential tests for residentKey/credProps to WPT > > Bug: 1117630 > Change-Id: I2fa4d73b7a4cfe5e7f19fd835cb32e1bb4926d2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508878 > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#825930} Bug: 1117630 Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel Change-Id: I08cb469ab937a704c23da30b7120374d31ecbff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548299 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829793}
-
Ryan Sturm authored
JS is a key factor in understanding when the page loads, so clietns who do not allow JS to run (overall or on the DSE) should not get prefetch behavior at all. Bug: 1151134 Change-Id: I51005f5453d9bb14bd54fe0885c446b0e97581e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551625 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#829792}
-
Patrick Monette authored
This class submits a USER_VISIBLE vote when a frame is visible. This class will first be used in in https://chromium-review.googlesource.com/c/chromium/src/+/2538310. Bug: 971272 Change-Id: I4462efab6c105e2ecd7f4cfbf479f3627ac9aa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537143 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#829791}
-
rajendrant authored
The LitePages robots rules fetcher sends the origin in "u" request parameter. Instead the full robots.txt URL should be sent in that parameter. Bug: 1147565 Change-Id: I0df86b28d1c4a8ee7d9053b2040f3941d894b9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552577Reviewed-by:
-
Ryan Sturm authored
This checks that the search prefetch can only be served to main frame navigations. Bug: 1148512 Change-Id: Idd26f0fc3b81bf9114990e60f53eb532dbeb4a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551746 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
David Van Cleve authored
This comment-only change removes a duplicated 'ERR_' from a comment in URLLoaderCompletionStatus. R=mmenke Bug: None Change-Id: Ibd2a315ddf9a0a08a3c4ea99ce134c23a0435ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552573 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829788}
-
Rob Buis authored
Only accept operators with inline children since ::first-letter selector could add a non-inline child, in that case fall back to block layout algorithm. Bug: 1146872 Change-Id: I848ab24089a98a26f881c4f2c3f396932a62506a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539966Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#829787}
-
Ian Kilpatrick authored
This reverts commit 8ebfa3e7. Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=1150774 This has subsequently been fixed by moving the layout overflow calculations into NG, however if we need to disable this new pass I'd prefer to not break any content in M89/M88. Original change's description: > [LayoutNG] Avoid computing overflow for positioned elements twice > > In LayoutNG the overflow of positioned elements is already computed in > LayoutNGBlockFlowMixin<Base>::AddLayoutOverflowFromChildren(), > so we don't need to compute it again in the legacy code. > > Specifically positioned elements are already considered in > NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). > > BUG=1098231 > > Change-Id: I8e527617ae31ef564eeea57eb823ca93465cf62b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391256 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809272} TBR=rego@igalia.com,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098231, 1150774 Change-Id: I7d1345cdc12c63dd122e3daab929b9398702cdfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552296Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829786}
-
adoneria authored
Bug: 1151436 Change-Id: I6e5836927a2367f2220093bda579ee436417bd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552882Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#829785}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8dae1eb937cb..a63f1abf172a 2020-11-20 miu@chromium.org Implement a more-specific AppAgent::IsConnectionAllowed() policy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3a873d3bdf619d8b927cba713b88320060d96b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552823Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/94b2c943..8a682e08 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I087edc79426e22548a7c7d7527591ff255a5d760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552743Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829783}
-
Frank Liberato authored
Due to what appears to be framework bugs, android sometimes calls back on the UI thread when tearing down Dialog-based video overlays. Since they should run on a separate thread, this causes the framework to issue strict mode violations / other bad things. This CL moves overlays to the browser UI thread, so this no longer is a problem. As part of this, it introduces a sync call on the browser UI thread when the Dialog is lost after we have provided a Surface to the client, since we must (by Android API) quit using the Surface once surfaceDestroyed is sent by the framework. Bug: 1148995 Change-Id: I96237a7c5852837f2d9cb7f5e57908f267de7b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545773Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Chris Sharp authored
Change-Id: Ic02543fcb182325269bacc00cb79e389471a0215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551489Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829781}
-
Kyle Milka authored
Make 3P app icons larger. Rework the padding for all share sheet items so the tap target takes up the entire height. https://screenshot.googleplex.com/DwKgdDxahoETPCz.png Bug: 1148914 Change-Id: I78524a78aa0350552860404082616cbf3891e228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542728Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829780}
-
