Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Jul, 2018 35 commits
  3. 03 Jul, 2018 5 commits
    • Robbie McElrath's avatar
      Fix downloading pdfs with network service. · a5adc4ec
      Robbie McElrath authored 
      When the network service is enabled, we wouldn't download responses
that had a plugin associated with their mime type. This makes the
PluginResponseInterceptorUrlLoaderThrottle check if the response
is meant to be a download before intercepting it.

Bug: 855539
Change-Id: I8b70abb2a7e24c27b5a6866a0f09c24f59c12e05
Reviewed-on: https://chromium-review.googlesource.com/1119581
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572399}
      a5adc4ec
    • Xiaocheng Hu's avatar
      [LayoutNG] Add scrolled offset when hit testing scrolled content · 555b4daa
      Xiaocheng Hu authored 
      This patch takes scrolled offset into account when hit testing the
children of a scroll container, so that scrolled contents can be hit
tested correctly.

Bug: 855279
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic84b40c06302c457cf32cacaa5e79f419dcc3a2b
Reviewed-on: https://chromium-review.googlesource.com/1125312Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572398}
      555b4daa
    • Manu Cornet's avatar
      Shelf: start new UI with centered items · b38610a1
      Manu Cornet authored 
      * Add flag for the shelf new UI
* When it's on, center some shelf items (apps, pinned apps)
* Minor dimension and opacity tweaks when the flag is on
* Fix some minor typos here and there

Change-Id: I87b7fa819bac0fff77f5007c4a0cee760a630239
Bug: 805612
Reviewed-on: https://chromium-review.googlesource.com/1116540Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarAlex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572397}
      b38610a1
    • Trent Apted's avatar
      MacViews: Always null-check BridgedContentView's textInputClient_ · 9fc16442
      Trent Apted authored 
      When a real IME window is up, AppKit spins a nested runloop that
interacts with the IME window over XPC while we're trying to
invalidate our NSTextInputClient (e.g. because the window has been
deleted). However, this may also cause AppKit to *use* the very
NSTextInputClient that we're trying to invalidate.

Specifically, this seems to happen with phonetic languages such as
Korean and Vietnamese. These use rule-based transforms that do not
commonly pop-up a candidate window. In such cases, a key such as
Enter may simultaneously commit a composition _and_ trigger the omnibox
action, which moves focus away from the omnibox thereby invalidating
the textInputClient_.

-BridgedContentView insertText: was the last hold-out that didn't
have a null check. AttributedSubstringForRangeHelper() and
GetFirstRectForRangeHelper() handle a null client already.

  SystemPreferences -> Keyboard -> Input Sources, then interact with
  the omnibox.

Test: On Mac, add/enable the "2-Set Korean" input method under
Bug: 817097
Change-Id: Ia7d1ebb796b9c98437b563ea405cad785e92ea30
Reviewed-on: https://chromium-review.googlesource.com/1124073Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572396}
      9fc16442
    • Joel Einbinder's avatar
      DevTools: Make targetId optional for Target.getTargetInfo · 33c9d271
      Joel Einbinder authored 
      If the targetId is not specified, the info for the target of the current
session is returned.

DevTools receives a connection to a target, but does not know the
targetId. Certain commands, particularly Target.attachToTarget, take
a targetId. Using Target.attachToTarget will allow DevTools to create
parallel connections to the page for a better Lighthouse experience.

Change-Id: I777350d6fb486c4e5ed6256ebc0bcc1d738d0ab2
Reviewed-on: https://chromium-review.googlesource.com/1096434
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572395}
      33c9d271