GitLab

- Use VKEY_CONTROL instead of VKEY_LCONTROL/VKEY_RCONTROL to be consistent with Windows' behavior.

Windows (and ui/base/keycodes/keyboard_code_conversion_x.cc) never sends a VKEY_[LR]CONTROL event when left/right control is pressed. The VKs are used only as a return value of GetKeyboardState() Windows API.

- Add unit tests for Command+NumPad presses.

Add tests that checks if NumPad1 + Command key presses on an Apple keyboard are treated as VKEY_NUMPAD1 with EF_CONTROL_DOWN.

BUG=None
TEST=manual + unit_tests


Review URL: https://chromiumcodereview.appspot.com/10397003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137621 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new histogram that can be called from JS to record stats on the upcoming destination selector.

BUG=128275
TEST=No user visible change.


Review URL: https://chromiumcodereview.appspot.com/10387162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122687
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10310113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126132


Review URL: https://chromiumcodereview.appspot.com/9985012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137616 0039d316-1c4b-4281-b951-d872f2087c98

Streamline methods of PushClient and its Observer subclass.

Remove sync/protocol/service_constants.h and consolidate use of each
constant in one place.  Remove duplicate constant in cloud print code.

BUG=76764
TEST=
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10398051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125059

TEST=


Review URL: https://chromiumcodereview.appspot.com/10391172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137614 0039d316-1c4b-4281-b951-d872f2087c98

Note: this will appear as a regression to latency tests, but it is actually just a more accurate measurement of the GPU path.


Review URL: https://chromiumcodereview.appspot.com/10378112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137613 0039d316-1c4b-4281-b951-d872f2087c98

Moved gtk-dependent code to files with _gtk suffix that are
excluded when compiling without GTK. Also some minor cleanups in remoting.gyp.

BUG=114211


Review URL: https://chromiumcodereview.appspot.com/10386181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10398054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137609 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org
R=jhawkins@chromium.org

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10377180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137606 0039d316-1c4b-4281-b951-d872f2087c98

The command-line flag to turn on the HUD is --ash-touch-hud. It can also be
turned on from about:flags

BUG=none
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137549

Review URL: https://chromiumcodereview.appspot.com/10386178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137605 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to set up a PPAPI HostDispatcher in Chrome code, so we can
work on the NaCl IPC proxy outside of src/content.
BUG=116317
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10407009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137604 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10388173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137601 0039d316-1c4b-4281-b951-d872f2087c98

+++ REVERT NOTICE +++
Test still fails.
http://build.chromium.org/p/chromium.pyauto/builders/Win%20XP/builds/16004/steps/pyauto_functional_tests/logs/stdio
+++

TEST=137047 merged, re-enabled password autofill for Incognito window.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10389183

TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=DownloadProtectionServiceTest.CheckClientDownloadZip


Review URL: https://chromiumcodereview.appspot.com/10382113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10392094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109818
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10332210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137594 0039d316-1c4b-4281-b951-d872f2087c98

Remove all the unnused automation IPCs. These were used by UI tests that have been converted to browser_tests.

BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10388175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137593 0039d316-1c4b-4281-b951-d872f2087c98

Refactored default detection for all versions for better code reuse.  IApplicationAssociationRegistration::QueryCurrentDefault is used on Windows 8.  For now I'm keeping the Vista/Win7 detection as-is since I don't want to break it.  I think the new technique will work there, too, but I don't want to spend time validating this right now.

BUG=113326
TEST=check that chrome can tell whether or not it's the default browser and assorted protocol handler under XP, Vista/Win7, and Win8 at user and system levels.

Review URL: https://chromiumcodereview.appspot.com/10388151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127996
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10387142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137589 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137588 0039d316-1c4b-4281-b951-d872f2087c98

If "BREAKPAD_DUMP_LOCATION" environment variable is set, use this path instead.  Currently Mac's breakpad uses this to specify alternative path for breakpad dump location.  For Chromebot this allows crashes to be identified with multiple Chrome instances.

Review URL: https://chromiumcodereview.appspot.com/10391175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137587 0039d316-1c4b-4281-b951-d872f2087c98

r1378 | Two overflows when many actions are in one target/one script.
r1379 | msvs: error out on actions w/o inputs
r1380 | ninja: Change the default target from 'build everything' to 'build target "all"'.
r1381 | msvs: fix regression in r1378, environment not set up properly for multiple actions on one input

TBR=grt@chromium.org
BUG=gyp:261

Review URL: https://chromiumcodereview.appspot.com/10391166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137586 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vivianz@chromium.org
BUG=128300
TEST=

Review URL: https://chromiumcodereview.appspot.com/10406023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125964
TEST=none.


Review URL: https://chromiumcodereview.appspot.com/10383199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122753
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10386076

TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137581 0039d316-1c4b-4281-b951-d872f2087c98

The default paths have changed under from Visual Studio 2008 to 2010 and which causes the PDB and MAP files for the syzygyized mini_installer to get generated to the same locations as for the regular mini_installer. This further causes the staging of the Syzygy optimized build to fail because it expects the PDB file to be somewhere else.

Made the paths of the PDB and MAP files explicit.


BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10407006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137580 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky,sadrul
BUG=124724
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10388177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128319
TEST=


Review URL: https://chromiumcodereview.appspot.com/10332192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137576 0039d316-1c4b-4281-b951-d872f2087c98

Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery.

BUG=55584

Review URL: https://chromiumcodereview.appspot.com/10356052

TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10387167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137575 0039d316-1c4b-4281-b951-d872f2087c98

We're moving all the extension api implementations out of
browser/extensions into the directory with the code they are
automating.

BUG=101244
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10381097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137574 0039d316-1c4b-4281-b951-d872f2087c98

Make password generation switched by a preference in chrome settings rather than a command line flag.


BUG=
TEST= AutofillManager_Unittest,  PasswordgenerationManager_Browsertest


Review URL: https://chromiumcodereview.appspot.com/10222017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121592
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10383127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105165
TEST=updated compositor test to cover OnDeviceScaleFactorChagned.

Review URL: https://chromiumcodereview.appspot.com/10391165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137571 0039d316-1c4b-4281-b951-d872f2087c98

Replaced EXPECT_TRUE with a LOG(WARNING) for automation commands to provide more information about the failure.

Also reports the amount of time the automation call took, which should give some idea whether it returned due to a timeout.

BUG=chromium-os:30880
TEST=Compiled and ran a PyAuto test.

Review URL: https://chromiumcodereview.appspot.com/10383216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137570 0039d316-1c4b-4281-b951-d872f2087c98

Revert 137558 - Revert 136935 - Sometimes data is NULL. I am not sure if it's correct behavior , but it's safe just to check pointer.

Reverted by mistake instead of branch.

BUG=127865


Review URL: https://chromiumcodereview.appspot.com/10386106

TBR=vitalybuka@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383225

TBR=vitalybuka@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10389186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124167
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10310182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137566 0039d316-1c4b-4281-b951-d872f2087c98

These tests were disabled before because libppruntime.so was failing
to link because the link command sometimes hit a command line length
limit.  We have since worked around the length limit, and
libppruntime.so should no longer be built by the tests anyway.

This was previously committed as r136913 but it failed on the
buildbots and was reverted because of a compile problem with
__cpuidex() that has since been fixed.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2648
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10389182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137565 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the nacl SDK build

R= binji@chromium.org
BUG=none (broken nacl SDK bots)
TEST=nacl SDK build


Review URL: https://chromiumcodereview.appspot.com/10392137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137561 0039d316-1c4b-4281-b951-d872f2087c98