- 01 Mar, 2018 31 commits
-
-
Charles Harrison authored
Currently, tab-unders require that the tab has opened a popup since the last user gesture in the tab. However, we check this condition on every navigation redirect, which is wrong. For example: 1. Navigate to a.com 2. Start a navigation without a user gesture to b.com 3. Open a popup 4. Navigation from (2) redirects and should not be blocked. This is fixed by checking the popup condition once at the start of the navigation. This CL also makes a couple of `bool` members const. Bug: 817514 Change-Id: I9ddcd383fa299d8d560889b2d0e393114b5afa96 Reviewed-on: https://chromium-review.googlesource.com/941923Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#539980}
-
gogerald authored
Bug: 812297 Change-Id: Ifb855b4e52ed3fde171569a017fa856cad5cc2dd Reviewed-on: https://chromium-review.googlesource.com/940324 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539979}
-
Simeon Anfinrud authored
Added some features to reactive framework to make this smooth. This is one step to refactoring CastWebContentsActivity and adjacent classes to be testable. The ultimate goal is to express the logic of CastWebContentsActivity and other classes in terms of observable events, with the Activity, Service, and Fragment classes being thin adapters from Android API events to reactive Observables. That will let us cleanly separate concerns in the behavior classes and mount them in lightweight, potentially non- Robolectric test fixtures. Bug: Internal b/36777136 Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: Iacdeb0084e34d99193fc2733c2dbd42d9560b16a Reviewed-on: https://chromium-review.googlesource.com/929892 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539978}
-
Theresa authored
We use a narrow snackbar on tablets, so a different background asset is needed to show shadows on all edges of the white snackbar. For now, don't use the modern snackbar on tablets. BUG=817518 Change-Id: I49bb4f6a14cf804e719d433db9f26192a52a9495 Reviewed-on: https://chromium-review.googlesource.com/941506Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539977}
-
Ken MacKay authored
This reverts commit d0ca87de. Added ifdef guard for death tests. Bug: internal b/71559266 Change-Id: I204a00d7a1759a4a18407f5162843366e9229da5 Reviewed-on: https://chromium-review.googlesource.com/941789Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#539976}
-
Nate Fischer authored
No change to behavior, this only adds a comment. This adds a comment explaining why we're going to ignore the StaticFieldLeak lint warning. There is no real leak because the task doesn't run for a long time. Bug: 804422 Test: N/A Change-Id: I5a70a04a4eb5eed748f20a2396ea8dad3b86770c Reviewed-on: https://chromium-review.googlesource.com/942029Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539975}
-
Tibor Goldschwendt authored
Bug: 762588 Change-Id: I73723544788847a2209155eec756c7573dfe7b1d Reviewed-on: https://chromium-review.googlesource.com/788891Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539974}
-
John Chen authored
Change-Id: I5ae7c91a864a9c760965d38296ae5dbf4cf3fbec Reviewed-on: https://chromium-review.googlesource.com/940166Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539973}
-
Mark Pearson authored
Bug: 726044 Change-Id: Id607c942778e89fc4c1e89b372196a5c711ce51b Reviewed-on: https://chromium-review.googlesource.com/940820Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#539972}
-
Peter Wen authored
This reverts commit 6d411ef0. Reason for revert: Failed perf builders with division by zero Original change's description: > Supersize: Fix pak spurious deltas > > Previously we recorded the exact pak compression ratios in .size files. > This results in minor changes to 1k+ unrelated symbols due to changes in > compression. Use a mostly accurate static constant instead to make .size > files comparable across runs. > > Bug: 814078 > Change-Id: I63c78379898ef02885ae86e0b95df95d51965918 > Reviewed-on: https://chromium-review.googlesource.com/938122 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539252} TBR=wnwen@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814078,817534 Change-Id: I5cd4a6375e1f318c3559801da95a850f5ffcf4fa Reviewed-on: https://chromium-review.googlesource.com/942061Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539971}
-
Reid Kleckner authored
It's unlikely that pruning the cache will resize the hash table, but this makes a copy of the scoped_refptr just in case. R=drott@chromium.org BUG=812600 Change-Id: I5a6256b9079e9c7f36249cadbb679189f0248afd Reviewed-on: https://chromium-review.googlesource.com/852531Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#539970}
-
Tsuyoshi Horo authored
This reverts commit 878a6bb6. Reason for revert: Caused build error https://ci.chromium.org/buildbot/chromium/Linux%20x64/59639 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59639%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout In file included from ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc:6: ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h:12:10: fatal error: 'chrome/common/extensions/api/easy_unlock_private.h' file not found #include "chrome/common/extensions/api/easy_unlock_private.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Extension API: Move easyUnlockPrivate API to be CrOS-only. > > This is true in practice and is the next step in making SmartLock > CrOS-only. > > Bug: 817115 > Test: Existing tests > Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5 > Reviewed-on: https://chromium-review.googlesource.com/940538 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Toni Barzic <tbarzic@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539965} TBR=tbarzic@chromium.org,jhawkins@chromium.org,lazyboy@chromium.org,benwells@chromium.org,karandeepb@chromium.org Change-Id: Ib5425ec7d3c9283a6fcb776a11c6a1a2f6b61efe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817115 Reviewed-on: https://chromium-review.googlesource.com/942421Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539969}
-
Nico Weber authored
Bug: 693709 Change-Id: I4e846d36fac5ca170c47c8e20906b0cf2715fbf5 Reviewed-on: https://chromium-review.googlesource.com/941904Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539968}
-
file:///android_res/Torne (Richard Coles) authored
The removal of GetApplicationContext accidentally removed the parameter used to try shorter versions of the package name if the R class isn't found in the original package name, reintroducing crbug.com/599869 that this logic was written to fix. Put the package name parameter back so that stripping off elements of the package name actually has an effect. Bug: 599869 Change-Id: Iad5e0174052b1362c8fe7e86089655e3fd60b847 Reviewed-on: https://chromium-review.googlesource.com/941591Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539967}
-
Fan Yang authored
Turn on FLAGS_quic_reloadable_flag_quic_use_write_index. Increase acceptable time delta from 1 min to 2 mins. Merge internal change: 186930823 https://chromium-review.googlesource.com/c/chromium/src/+/937681 Deprecate FLAGS_quic_reloadable_flag_quic_fix_sequencer_buffer_block_count2. Merge internal change: 186669590 https://chromium-review.googlesource.com/c/chromium/src/+/937661 In QuicDispatcher: - Rename 'client_address' to 'peer_address' when it makes sense, i.e. if a variable named 'client_address' may not contain the actual client address, it is renamed to 'peer_address'. - For symmetry, rename 'server_address' to 'self_address'. Merge internal change: 186664180 https://chromium-review.googlesource.com/c/chromium/src/+/937587/1 Use QuicMakeUnique when initializing an unqiue_ptr. Merge internal change: 186475749 https://chromium-review.googlesource.com/c/chromium/src/+/937565/1 Replace FLAGS_quic_reloadable_flag_quic_enable_version_42 with FLAGS_quic_reloadable_flag_quic_enable_version_42_2. Merge internal change: 186384559 https://chromium-review.googlesource.com/c/chromium/src/+/937586/1 Remove unused Randomize() function from quic_http_frame_decoder_state_test_util. Merge internal change: 186374471 https://chromium-review.googlesource.com/c/chromium/src/+/937564/1 In QUIC, let session unblock stream in UpdateSendWindowOffset. So that in QuicStream::OnCanWrite, we can directly return after stream retransmits lost data. Protected by existing FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2. Also add DCHECK after stream's OnCanWrite to make sure that if a stream has buffered data and it is not stream flow control blocked, it must be in the session's write blocked list. Merge internal change: 186305642 https://chromium-review.googlesource.com/c/chromium/src/+/937584/1 In QUIC, framer incrementally report ack ranges to the connection, also stop appending timestamps in ack frame. Protected by FLAGS_quic_reloadable_flags_quic_incremental_ack_frame. Merge internal change: 185827616 https://chromium-review.googlesource.com/c/chromium/src/+/937561/1 Change-Id: I0299a5c489eabd0ce47a21af9ba0093631c21b2c Reviewed-on: https://chromium-review.googlesource.com/941586Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539966}
-
James Hawkins authored
This is true in practice and is the next step in making SmartLock CrOS-only. Bug: 817115 Test: Existing tests Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5 Reviewed-on: https://chromium-review.googlesource.com/940538Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#539965}
-
Thomas Tangl authored
Instead of using the full name in the settings sync promo, only the first name should be used. This CL fixes this. Bug: 810865 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib707abeebe65f8d5b02cfa94dca75c00596997e7 Reviewed-on: https://chromium-review.googlesource.com/941202 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539964}
-
Stephen Martinis authored
Adds the compile builder, and the tester. Bug: 790710, 790644 Change-Id: Ie7184a94b0ec7e518aa65a96432880529c1920c7 Reviewed-on: https://chromium-review.googlesource.com/940423Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#539963}
-
Mitsuru Oshima authored
* Start resizing upon resize request from client. * Client can start drag only if 1) mouse is pressed on the shell surface. 2) gesture is on progress. This CL includes a fix for potential issue when the drag to resize/move was requested when the mouse/touch drag wasn't in progress. BUG: b/72918846 TEST: covered by unit test Change-Id: Id32f9da7a2c718fdaef1cb0e4a4adb3b99cbd7f8 Reviewed-on: https://chromium-review.googlesource.com/938498 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539962}
-
Weiliang Chen authored
Trying to access GL will crash vulkan build. Only create sync queries when it can be used. R=enne Bug: 644851 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibffe46608195541ab094aae9de4161871c1ab2b1 Reviewed-on: https://chromium-review.googlesource.com/941383Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#539961}
-
Katie D authored
Bug: 806169 Change-Id: Ibd56a9c4d281b2826901cceb07d5f84e7a6ab1c8 Reviewed-on: https://chromium-review.googlesource.com/941411Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#539960}
-
W. James MacLean authored
This CL corrects a bug where, in the case of an OOPIF, the ScrollableArea rects are computed in the coordinate space of the main frame, when they need to be in the coordinates of the LocalRoot's Document in order that the compositor, which is owned by the LocalRoot, can deal with them properly. The manifestation of the bug required a non-fast-scrollable rect to be recomputed after its localroot container was scrolled. In that case the coords change due to the scroll, when they shouldn't. This CL also updates Internals::nonFastScrollableRects() to work for OOPIF frames, and it adds code to force recalculation of the rects, otherwise it might be unable to detect if this change gets regressed (since scrolling is not sufficient to make the non-fast-scrollable rects change, something must also trigger their recalculation after the scroll). Bug: 807683, 680606 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iccb7a694f43e98265e1bfde3d334efe51d64a59a Reviewed-on: https://chromium-review.googlesource.com/922421Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#539959}
-
Sergey Poromov authored
Device DMToken will be included in user policy fetch for affiliated users. In order to do it even for the initial policy fetch, server will provide |user_affiliation_ids| in user registration response and they will be used to check affiliation with the device. BUG=810336 Change-Id: I89f83807be88bb47160381e8320912dfd638c787 Reviewed-on: https://chromium-review.googlesource.com/907568Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#539958}
-
Lambros Lambrou authored
For WebRTC-enabled connections, ensure capturer is not scheduled more often than 30FPS, to limit CPU usage. Bug: 816727 Change-Id: If2efd9de0749848f209fad7ed1926be108f402c3 Reviewed-on: https://chromium-review.googlesource.com/940449Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#539957}
-
Ali Tofigh authored
This is a reland of 21489fa9. Original change's description: > Update Google Update COM interface definitions in google_update_idl.idl. > > This update is required for work that is underway related to management > of Chrome browsers for enterprise users. > > The google_update_idl.idl file was originally provided by the Google > Update team. It has been modified as described in the README.chromium > file in this CL. > > The change was tested with Chrome-branded builds with target_cpu set to > "x86" and "x64". I followed these steps to make sure that this change > does not break Chrome updates. > > 1. Manully set the version of Chrome in src/chrome/VERSION to a version > prior to that which is currently served on the Dev channel. > 2. Compile with is_chrome_branded=true and target_cpu set to one of > "x86" or "x64". > 3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit > Win10 machine. > 4. Navigate to chrome://help and make sure that the update process works > as expected. > > Bug: 796270 > Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3 > Reviewed-on: https://chromium-review.googlesource.com/924474 > Commit-Queue: Ali Tofigh <alito@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539457} Bug: 796270 Change-Id: I13c1fd5446ca8278ba43f57181fa5994e89608a8 Reviewed-on: https://chromium-review.googlesource.com/939656Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Ali Tofigh <alito@chromium.org> Cr-Commit-Position: refs/heads/master@{#539956}
-
Kevin McNee authored
Consider a page with a nested iframe such that the main frame is navigated to site A, the outer iframe is site B, and the inner iframe is site B. With Site Isolation, the outer iframe is an OOPIF and the inner frame is local to said OOPIF. When attempting to scroll in the inner iframe, ScrollManager::HandleGestureScrollBegin for the outer frame passes the event along to its local child, but ignores the return value which indicates whether the child has a non-empty scroll chain. It goes on to create a scroll chain for the outer frame and bases the event ACK on that. Hence, if a local child frame is scrollable in a given direction, but the OOPIF containing it isn't, then the GSB will be acknowledged as unconsumed which will cause the browser to bubble scroll to an ancestor of the OOPIF. We now use the return value for the local child to inform the GSB ACK. In order to do this, we also no longer unconditionally add the document element for a local subframe to the scroll chain. Bug: 807683 Change-Id: I4cd76888f8362e14aa660d7727dfcb0d24323a40 Reviewed-on: https://chromium-review.googlesource.com/939522 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539955}
-
Mike Wittman authored
Converts the browser process profiling to use the ThreadProfiler abstraction. This simplifies the browser process profiling implementation and removes all users of the the current continuous profiling implementation, allowing it to be cleaned up. This also alters the way continuous profiling is done in the browser process, from taking samples at 1Hz continuously to taking samples at 10Hz for 30 seconds during 2% of execution time. This will reduce the number of samples by 80%. Bug: 808588 Change-Id: I2925dc75b27aaab093b4ea99ae5e8dabfa2b273c Reviewed-on: https://chromium-review.googlesource.com/941730Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539954}
-
Yuqian Li authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibb10f26a84f8fe3854f2d9dc76ae73ed64bb2b22 Reviewed-on: https://chromium-review.googlesource.com/923767Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#539953}
-
Sandeep Vijayasekar authored
The new VP9 profile 2 string format gets mapped to EME_CODEC_COMMON_VP9 in key_systems.cc. Bug: internal b/73148168 Bug: internal b/70520890 Test: Play secure vp9 profile 2 content Change-Id: I32c0e319113db70e2bdfd2afc8e131e3470b3fe0 Reviewed-on: https://chromium-review.googlesource.com/940610Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Cr-Commit-Position: refs/heads/master@{#539952}
-
Anthony Vallee-Dubois authored
This CL also enables the MacViews translate bubble when --secondary-ui-md is enabled. Bug: 814477 Change-Id: I107edf4fcbfde529b60433873c8e785a4fdbc2bf Reviewed-on: https://chromium-review.googlesource.com/939521Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#539951}
-
Peter Wen authored
NOTRY=true Bug: None Change-Id: I40ae8bda58079de746b2947dca0b41b70afb2d9a Reviewed-on: https://chromium-review.googlesource.com/941921Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539950}
-
- 28 Feb, 2018 9 commits
-
-
Dmytro Golovchenko authored
This reverts commit 6e3fb99a. Reason for revert: install-build-deps.sh brocken: The following packages have unmet dependencies: libappindicator3-1 : Conflicts: libappindicator3-1:i386 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed libappindicator3-1:i386 : Depends: libindicator3-7:i386 (>= 0.4.90) but it is not going to be installed Conflicts: libappindicator3-1 but 12.10.1+13.10.20130920-0ubuntu4.1 is to be installed E: Unable to correct problems, you have held broken packages. Original change's description: > Add 32-bit version of libappindicator3-1 > > When doing a 32-bit build on a 64-bit system, the 32-bit version of the > library is not available. This CL should fix that. > > Bug: 799144 > Change-Id: I40c6d16d708db102eb4da90ded7bc336cb9f9b09 > Reviewed-on: https://chromium-review.googlesource.com/940196 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Tim Brown <timbrown@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539851} TBR=dpranke@chromium.org,timbrown@chromium.org Change-Id: Ic6ee1c67eb9c8a5cd438b7f0bc86fbea18125b46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799144 Reviewed-on: https://chromium-review.googlesource.com/941614Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dmytro Golovchenko <dgolovchenko@google.com> Cr-Commit-Position: refs/heads/master@{#539949}
-
Andrii Shyshkalov authored
But leave doc for troopers in case this is needed again in the future. R=jchinlee@chromium.org Bug: 817498 Change-Id: I46c33c17752f52394bb96cbd3d7bbbe944f89a17 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/942240 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#539948}
-
Tommy C. Li authored
Bug: 737787 Change-Id: Ib967821fd071f718d72e9a300809d33070e9729c Reviewed-on: https://chromium-review.googlesource.com/938957Reviewed-by:
Anthony LaForge <laforge@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#539947}
-
Vaclav Brozek authored
This CL adds PasswordManager.ExportedPasswordsPerUserInCSV to the code for exporting passwords from Android settings. More details about the metrics are in the design doc [1]. (Remaining TODO for metrics, not addressed here: user actions.) [1] https://docs.google.com/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?ts=5a313898#heading=h.chwovfmlf7pk Bug: 788701 Change-Id: I844f7506590d505b1d2e4671e21f5d363d73a2e7 Reviewed-on: https://chromium-review.googlesource.com/926527Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539946}
-
Julia Tuttle authored
This will eventually be used to parse JSON using data_decoder. Bug: 810142 Change-Id: Ie0395104c64c24eee2df568be337bb251f500241 Reviewed-on: https://chromium-review.googlesource.com/919621 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#539945}
-
W. James MacLean authored
TBR=ekaramad@chromium.org Bug: 817067 Change-Id: I3fd386ed4d6f718bf1de6deef73bf9247b9767e5 Reviewed-on: https://chromium-review.googlesource.com/941588Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#539944}
-
Andrii Shyshkalov authored
R=hinoka@chromium.org Bug: 816721, 817494 Change-Id: Ic39f00a60a246ab39e0547108a8ae3f057640220 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/941962Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#539943}
-
Andrii Shyshkalov authored
No CLs submitted after that time to CQ will be procesed until this CL is reverted. R=iannucci@chromium.org, jchinlee@chromium.org Bug: 817498 Change-Id: I9e0f8a542cff370013d46166f12d5e81b3c1c58c No-Try: True Reviewed-on: https://chromium-review.googlesource.com/941967Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#539942}
-
https://chromium.googlesource.com/catapult.git/+log/e544456fc734..b019720d08b2 $ git log e544456fc..b019720d0 --date=short --no-merges --format='%ad %ae %s' 2018-02-27 bsheedy Make PushProfile set security context Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If13ca8dc2bec52943bdd4cd992996364f83ba259 Reviewed-on: https://chromium-review.googlesource.com/941729Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539941}
-