- 24 Aug, 2018 40 commits
- 
- 
wutao authoredThis patchs implements the assistant audio decoder service. Bug: b/80315134 Test: manual. Change-Id: I3643614339c4623fb26e1aaeed968c0bdea99796 Reviewed-on: https://chromium-review.googlesource.com/1184385 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#585717} 
- 
Chromite Chromium Autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/790b2751b515..195b9510dbe5 git log 790b2751b515..195b9510dbe5 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 achuith@chromium.org cros_run_vm_test: Support for test_that args. 2018-08-23 vapier@chromium.org cbuildbot: sdk: stop trying to uprev android Created with: gclient setdep -r src/third_party/chromite@195b9510dbe5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2980a1fde59e78ca3237889984e24d02f261450 Reviewed-on: https://chromium-review.googlesource.com/1187862Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585716} 
- 
Hayato Ito authoredBUG=877299 TBR=yosin@chromium.org Change-Id: I98846bfc3dd89d07e2703cda8b8c32e3e6767cfd Reviewed-on: https://chromium-review.googlesource.com/1187849Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585715} 
- 
Sam McNally authoredOne of the two implementations now supports moving directories so update the documentation to mention that moving directories may be supported, depending on the implementation. Bug: 172187 Change-Id: Ie5fde919681fef8a80528d25fd7b9e5a48225013 Reviewed-on: https://chromium-review.googlesource.com/1186931Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585714} 
- 
Tetsui Ohkubo authoredThis CL replaces WiFi off icon to new one. The icon is specific to ash so it's placed in ash/resources/vector_icons. TEST=manual BUG=876218 Change-Id: I47d40641f2e8d4c7bc0d68322d84b6cd15d0bb69 Reviewed-on: https://chromium-review.googlesource.com/1184654Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#585713} 
- 
Stuart Langley authoredDuring normal processing, the file system starts a number of periodic requests to drive to refresh state. Many of these are not in response to user input and can complete gradually. However the underlying drive service has no way to differentiate between user initiate requests and background requests and uses the same processing queue for both, resulting in user initiated requests being delayed. This CL introduces a rate limited queue that the file system can use for requesting background requests, so that we always have capacity to quickly service user initiated requests. Bug: 874456 Change-Id: I5c041d7406f99d7f70af89aacc84bec39134f9a4 Reviewed-on: https://chromium-review.googlesource.com/1179119 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585712} 
- 
Alexei Filippov authoredOn MacOS the implementation of libmalloc sometimes calls malloc recursively, delegating allocations between zones. That causes our hooks being called twice. The scoped guard allows us to detect that, and avoid double counting. BUG=803276 Change-Id: I96bfa2c7cf29b0f21777033f259c2e2d8286b2e2 Reviewed-on: https://chromium-review.googlesource.com/1187831 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585711} 
- 
chrome-release-bot authored# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I30aabba8626d648fa80ca3353a37dd9d97668b23 Reviewed-on: https://chromium-review.googlesource.com/1188062Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#585710} 
- 
Wez authoredPreviously if QEMU ran but neither exited prematurely, nor did the guest ever become connectible via SSH, then the QEMU sub-process would be left running after the runner script exited. Bug: 877194 Change-Id: Id50fa44e11987f69afc469d73adc445b5066b7a5 Reviewed-on: https://chromium-review.googlesource.com/1187543 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585709} 
- 
Lei Zhang authoredFix some lint errors as well. TBR=emircan@chromium.org,kbr@chromium.org,reillyg@chromium.org,sandersd@chromium.org,thakis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6753c2e20302ce2296950d9a033bf0d0ac3cf509 Reviewed-on: https://chromium-review.googlesource.com/1183847Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585708} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d5c73cf..b44922e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52f10ea76f26b0ed65f565fabb6d9f500b27ced5 Reviewed-on: https://chromium-review.googlesource.com/1187378Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585707} 
- 
depot-tools-chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b16da6a2a9e5..7b7eb8800be0 git log b16da6a2a9e5..7b7eb8800be0 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 tandrii@chromium.org git cl: restart using project~number on Gerrit. 2018-08-23 tandrii@chromium.org git cl: temporary stop using project~number on Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@7b7eb8800be0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876964,chromium:876910,chromium:876964,chromium:876910 TBR=agable@chromium.org Change-Id: Ifa9855cab76e938fb4be4584ebb2e61708bcb3e8 Reviewed-on: https://chromium-review.googlesource.com/1187095Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585706} 
- 
rajendrant authoredThis CL defers the loading of CSS background images. StyleResolver registers the element to LazyLoadImageObserver so that when the element is scrolled near the viewport, full image will be triggered. The image load is deferred using ResourceFetcher::ResourceNeedsLoad() and the full image load is triggered via ResourceFetcher::StartLoad(). Bug: 846170 Change-Id: If90bf69e4583e4d8ff8006485c10229c3dca22f2 Reviewed-on: https://chromium-review.googlesource.com/1161208 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585705} 
- 
Robert Ogden authoredIncluding: * domains without a dot as in ".com" * private IPs * localhost, except in testing Whether or not to trigger on localhost is determined by a variation param to allow it to be changed in browser or unit tests, and during local development. Bug: 864644 Change-Id: I8798c202342ababa95c90e5918b8d836a4ec15e3 Reviewed-on: https://chromium-review.googlesource.com/1187502 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585704} 
- 
Ramin Halavati authoredInvalidation, search engines, and omnibox preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I8c2fbfac8ff8e9002ab828c908e826419bff2abc Reviewed-on: https://chromium-review.googlesource.com/1185599Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585703} 
- 
Will Harris authoredRunning Chrome normally and watching it for a few minutes, I don't see this being delay loaded by anything, so this is probably a load time improvement. BUG=871847 Change-Id: I7c6647325f63d7d7dfa0e6b0807c15757cf8fda0 Reviewed-on: https://chromium-review.googlesource.com/1187711Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585702} 
- 
Xiaocheng Hu authoredThis patch refactors the function by extracing DirectionAt() out of it, so that the logic of getting direction from VisiblePosition is abstracted. It also reduces one client of InlineBox, making it easier to transition to LayoutNG. Bug: 877263 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifba556e3fb03b7bfa6e4ed27df5e39d07a45eb7c Reviewed-on: https://chromium-review.googlesource.com/1187630Reviewed-by: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585701} 
- 
Noel Gordon authoredMore variables in this file are said to be const but are declared var. Make the directory tree selectors const. ENTRY_SET is too generic (not really helpful for code searching): make it FOLDER_ENTRY_SET, also make it const. Ahhh DIRECTORY: be const till I think of a better name. Bug: 876267 Change-Id: Ic0c1a25c4d019088cf73e45119081b4582c640c0 Reviewed-on: https://chromium-review.googlesource.com/1186521 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#585700} 
- 
Luciano Pacheco authoredAdd new test file for tests related to Launcher. Add test util to call the Files app event listener that listens to chrome.launcherSearchProvider.OnOpenResult event, which emulates a call from the Launcher app. Bug: 869481 Change-Id: I178b20a8860348d613dd655291747a98e94cce95 Reviewed-on: https://chromium-review.googlesource.com/1186295Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#585699} 
- 
Luciano Pacheco authoredThe IF condition is inverted, it should return when it isn't a native FileEntry/DirectoryEntry, only FilesAppEntry's types have "type_name" attribute defined. Test: New browser test being added on crrev.com/c/1186295 Bug: 869481 Change-Id: Icfdbdedc8289c65447f02c0604e6a36ac8176e6b Reviewed-on: https://chromium-review.googlesource.com/1186006 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585698} 
- 
Lei Zhang authored- Make sure the base::SharedMemory passed in is valid. - Add a helper function in PdfCompositorImplTest to create test data. - Remove some unused headers. Change-Id: I2e6efeec7ec6efb75bd973edc9d1a532e1919ff0 Reviewed-on: https://chromium-review.googlesource.com/1186271Reviewed-by: Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585697} 
- 
Noel Gordon authoredTREEITEM_DRIVE and TREEITEM_DOWNLOADS are shared between various tests but are var-defined in multiple places. Multiple definitions are error-prone: choose one place and define them as const therein (CreateNewFolder for now). Update folder_shortcuts.js test to use this new TREEITEM_DRIVE definition, keyboard_operations.js already uses the TREEITEM_DRIVE/DOWNLOADS definitions. Test: browser_tests --gtest_filter="*/FilesApp*" No-presubmit: true Bug: 876267 Change-Id: I7b86719a29a25e9d649c33edbe8af6cddae529bc Reviewed-on: https://chromium-review.googlesource.com/1186390 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#585696} 
- 
agrieve authored-keepname -> -keepnames Change-Id: Ie8febb9c4239e5344b0e3e6b333b4576cccb84b3 Reviewed-on: https://chromium-review.googlesource.com/1185692Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#585695} 
- 
JunHo Seo authoredConvert list: snav-display-contents-crash snav-div-in-anchor snav-fully-aligned-horizontally snav-fully-aligned-vertically snav-hidden-focusable-element snav-imagemap-area-not-focusable snav-imagemap-area-without-image snav-imagemap-overlapped-areas snav-imagemap-simple snav-media-elements Bug: 803086 Change-Id: Iebe20bba5868fec1e1c38f2a188346432c42d568 Reviewed-on: https://chromium-review.googlesource.com/1184945Reviewed-by: Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#585694} 
- 
Nigel Tao authoredA follow-up commit will use the IDs as a map key, to de-duplicate installation tasks and avoid re-installing a web app that's already installed. That requires that different web apps have different IDs. Change-Id: I8a86e6cd20ed59a2f5df0683353935004a2c39a5 Reviewed-on: https://chromium-review.googlesource.com/1186927Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585693} 
- 
Brandon Wylie authoredBug: 875087 Change-Id: I983ea386fa6ea80d46ea0ed732f620003c1c4099 Reviewed-on: https://chromium-review.googlesource.com/1185855Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585692} 
- 
rbpotter authoredCurrently, the new print preview always sends fit to page = false for HTML documents where this setting is not available. Instead, send true unless the destination is Save as PDF, to match the old UI behavior. Bug: None Change-Id: I6f303aa176dd87fe90f6bde3a603800e9617b831 Reviewed-on: https://chromium-review.googlesource.com/1180590Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585691} 
- 
Hitoshi Yoshida authoredThis is a follow-up CL for http://crrev.com/585412 We can't find a specific description in spec, but it is natural to put optional arguments after all non-optional arguments. This changes the order of arguments in a code generator test case from: method(arg1, optional arg2, arg3) to : method(arg1, arg2, optional arg3) Bug: 876608 Change-Id: Ief33bbdeef7fefc832a03d78b5ca28ab68aa63f2 Reviewed-on: https://chromium-review.googlesource.com/1187847Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#585690} 
- 
George Burgess IV authoredThis lets users turn ThinLTO optimizations on with a single gn arg, and adds some special optimization settings for Android. No functionality change is intended by this patch. Bug: 807147 Test: `ninja` Change-Id: I7c2da21c1d5c2e779abce598ed775109453c8fa0 Reviewed-on: https://chromium-review.googlesource.com/1148997Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#585689} 
- 
Tatsuhisa Yamaguchi authoredThe animation on network feature pod button was drawin in a wrong color while a wireless network is connecting, when in OOBE and Unified System Tray is enabled. Bug: 874829 Change-Id: I4506008e5584e6f3830198d7236a7d75f2ca0aa5 Reviewed-on: https://chromium-review.googlesource.com/1183008Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585688} 
- 
Boris Sazonov authoredThis CL adds SignInPreference to SyncAndServicesPreferences that is only visible when the user is not signed in. SignInPreference in SyncAndServicesPreferences shouldn't show personalized sign-in promo, so setPersonalizedPromoEnabled method is added to SignInPreference. This CL also hides 'Use Sync and all services' toggle and collapses 'Sync and personalization' section in SyncAndServicesPreferences if the user is not signed in. Bug: 814728 Change-Id: If09fa20144bc4669fe03e95cb5719347aa652afc Reviewed-on: https://chromium-review.googlesource.com/1187154Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585687} 
- 
Daniel Erat authoredRemove the Delegate interface from ProxyResolutionServiceProvider. This code lives in //chrome/browser/chromeos/dbus now, so it's able to access profiles directly. Bug: 843392 Change-Id: I1fe04762b260fdd4f4cc792f8921c085f1ded7b8 Reviewed-on: https://chromium-review.googlesource.com/1187727Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#585686} 
- 
David Black authoredMotion implementation has stabilized. Deleting the flag and removing dead code paths. Bug: b:113107934 Change-Id: I3dac44473d176fbe241a4b344527e8e37d69b0c9 Reviewed-on: https://chromium-review.googlesource.com/1187266 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#585685} 
- 
Katie D authoredThis reverts commit ecdb6a3b. Reason for revert: This is causing a weird behavior where if you mouse-down on the button and then hold and drag way, select-to-speak is activated anyway. Select-to-Speak can also be activated from behind the on-screen keyboard. TBR=jamescook@chromium.org,dtseng@chromium.org Bug: 870922 Change-Id: Ib9b7395e3a66c491a6c3274dd93898b4e064dd4d Reviewed-on: https://chromium-review.googlesource.com/1187728 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585684} 
- 
Shu Chen authoredTurns out the new version of iBus (starting from 1.5.17) will multiply the coordinates with the scale factor specified by GDK_SCALE. Chrome on linux now send the system based coordinates to the system's gtk-base IME, despite the scale factor specified by the app. The correct coordinates should be divided by the GDK_SCALE of the app window. Bug: 774974 Change-Id: I654bacaa1a4eaba13680a33f2516e41b35d31a13 Reviewed-on: https://chromium-review.googlesource.com/1186291Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585683} 
- 
agrieve authoredBug: 648475 Change-Id: Ibbafd96a020850881c0c515e0e4dd71ee530c099 Reviewed-on: https://chromium-review.googlesource.com/1187922Reviewed-by: Peter Collingbourne <pcc@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#585682} 
- 
Alan Cutter authoredHosted app windows using GlassBrowserFrameView (Windows 10 only) had their controls and title misplaced when maximized. This CL adds missing padding values to the titlebar layout. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354512&signed_aid=Tmrgizah9A_QhgrbRHXHFQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354513&signed_aid=h_aEa4bnb7fIu3UutTuNrA==&inline=1 Bug: 876168, 872203 Change-Id: I9e4d3e1ff0776cfba09981cad30a0cfa39469e7c Reviewed-on: https://chromium-review.googlesource.com/1183019 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#585681} 
- 
Hayato Ito authoredThis reverts commit a2a4e75d. Reason for revert: [sheriff] a culprit for cronet_tests failing on multiple builders See https://crbug.com/877355 for details. Original change's description: > Check that TaskScheduler is not leaked between tests, or test-cases. > > - Move some APIs off of base::TestSuite, that we unnecessarily public. > - Rename the various internal TestEventListeners to express purpose. > - Add CheckForLeakedGlobals check, and DisableCheckForLeakedGlobals API. > The latter is called by the content::ContentTestSuiteBase, since the > various browser- and ui-tests running under that suite base run more > like the browser itself, and so are expected to let global singletons > leak. > > Bug: 875486 > Change-Id: If749dfe8530abc4a5c13a840bbf8258d48c377c5 > Reviewed-on: https://chromium-review.googlesource.com/1182612 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585652} TBR=sky@chromium.org,wez@chromium.org,gab@chromium.org Change-Id: I906458f276100d9f924a0a78c7cca3a55bcb28b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875486 Reviewed-on: https://chromium-review.googlesource.com/1187982Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585680} 
- 
James Cook authoredNeither the mustash team nor the accessibility team has any concrete plans to ship this. We can always restore it if we change our minds. This eliminates a couple IsAshInBrowserProcess() checks in //ash. Bug: 876115 Test: ash_unittests Change-Id: I60928f52facc4a4d382dff2c4c373d967f203f0a Reviewed-on: https://chromium-review.googlesource.com/1187563Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585679} 
- 
Yuwei Huang authoredThis CL makes HostViewController request to autohide the home indicator (the bar acting like a virtual home button), so that user can see things on the bottom after the home indicator times out. This CL is dependent on internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/666568 Bug: 876014 Change-Id: I4d5e3f983100dd43f84f5d422bba31207707c651 Reviewed-on: https://chromium-review.googlesource.com/1187655Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#585678} 
 
-