- 26 Jun, 2018 40 commits
-
-
Hitoshi Yoshida authored
Now all interfaces are on Oilpan heap, and we don't support [GarbageCollected]. Hence we don't have to have tests for InterfaceGarbageCollected separately from Interface. Bug: 819112 Change-Id: I7ef1d9e373944836e61194419d6d4c12300d4610 Reviewed-on: https://chromium-review.googlesource.com/1114398Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#570341}
-
Sara Kato authored
Bug: 853104 Change-Id: I6b6a0e0436e7c3753e09f9071110bf36c10be1a1 Tests: ash: ash_unittests:AcceleratorControllerTest.TestDialogCancel ash: ash_unittests:AcceleratorControllerTest.TestToggleHighContrast ash: ash_unittests:MagnifiersAcceleratorsTester.TestToggleFullscreenMagnifier ash: ash_unittests:MagnifiersAcceleratorsTester.TestToggleDockedMagnifier Reviewed-on: https://chromium-review.googlesource.com/1102217 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570340}
-
Darren Shen authored
We rename some KeyboardControllerObserver events to avoid confusion: - OnKeyboardClosed -> OnKeyboardDisabled ("closed" could mean hidden too). - OnKeyboardAvailabilityChanged -> OnKeyboardVisibilityChanged ("available" could mean that VK is enabled). Bug: 845780 Change-Id: I8a0f1532b064377ce4441e2e407ba136778cd506 Reviewed-on: https://chromium-review.googlesource.com/1111489Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#570339}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/111fdfd73204..84916937b704 git log 111fdfd73204..84916937b704 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 deadbeef@webrtc.org Update packetsLost and jitter stats any time a packet is received. Created with: gclient setdep -r src/third_party/webrtc@84916937b704 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I911fc8def915a9f75350355c1905c72974f55374 Reviewed-on: https://chromium-review.googlesource.com/1114050Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570338}
-
Henrique Nakashima authored
Bug: pdfium:1105 Change-Id: Ieb85b8258ce321b9b28bc1f7265980395b184fc5 Reviewed-on: https://chromium-review.googlesource.com/1114072 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570337}
-
junweifu authored
The new implementation is based on Mac OS Vision Framework[1] which recognizes more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode detection provider to choose different implementation. Split original large CL[2] up in smaller subpatches including this CL. [1] https://developer.apple.com/documentation/vision [2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466 BUG=848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e Reviewed-on: https://chromium-review.googlesource.com/1107493 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570336}
-
Xiaocheng Hu authored
This patch implements hit testing on culled inline elements by: - After hit testing each inline fragment, fall back to the legacy LayoutObject tree to see if there is any culled inline ancestor element, and hit test each of them. This part replicates relevant logic in InlineFlowBox::NodeAtPoint. - Adds a |parent_fragment| parameter to LayoutInline::HitTestCulledInline to ensure that only descendant rects of |parent_fragment| are hit tested. This ensure that, e.g., for a multi-line SPAN, we hit test its rects line-by-line, to ensure correct hit test ordering. Tests: 6 layout tests are fixed. One of them is rebaselined due to whitespace-only difference in text dump. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic303ce5f8a192f92ad326c304a9d84fa898e4c94 Reviewed-on: https://chromium-review.googlesource.com/1110737Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570335}
-
John Abd-El-Malek authored
Change-Id: I5f171e2c769be38ffc5f2a8c63230071163235a5 Reviewed-on: https://chromium-review.googlesource.com/1114152Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570334}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fcd480bcab9e..f46710802ad5 git log fcd480bcab9e..f46710802ad5 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f46710802ad5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I09638c1e2ae4d354d547f523e8edc14b7ebac393 Reviewed-on: https://chromium-review.googlesource.com/1114051Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570333}
-
Lei Zhang authored
It is currently calculated in many places as 10 * kHundrethsMMPerInch. Since it is commonly used, add a constant for it and replace the calculations. After which, kHundrethsMMPerInch is infrequently used, so remove it. Change-Id: I5b0297b8ed175ef2936657f0db8f92ce6e294b4d Reviewed-on: https://chromium-review.googlesource.com/1111682Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570332}
-
Wenzhao Zang authored
May control this with a Finch flag later. Bug: 800945 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idfaa09501781398a805d8b4ae0453538d7a5ee4b Reviewed-on: https://chromium-review.googlesource.com/1099999 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570331}
-
Adam Rice authored
Add CHECK statements to KURL::Port() to verify that it is behaving as expected, in preparation for removing unnecessary code. The CHECKs will be replaced with DCHECKs in a followup CL after there's been time for any crashes to appear. BUG=606462 Change-Id: Ib3bcc738005de27201435f2c62aa4056965d5c91 Reviewed-on: https://chromium-review.googlesource.com/1111879Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#570330}
-
Oliver Chang authored
TBR=inferno@chromium.org,rockot@chromium.org Bug: 856188 Change-Id: Ic215f12810032592df4ed6832ecc40f92068bbc8 Reviewed-on: https://chromium-review.googlesource.com/1113710 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570329}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifa7108a77525552b091b2fc6877c5e7042022cc4 Reviewed-on: https://chromium-review.googlesource.com/1114391 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570328}
-
Karan Bhatia authored
With Declarative Net Request, there is no easy way for extensions to collapse the DOM elements corresponding to the resources they blocked. This CL implements the ability for the blocked <iframe> elements to be automatically collapsed in the DOM. BUG=848842 Change-Id: Iaf9ce75b5dc1a978a09e1ae698f2ed180351c288 Reviewed-on: https://chromium-review.googlesource.com/1111341 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570327}
-
David Tseng authored
- correct message string id (i.e. + '_description') - walk up to the first scrollable ancestor (based on the availability of the scrolling action). Test: 1. open Learn Mode. Perform three finger swipe up/down. Verify scroll back/forward output. 2. Scroll within an Android app. Verify content changes appropriately. Change-Id: I4da02e1f09eb38dc2a61e5141b4ef67e57139b46 Reviewed-on: https://chromium-review.googlesource.com/1114200Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570326}
-
Makoto Shimazu authored
TEST=./out/Default/chrome https://web-platform.test:8444/service-workers/service-worker/referrer-policy-header.https.html --enable-features=ServiceWorkerServicification (with ./third_party/blink/tools/run_blink_wptserve.py) Bug: 855948 Change-Id: Ib055174295d6b54f9e3bf0e14bd4f7002ceb33f2 Reviewed-on: https://chromium-review.googlesource.com/1113711Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570325}
-
Wei Li authored
Mac browser fullscreen mode allows to keep the top UI, as well as toggling between showing and hiding the top UI. In these cases, bookmark bar should always show or hide in sync with the top UI. This requires tracking top UI change, and change bookmark bar state or visibility accordingly. In Views, bookmark bar state is cached in Browser::bookmark_bar_state_, and is updated through Browser::UpdateBookmarkBarState(). So when the visibility of top UI changes, we need to execute UpdateBookmarkBarState() to update bookmark bar state as well. BUG=831219 TEST=pls check bookmark bar (non-detached) in fullscreen mode, which should always show or hide along with toolbar/tabstrip. Change-Id: I04475edc455a62e045857ed666c44a31ead2b402 Reviewed-on: https://chromium-review.googlesource.com/1109405 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#570324}
-
Min Chen authored
The contents view of |menu_widget_| in PowerButtonController will be updated when showing menu, which means the destructor of PowerButtonMenuScreenView will not be called when DismissMenu. This will cause the arrow key traversal enabled value in FocusManager will not be restored correctly. Move the logic from PowerbuttonMenuScreenView into PowerButtonController to make sure the value can be restored correctly if dismiss the menu. Bug: 846639 Change-Id: I32ceebb8e81cf19e3fed119af0ccee3bd8c55638 Reviewed-on: https://chromium-review.googlesource.com/1114309 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#570323}
-
Kenneth Russell authored
webgl2_conformance_tests' shards are taking at least 3 hours to schedule, so increase the timeout to 6 hours. Bug: 856268 Tbr: jbudorick@chromium.org Change-Id: Idf610388955f4b6cb73b81f5075a810c13c2fda0 Reviewed-on: https://chromium-review.googlesource.com/1114356Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570322}
-
Chris Harrelson authored
* There is no need to do any work for a PaintLayer if it has no past/current compositing state. * There is no need to recurse if the entire stacking subtree has no past/current compositing state. Bug: 814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1d2c23e1e2c9a34bea63432d95f83a8bbe0ab13 Reviewed-on: https://chromium-review.googlesource.com/1101817 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570321}
-
sawtelle authored
This change adds onpictureinpicturecontrolsclick to the partial interface of an HTMLVideoElement and creates the plumbing that allows for functions to trigger that event (note: it is not currently being called in this CL). Manual testing was done by initiating the call in overlay_window_views.cc by calling controller_->ControlClick() and confirming the new EventHandler was triggered. Bug: 852572 Change-Id: I57038fa4809085b7000ca7e5d933c38e82d133e7 Reviewed-on: https://chromium-review.googlesource.com/1100043 Commit-Queue: Steven Sawtelle <sawtelle@google.com> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#570320}
-
Matt Falkenhagen authored
This CL: - Removes ServiceWorker.ScriptLoadSuccess UMA. It was only recorded on success, since script streaming launched in M64. We were recording it in DidLoadInstalledScript (the success case for installed script loads). There was a callsite of script load failed in ServiceWorkerContextClient::WorkerContextFailedToStart, but we seem to abort start in the browser process before reaching that point, when script streaming fails to load from storage. - Removes OnScriptLoadFailed() IPC. It was only used for the UMA, removed above. - Removes OnScriptLoaded() IPC for installed worker scripts. For installed worker scripts, it was only used for the UMA removed above. We still need it for non-installed worker scripts for ResumeAfterDownload() after the byte-to-byte update check. Bug: 855952 Change-Id: I51c9da88eb8265fd1e6ce89972578408ec74d364 Reviewed-on: https://chromium-review.googlesource.com/1113089Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570319}
-
Aga Wronska authored
Demo mode setup flow is only shown from OOBE welcome screen and not from sign-in screen. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie49fdcb2f75be66bd3db5c3f709a1658508d8589 Reviewed-on: https://chromium-review.googlesource.com/1113021Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#570318}
-
Matt Falkenhagen authored
When a page has a controller service worker without a fetch event handler, the service worker is not started and does not intercept requests. Therefore we don't care about such loads for most UMA about controlled page loads. Bug: 854851 Change-Id: I55198f43177c3d2468028672380bd2a8d08eb1f4 Reviewed-on: https://chromium-review.googlesource.com/1109314 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570317}
-
Kunihiko Sakamoto authored
The name of draft canSignHttpExchanges extension OID has renamed from id-ce-testCanSignHttpExchanges to id-ce-canSignHttpExchangesDraft in https://github.com/WICG/webpackage/pull/231. Bug: 851778 Change-Id: I1d6940d9f9028ea55d0ee2e86c854a02a9dd3b47 Reviewed-on: https://chromium-review.googlesource.com/1112894Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570316}
-
David Black authored
Change requested by JA Lindsey in comment on: https://chromium-review.googlesource.com/c/chromium/src/+/1091162 Bug: b:77638210 Change-Id: I19492f293475d8dcbdfb25d5cdf0401c56176cc5 Reviewed-on: https://chromium-review.googlesource.com/1112676Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#570315}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Idd5f6989b2f75f52715c634f37ab7ce57bdb2dd7 Reviewed-on: https://chromium-review.googlesource.com/1114270Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570314}
-
yoshiki iguchi authored
Since we have not shown the control buttons for inline settings, we don't need to support custom bgcolor of it. So let's remove the code for it. With this CL, the bgcolor is fixed to white with 90% opacity. Bug: b/110329209 Test: Ran the added unittest. Change-Id: I473e0424d9fab5f655cfd48b26cb35ad3efe5c75 Reviewed-on: https://chromium-review.googlesource.com/1105686Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#570313}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0b24e08909e..7269fa01fb54 Created with: gclient setdep -r src-internal@7269fa01fb54 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: I0d22e6e89331f7623a53879c733ecb355cf8a761 Reviewed-on: https://chromium-review.googlesource.com/1114357Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570312}
-
Shu Chen authored
Change-Id: Iba7d37b3698e2092cd0cba6b117505e03ab912ff Reviewed-on: https://chromium-review.googlesource.com/1111748 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#570311}
-
Ken Rockot authored
Updates some stale system API references, adds new stuff for invitations and platform APIs, and deletes a bunch of EDK crap. Also adds a new convenience API to PlatformChannel and uses it in a few places, because it makes example code in the documentation less ugly. :) Bug: 844763 Change-Id: I91fbff53659dc87fc6fd33a2e5a774c419ba87a7 Reviewed-on: https://chromium-review.googlesource.com/1110954 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570310}
-
Patti authored
This is a reland of e2cac39f Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} Bug: 835712, 717468 Change-Id: I7825326b8fa133d54971180bfd37494b19c5e86c Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1113037 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#570309}
-
Tetsui Ohkubo authored
According to UnifiedSystemTray UX spec, when a feature pod button has the corresponding detailed view, it should show arrow icon on the left of the label to indicate the existence of the detailed view. As described in the UX spec, it needs custom layout logic. UX spec: http://shortn/_UobIhDkQUx Screenshot: http://screen/EogahaoN3m3 TEST=manual BUG=none Change-Id: I73b226e7c36c8138310d27fa455133dec421f744 Reviewed-on: https://chromium-review.googlesource.com/1111488 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#570308}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1143433f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20250 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iec31eac2efc77eee9b9a6df6a640f8881a9340d6 Reviewed-on: https://chromium-review.googlesource.com/1114319 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570307}
-
Thomas Guilbert authored
Fixes a script crash from |incremental_apk_exists| being used without being initialized. NOTRY=true # bot failures unrelated Bug: 856384 Change-Id: Iea429a58610bc9d409f35ee6b5cf3314bb12eab7 Reviewed-on: https://chromium-review.googlesource.com/1114329 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570306}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d91a468aa50d..4c50badb2927 git log d91a468aa50d..4c50badb2927 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-25 vadimsh@chromium.org [cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9. 2018-06-25 tandrii@chromium.org Reland of "Wipe out shallow checkout support from bot_update." Created with: gclient setdep -r src/third_party/depot_tools@4c50badb2927 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:801423,chromium:855137 TBR=agable@chromium.org Change-Id: I7aed0e8eeb410cdc42f0468278104037dd9edbf3 Reviewed-on: https://chromium-review.googlesource.com/1114049Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570305}
-
Paul Irish authored
Change-Id: I411b6c8686c4d1d3e790a63a65225bb0ba5aac44 Reviewed-on: https://chromium-review.googlesource.com/1110230Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#570304}
-
Matt Falkenhagen authored
Rely on mojom to document the individual functions, and move the higher-level explanation to the class-level. Bug: 31666 Change-Id: Ie493492db6616c7b967faf6a8d961c6f97dc9a10 Reviewed-on: https://chromium-review.googlesource.com/1113400Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570303}
-
Kenneth Russell authored
fast/events/context-no-deselect.html - Suppress on all platforms, not just Windows. external/wpt/service-workers/service-worker/ about-blank-replacement.https.html - Timing out in main and virtual test suites. http/tests/navigation/rename-subframe-goback.html - Fix linked bug ID. Bug: 663847, 855816, 856330 Change-Id: If2178c22714e64f6cd76267323f26634a18f9347 Tbr: alph@chromium.org Tbr: tkent@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1114132 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#570302}
-