- 26 Jun, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I65cb05bf485d9ede8f9bcbb2b6e6d305acbd77bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782808}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d781655d0f3..6ee18c2d01f6 2020-06-25 syoussefi@chromium.org Vulkan: Remove debug symbols from internal shaders 2020-06-25 jonahr@google.com CGL: Add basic multithreading support 2020-06-25 jonahr@google.com Add basic multithreading support to GLX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1087084 Tbr: cwallez@google.com Change-Id: I2d889ea211a85ce2016fe14a0c0dc0c7e57e7a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268501Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593108049-54cd7c484f00124b00c3e227cbddebfe7f650a96.profdata to chrome-mac-master-1593129542-eae571d99fb364561b81bf0410208d0db84ed4e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieccf5eaf60f0ae8fd848cf1ea066b99c2515401e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269060Reviewed-by:
-
Eric Roman authored
Change-Id: I935dafb8a08ac65871798ba9a74dc2943f672d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268887 Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782805}
-
Nico Weber authored
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/431d6e57284a..6c656df63da5 $ git log 431d6e572..6c656df63 --date=short --no-merges --format='%ad %ae %s' 2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK. 2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them. 2020-06-25 thakis Fix argument order for aligned_alloc on mac. 2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK. Created with: roll-dep src/third_party/vulkan_memory_allocator TBR=jmadill Bug: chromium:1098741 Change-Id: I0553a043471e4a45603b9e1fd7fbd9302382e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268639Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782804}
-
Stefan Zager authored
Bug: 1092673 Change-Id: I088d993addb97e76dd35c6166f5b179008bf50a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268880Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#782803}
-
Nidhi Jaju authored
This CL replaces the use of IsolatedPrerenderServiceWorkerObserver:: IsServiceWorkerRegisteredForOrigin() by directly calling ServiceWorker Context::HasRegistrationForOrigin() in IsolatedPrerenderTabHelper:: CheckEligibilityOfURL. This can be done because this method is called on the UI thread. By using HasRegistrationForOrigin(), we are able to use the already existing |registered_origins_|, as it is not necessary to retrieve all service registrations just to confirm if a service worker is registered for a particular origin. Furthermore, the IsolatedPrerenderServiceWorkerObserver class is also removed as it is not needed anymore. The motivation of this change is to eliminate unnecessary memory allocations and data conversions GetAllOriginsInfo() performs (see [1] for details). When the browser has many service worker registrations for different origins, these allocations/conversions have considerable performance impact. [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA Bug: 807440 Change-Id: I6081df48fd6b02850ca8276923134ee7c821b92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259677Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#782802}
-
James Cook authored
Add the skeleton for a mojo API for open/save file dialogs, roughly following the existing SelectFileDialog C++ interface. Add SelectFileDialogLacros, which lives in lacros-chrome and binds to a remote SelectFile interface in ash-chrome. The class lives in //ui/shell_dialogs to be close to other per-platform select dialog wrappers, as well as to demonstrate how a lacros mojo API can be called from a component outside src/chrome. Add a stub SelectFileImpl in ash-chrome. For now this just returns a single file immediately. Follow-up CLs will actually open a dialog, using the existing file manager-backed dialog used by ash. 1-page design doc at go/lacros-file-picker Bug: 1090587 Test: manual, hit Ctrl-O and /etc/lsb-release is loaded in a tab Change-Id: I9ebd9ff25f8aa32deac5eabb85f40a37e4b72856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261405 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#782801}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a7aeca54da..0cf906bce58a 2020-06-25 fancl@chromium.org auto-triage: Separate alert groups by domain If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097767 Tbr: oysteine@google.com Change-Id: I91c92ffcceb9d0febcbf281384b6a602fd3ad6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268739Reviewed-by:
-
Owen Min authored
This reverts commit 350e9c41. Reason for revert: This CL is not related to AutotestPrivateApiTest.AutotestPrivate failure. The test was flaky before the original CL landed. Original change's description: > Revert "Fix issue that webstore private APIs return array improperly" > > This reverts commit 0403341d. > > Reason for revert: AutotestPrivateApiTest.AutotestPrivate is failing > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19325 > > Apologies to developer if reverted in error. > > Original change's description: > > Fix issue that webstore private APIs return array improperly > > > > webstorePrivate.getExtensionStatus and requestExtension should return > > extension status as a string but not an array of string. > > > > Bug: 1099334 > > Change-Id: Ib56e466cc1d967e3a322494076ad7640a6868aac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267719 > > Commit-Queue: Owen Min <zmin@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#782607} > > TBR=zmin@chromium.org,karandeepb@chromium.org > > Change-Id: Ibe7b886da11ee5864d3b8a73b8ed7d98f53327d6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1099334 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268839 > Reviewed-by: Chris Mumford <cmumford@google.com> > Commit-Queue: Chris Mumford <cmumford@google.com> > Cr-Commit-Position: refs/heads/master@{#782740} TBR=cmumford@google.com,zmin@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1099334 Change-Id: I60e43ed8b5d5450e7143683c2ff1516c5d93f8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268542Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782799}
-
Matt Wolenetz authored
The upcoming MSE-in-Workers experimental implementation will also have SourceBuffer and SourceBufferList exposed on DedicatedWorker. This change adds that conditional exposure (though it's all currently gated on MediaSourceInWorkers RuntimeEnabled feature, which is experimental-only and disallows MediaSource construction success at the moment). As the implementation is refined later, similar may need to occur for {Audio,Video}Track{,List} and their relevant SourceBuffer supplement IDLs, and possibly also TrackDefault{,List}. BUG=878133 Change-Id: I67a460515e3d3e53631a45a2e687505ff981bf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268937 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#782798}
-
nancylingwang@google.com authored
Replace usages of ExtensionPrefs::SetExtensionBlacklisted with ExtensionPrefs::SetExtensionBlocklistState based on the TODO comments, and remove the ExtensionPrefs::SetExtensionBlacklisted function. This CL replaces blacklist with blocklist for the extensions/browser directory only, and it doesn't include other directories. There will be some follow up CLs to change it for other directories, e.g.: chrome/browser/extensions extensions FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html BUG=1097644 Change-Id: Ia3053fd437a73b9a4e21b5c74caf77cfb85ba982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260273Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782797}
-
Wan-Teh Chang authored
In https://crrev.com/c/2145570 we concluded that an origin trial for AVIF image decoding would require a lot of plumbing from the renderer to the browser to control the addition of "image/avif" to the HTTP Accept headers for navigation requests. A Finch experiment for AVIF would also have the difficulties of enabling the feature for a large enough user population and coming up with meaningful A/B tests. Given the extensive developer interest[1] in using AVIF, the intent to implement from Firefox[2], and low risk of adding the feature, enabling the feature by default seems to be the best option for conducting a large-scale experiment with a partner. The expected result for the Blink web test "http/tests/misc/xhtml.php" needs to be updated because the HTTP Accept header contains "image/avif" now. [1] https://crbug.com/960620 [2] https://groups.google.com/g/mozilla.dev.platform/c/bIM8ZaFS-d8 Bug: 960620 Change-Id: I8d8dd4f728d505a49487468bfbbebd0e1c12e9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261172 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782796}
-
Tom Anderson authored
The goal of this CL is to avoid memcpy's during {Get,Change}Property and {Put,Get}Image. The former can copy large data if an image is on the clipboard, and the latter is used to draw to and read from the screen. Strategy for writes: instead of copying data to a linear buffer, break up the data into chunks where each chunk is a base::RefCountedMemory. If a RefCountedMemory needs to be written, just copy the refptr rather than the data. Strategy for reads: XCB gives us malloc'ed data for events and replies, so we can wrap this in a MallocedRefCountedMemory. If a member is a RefCountedMemory when reading, create an OffsetRefCountedMemory to wrap the MallocedRefCountedMemory. BUG=1066670 R=sky CC=msisov,nickdiego Change-Id: I49f6e7d7ac9dde419e1afa6efe0081127c5cd31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265393 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: -
Nate Chapin authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2258426, I added an early-exit to address crashes in document.open(). It looks like we probably need the same early-exit in document.write(). Two tests depend on the old behavior of invoking document.write() from a detached context. However, the new behavior matches firefox's behavior (though they thrown an exception), so I think these tests are asserting unnecessary behavior. Bug: 1099191 Change-Id: Iad039d6a7203b4321602399c0cb0feed39b32d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267446 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782794}
-
Chris Cunningham authored
"Broker" acts as a simple decoder, but under the hood manages creation and selection of of underlying media::VideoDecoders, and thread-hopping required to use them. This enables WebCodecs to use hw accelerated decoders (depending on platform/gpu) when not in a Worker context. For Workers, we still need to expose the relevant Mojo interfaces (currently tied to the RenderFrame). The code in webcodecs/ will then support hw-decode in workers automatically. Bug: 1094103 Change-Id: I9d1abcae842b16cbb095e2e24dc095c284075473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152106 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Dale Curtis authored
This will allow us to remove our custom patch which breaks upstream ffmpeg functionality for unknown reasons. R=sandersd Fixed: 1062037 Change-Id: I253011843dee4dd6a8c958b14990ad836a9f1dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268221 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Scott Little authored
This histogram was removed quite a while ago (M52 is the latest milestone I can find data on), so this CL marks the Net.PrefProxyConfig.GooglezipProxyRemovalCount histogram as obsolete. Fixed: 1089014 Change-Id: I6bcf717539214fe4fe2c5ab985c6108599a0bd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267509 Commit-Queue: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#782791}
-
Asami Doi authored
The field trial testing config will be applied to Chrome performance bots and Chrome browser_tests. This CL enables the CheckOfflineCapability flag for Finch experiment. Bug: 965802 Change-Id: Ie885c727a659711baa8a93553b26d2269631ddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235580Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782790}
-
Devlin Cronin authored
Extend the following metrics to 2021-06-01. - Extensions.ThrottledNetworkRequestDelay - Extensions.Permissions_InstallAbort3 - Extensions.Permissions_Uninstall3 - Extensions.Permissions_WebStoreInstallAbort3 - Extensions.LoadExtensionUser - Extensions.LoadOffStoreItems - Extensions.SearchEngineOverrides - Extensions.NewTabPageOverrides - Extensions.HomepageOverrides - Extensions.StartupPagesOverrides - Extensions.Events.DispatchToComponent - Extensions.EventlessEventPages - Extensions.AttemptedToDowngradeVersionLocation - Extensions.AttemptedToDowngradeVersionType - Extensions.ApiBindingGenerationTime - Extensions.ApiBindingObjectGenerationTime Bug: 1088795, 1088793, 1088791, 1088787, 1088784, 1088774, 1088771 Change-Id: I454890f2601450b3f6d3ab1fac1d0872a237cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265563Reviewed-by:
-
Songtao Xia authored
Frontend change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2233229 made changes to NetworkLog. 37 web_tests are disabled by: https://chromium-review.googlesource.com/c/chromium/src/+/2245031 Bug: crbug.com/1094669 Change-Id: I6a8903ed4ceb1edffc737685ea9c0a680823246e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245668 Commit-Queue: Songtao Xia <soxia@microsoft.com> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782788}
-
Xing Liu authored
This CL adds the don't show again checkbox and the text to let the user edit download location in download later dialog. Bug: 1078454 Change-Id: I35cfa89848dc06f0241a4baa08f44f1e83ab7b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262116 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782787}
-
Rouslan Solomakhin authored
Before this patch, requesting the unavailable payment method https://play.google.com/billing method would return an error message that mentioned that payment method is available only in a Trusted Web Activity (TWA). This message was printed even inside of a TWA. This patch adds a method to check whether Chrome is currently in TWA mode and makes sure that the error message about requiring a TWA is not printed in that case. After this patch, requesting payment via https://play.google.com/billing inside of TWA does not result in an error message about being outside of TWA. Bug: 1095808 Change-Id: I7d24532f871daf7ba3b2e690d52bbe5615393c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265413 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782786}
-
Ian Wells authored
Reuses zero-state layout from v1, but excludes the spinner since we show a spinner separately for LOADING_SPINNER_SLICE. Bug: 1044139 Change-Id: I9aa67066e82441ce78d7a43d9ff212cb2d381764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261717Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#782785}
-
Hiroki Sato authored
Previously we had an assumption that the event source from Android is serialized in event node data. But it can be incorrect in some rare cases. This change prevents Chrome crash on such a case. AX-Relnotes: n/a. Bug: b:159861631 Test: AXTreeSourceArcTest Change-Id: I22308ba29e23ff1de9271661443ceb7f67e79275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265895 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782784}
-
Hazim Mohamed authored
No intended logic change. Change-Id: I569f05fe409ef57078d6d24c34e183889405fd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265132 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782783}
-
Justin DeWitt authored
Refactor processing of additional_readme_paths.json into a newly added ProcessAdditionalReadmePathsJson function //clank is filtered by default, but projects inside //clank (such as //clank/third_party/elements) might need to add a license file to about:credits if they depend on open source code. Bug: 1099355 Change-Id: Id0e03664e1eb2e3b287ed33ee1771f21c13278eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267919 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#782782}
-
Alexander Surkov authored
Bug: 1095619 Change-Id: I0ecd3773b2156adbdc65d6958b756094ee26dbc1 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261396 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782781}
-
Scott Little authored
These histograms are still in use, so this CL extends the expiry of these histograms. Fixed: 1089120 Change-Id: Iade5d95da8bb50d32a065a481110ec68747c9791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268214 Commit-Queue: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
-
Hayato Ito authored
This CL is factored out of https://crrev.com/c/2266237 so that we can land this separately. BUG: 1082020 Change-Id: I6967bdfb0f0f2680f4d5f5f390f3140f31ea2826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266135Reviewed-by:
-
Nico Weber authored
ld64 in the MacOSX11.0 SDK warns that 10.6 and 10.7 are deprecated. Rather than jump to hoops to ignore the warning, just bump the min version to 10.8 -- from what we can tell, this suffices for all users of this project. Bug: 1098738 Change-Id: I81110a4f8d4a2954deb014c36aa3c28d4d205ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268642 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#782778}
-
Dan Harrington authored
If the server doesn't provide a continuation token, we shouldn't continue to request the next page. Bug: 1044139 Change-Id: I8a9de4013fdedb269dda904cc3c81123631e7eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261410 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#782777}
-
Albert J. Wong authored
In preparation for changing the DOM attribute APIs on Element to avoid unnecessary creation of AtomicStrings for the purpose of doing an existience check, this adds a set of "Hinted" APIs AttributeCollection that accept a hint parameter representing a weak lookup from the AtomicStringTable. WeakFind() APIs are added to AtomicStringTable to facilitate this. Knowing that no AtomicString exists for a given string contents can be used to skip a data structure search thereby avoiding all of the AtomicStringTable traversal, a potential malloc/free for a new AtomicString, and a AttributeCollection traversal. This is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: Ib996e9075704c8b68ff3cb55369adaf3bd129059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263472 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782776}
-
Daniel Murphy authored
The test waits for both installations, but this can be flaky as waiting for the first installation could hide the second installation. So when it waits for the second installation, it already happened. This fix only waits for the second installation to prevent this race from happening. R=loyso@chromium.org Change-Id: I57549f0d1be11e980ecebc6ba7fb8d2ec4e0b7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268180 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#782775}
-
Xiaohui Chen authored
Bug: None Change-Id: I193dba8deb36be925b99d216b9ff28adcece660c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268473 Auto-Submit: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#782774}
-
Matt Falkenhagen authored
To verify X-Client-Data is added properly. Change-Id: I43b08efe875ccca43b471489de56af3f4124b913 Bug: 1095842, 1092329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264173Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782773}
-
Ben Blake authored
This change will introduce the interface for a new AutofillOfferManager class. The AutofillOfferManager will be responsible for retrieving offer data via the payments client; it will do this through GetOfferData() and the subsequent callback function OnDidGetOfferData(). This change will be followed by another change to implement the interface and connect the AutofillOfferManager to both the AutofillManager and the payments client. Change-Id: I3d8824123330696f88c07d9729892a2c1d006a6e Bug: 1093057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248219 Commit-Queue: Ben Blake <fiorito@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#782772}
-
Yulun Wu authored
Navigation and Status widgets should follow shelf bounds which do not change during drag when auto hide is disabled. Bug: 1097622 Change-Id: Icefb10663c39aeefb22a02bef2cdfca0958b4a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265555Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782771}
-
Liquan (Max) Gu authored
Purpose: Move JourneyLogger from //chrome into //components so that it can be reused by //weblayer. Change: * Remove mWasPaymentRequestTriggered from JourneyLogger as it's unused * Move JourneyLogger * Move the JourneyLogger related enums Bug: 1098906 Change-Id: I74a38f7b829dfe7a813596c837cb5c3d1e799b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264509Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782770}
-
tby authored
Currently we dedup results in two cases: 1. the results point to the same URL 2. one result is a direct child of another result, eg. the "known wi-fi networks" setting and the "wi-fi networks" subpage. This CL replaces case 2 with a more comprehensive version. Setting, subpage, and section results loosely form a tree, and we never want to display two results that have an ancestor/descendant relationship. We should always pick the most general (ie. highest up the tree) result. This fixes bugs including a search for "wifi" showing both "Wi-fi networks" and "Forget Wi-fi networks", because the forget setting's subpage is nested within a subpage within Wi-fi networks. Bug: 1097166 Change-Id: Ibc6b5d54a15a405a2a9e435bbfa362ccf74cf471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265711 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782769}
-
