- 09 Jan, 2020 40 commits
-
-
Ioana Pandele authored
Bug: 1037194, 1037188 Change-Id: Ib26d7e0a5e27ee6411663e6c560897826572d2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989536Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#729689}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3a3dcd5f271d8f730decf6739405e5c8ddca1b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729688}
-
Gauthier Ambard authored
This CL adds a flag to have BVC being contained by the TabGrid instead of being presented. It also add specific method to have the TabGrid notified of its presentation instead of relying on viewWill/DidAppear/Disappear which is not called when BVC is contained. Change-Id: I5e3651c986300d045998b08d0e5daf40a7a91acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939491 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#729687}
-
Koji Ishii authored
This patch uses a new struct added in r715013 <crrev.com/c/19118620>. This patch has no behavior changes. Bug: 982194 Change-Id: Ie15c2c9f71de6037bba5acfbda01c7a1307a0bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993069Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729686}
-
Hirokazu Honda authored
crrev.com/c/1923986 handles a profile change in V4L2SVD/VDA. This CL handles a profile change in VaapiVD/VDA. Since VA-API is initialized with a codec profile, it is necessary to reinitialize VA-API with a new profile. VaapiWrapper manages several VA-API resources. For example, surfaces will be destroyed after the profile change. It will be easier to replace VaapiWrapper used in AVD::Accelerator with a new VaapiWrapper than reinitialize the existing VaapiWrapper properly. Bug: 1022246, 1029397 Test: video.DecodeAccel(VD).h264_profile_change (crrev.com/c/1924217) on eve and grunt Change-Id: Ic3ff0b231cf454ce61193ee9f2642050d588ef24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930368 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#729685}
-
Koji Ishii authored
Following bot results are included. 864 865 867 871 877 878 879 880 881 882 883 885 886 147 lines were removed and 14 lines were deflaked by consecutive results since 855. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id00a966551a54e6a2eb191efc76566042ca0eddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989706Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72cd27a20441..65793110f5f1 Created with: gclient setdep -r src-internal@65793110f5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6f02673b1a6cf6ef94dcf4004792a067dc9fd27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993057Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729683}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c431d59626e1..f6228fdf6f84 git log c431d59626e1..f6228fdf6f84 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 1642ca11282a..51813670627c (2 commits) Created with: gclient setdep -r src/third_party/angle@f6228fdf6f84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I6ceb1269c64c99e8c068304880a503f5108b0215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993051Reviewed-by:
-
Chinglin Yu authored
The jank monitor incorrectly uses task stack bottom for checking janks. This makes nested runloop reported as janky because the enclosing task will have a long running time, while the nested runloop keeps running tasks. Fix by checking the stack top. Bug: 1040013 Test: unit test: JankMonitorTest.{ReentrantResponsive|JankNestedRunLoop} Also manually verify on DUT by dragging a tab and then check "ChromeOS.CWP.JankinessTriggerStatus". Change-Id: I1614c152ec5e737c11a3ec771f2c6e2fbb55ebb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991067 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729681}
-
Fredrik Söderquist authored
The operation of finding out the "oriented" image size is used in a few places. Put this in a new overload of Size() in Image which takes and applies a RespectImageOrientationEnum argument. This should allow to (finally) eliminate the IntrinsicSize(...) method from ImageResourceContent. Bug: 773272 Change-Id: I031cfe735ebf285405c240e294686f755b7e0c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991564Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#729680}
-
Oriol Brufau authored
r728012 allowed <summary> elements to be list items and originate a marker when they have 'display: list-item'. This was not bad, since actually they are supposed to be list items by default. However, currently they aren't, so their disclosure symbol is not really a ::marker (bug 590014). Therefore, if they are styled with 'display: list-item', they originate a real ::marker, so they seem to have two markers. This patch fixes the problem by computing 'display: list-item' to 'display: block' for <summary>. This is just a temporary adjustment until bug 590014 gets fixed. BUG=1038644 TEST=external/wpt/html/rendering/the-details-element/summary-display-list-item.html TEST=fast/css/usecounter-summary-display-block.html Change-Id: I868752fc32fcc5e6a72f94841583ead7dbc997ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991445Reviewed-by:
-
Hayato Ito authored
This CL is the part in a series of CLs, roughly described as follows: 1. Refactor SeriviceWorkerTimeoutTimer Unify normal events and pending tasks. 2. Rename SeriviceWorkerTimeoutTimer to ServiceWorkerEventQueue. 3. Further clean up ServiceWorkerEventQueue. 4. Support offline events in ServiceWorkerEventQueue 5. Support offline mode in ServiceWorkerGlobalScope 6. Provide a high layer API to check SW's offline capability (<= this CL.) This CL implements a high layer API, |ServiceWorkerContext::CheckOfflineCapability(url, callback)|, which is intended to be used from clients, such as Add2HomeScreen feature, who want to know SW's offline capability. A callback receives enum, |OfflineCapability|, whose meaning is: - kSupported: SW exists for the url, and its fetch event handler can return a 200 result even in offline mode. We consider SW has an offline capability in this case. - kUnsupported: Any other cases, such as: - SW does not exist. - SW's fetch handler can't return a 200 result in offline-mode. - internal errors such as disk failures, timeout, and etc. Bug: 965802 Change-Id: If68cfeea2f3337b88a53a3cf0fd6ac87ee3bd66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900804 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729678}
-
Huanzhong Huang authored
Part of the new clear browsing data dialog cleanup effort. This change prunes no longer needed code, reflecting the now simplified code path and the removal of the CBD collection view. Bug: 947456 Change-Id: Ic4810e2697444d5301f0b866f31006b31f9e8219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985002 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729677}
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on both HALv1 and v3 devices. Change-Id: If66296d9caa12171a390066ca7630aba3323982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986484Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#729676}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dcb1cc6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic5b212d2cc1e8dd8a225f5784e8ab946fccc6410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992525Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c30f07c..065d0bc7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6777bb1926e1273b7d8a598c5d6dfefc03a6c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992527Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729674}
-
Yoshifumi Inoue authored
This patch makes |NGAbstractInlineTextBox| to handle both |NGFragmentItem| and |NGPaintFragment| by utilizing |NGInlineCursor|. This patch reduces web tests failures of accessibility/ from 18 to 1. Note: This patch enablies |LayoutObject::FirstInlineFragmentItemIndex()| partially. It is used for deattaching |NGAbstractInlineTextBox| but not for caching for fast traversing |NGInlineCursor::MoveToNextForSameLayoutObject()|. Following patch will enable it. Bug: 982194 Change-Id: Ic95739e355c14487a21044c3a360a3014f37dceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941651 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Polina Bondarenko authored
Set up a CertStoreBridge between arc-keymasterd and chrome to allow arc-keymasterd to use the keys accessible by chrome. Add SecurityTokenOperationBridge that implements SecurityTokenOperation and performs the signature of pre-hashed digest using security token certificates. Bug: b:119914122 Test: ./unit_tests --gtest_filter=SecurityTokenOperationBridgeTest* Test: local device Change-Id: I791ab28ab639b85652ae4ccaf0b3d4f8fb37ae83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852447Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#729672}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/geometry only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - ImageBitmap::Create Bug: 939691 Change-Id: I7de5efe568fee9355659e22661b615217769e787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969282 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#729671}
-
Jinsuk Kim authored
Adds UMA histogram for BottomSheet-based preview tab. Only takes care of the state transition-related events that are already logged for OverlayPanel-based one. Bug: 1025081 Change-Id: Ib4273067bdcbc88baf77521f0f9eaef4dba7857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984796Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#729670}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::SetTextWithOffset()| not to reuse existing data because we can't figure out insert position of bidi control codes before/after editing. Example: For <pre><b dir=ltr>\nXYZ</b></pre>, we have \u2066\u2069\n\u2066XYZ\u2069 after removing "\n", we have \u2066XYZ\u2069 Bug: 1039143 Change-Id: Iba443f0228bece9e8b08fc8f49d827565073d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991037 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/webcodecs. Bug: 1001114 Change-Id: I43b29101ae577c2e5e2a94a8d02e5e02a4503f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986472Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#729668}
-
Ting Shao authored
This change adds tests for measuring the performance of open, add, and delete APIs of Cache Storage. Also adds support for running tests in workers. Design doc: https://docs.google.com/document/d/1bGBWHAsIsrQ0hrjU7oEVAcGSBS9gFSPcDL9nVWXDeeE/edit Bug: 1019097 Change-Id: Ib173c699cda3ae9984ff20500e81b666b49d4e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935928 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#729667}
-
Miyoung Shin authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/core/streams/underlying_sink_base.idl. Bug: 1001114 Change-Id: I81c3012edec1c110e358e520f53d717313c0ed19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986475Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#729666}
-
Takuto Ikuta authored
Before rename, let me remove 'ChromeOS Swarm'. This does not have appropriate setup now. Bug: 955013 Change-Id: I5a520236b01dc969b041b6b6db6c2ef7bff37900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992950 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#729665}
-
Rijubrata Bhaumik authored
This CL adds some documentation for the NFC module in Chrome. The detailed design documentation is located at https://sites.google.com/a/chromium.org/dev/developers/design-documents/web-nfc and the READMEs do reference that document for more details. Bug: 520391 Change-Id: Ib8b7632d0bf9bba2b3de9fb1b9bf4f528fa11162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985961 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#729664}
-
Marc Grimme authored
This is a reland of f1f1258e Original change's description: > Fixed overwriting of static default_policy_hosts > > The default policy for allowed or blocked hosts is overwriting > from different contexts(profile) and can lead to wrong policies > being applied to extensions (see bug #1028577). > > This fix creates a static map that stores the profile (by id) and the > relevant default_policy_allowed_hosts/default_policy_blocked_hosts in > a struct. > > TODO: > Write integration tests (crbug.com/1031179) > > R=marcgrimme > > Bug: 1028577 > Change-Id: Ie08447ddd5175562b474fa5801f6959315372c6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946368 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Marc Grimme <marcgrimme@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726333} R=marcgrimme Bug: 1028577 Change-Id: Icf51024c16c110ae71a7d7100714ced3100b0055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978680Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#729663}
-
Koji Ishii authored
This patch supports hit-testing culled inline boxes by leveraging |NGFragmentItem| generated for them by <crrev.com/c/1774425>. This patch recovers the most of regressions in the CL, in addition to fixing ~70 failures. Bug: 982194 Change-Id: I094a77440e5040fcd5a2d8f864c4d95d85925fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989727 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Theodore Olsauskas-Warren authored
To support the display of recently changed permissions to the user as part of the the privacy settings redeisgn, the ability to query when a permission was embargoed is needed. This CL introduces a GetEmbargoStartTime function in the permission auto blocker that facilitates this. Bug: 1032584 Change-Id: I04da71522175a8e59051b45e7573bd65468e78cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983216 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#729661}
-
Hiroki Nakagawa authored
This fails on win bots: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/43765 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/98722 Bug: 946023 Change-Id: I59c01572ffbf33416fb3c13d44234281bc3330e2 Tbr: crouleau@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993064Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#729660}
-
Daichi Hirono authored
When accessibility event from Android does not fulfill correct task ID, ArcAccessibilityHelperBridge uses window ID as an identifier of surface instead. BUG=b:146591913 TEST=None Change-Id: I8a5a4750e02de3a2fa22b673c9018d02cc6d8592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982507 Commit-Queue: Daichi Hirono <hirono@chromium.org> Auto-Submit: Daichi Hirono <hirono@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#729659}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92ca3baba6a5..1d457b7d9533 git log 92ca3baba6a5..1d457b7d9533 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 61f03e9a..5d178c93 (411 commits) 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 45a4d0f36bd6..77c89ff847b6 (13 commits) 2020-01-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 db49bc7dd075..c431d59626e1 (7 commits) Created with: gclient setdep -r src/third_party/skia@1d457b7d9533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Id2e168e6c30ed64174239a2863dc93114047c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992703Reviewed-by:
-
Christopher Lam authored
Bug: 1036932, 1037124, 1037000, 1037295 Change-Id: I99d7265fb4a8af9bc4ef19d1ac61bef2e06643ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988089 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes to generate |NGFragmentItem| for culled inline boxes. In common cases, inline boxes are not needed for paint purpose, and that we suppress generating |NGPhysicalFragment| for them. However, hit-testing, |getClientRects()|, and some other scenarios require the coordinates of such inline boxes. Synthesizing it saves memory, but has drawbacks in the performance, the correctness, and the code complexity. With this change, we always generate |NGFragmentItem|, while |NGPhysicalBoxFragment| is still suppressed when possible. Some related code need to change accordingly; e.g., hit- testing and |NGInlineCursor|. ~120 new failures are due to the lack of these changes. They will be fixed in following patches. Bug: 982194 Change-Id: I53a336952202087abb0f80214354d092e970a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774425 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Glen Robertson authored
Split out from subsequent CL crrev.com/c/1897398 plus surrounding cleanup. Mostly refactoring except: -remove deprecated metric logging. -diverge when the "Open in PWA Window" menu item is enabled. Previously this used the same CanCreateWebApp check as "Create Shortcut" and "Install <PWA>". The presence of this item is already controlled separately (by checking whether the page is in scope of a PWA) so most of the checks in CanCreateWebApp are redundant. The relevant checks are within AreWebAppsUserInstallable (but just calling that method is answering a different question). So copied body of AreWebAppsUserInstallable. Subsequent CL will modify CanCreateWebApp. Change-Id: Ib2a32b74637be89b6ac230f4d046e31316512680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989739 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#729655}
-
Jinsuk Kim authored
There is a timing issue that keeps the desired bottom sheet content height from being set correctly if tab switcher is invoked between device rotation. The activity tab from which the desired content height is obtained can be still be null when the height change occurs. Currently the related logic does nothing in this case, and the following layout change events cannot update the height either, since they see no change in the height. Therefore, BottomSheet.mContentDesiredHeight retains the old value in |ensureContentDesiredHeightIsComputed|, not being able to get updated with the right value. This CL fixes it by keeping track of the current content height, and updating it when a valid height is available. Bug: 1039204 Change-Id: Id173e90ac35bc3177f647f3c937da61089de7516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989305 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729654}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8d82854..1c30f07c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If24e11f16a7e67bfe4f13ce4b0cc1cc80993ebc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992524Reviewed-by:
-
Miyoung Shin authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/screen_orientation. Bug: 1001114 Change-Id: Ie5d342d6a2a78bb9f44345e7ef61322a188f6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986478Reviewed-by:
-
Kent Tamura authored
Move Node::DispatchInputEvent() and HTMLFormControlElement::DispatchChangeEvent() to HTMLFormControlElementWithState Only subclasses of HTMLFormControlElementWithState require 'input' and 'change' events. This CL has no behavior changes. Change-Id: Iefe8b128c4b63cc95dc27d660064ad8cec3b4f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990892Reviewed-by:
-
Yoichi Osato authored
This patch makes some parameters |const T&| than |T| to avoid unnecessary copy. Bug: 787704 Change-Id: I914043a82192c18a3db535c77a3a29ab742fd1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989319Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#729650}
-
