- 20 Aug, 2019 40 commits
-
-
minch authored
Color for the auto click menu button is actually SK_ColorWHITE, 10%, not kUnifiedMenuButtonColor (gfx::kGoogleGrey200). Color for the separators between scroll pad buttons is actually ../Base/Content/Separator, kScrollpadStrokeColor is not needed. See spec: https://spec.googleplex.com/crosux-spec/feature-specs/accessibility-auto-click.html And the color of kStackingNotificationCounterLabelColor (0x5f, 0x64, 0x68) is actually should be gfx::kGoogleGrey700 (0x5F, 0x63, 0x68). See spec at https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQpLhKoE-Okp/files/MCH8Xi1gx9PQWEsGsKPbLGpxwMSJbxAVNpw Bug: 982950 Change-Id: I4fdb7538b174964d1a9130fedee2f418128ee6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761211Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688703}
-
Kristi Park authored
CSS variables cannot be used in pseudo elements. Bug: 995664 Change-Id: Id607d2b27ba65fd1ca056a89976def2251ea7dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762577 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bbfec9db84cf..916a904fb7f2 git log bbfec9db84cf..916a904fb7f2 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 jlavrova@google.com Placeholders implementation + unit tests 2019-08-20 reed@google.com make pathiter bench a little more realistic 2019-08-20 halcanary@google.com RELEASE_NOTES: note change to SkMallocPixelRef 2019-08-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@916a904fb7f2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I0a319c34a907fa3bcb1528ffb705034f5036fecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688701}
-
Nina Satragno authored
Add the `RemoveAllCredentials` WebAuthn command to ChromeDriver. This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: I2fd4ec95163487f955b746db8044f98aa9dd90db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761484Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#688700}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1749845 inadvertently removed the ability to change the current tab model before tab models have been initialized. This CL fixes that by refactoring how initial incognito state is set when the tabmodelselector is initialized. Bug: 995680 Change-Id: I1136d1365078db50decd5868f12445bdbfad65a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761485 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688699}
-
Yang Guo authored
Currently we always drop the last trace event due to the way the time range for a process is computed. Change-Id: I1c68d73269753ef90b2c95cbb654ffb20af5ef59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751189Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688698}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/428149962b00..0d7ff782762c git log 428149962b00..0d7ff782762c --date=short --no-merges --format='%ad %ae %s' 2019-08-20 simonhatch@chromium.org Dashboard - Rework update_test_suite_descriptors a bit. Created with: gclient setdep -r src/third_party/catapult@0d7ff782762c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:992162 Change-Id: I59b64502b94f128c89cba62fe4d1bed54d946c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688697}
-
Haiyang Pan authored
win-10-perf, linux-perf, mac-10_13_laptop_high_end-perf, and android-pixel2-perf Commands used to update/generate the data are: src/tools/perf/generate_perf_data src/tools/perf/generate_perf_sharding update \ -b win-10-perf \ -b linux-perf \ -b mac-10_13_laptop_high_end-perf \ -b android-pixel2-perf Bug: 954861 Change-Id: Ia22c8b5b07d61b1eed186f21c5ad85d522f7fedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756090 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#688696}
-
Madeleine Barowsky authored
This change attaches a string |image_type_| to ScopedImageDecodeTasks, representing the file extension of the image to be decoded. When the task is complete and the destructor records the duration, we record an additional UMA if it's a WebP image called Renderer4.ImageDecodeTaskDuration.WebP.{Software, Gpu}. Bug: 966008 Change-Id: I4f7d3837df94facbb637c0402c6bcce66aae2a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760875Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688695}
-
Tommy Steimel authored
This CL modifies the logic for enabling GMC by default. This fixes an issue where GMC was enabled by default on ChromeOS. Bug: 995836 Change-Id: I6b38423043a9c50480dc255eb9a12dc2500cb714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761779Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688694}
-
Nick Harper authored
The HSTS header served by bitbucket.org now has the includeSubDomains directive as well as preload, so it can be moved to the bulk entries section of the preload list and set the include_subdomains flag. Change-Id: I3ec1a1b4c10f00fc1696760c72be602775ccc949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761521 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688693}
-
Lan Wei authored
In ExecutePerformActions function, we dispatch key events first, mouse events then touch events, but we should dispatch whatever actions come first in the action sequence. This CL changes high level of structures of processing actions and dispatching events in the action sequence, and I still need to refactor some details when procession the actions in a following CL. Bug: 606367 Change-Id: I46e02e547d0e5d5c2ddcdc949efc6b141142ea2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759855Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#688692}
-
Daksh Idnani authored
On dual-GPU machines, we should ensure that the high-performance GPU is active during WebGL conformance tests. Bug: 985486, 984780, angleproject:3701 Change-Id: I93280f9335d919af9fbbf77e008dd3582a20c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761430 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688691}
-
Maggie Chen authored
This reverts commit 752f7f2c. Reason for revert: <Watchdog V2 causes crashes in the bots and it falls back to SwiftShader. bug 995372> Original change's description: > Enable GpuWatchdogV2 in Field trial testing for all platforms > > Bug: 949839 > Change-Id: I5939069144719c501209af3cda3b7693f61f8866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682315 > Commit-Queue: Maggie Chen <magchen@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688375} TBR=isherman@chromium.org,zmo@chromium.org,magchen@chromium.org Change-Id: I2f64da411b2289265c1a9657fae85c083953bfb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761559Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688690}
-
Gabriel Charette authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 for the task traits additions that were already LGTM'ed. TBR=fdoray@chromium.org Bug: 968047 Change-Id: I2dc33aadae040b12e58157c80c343a055ed441f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762417 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688689}
-
Sammie Quon authored
It's only used for ash, but I think it makes most sense to be in transform_util.cc. Test: added test Bug: none Change-Id: I6cef151a97a1841e57db17083320bd444bb24b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#688688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f624b9be..15b9f9d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5079b45577a3365d646820b164e92a0ea33e9b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688687}
-
Lutz Justen authored
Tickets should be forwardable by default to match the behavior for Chromad. This was an oversight. BUG=None TEST=Tested manually that getting tickets still works Change-Id: If35ba1d73e4348c3d87f6a685d509c24bdf5f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753929Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#688686}
-
Koji Ishii authored
This patch moves |EnsureNodeId()| to inside of |NGTextFragmentPainter::Paint()| from its callers. All callers do the same preparations, this unifies them Bug: 924681 Change-Id: I3f0ca7d1ca418943604254ffd425df4e9edb7c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761872 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688685}
-
Ryan Powell authored
This CL creates the SystemMemoryPressureEvaluator for ChromeOS, as part of a refactoring of the MemoryPressureMonitor to use the Voter-Aggregator design described here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714#heading=h.7nki9mck5t64 This Evaluator calculates memory pressure and emits notifications identically to the previous Monitor, but does so by casting its votes for memory pressure through a MemoryPressureVoter. Bug: 980965 Change-Id: I0b3d9caa19ede5474ef1bae04be43fd5a9334869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756765 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688684}
-
Malay Keshav authored
This patch replaces the use of apng animation file (580 KiB) with a lottie animation file (8 KiB). Bug: 976057 TEST: Manually navigated to the animation page Change-Id: I4c8fa8784b1e2bd1be071752eae8696f58c66737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725235 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688683}
-
Gabriel Charette authored
Partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 Extracted HasTraits() modification to make revertable part of the desired change as small as possible. TBR=fdoray@chromium.org Bug: 968047 Change-Id: I9683326cceee53164e4482d71cf6929296a8db7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762332 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688682}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f878992e96bd..35815c5fbd26 git log f878992e96bd..35815c5fbd26 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 saklein@chromium.org Revert "AndroidService: Refactor uprev and unpin endpoints." 2019-08-20 cjmcdonald@chromium.org Migrate DepgraphGenerator to separate library 2019-08-20 dhanyaganesh@chromium.org config: Make fizz-moblab experimental 2019-08-20 mmortensen@google.com Update gen/chromite/api/binhost_pb2.py for PrepareDevInstallBinhostUploads. Created with: gclient setdep -r src/third_party/chromite@35815c5fbd26 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8257e433812a2faf619f4cfb36bc25830d33246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688681}
-
Yi Gu authored
VizHitTestSurfaceLayer will go 1% on stable in M77 (SR: Sep 10). In case that it cannot be fully shipped in M77, it's better to have the flag available in M78 (branch Sep 5) and M79 (branch Oct 17). Bug: None Change-Id: I0db79a07667ce18bafa66b6fd2f2e7a4b5f6aab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762580 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#688680}
-
Aaron Leventhal authored
Defer the menu start event, so that it does not conflict with form control focus announcements. Bug: 990476 Change-Id: I3c2559080aa8ccde5e515977077ae8dd08ce251f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758587Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688679}
-
Madeleine Barowsky authored
YUV decoding is rolling out across platforms and bots for certain kinds of WebP images (crbug.com/900264). Because we do not yet (crbug.com/943519) support caching YUV decoders to incrementally decode an image as more data arrives, this can cause flakiness of the final web_tests image because the YUV and RGB shader results differ by a couple of pixels [1]. Thus we use JavaScript to preload images in web_tests that may go down the YUV path before decoding them. Because this makes the test asynchronously modify the DOM, we refactor the tests to use testRunner.waitUntilDone() to ensure all images have been decoded and added to the page before capturing pixel results. These modified tests are moved under images/yuv-decode-eligible/. Also, the gpu-rasterization virtual test suite now forces YUV decoding for the images/ directory because we intend this to become the default path. However, there will still be cases for RGB decoding and GPU rasterization, so this change maintains coverage by adding virtual/gpu-rasterization-disable-yuv. We update test expectations and baselines for those tests and suites affected by this change, committing deterministic results about which images currently go down the YUV or RGB decoding path. [1]: https://test-results.appspot.com/data/layout_results/win7-rel/130854/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html See webp-no-color-profile-lossy.html. Bug: 981137, 943519, 730267 Change-Id: I6f783833489b116a4d64c8853fe63323f4236f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700112 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#688678}
-
Malay Keshav authored
This patch introduces a new polymer element for chrome OS that is responsible for running lottie animations on a third party player on a worker thread. Added unit tests. Bug: 976057 Change-Id: I32323d758e432d7506fed6d9346b019cd9234653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725322 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688677}
-
Zinovy Nis authored
Bug: 994915 Change-Id: I2e1bcf286a2d2fa6613e18b5268098a0d258fb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759163 Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#688676}
-
Junbo Ke authored
Change-Id: I900f6f167ce35947be9c0908d2920fa9ddadd327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761442Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688675}
-
Connor Clark authored
Bug: 981495 Change-Id: Ide73a699c3bc4cb06e05623778a6c41a91af6163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761216Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#688674}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. LGTM from all OWNERS. Using NOPRESUBMIT since aleloi does not have permission to CR+1 NOPRESUBMIT=true Bug: 977050 Change-Id: Ibae0ce78a7866e011c30ad9c252cbcfe6a9bd823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700921 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688673}
-
Malay Keshav authored
Lottie player runs on a worker thread to paint on an offscreen canvas. To enable this on chrome internal pages the content security policy needs to be modified. This patch adds a virtual method that can be used to add content security policy for worker source url. A Worker thread is initialized here: https://chromium-review.googlesource.com/c/chromium/src/+/1725322 Bug: 976057 Change-Id: I91ad1c46c86475d496e6b5b993d9523f12736607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724865Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#688672}
-
Kurt Horimoto authored
OverlayPresentationContext::CancelOverlayUI() has no guarantees that the UI being cancelled has been requested yet. For example, the referenced crash occurs when cancelling a queued request whose UI has never been shown. The previous code assumed that CancelOverlayUI() was only ever called for OverlayRequests for which ShowOverlayUI() has been called previously. This CL updates the logic to early return if it's called for requests that haven't been passed to ShowOverlayUI(). Bug: 991614 Change-Id: I63532e13a32c10498901ae9b70082ded1b348c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762354 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#688671}
-
Kazuki Takise authored
Along with the changes to move always on top to ARC attributes in Android, this CL integrates always on top into commit logic in exo. For PIP, as we want to ensure that always on top is toggled after window state and bounds changes have been done, we update always on top in onPostWidgetCommit. BUG=b:138768141 BUG=b:138741400 TEST=Manually confirmed always on top works properly with ArcCompanionLibDemo TEST=Manually confirmed YouTube doesn't flicker when entering PIP Change-Id: I22dbad22985bd6e0249b207509e1b0563486edbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732703Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#688670}
-
Akihiro Ota authored
This change allows kMenuItems to be valid children of kMenuListOption elements for PosInSet and SetSize calculations. The motivating example for this change was navigating through the app menu in the Chrome toolbar using ChromeVox(the menu that contains buttons for new tab, history, downloads, bookmarks, dev tools, etc.). ChromeVox would report PosInSet and SetSize of 0 for many elements, due to the fact that the elements are held within a kMenuListOption, not a kMenu. In the PosInSet and SetSize code, we have checks to ensure valid parent-child relationships. This is a case that must have been missed in the initial implementation. Change-Id: I8ab6182862cb9a4112d525044046a1e15048fc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757467 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688669}
-
Victor Fei authored
Added UIA_IsDialogPropertyID to AxPlatformNodeWin::GetPropertyValue and associated unittests. Bug: 844149 Change-Id: Iebdc0a6227022bb27c355b799f40a9480d3ee7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757887Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688668}
-
Nicolas Ouellet-payeur authored
The new `python_script' backend for network annotation buildbots checks calls to CreateMutableNetworkTrafficAnnotationTag(), except for whitelisted files. This CL updates the whitelist for the upcoming migration to the new backend. TBR=rhalavati@chromium.org Bug: 966883 Change-Id: Ib61fa214230a45b8d638f0626c3c2c9dfb5ab1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760886 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#688667}
-
John Budorick authored
includes: - new footer syntax - correct links to commit-queue.cfg - description of how to configure partial CQ bots Change-Id: I3ba27a6abbe20186d5e3a094737a5f24dbf9e1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761742Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688666}
-
John Lee authored
This layers the Settings page's main contents above the toolbar such that the main content is interactable no matter how far the toolbar's text overlaps the main content. Bug: 995686 Change-Id: Id8e244a47a13f19c13b47ce86e8b44afc6255524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762062Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#688665}
-
Julie Jeongeun Kim authored
This CL converts RendererPreferenceWatcherPtr and RendererPreferenceWatcherRequest to new Mojo types. It updates CreateSharedWorker from shared_worker_factory.mojom and all methods and members for RendererPreferenceWatcher to new Mojo types. Bug: 955171, 978694 Change-Id: Ic7c2a1482d5b758e11a6ba48e4809d0542092247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760580 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688664}
-