GitLab

Everything goes through mailboxes when used with this context.

R=piman@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1898423005

Cr-Commit-Position: refs/heads/master@{#388618}

BUG=None

Review URL: https://codereview.chromium.org/1905783002

Cr-Commit-Position: refs/heads/master@{#388617}

BUG=554298

Review URL: https://codereview.chromium.org/1902873002

Cr-Commit-Position: refs/heads/master@{#388616}

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org

Review URL: https://codereview.chromium.org/1904823002

Cr-Commit-Position: refs/heads/master@{#388615}

Sometimes, a machine goes down, but the waterfall stays green. We want the perfbot health sheriffs to watch out for these kinds of failures.

Review URL: https://codereview.chromium.org/1903913002

Cr-Commit-Position: refs/heads/master@{#388614}

There was one reference to Document::layoutView() (hitTest() method)
which is deprecated by the new layout API. I converted it to use
layoutViewItem() instead. No new API methods were required.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1908573003

Cr-Commit-Position: refs/heads/master@{#388613}

BUG=

Review URL: https://codereview.chromium.org/1896363003

Cr-Commit-Position: refs/heads/master@{#388612}

Additional to the original, this CL checks for >=OSX10.9
in content/common/gpu/media/vt_video_encode_accelerator_mac.cc
since VideoToolbox HW features are introduced there.
The original CL got reverted because of a failure on a bot running 10.8.5.
https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_9/VideoToolbox.html

Original CL description:
https://codereview.chromium.org/1852523002/
This CL enables using VideoToolbox encoder when
kWebRtcH264WithOpenH264FFmpeg flag is on.

BUG=597334
TBR=mcasas@chromium.org, hbos@chromium.org

Review URL: https://codereview.chromium.org/1886363002

Cr-Commit-Position: refs/heads/master@{#388611}

BUG=554298
R=ben@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/1910673002

Cr-Commit-Position: refs/heads/master@{#388610}

On Windows 8, now make sure the required registry key exist so that
Chrome is always given as an option when poping the intent picker.

On Windows 10, now shows the system settings to the user to set the
default handler for a given protocol.

Also fixed a small UI issue.

BUG=562671

Review URL: https://codereview.chromium.org/1896513002

Cr-Commit-Position: refs/heads/master@{#388609}

This CL adds Google Activity Controls preference in setting sign in account management screen and an icon for sync preference.

BUG=595349

Review URL: https://codereview.chromium.org/1880203002

Cr-Commit-Position: refs/heads/master@{#388608}

The first step to emulate ES3 BindBufferRange semantics on
Desktop GL 4.1 or lower.

BUG=604436
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1905743002

Cr-Commit-Position: refs/heads/master@{#388607}

If someone adds a resource then it should be in the ResourceBundle.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1905553003

Cr-Commit-Position: refs/heads/master@{#388606}

This function is not called.

R=piman, sievers

Review URL: https://codereview.chromium.org/1906693002

Cr-Commit-Position: refs/heads/master@{#388605}

Currently we have only one type of BluetoothGattService,
BluetoothGattCharacterstic and BluetoothGattDescriptor. Each of these objects
have significantly divergent functionality depending on whether they are
objects representing a remote or local version. For example, ReadRemoteValue
or WriteRemoteValue makes no sense on a local characteristic. Similarly,
delegates for receiving read/write requests for characteristics and
descriptors doesn't make any sense for a remote service. Trying to accomodate
this led to very ugly code with lots of NOTIMPLEMENTED()s, varying
implementations of the same code and a lot of repeated but unused code.

Seperating these out into remote and local interfaces allows us to have platform
specific implementations which only contain code relevant to remote and local
objects (with common implementation deriving the common interface).

This is just a refactor with no actual code change. To keep reviewing easier,
any fixes to the code that is being moved around is being reserved for other
CLs.

This CL also moves all BlueZ specific code into its own directory. We should
do the same for other platforms too so the //device/bluetooth directory isn't
as crowded.

Reviews requested,

OWNERS (should most probably be rubberstamps),
chrome/browser/extensions/api/* - rockot
components/arc/bluetooth/* - elijahtaylor,lhchavez
components/proximity_auth/* - tbarzic

scheib/ortuno for the general review.

R=elijahtaylor@chromium.org, lhchavez@chromium.org, ortuno@chromium.org, rockot@chromium.org, scheib@chromium.org, tbarzic@chromium.org
BUG=601935

Review URL: https://codereview.chromium.org/1898643002

Cr-Commit-Position: refs/heads/master@{#388604}

BUG=554298
R=tnagel@chromium.org

Review URL: https://codereview.chromium.org/1902633006

Cr-Commit-Position: refs/heads/master@{#388603}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2a883daa..d48fa2bb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1901103005

Cr-Commit-Position: refs/heads/master@{#388602}

Also fix some typos.

Review URL: https://codereview.chromium.org/1900033005

Cr-Commit-Position: refs/heads/master@{#388601}

The swarming/isolate system copies the built remoting_me2me_host
executable, preserving the filename, so make sure this script can still
find it in tests.

Review URL: https://codereview.chromium.org/1903503006

Cr-Commit-Position: refs/heads/master@{#388600}

1. Some sites result in an accessibility tree as follows:
link name=foo children=(heading, paragraph)

We end up reading the link's name when reading the children
(e.g. bar heading 1, foo link

This becomes noisy across multiple instances of this structure across a page.

The nameFromNode attribute only adds the name if it isn't computed based on the contents of the node.

2. Content editables containing spaces come through as non-breaking spaces. In particular, this is seen in Google Docs. Add the literal string for the space so we read it when navigating by character.

TEST=navigate to sites containing links with complex children. Ensure we don't read the link's name.
Navigate by character in Google Docs with braille mode on in chromeVox Next. Ensure we read the space.

Review URL: https://codereview.chromium.org/1866043004

Cr-Commit-Position: refs/heads/master@{#388599}

ContentLayerDelegate::paintContents() is being used as an alternate
painting path by the rasterize and record microbenchmark. This benchmark
can crash if any frame on the page is being throttled, because this
way of painting doesn't enable throttling. This patch fixes that by
enabling throttling, which also makes the benchmark more realistic since
the real painting path also uses throttling.

BUG=600377
TEST=tools/perf/run_benchmark rasterize_and_record_micro.top_25_smooth --browser=debug --story-filter=Blogger

Review URL: https://codereview.chromium.org/1898813002

Cr-Commit-Position: refs/heads/master@{#388598}

BUG=585312

Review URL: https://codereview.chromium.org/1894173002

Cr-Commit-Position: refs/heads/master@{#388597}

For context, see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/zJZPkxEFVxY

For the things to look out for while reviewing this, see the doc https://docs.google.com/document/d/1qjSBV2ioi0mykAT1eSXuMaNqO0BIS-j1PeYfxT-TbW4/edit?usp=sharing

BUG=597321

Review URL: https://codereview.chromium.org/1842653006

Cr-Commit-Position: refs/heads/master@{#388596}

https://chromium.googlesource.com/skia.git/+log/9134686fd9ce..650f9e9a2630

$ git log 9134686fd..650f9e9a2 --date=short --no-merges --format='%ad %ae %s'
2016-04-20 mtklein SkOnce: 2 bytes -> 1 byte

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/1910483003

Cr-Commit-Position: refs/heads/master@{#388595}

This test is for detecting an error caused by a compiler
bug on Windows (which is now worked around by
crrev.com/1878963005).

I've verified that the test is failing without the
workaround by temporarily undoing it (by switching the optimization from speed to size).

BUG=599427

Review URL: https://codereview.chromium.org/1897383004

Cr-Commit-Position: refs/heads/master@{#388594}

There are several references to Document::layoutView(), which is deprecated
by the new layout API. I converted them to use layoutViewItem() instead. I
added LayoutViewItem::invalidatePaintForSelection() to the API.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1885373005

Cr-Commit-Position: refs/heads/master@{#388593}

BUG=604495
R=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/1902573002

Cr-Commit-Position: refs/heads/master@{#388592}

This change adds the ability for the filter UI to present the user with the
option to create a new sink that is named with the currently entered search
text if any route providers support this. This change adds all the necessary
wiring for the UI to talk to the Media Router and for the Media Router to talk
to the MRPM extension. Additionally, a route will be created to the currently
selected media source if a sink is found.

BUG=565696
R=amp@chromium.org,imcheng@chromium.org,apacible@chromium.org,mfoltz@chromium.org,isherman@chromium.org,avayvod@chromium.org

Review URL: https://codereview.chromium.org/1805813002

Cr-Commit-Position: refs/heads/master@{#388591}

These are (very) temporary because we'll use the Mojo types everywhere,
but they'll make the initial transition to Mojo significantly easier.

BUG=595685

Review URL: https://codereview.chromium.org/1898193003

Cr-Commit-Position: refs/heads/master@{#388590}

R=piman@chromium.org
BUG=582564 582558 582554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1892303003

Cr-Commit-Position: refs/heads/master@{#388589}

Review URL: https://codereview.chromium.org/1659323003

Cr-Commit-Position: refs/heads/master@{#388588}

StyleResolver (used for building the font that gets used
during filter construction) and StyleResolverState (used
for filter construction) both currently assume the
existence of a frame.

BUG=603830

Review URL: https://codereview.chromium.org/1903613002

Cr-Commit-Position: refs/heads/master@{#388587}

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230

Review URL: https://codereview.chromium.org/1903183003

Cr-Commit-Position: refs/heads/master@{#388586}

Change the cancelable flag to be an enumeration so that we
can determine if it is blocking or non-blocking and the reason.

Wheel events will add this flag in a follow up CL.

BUG=601661

Review URL: https://codereview.chromium.org/1888163003

Cr-Commit-Position: refs/heads/master@{#388585}

https://chromium.googlesource.com/skia.git/+log/36db3f44b6cd..9134686fd9ce

$ git log 36db3f44b..9134686fd --date=short --no-merges --format='%ad %ae %s'
2016-04-20 mtklein Revert of SkOnce: 2 bytes -> 1 byte (patchset #4 id:60001 of https://codereview.chromium.org/1904483003/ )
2016-04-20 msarett Add SkEncodedInfo to report properties of encoded image data
2016-04-20 robertphillips Begin removing deprecated (and now, unused) ImageFilter code paths
2016-04-20 robertphillips Fix ImageFilter fuzzer issue
2016-04-20 mtklein SkOnce: 2 bytes -> 1 byte
2016-04-20 brianosman Get skiaserve working on Windows.
2016-04-20 jvanverth Revert of Use transfer buffer for BatchAtlas texture copies (patchset #9 id:160001 of https://codereview.chromium.org/1888473002/ )
2016-04-20 bungeman SkTArray movable and swap for move only elements.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/1899943006

Cr-Commit-Position: refs/heads/master@{#388584}

The original code encodes the PNG and sends the buffer over to the
renderer. The renderer then registers a blob with that buffer, which
transfers all the data back to the browser. Then the data is copied back
over to the renderer when the page tries to read the image/png
DataTransferItem.

Instead of sending the data back and forth so many times, just register
the blob directly in the browser process.

On a 1366x768 test image, there's no measurable difference: it takes
~0.125s to execute DataTransferItem::getAsFile() for an image.

On a 4000x4000 test image, there's a small difference: the old version
takes ~9.1s and the new version takes ~8.9s. It turns out memcpy is
pretty fast!

BUG=none

Review URL: https://codereview.chromium.org/1876653003

Cr-Commit-Position: refs/heads/master@{#388583}

Refactors SourceBufferStream::FindNewSelectedRangeSeekTimestamp() to be more
readable and to handle a few edge cases when the last read position has been
removed and new buffers are appended. Includes new tests for the edge cases.

BUG=140875

Review URL: https://codereview.chromium.org/1898373002

Cr-Commit-Position: refs/heads/master@{#388582}

Add bindings for EGL_ANGLE_stream_producer_d3d_texture_nv12,
EGL_KHR_stream, EGL_KHR_stream_consumer_gltexture, and
EGL_NV_stream_consumer_gltexture_yuv.

BUG=574292

Review URL: https://codereview.chromium.org/1903063002

Cr-Commit-Position: refs/heads/master@{#388581}

It should be true if the GL context supports it, and off otherwise.
Lying isn't helpful.

It was added in the initial blimp/ commit, without discussion about
why it was there, though it was at least considered as it came up
here: https://chromiumcodereview.appspot.com/1295243003/diff/20001/blimp/client/compositor/blimp_context_provider.cc?_ga=1.66997032.780449993.1417466767#newcode101

R=dtrainor@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1898983003

Cr-Commit-Position: refs/heads/master@{#388580}

The gn built mini_installer was failing on Windows 10. This was
because the mini_installer was inadvertently launching Chrome when it
was not supposed to. This in turn was because setup.exe was missing its
manifest and therefore thought it was running on an earlier version of
Windows and therefore tried to pin Chrome's shortcut which on Windows 10
launches Chrome through a separate thread that runs inscrutable shell32
goop.

Messy problem, trivial fix.

BUG=604752

Review URL: https://codereview.chromium.org/1900343005

Cr-Commit-Position: refs/heads/master@{#388579}