- 23 Jan, 2019 40 commits
-
-
Kristi Park authored
Support dark mode colors for the gear dialog and the custom background dialog. Screenshots: https://screenshot.googleplex.com/ragisEWgh7Y.png https://screenshot.googleplex.com/Xg85JK8n9PK.png https://screenshot.googleplex.com/bTTH2f44Q6t.png Bug: 919961 Change-Id: I789bf56506ef8aee9225f27b8990244c7898c0ea Reviewed-on: https://chromium-review.googlesource.com/c/1427621Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625294}
-
Jordan Demeulenaere authored
[Autofill Assistant] Header, Details, Carousel, PR coordinators are now instantiated by BottomBarCoordinator. Change-Id: Ia609f0ee4807c2fb9f58cba48e7c638f0ae094af Reviewed-on: https://chromium-review.googlesource.com/c/1430087 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625293}
-
Yusuke Sato authored
BUG=None TEST=None Change-Id: I9af69df7832958ca6f1b8c7a65f8ae018d7ad32a Reviewed-on: https://chromium-review.googlesource.com/c/1427879 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#625292}
-
Robert Ogden authored
When navigations are cancelled by a preview, the cancelled reload type is lost. This CL adds ReloadType to the various parameters and layers in browser-initiated navigations so that it can be preserved. Bug: 914547 Change-Id: Ibd5c272252ec06fff8ac6300287c70a5074a6193 Reviewed-on: https://chromium-review.googlesource.com/c/1426519Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#625291}
-
Kristi Park authored
Screenshots: https://screenshot.googleplex.com/xdxsFVdfMT3.png https://screenshot.googleplex.com/60nh9bRXjLu.png Bug: 919961 Change-Id: I620997bc3b76eff3c0126c69af122b0875b4f56a Reviewed-on: https://chromium-review.googlesource.com/c/1428539Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21b1ee52..9df9418e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb370322e6d064014657d697106bfd3331c7119b Reviewed-on: https://chromium-review.googlesource.com/c/1430661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625289}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb5076ed0c1..d1737fb0576a Created with: gclient setdep -r src-internal@d1737fb0576a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734,chromium:891313,chromium:891734 TBR=mmoss@chromium.org Change-Id: I6bab4fe920a70b802ac5e66dbd41f525da225075 Reviewed-on: https://chromium-review.googlesource.com/c/1430894Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625288}
-
Vladimir Levin authored
This patch ensures that the elements in a locked subtree with searchable: false are not focusable by either mouse or keyboard. In effect this prevents tab order navigation to elements in locked subtrees. R=chrishtr@chromium.org Bug: 882663 Change-Id: I0fbde6ba811be21021e450b38b584aa24ad7e52a Reviewed-on: https://chromium-review.googlesource.com/c/1417715Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625287}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f22b9ad..db52df1 TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win-angle-rel Change-Id: Ia39997032b4ac59d5da49051396e1b8e931101b1 Reviewed-on: https://chromium-review.googlesource.com/c/1427576Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#625286}
-
Peng Huang authored
Bug: 919865 Change-Id: Ia24d527ef1ac7af7c58fda5bf232c429d0ebc453 Reviewed-on: https://chromium-review.googlesource.com/c/1427610Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625285}
-
Esmael El-Moslimany authored
Bug: 923274 Change-Id: I98b7a42fd02ec0a950074265f4bf0c992ecc9b08 Reviewed-on: https://chromium-review.googlesource.com/c/1427739 Auto-Submit: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625284}
-
Moe Ahmadi authored
This reverts commit 9df0aa65. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-x64-cast/11742 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-arm64-cast/11675 Original change's description: > Enable connectivity checker for fuchsia > > We are using the default connectivity checker, and adding the switch > |--require-wlan| to allow developers to force connections to only WLAN > network interfaces. > > Fuchsia devices typically have an ethernet cable connected for > development, which causes the connectivity checker to always return connected. > For some tests and development, we need to force the usage of WLAN > interfaces, thus this switch was needed. > > Run cast with --require-wlan, observe disconnected > > Bug: 777973 > Test: net_unittests && Run cast with no flags, observe connected && > Change-Id: I359c57a83ce42eb81e5795c0c2c7b711b907471e > Reviewed-on: https://chromium-review.googlesource.com/c/1419903 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625258} TBR=wez@chromium.org,pauljensen@chromium.org,halliwell@chromium.org,awolter@chromium.org Change-Id: I5ea25b3824c74669aa4180706da8d9ada7d244a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777973 Reviewed-on: https://chromium-review.googlesource.com/c/1431015Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625283}
-
Jun Mukai authored
Right now maximum/minimum sizes are computed from views, it's hard to detect when it exactly changes. Because of that, individual client sets those properties for now to configure those metrics propertly. Bug: 921272 Test: manually Change-Id: I062da6e771f7f1c02d3ab07bebd98ceff410b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1422704Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Jon Kunkee authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/42bb040dde0a..4b75b8bab993 $ git log 42bb040dd..4b75b8bab --date=short --no-merges --format='%ad %ae %s' 2019-01-10 chcunningham Add ARM64 Windows support to the Chromium FFMPEG repo 2019-01-10 liberato Handle autorename files automatically. Bug: 893460 Change-Id: Iccb2d42f701e5a45e04d1cd47b15f4fb4e00682c Reviewed-on: https://chromium-review.googlesource.com/c/1429385Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#625281}
-
Lei Zhang authored
Instead, print more like as other platforms. On the renderer side, remove most Android-specific code, so it behaves like Linux. As a result, the printed document data is transferred via PrintHostMsg_DidPrintDocument, instead of the Android-specific IPC messages. To handle this in WebView, add AwPrintManager::OnDidPrintDocument() to receive the printed data, and write it out to its file descriptor. To handle this in Chromium, reuse the existing printing architecture and add the missing Android-specific bits. Hold the file descriptor used for printing in PrintingContextAndroid, and implement PrintingContextAndroid::PrintDocument() to write to the file descriptor. BUG=922657 Change-Id: I1c0123cade448de5a3ace00d671ecae61a04ffd3 Reviewed-on: https://chromium-review.googlesource.com/c/1420297 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625280}
-
Leonardo Padilha authored
Add return from suspend mode as trigger to status report. Bug: 919132 Change-Id: I9a3533de21bc8d83761889d26e81066c14e03428 Reviewed-on: https://chromium-review.googlesource.com/c/1427839Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#625279}
-
Stepan Khapugin authored
This reverts commit 2cd80cbb. Reason for revert: DCHECK fires on real users' devices. Unclear why. Original change's description: > Add a DCHECK in omnibox_view_ios. > > I suspect that processing_user_event is always true. > If this is the case, the textfield delegate can be simplified. In > order to verify this, add a DCHECK and see if it fires on the bots. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic45526950bf1f4b05a4c11a9cde551d0eef6dc0e > Reviewed-on: https://chromium-review.googlesource.com/1120816 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573710} TBR=rohitrao@chromium.org,justincohen@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2729f16524f3523098c09543705f007fb5e14515 Reviewed-on: https://chromium-review.googlesource.com/c/1430088 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625278}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71b5a7df7794..b0397d69a93a git log 71b5a7df7794..b0397d69a93a --date=short --no-merges --format='%ad %ae %s' 2019-01-23 hofbauer@webrtc.org Always send abs-send-time when negotiated and do not filter it out. 2019-01-23 yvesg@webrtc.org [CodeHealth] Fix use after std::move instances. 2019-01-23 oprypin@webrtc.org Correctly specify Mac version as 10.13 for iOS simulator tests 2019-01-23 jonasolsson@webrtc.org Don't pretend we've received an end-of-candidates indication. 2019-01-23 kwiberg@webrtc.org Rename new build targets to follow the recent large file rename 2019-01-23 srte@webrtc.org Enables feature to account for unacknowledged data. 2019-01-23 srte@webrtc.org Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" 2019-01-22 mbonadei@webrtc.org Fix typo in rtc_base/thread_checker.h. 2019-01-22 eladalon@webrtc.org Make SetFirstSubFrameInFrame and SetLastSubFrameInFrame protected 2019-01-22 eladalon@webrtc.org PSFB without REMB magic word is not an error 2019-01-22 ilnik@webrtc.org Always use real VideoStreamsFactory in full stack tests 2019-01-22 ilnik@webrtc.org Report rendered pixels statistic in full stack tests 2019-01-22 ilnik@webrtc.org Reduce webrtc_perf_tests duration on buildbots 2019-01-22 nisse@webrtc.org Refactor FileRotatingStream to use FileWrapper rather than FileStream 2019-01-22 nisse@webrtc.org Include video_bitrate_allocator.h, now that's in api/ 2019-01-22 sprang@webrtc.org Parsing of pacing factor and alr probing in RateControlSettings 2019-01-22 mbonadei@webrtc.org Remove NetworkManager::{set_ipv6_enabled,ipv6_enabled}. Created with: gclient setdep -r src/third_party/webrtc@b0397d69a93a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:922588,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib82b38129a76de737f00c2d0edd23c83d9e9b551 Reviewed-on: https://chromium-review.googlesource.com/c/1430219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625277}
-
Wei Lee authored
This CL adds OWNERS file into camera folder to clarify the ownership which it should belongs to the same owners of Chrome Camera App. Bug: 918091 Test: None Change-Id: I447ce86bea6eb420ec98c9b6a387cb69a7368a4d Reviewed-on: https://chromium-review.googlesource.com/c/1429301Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625276}
-
Manuel Rego Casasnovas authored
This optimization was introduced in r578233 but it's causing a crash when you use "text-overflow: ellipsis". We need to check if we need or not an ellipsis in the new text, and compute the position of the ellipsis if it's required. For that reason we cannot apply the optimization and we need to do a proper layout. The patch adds a new condition in LayoutText::CanOptimizeSetText() to avoid applying the optimization in that case. BUG=805785 TEST=fast/css/containment/change-text-node-data-ellipsis-crash.html Change-Id: I18c2ff04af9df64930510a6bda1071322cf07664 Reviewed-on: https://chromium-review.googlesource.com/c/1430082 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#625275}
-
Lutz Justen authored
Group device policies loosely based on the Help Center: https://support.google.com/chrome/a/answer/1375678?hl=en This grouping is used in user-facing policy docs and ADMX templates. Having the groups match the Help Center structure lets administrators find what they are looking for more easily. In particular, this is true for administrator of Active Directory managed devices, who use ADMX templates to edit GPO. This is a best effort. Things don't always work out nicely. For instance, accessibility settings have their own group and contains user and device policies, but they are under SignIn in the Help Center. Also groups some user policies (for Arc, Crostini, printing) as it fit in. Bug: 746981 Change-Id: Iba7e02cb758c7ba1004737a05c3af2ac13d909c9 Reviewed-on: https://chromium-review.googlesource.com/c/1407005Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#625274}
-
Andrew Xu authored
partial screenshot In previous code, when the partial screenshot is triggered, all of key events are stopped from propagation. As result, the release of the partial screenshot accelerator is unknown to AcceleratorHistory. It would lead to malfunction of the accelerators which rely on AcceleratorHistory, such as toggle CapsLock shortcut. This CL fixes the bug by updating AcceleratorHistory in the code block which processes the partial screenshot accelerator. Test: ash_unittests Bug: 920032 Change-Id: Ie4f553a841869db82f2710329e7968aa058713f4 Reviewed-on: https://chromium-review.googlesource.com/c/1408221Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Sorin Jianu authored
Bug: 924571 Change-Id: Iab05d07ab124240ae8d7b773565b059d623ba1db Reviewed-on: https://chromium-review.googlesource.com/c/1423562 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Katie D authored
Bug: 923132 Change-Id: I9d846ed994a4d515751b234fb6ba4c3b190ad029 Reviewed-on: https://chromium-review.googlesource.com/c/1423538Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#625271}
-
danakj authored
Change fullscreen to be set through a setter method when receiving the visual properties. This would allow tests to set it directly without needing a full visual properties. Remove a GetWebWidget() early out since visual properties only arrive and are processed before the RenderWidget is closed. Left a TODO to move it to the RenderView since it is a view-based property on both the browser and renderer side. Change-Id: Iecad0bd090b4c19aa260f6755c4b56e4232e0e63 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1425917Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625270}
-
Lei Zhang authored
They are not doing much to make writing code easier. Change-Id: I93427276472b6cb72a845341ea09163f62e5b230 Reviewed-on: https://chromium-review.googlesource.com/c/1428320Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625269}
-
Alexei Filippov authored
Currently allocator_shim.cc provides implementation for samples streaming for the SamplingProfilerWrapper class. There are no allocator shims there anymore. The refactor has no intended behavior changes. BUG=923459 Change-Id: I3d03715646b118abf109e0ae40d24688bd395a05 Reviewed-on: https://chromium-review.googlesource.com/c/1422591 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625268}
-
Mohamed Amir Yosef authored
This patch introduces a new method to remove logins given the DB primary key. This will be used in later patches. Bug: 902349 Change-Id: I9c2bf659dbb9e4710ef1469b0296b836a0212301 Reviewed-on: https://chromium-review.googlesource.com/c/1430008 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#625267}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5313c8a89964..47ca1b2fa399 git log 5313c8a89964..47ca1b2fa399 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 tobine@google.com Revert "Vulkan: Adding custom pool allocator" 2019-01-23 syoussefi@chromium.org Documentation update Created with: gclient setdep -r src/third_party/angle@47ca1b2fa399 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I7e6f20c3f089509d828ec419bcbb577286c9d5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1430680Reviewed-by:
-
Lei Zhang authored
https://crrev.com/624360 added lots of DCHECKs to PrinterQuery to make sure it only lives on a single thread. Turns out it does not. To fix the most obvious issues: - Fix the DetachWorker() DCHECK and document the thread it is called on. - Change the class to use base::RefCountedDeleteOnSequence, so it is always deleted on the IO thread. Right now, it is deleted on the UI thread for a successful print job, and on the IO thread when there is a failure. BUG=924033 Change-Id: If5be27bf91e18a5ec110894c56a0da525882e800 Reviewed-on: https://chromium-review.googlesource.com/c/1428087Reviewed-by:
-
Balazs Engedy authored
Be more frugal with std::string copies, and use StringPieces wherever possible. There should be no change to functionality. This change does not seem to affect performance much on Desktop, but based on local testing with some real-world inputs, yields a 5-10% gain on Android. Bug: 890129 Change-Id: I4b1779e11ca32b919864edd3630ffd775beb6300 Reviewed-on: https://chromium-review.googlesource.com/c/1425723Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#625264}
-
Tomasz Wiszkowski authored
This change applies style changes for new answer layout - essentially: - flips order of answer and query for all except dictionary suggestions, - changes colors for all answersr except dictionary suggestions. Dictionary suggestions follow the old scheme. Bug: 920396 Change-Id: Ia904600a535f6b018ab4abef582c8efc26cf193a Reviewed-on: https://chromium-review.googlesource.com/c/1419500Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#625263}
-
Takumi Fujimoto authored
There were unwanted squares being drawn around these icons that were shown only at certain zoom levels. This CL removes them. Bug: 899359 Change-Id: I5c8529ef7d671fa2f6877032c77163e994c60d4f Reviewed-on: https://chromium-review.googlesource.com/c/1428084 Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#625262}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dd2de388fc4e..42be5d65ef03 git log dd2de388fc4e..42be5d65ef03 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 simonhatch@chromium.org Pinpoint - Handle UTC offsets in dates Created with: gclient setdep -r src/third_party/catapult@42be5d65ef03 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923511 TBR=sullivan@chromium.org Change-Id: Ic8766b4d67ad079feba1ca18e4c81ff21bb21186 Reviewed-on: https://chromium-review.googlesource.com/c/1430461Reviewed-by:
-
Xiaocheng Hu authored
Blink Oilpan can't automatically remove pending spellcheck requests of a closed document, as the requests are referenced by SpellCheckProvider, which is out of Blink. This may become a leak source as revealed by crbug.com/855383. This patch prevents leak by changing the reference into a weak pointer. Bug: 855383 Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_rel_ng Change-Id: Ibdd535ddb51351a3e30776812dcd6ac4234feae3 Reviewed-on: https://chromium-review.googlesource.com/c/1428085Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f81bb73311d..9dc532dd1350 git log 4f81bb73311d..9dc532dd1350 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 halcanary@google.com SkLoadICU: s/LoadLibrary/LoadLibraryA/ 2019-01-23 csmartdalton@google.com Rename GrCaps::canUseAdvancedBlendEquation Created with: gclient setdep -r src/third_party/skia@9dc532dd1350 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Icc9ea615b4719f90904e9c870dcebf32b95396a2 Reviewed-on: https://chromium-review.googlesource.com/c/1430739Reviewed-by:
-
Aidan Wolter authored
We are using the default connectivity checker, and adding the switch |--require-wlan| to allow developers to force connections to only WLAN network interfaces. Fuchsia devices typically have an ethernet cable connected for development, which causes the connectivity checker to always return connected. For some tests and development, we need to force the usage of WLAN interfaces, thus this switch was needed. Run cast with --require-wlan, observe disconnected Bug: 777973 Test: net_unittests && Run cast with no flags, observe connected && Change-Id: I359c57a83ce42eb81e5795c0c2c7b711b907471e Reviewed-on: https://chromium-review.googlesource.com/c/1419903Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625258}
-
sebsg authored
Adds methods to get local and server cards separately, adds new observers for these card types separately, etc. Bug: 917396 Change-Id: Ic9d05f00c14b7fbd43f47fbc1e5d58427fc45fd5 Reviewed-on: https://chromium-review.googlesource.com/c/1418497 Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#625257}
-
Ken Rockot authored
Converts all service manifests for content processes to use C++ instead of the deprecated JSON manifests. Also uses some defined constants in place of string literals where appropriate, and cleans up some comments which are no longer necessary as a result. Note that this change copies the JSON-generated C++ Manifest contents pretty much verbatim for now, because the manifests are so large. As a separate follow-up change, the interface name sets will be converted to InterfaceList<...> invocations with proper mojom symbol references and build dependencies. Bug: 895616 Change-Id: I0a07be6733e357e8e1d5c3daee9128f7fd3c4732 Reviewed-on: https://chromium-review.googlesource.com/c/1423418Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625256}
-
Christopher Cameron authored
views::NativeViewHostMac currently updates its in-browser-process NSView using native Cocoa calls but uses the ui::ViewsHostableView interface to update its app-shim-process NSView. This can get hard to follow. Simplify this by using the ui::ViewsHostableView interface exclusively, when it is present. Move the browser and app shim calls to exist side-by-side in WebContentsViewMac. R=ellyjones TBR=avi (for web_contents_view) Bug: 898608 Change-Id: Id0d989529590103954cdef5e4fa131d70ab51c2b Reviewed-on: https://chromium-review.googlesource.com/c/1429244 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
