- 06 Mar, 2020 40 commits
-
-
Ehsan Kia authored
By default, traffic_annotation_auditor will use the proto file compiled into the binary, which can be problematic if the proto was modified since the last deployment of the binary. Removed fields can go undetected while added fields will throw an exception and require a redeployment. This change uses a DynamicMessageFactory to load the latest .proto file from source and uses it to parse the serialized annotation, catching any exception that may turn up. It also uses the dynamic proto to serialize back the proto before it is turned into a hash. All other functions are performed on the original static proto, since we really care about changes to chrome_settings.proto and the chrome_policy field is never directly accessed within this binary. Bug: 1048178 Change-Id: I2acbbe962b3233424982e9d5216e0c385dfaf577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079202 Commit-Queue: Ehsan Kia <ehsankia@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#747744}
-
Matt Menke authored
Downloads are currently treated as main frame navigations, with respect to same-site-cookies, but as subresources, with respect to NetworkIsolationKey. This means we don't gain any cross-site tracking protections as a result of the NIK, and there are often mismatches between NIKs and their site-for-cookies values. This CL makes downloads act like navigations with respect to NetworkIsolationKey, to mirror the site-for-cookies behavior. This does mean that downloads leak data across sites, and we may want to address this in the future, but for now, we should at least be consistent, since NIK and site-for-cookies are similar concepts, and should have complementary behavior. This is one of several CLs aimed at letting us DCHECK that NIK and site-for-cookies are consistent. Change-Id: I6e35d189c87dc6b04b35ca4ef16170e65a07f990 Fixed: 1046453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050987Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747743}
-
Alexander Timin authored
Remove it as it is not being used now. BUG=954271 R=arthursonzogni@chromium.org Change-Id: I7f7e0d0e4d5b1937c9c2a87aaf39f45da6f40bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091488 Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747742}
-
Ulan Degenbaev authored
ArrayBufferView and friends currently cache the buffer start and length. The cache is cleared on ArrayBuffer::Detach, which requires ArrayBuffer to keep track of all its ArrayBufferViews in a linked list. This function adds ArrayBuffer::IsDetached before accessing each cached value. This will allow us to remove the linked list and simplify the ownership model and eventually get rid of WTF versions of ArrayBuffer, ArrayBufferView, and friends. Bug: chromium:1008840 Change-Id: Ib29d2d4f493ea4abfad0b85314b7934137fa1857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091489Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747741}
-
Anna Malova authored
Bug: 1007815 Change-Id: I048e2563334e886d0828323c2422cc64aee6efd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090422 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747740}
-
Viktor Semeniuk authored
Comments after merge from: https://chromium-review.googlesource.com/c/chromium/src/+/2078257 are applied here. Bug: 1047726 Change-Id: I130f410e1fdfbf8b44c630279efff0e9618b1fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089851 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747739}
-
Timothy Gu authored
V8PersistentValueVector is a flavor of v8::PersistentValueVector that uses WTF::Vector as the underlying container. It is now dated with the introduction of Oilpan and unified GC. Use HeapVector with TraceWrapperV8Reference instead. Also, make one of the tests for WebLocalFrame's RequestExecuteV8Function() use receiver and arguments in order to test those functionalities. Bug: 1058706 Change-Id: I46c76ae087af478f9368c90ff27a0f6a69c71b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089984Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747738}
-
Stephen Nusko authored
This is failing consistently. BUG=1059273 NOTRY=true CC=sadrul@chromium.org,vmiura@chromium.org TBR=crouleau@chromium.org Change-Id: I36aa5ca865e7751ef51cf01b561744711d161c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090427Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747737}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93a2a6b8badb..491df6ba72d3 git log 93a2a6b8badb..491df6ba72d3 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 mtklein@google.com remove SkTLS Created with: gclient setdep -r src/third_party/skia@491df6ba72d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: If1c3a56eed374ed895cc2aa6af0c25ecd00e7e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747736}
-
Ewann authored
Renames google_drive_app_util. files to external_app_util. and GetFilesAppDownloadsDirectoryUrl() to GetFilesAppUrl(). Moves GetFilesAppUrl() inside external_app_util. Bug: 1052851 Change-Id: I15195179615bba4c891e66443d1518f02eacd4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090416Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#747735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7e1c6b5bd96..f291e9f01a9c git log c7e1c6b5bd96..f291e9f01a9c --date=short --first-parent --format='%ad %ae %s' 2020-03-06 sanikak@chromium.org auto_updater: update CheckPayloads method to ssh into devserver 2020-03-06 saklein@chromium.org flash-ap: Create deploy config. 2020-03-06 saklein@chromium.org flash_ap: Fix dut control command. 2020-03-05 saklein@chromium.org cros build-ap: Add FW_NAME support. 2020-03-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-05 saklein@chromium.org lib/firmware: Fix octopus build config. Created with: gclient setdep -r src/third_party/chromite@f291e9f01a9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Id89694bb4ef30da3baae8492b995a65ec983330f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091418Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1bf49a28878573d79b2bf6ac31fe6f7ebffb0288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091420Reviewed-by:
-
behdad authored
The guides for investigating the representative perf tests are added: - Common failures listed - accessing the traces and benchmark logs are documented Bug: none Change-Id: Ic087fb97ee362e04d839414f1396165f111b9934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087220 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#747732}
-
Friedrich Horschig authored
This CL adds the missing wiring call that lets the check button trigger the native check call. (Only bridge code, no tests possible.) Bug: 1047726 Change-Id: Ib430e3c10730d664c5364684c2c70ccdaff22ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089707 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747731}
-
Hans Wennborg authored
Bug: 1059231 Change-Id: Iea8de23e989a450caa02e67bfb9b5a5e780af8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089686Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747730}
-
Dave Tapuska authored
In order to move BeginFrame into blink change WebWidgetTestProxy to use an alternate method that occurs before BeginFrame. No behavioural changes intended. Change-Id: I5b8e1c2346005321f7f7c294edd598b451aeaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090306Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747729}
-
Omer Katz authored
This is a reland of 2f69de56 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} Bug: 986235 Change-Id: I3bdc6c53fcf7f2d0cc17c5eabbb1a86f470a263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090421Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements the passwordsPrivate.getPasswordCheckStatus extension API. In order to obtain this information, the PasswordCheckDelegate instantiates a BulkLeakCheckAdapter, and forwards its GetBulkLeakCheckState(). An event listener that notifies about changes to this event will be added in a follow-up CL. Bug: 1047726 Change-Id: Id9b6aeff1d604df4924be81a2213d77c16cd0ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085273 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747727}
-
Andrew Luo authored
Bug: 1058637 Change-Id: I519f740d02078cb38d67e38d7d4a3307f5cce88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090839Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b1579a826af..88d9224c538a git log 0b1579a826af..88d9224c538a --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com Merge "tp: refactor systrace serialization code in raw table" Created with: gclient setdep -r src/third_party/perfetto@88d9224c538a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1bdd286458a2239445f8c92c41fa76069cc549c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091417Reviewed-by:
-
Omer Katz authored
Moved the CHECK to when we pop from the worklist on the main thread instead of before we push concurrently. Bug: 1059185 Change-Id: I3b010d263c943395c7e483b3775a03e766ee1b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091525Reviewed-by:
-
ckitagawa authored
This CL makes FileManager async friendly for common IO operations required for Paint Previews. The aim of this change is to improve the FileManager and add support for SequencedTaskRunner to avoid risk of races when manipulating subdirectories which store Paint Previews. Bug: 1055508 Change-Id: I758bf4687cbec46eb9ef98ace8a0d3ada55d7ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082319Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#747723}
-
Christopher Cameron authored
Remove the remaining use of extension::Extension from ExtensionAppShimHandler. All uses are now in ExtensionAppShimHandler::Delegate, which we can move out of app code. Bug: 1057195 Change-Id: Ia5844bbe72d865ca54a69f3f3bfd7f9de7a204e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089677 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#747722}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51afe2e3ccf5..93731aec6bd2 git log 51afe2e3ccf5..93731aec6bd2 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-06 tvanderlippe@chromium.org Fix clang-format configuration 2020-03-06 sigurds@chromium.org [COEP] Improve error messages for COEP Created with: gclient setdep -r src/third_party/devtools-frontend/src@93731aec6bd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051473 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id340565a05db4fe96ce8f2127e51d866a4db0c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091414Reviewed-by:
-
Livvie Lin authored
Since we're adding lookalike interstitials, which also need the tab helper, IOSSSLErrorTabHelper should live in a common folder and be renamed to something more general. Bug: 1058898 Change-Id: Ia27eca489a0f62ce3584ca7d25ca13126810f973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089149Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747720}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I39db7fce8ef18f7000dba88307e8e76908901487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091545Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747719}
-
Anqing Zhao authored
Whenever upload list is loaded from log file, the format is checked at first. The JSON format and CSV format will be handled respectively. Following methods are extended. - ClearUploadList - ParseLogEntries Bug: 1040078 Change-Id: Ib0370ac4565c7c28b7a9a8480d080b628abaabc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058808Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#747718}
-
Justin Miron authored
Change-Id: I425ce0487fa3306a4f3cd50fa8b4ed0c2ee86539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078416Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#747717}
-
chrome://browser-switchNicolas Ouellet-Payeur authored
On chrome://browser-switch, show a building icon next to the heading. Screenshot: https://i.imgur.com/F2ShKHz.png Bug: 1056718 Change-Id: Ib43064bf8dd6ad072c3d7c06f71c66724260d170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089961 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747716}
-
Samuel Huang authored
Previously ProcessInitException thrown from LibraryLoader gets swallowed by AsyncInitTaskRunner. For the main usage (where the caller is NativeInitializationController.startBackgroundTasks()), AsyncInitializationActivity.onStartupFailure() is called, and it creates a new ProcessInitException while forgetting the old ones. This CL changes: * AsyncInitTaskRunner.onFailure(), * ChromeActivityNativeDelegate.onStartupFailure(), to take an Exception |failureCause|, so that it can be propagated wherever possible. This allows the old ProcessInitException to be attached to the new ProcessInitException instance, and gets passed to RuntimeException. Unfortunately, the old failure still does not get used to render start up error logs -- but at least now we have a better pipeline to enable better logging. This CL also refactors AsyncInitTaskRunner to make its completion criteria (in tasksPossiblyComplete()) more explicit, and simplify the inner class FetchSeedTask. Change-Id: I8f0443cbafd491f521d3f799622a82733b770099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085735 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#747715}
-
Christoph Schwering authored
</dom-module> was missing the >. Change-Id: Ic2a588c819de882878a0f3d0d62a6ad65c7020c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091350Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#747714}
-
Dominique Fauteux-Chapleau authored
These tests use the least possible amount of overrides to ensure DeepScanningDialogDelegate every requests/callbacks eventually resolves and returns to the caller. Also add code to handle the web contents being destroyed and avoid ASAN issues. Bug: 1041890 Change-Id: Ibfe232354f0591ae9e854bf5a0163ede68d6faf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083598 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#747713}
-
Joshua Pawlicki authored
Integrity of the check is still guaranteed by CUP. The check will no longer be confidential. Bug: 1057341 Change-Id: I366453b1586f3116ec75a11ef3718cfbbf5522ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090336 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#747712}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I385d19863911be4a72161ae9184a17ca8e536abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091421Reviewed-by:
-
Robbie Gibson authored
This reverts commit 2aa19d70. Reason for revert: Breaks QR code scanner. In investigating that, I think I found a better solution. Original change's description: > Fix NTP omnibox animation when there are suggestions > > Before, if there were suggestions on the NTP, they would immediately > appear. The better animation is to scroll the fakebox up to the top > of the screen and then present the suggestions. > > To do this, when entering the omnibox from NTP, we only focus the > location bar, which causes the scrolling animation. -fakeboxFocused > is already called in the animation completion block, which does the > actual work to make the omnibox text field first responder, causing the > suggestions to appear. > > To finish off, the -locationBarDidBecomeFirstResponder code now only > focuses the location bar if we are not on the regular NTP. > > Bug: 1057643 > Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746450} TBR=stkhapugin@chromium.org,gambard@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057643 Change-Id: Ifda283f7733b9439e3803d1110b0afefeee084f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089782Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Thomas Lukaszewicz authored
Removed GetInstanceForNativeUi() from NativeFileSystemUsageBubbleView and CastDialogSinkButton. Changed the FileSystemUsageBubble to update its icons on theme change to keep sync with the current theme color values. Bug: 1056916 Change-Id: I81254025570f009cfea5db26ee982cf14ad45580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089986Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747709}
-
David Tseng authored
This is the first step in a series of changes to improve touch interaction with ChromeVox. This change: - introduces a new earcon when entering a touch anchor - introduces a new earcon when touching a blank area of the screen (defined as an anchor that is neither a touch leaf nor a touch object) - when moving from a touch anchor to a non-touch anchor, immediately stop speech so the user knows they have left. This will help avoid confusion about what's currently focused or not when hovering a finger. This might also be familiar (e.g. iOS behaves this way). Note for the last point, we will have to solve the issue of really small touch targets. One potential solution (not for this change) is to come up with a way to do "fuzzy" hit testing. Change-Id: I262c664bc0d86aa6e8ce96cf1e263db7a8f184cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088510 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747708}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2076423 After https://chromium-review.googlesource.com/c/chromium/src/+/2087971 and https://chromium-review.googlesource.com/c/chromium/src/+/2087892 R=ajwong@chromium.org Bug: 1026641 Change-Id: Ia2c180759677a51502c5c1c04508d165f7c35856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087893 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747707}
-
Andrew Shulaev authored
Change-Id: I91e8da3812ae5870f56023a247ca9b83ea1cb5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089850 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#747706}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 9284abd0040afecfd619dbcf1b244a8b533291c9`. linux_chromium_chromeos_msan_rel_ng trybot redness: Also red on the main waterfall in similar ways and has been for days (!). ipad-device, iphone-device trybot redness: happens on whitespace cl too, filed crbug.com/1059256 Bug: 1058012 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iafc17a96a7d40e9b99f58bce474ed50dc6bfb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086341 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747705}
-
