- 24 Nov, 2020 40 commits
-
-
Wenyu Fu authored
Add a privacy disclosure when ToS is skipped by policy in the FRE. The privacy disclaimer will be displayed on screen for 1 second before FRE is finished. Bug: 1108564, 1128158 Change-Id: I5f912e62484a5255bfda27db0318c0e92d541903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548293 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830685}
-
Dave Tapuska authored
The View implementation had a few more things that the frame left as a todo. Talking with wjmaclean@ it seems that the view implementation should just be used for this code as it handles things like long press gestures which were added after the frame code was written. BUG=1097816 Change-Id: Ic912c5d6fe9fda4183b25006c4b7631b37dade3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551791 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830684}
-
Eric Seckler authored
Not doing this may be causing flakes in other tracing tests later. Bug: 1141233 Change-Id: I67f5ad3b746a06a23de055b34b7c3236105b1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558791 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#830683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9490b30c229adb7b7ddcc5286b2895393a1ce6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830682}
-
David Maunder authored
This is for a new feature where we display price alerts in the Tab card in the Tab grid switcher as price drops are identified for shopping related websites. Bug: 1151401 Change-Id: Id2adfed52195da36ced7ca6baf37a70ac536f686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552624Reviewed-by:
-
Andrew Grieve authored
This reverts commit 4727f47b. Reason for reland: Cronet test fixed in crbug.com/1136963 Original change's description: > Revert "Enable whole-program devirtualization for arm64 Android build." > > This reverts commit 4f9f1598. > > The CL being reverted causes cronet_test_instrumentation_apk to crash > on builder "android-cronet-marshmallow-arm64-rel". > > Bug: 1115229 > Change-Id: I2b177353b00a57befe488e0bbef242a2b585162c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376316 > Auto-Submit: Nick Harper <nharper@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802814} TBR=nharper@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1136962 Change-Id: Ib9dd654111d6f45915c0b7ed1e454fb29668ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416569 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830680}
-
Sam Maier authored
Bug: 1139446 Change-Id: I3613007c5480aa59d4931b82dbaf352a30576179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553856 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Many spots using forward_variables_from(invoker, "*") were not allowing these two variables to be set in outer scopes. * Introduce a helper variable "EXPLICIT_FORWARDS" for use with the recommended pattern of: forward_variables_from(invoker, "*", [ "testonly", "visibility" ]) forward_variables_from(invoker, [ "testonly", "visibility" ]) * Ensures this pattern is used in android templates, test.gni, and BUILDCONFIG.gn * Documents this pattern in writing_gn_templates.md * Adds a PRESUBMIT.py for it * Fixes visibility of a few blink targets now that test() respects it. Bug: 862232 Change-Id: Ib71dbf34be76131fc749c721aea856e1146bc69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454427 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#830678}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b35dd76cd5f6..4c5dd5d863c4 2020-11-24 ehmaldonado@google.com [owners] Add tests for GetFilesApprovalStatus If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Idb42a0ee2ce0a9f16c7054905a10ada6dc918be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558173Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ibf476785b974d86e52a32c81cb12f04e46d684da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556517 Commit-Queue: Dan S <danan@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830676}
-
Yi Gu authored
The test has been "Timeout" in addition to "Failure": https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=virtual%2Fthreaded-prefer-compositing%2Ffast%2Fscrolling%2Flistbox-wheel-event.html TBR=mustaq@chromium.org NOTRY=True Bug: 841567 Change-Id: Ib8813e61070fbb202a313c9e5f33c56c0026058f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559090Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830675}
-
Fredrik Söderqvist authored
Move duplicated CSSValue creation to a helper function and put the LengthBox in a local variable. Change-Id: Icf06db6282d7c310717e8f0e9f18b547a9d7be41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558339 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#830674}
-
Jordan Bayles authored
This patch updates debugging breaking in openscreen's logging platform. TBR=btolsch@chromium.org Change-Id: Id0d855b898e32d38ed99fb2e7ef67534b40a9fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555585Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#830673}
-
Stepan Khapugin authored
Adds necessary observation code and plumbing to the tab switcher view controller to add UI in the future. Bug: none Change-Id: I5912042ecf4634b7a8c0b3628b40505293cfcdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536454 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830672}
-
Camillo Bruni authored
Introduce ModuleTestBase::CompileModule for simplifying module compilation for tests with the upcoming streaming compilation changes. Bug: 1061857 Change-Id: I8ad38331a4d2a0a4fd4d0b9fff749d91f848bdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557506Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830671}
-
Hiroshige Hayashizaki authored
While previously v8::Undefined was returned on errors, this CL changes it to empty v8::Local to align ExecuteScriptInIsolatedWorld() with other script evaluation methods (that already return empty handles or equivalents). This is probably safe because: - The v8::Undefined was introduced in 2012 at https://source.chromium.org/chromium/chromium/src/+/fcf7ab1ff6c5280d37007531821a1260ea92dd66 According to the codereview at https://bugs.webkit.org/show_bug.cgi?id=88451#c19, empty handles were changed to `v8::Undefined` due to lifetime-related issues around `v8::Array`. This is no longer relevant. - The (indirect) callers of ExecuteScriptInIsolatedWorld() are either: - Callers that don't use the return values. - RenderFrameImpl::JavaScriptExecuteRequestInIsolatedWorld() (see below). - ScriptInjection::InjectJs() that converts both empty handles and `undefined` into `base::Value()` in ScriptInjection::OnJsInjectionCompleted(). - components/translate callers that have DCHECK()s with non-`undefined` types. - Test-only helpers that don't expect errors (and thus neither empty handles or `undefined`) in successful cases. RenderFrameImpl::JavaScriptExecuteRequestInIsolatedWorld() converts the result of ExecuteScriptInIsolatedWorld() into `base::Value` in RenderFrameImpl::JavaScriptIsolatedWorldRequest::Completed(), but this previously didn't handle empty handles (failed at DCHECK() in V8ValueConverterImpl::FromV8ValueImpl). This CL fixes this so that it converts both empty handles and `undefined` into `base::Value()`, which is consistent with other callers. Tests: weblayer_instrumentation_test_apk: - org.chromium.weblayer.test.ExecuteScriptTest#testClearedOnNavigate - org.chromium.weblayer.test.ExecuteScriptTest#testScriptIsolatedFromPage in - android-pie-x86-rel - android-pie-arm64-rel - android-marshmallow-arm64-rel After this CL, WebScriptExecutor::Execute() returns empty handles on errors, regardless of main/isolated worlds. Bug: 1111134 Cq-Include-Trybots: luci.chromium.try:android-pie-x86-rel Change-Id: I288827b5b39ba05f625da53b486797f64e53fda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545745Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#830670}
-
Ben Kelly authored
This CL translates the path-to-regexp regular expression generator from typescript to c++. Its based on the code here: https://github.com/pillarjs/path-to-regexp/blob/125c43e6481f68cc771a5af22b914acdb8c5ba1f/src/index.ts#L532-L596 We deviate from the path-to-regexp code in a couple minor ways. First we only return a list of group names instead of the full "key" objects containing prefix, suffix, etc. Second, the code structure is reordered a bit to make early-return style more readable. Bug: 1141510 Change-Id: I4018cf99a91665a1661c5fe93f8eac4eb0bd3223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528938Reviewed-by:
-
Max Curran authored
course of a page load. Two key values within Translate are the source language (language of the web page) and the target language (the user's language). This new code will track the source and target language over the course of a page load and record the initial and final languages for every page load. We want to record both the initial and final values, because the user can manually change both the source and target language. In addition, this new code will record the number of times the target language is changed. We do not do the same for source language, because we expect the user to change that much less frequently. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 111486 Change-Id: Ibb9fec8f2f831aaf7bea09a543167c0220d795ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543342Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#830668}
-
Tomasz Wiszkowski authored
This change updates the priority of the Clipboard suggestion so that these are shown above the MV tiles. Bug: 1150086 Change-Id: I56dbb496ebd7e784ab1ca387f155648fe943fa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556212 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#830667}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4314.0-1605528048-benchmark-88.0.4324.12-r1 to 89-4324.9-1606129869-benchmark-89.0.4334.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia0c0b93a447ab78a115b36995a30762292b34674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558832Reviewed-by:
-
Patrick Noland authored
This replaces an expensive, synchronous process of fully re-classifying the current autocomplete match(es) by passing an extra bit of information when we receive the notification that suggestions have changed. Bug: 1149683 Change-Id: I5ea0cc556bdb6fb843d8a1e7b0e1ef6424fa4d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536373 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830665}
-
Yi Gu authored
The test has been flaky on Windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=MediaFeedsWebUIBrowserTest.ConfigTable TBR=beccahughes@chromium.org Bug: 1141621 Change-Id: Ibe9ca8baba96963c40bc99858916c100587b01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558170Reviewed-by:
-
Reilly Grant authored
Issue 839117 prevents the Exposed attribute from working properly on partial interfaces. There are therefore a handful of attributes which manually check the type of worker they are being requested in and return null rather than being undefined. This change adds tests for this behavior in shared workers. Bug: 839117 Change-Id: If79929622e8f98a01e059dc90ff1514131035487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538501 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830663}
-
Collin Baker authored
Bug: None Change-Id: Ib69156aa0fd3ca5c943e7ba324052943aa5254aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550487Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#830662}
-
Sigurdur Asgeirsson authored
Bug: 1143281 Change-Id: I5107ca4d324248456470f5880429d10760d77076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557223Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830661}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If6662e38a47f2e1130b007e06697f09a22c16f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556958 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#830660}
-
Daniel Cheng authored
Convert remaining uses to the macros defined in //base/metrics. Also convert the recorded enumerations to scoped enumerations so that: - clang can enforce kMaxValue correctness - enum histogram macro/function helpers can autodeduce boundary value Bug: 742517, 1047547 Change-Id: I618b5eeb53e6423de11ba994a623ccbaa3981206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552202 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbc19ea84ef4..751250705016 2020-11-24 csmartdalton@google.com Add "putBack" analogs to the DrawIndirect buffer pool 2020-11-24 csmartdalton@google.com Remove a slop term from the stroke tessellation shader 2020-11-24 reed@google.com rely on clients to guard old api 2020-11-24 csmartdalton@google.com Fix a bug with miters in the stroke tessellation shader 2020-11-24 49699333+dependabot[bot]@users.noreply.github.com Bump bl from 4.0.2 to 4.0.3 in /tools/perf-canvaskit-puppeteer 2020-11-24 nifong@google.com Add supporting function for finding image use in layers 2020-11-24 michaelludwig@google.com Move conservative bounds tracking from SkCanvas to SkNoPixelsDevice 2020-11-24 csmartdalton@google.com Add cusp detection to GrPathUtils::findCubicConvex180Chops 2020-11-24 egdaniel@google.com Remove unused parameter in vk bindDescriptorSets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: Iebaea26f0bb5d4c835bb07ed6a4a6c7783fbdfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558517Reviewed-by:
-
Nohemi Fernandez authored
This patch adds a sign-in entry point to the "Sync off" button in the Settings screen. Bug: 1125631 Change-Id: Ib45b1794b9028c229b7cc1442de26581a0987b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514149 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830657}
-
James Vecore authored
Canceling of a share sometimes comes through as a kCancelled frame and other times we get a failed payload transfer status first. This is non-deterministic so we have to handle both cases correctly. This CL does two things: 1) Ensures that no mater how a transfer fails either by the payload tracker or through a OnReadFrame cancel frame that incoming payloads gets cleaned up. This ensures we don't leave partial files around on disk. 2) Ensures the if a cancel frame comes in OnReadFrame that we don't send back a cancel frame which was previously causing a cancel frame loop while the connections were shutting down for cb <-> cb transfers (it didn't fail or cause problems, but it is not correct). Tested manually on device cb <-> cb and Android <-> cb canceling from both sender and receiver many time and verifying no partial file was left behind. Fixed: 1151673 Change-Id: I4a5c7f5d670db0f82864b4ddc8ad9384cb052663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556563 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#830656}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4dbfe439..35f663e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I45ef987e4d97a40f198ace26df8fd186f66771b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558497Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830655}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3dbbbe018a93719a9c8d333905016dd92ecff4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556937 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830654}
-
Patrick Monette authored
This class submits a TaskPriority::LOWEST when a frame is an ad. This class will first be used in in https://chromium-review.googlesource.com/c/chromium/src/+/2538310. Bug: 971272 Change-Id: If19d6f465533575c813f88623b3eed0631eb5587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541543Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#830653}
-
Gavin Williams authored
A util class to help Scanning open the Files app. Bug: 1059779 Change-Id: I12fad85174d5d6163fa46b4f47b9545354bd35cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545778 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830652}
-
Yi Gu authored
http/tests/devtools/service-workers/user-agent-override.js has been flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http%2Ftests%2Fdevtools%2Fservice-workers%2Fuser-agent-override.js TBR=shimazu@chromium.org NOTRY=True Bug: 1152532 Change-Id: I7d6c4521f9779f4db53f06c218071d53545a533d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558790Reviewed-by:
-
ssid authored
The memory infra proto writer will flush the trace writer when flush is called. Change-Id: I47d9d287c339b513ff5a5b492640c0df3482573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557880Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#830650}
-
Yutaka Hirano authored
Speculative fix for the performance regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/2537288. Bug: 1151277 Change-Id: I029528b26d26e28ce2a59bf260aad0ae810b0157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557817 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
John Lee authored
Fixed: 1141545 Change-Id: I037923cd5fd45b371c8ae2af480c969dc5640e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555588Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#830648}
-
dpapad authored
This file was previously auto-generated with a custom one-off python script, which is no longer necessary now that generate_grd() exists. The previously generated file was also unnecessarily using |flattenhtml| and |allowexternalscript| Grit attributes which are removed as part of using the new tool. Besides the benefit of removing a one-off script, this also removes a TODO about crbug.com/1112471 about making the one-off script work with Python 3, which is now obsolete. Bug: 1132403,1152343,1112471 Change-Id: I06928dcc2690b819eea1680fde23221ded94ed89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557349 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#830647}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606196878-8e98c60eb2828a7469f5671822f6024fb48eb0e5.profdata to chrome-win64-master-1606218923-28e4a6cb560c6a9acc44daf784662f70e5c57403.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1169bb59a50b6179bdbb6ee2f44ff87bcadc614c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558157Reviewed-by:
-
