- 20 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/93d4c10ffccc..e21f3f574b59 git log 93d4c10ffccc..e21f3f574b59 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 nisse@webrtc.org Revert "Delete mac_utils.h and mac_utils.cc" 2019-08-20 tommi@webrtc.org Make the callbacks to PollStats for RampUp* tests more regular. 2019-08-20 nisse@webrtc.org Delete mac_utils.h and mac_utils.cc 2019-08-20 peah@webrtc.org Removing all external access to the integer sample data in AudioBuffer Created with: gclient setdep -r src/third_party/webrtc@e21f3f574b59 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:993688,chromium:None Change-Id: I66d7b5127df296ab6cfa68fbd6d246e88ddfb178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688491}
-
Ivana Zuzic authored
Observer for the password list in PasswordEntryViewer should be removed while the view still exists, to avoid calling findViewById on an empty View. Previously, the observer was removed in onDestroy() which happens when the View is already gone and passwordListAvailable could call setRowText which uses findViewById. Bug: 994010 Change-Id: I10fbea31dd6faad777b24ec8783c7572e91484ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761589Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#688490}
-
Christopher Gunadi authored
Add tests to ensure the "Install with Linux" context menu item is shown/hidden when Crostini root access is allowed or disallowed by kUserCrostiniRootAccessAllowedByPolicy policy preference control. The feature flag kCrostiniAdvancedAccessControls is enabled for file manager browser tests always and its associated pref is set "on" by default. FilesApp test JS can send a message to the browser test C++ set the pref on/off as needed with the setCrostiniRootAccessAllowed command adding in this CL. Test: browser_tests --gtest_filter="ContextMenu*Install*DebianFile*" Bug: 983997, 993369 Change-Id: I8a5ee0cb21e43937a0f4a80cd68b7916ee2343c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752825 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#688489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d07afa7409e5..ebcc14092998 Created with: gclient setdep -r src-internal@ebcc14092998 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3dda691872934d01459fe1be8e7b9f76e91bd18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688488}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: Iab56d84cf26975f9c476680d74037a9088ec1c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760837 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Marina Ciocea authored
TBR=dmurph@chromium.org Bug: 995716 Change-Id: Ie57626524bd894e89fcd21a0ca5ba267156b76c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761599Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#688486}
-
Thomas Tangl authored
The only GAIAServiceType that is passed to ProfileMenuView in the code is GAIA_SERVICE_TYPE_NONE. Therefore the parameter is removed from ProfileMenuView::ProfileMenuView and all preceding and succeeding method calls. Bug: 966388 Change-Id: I9521931460c5c1e2e8a98d920b18fad67497f7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762067Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688485}
-
Michael Lippautz authored
TracedGlobal references (without callback) are eagerly cleared during unified heap garbage collections before sweeping is started. This change performs similar eager clearing for Blink stand-alone garbage collections. This allows for removing the destructor of v8::TraceGlobal and its wrapping type TraceWrapperV8Reference. Bug: 995684 Change-Id: Ie0394bb23ee4c5e1ecf4d1ad2a591aa77787ab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760922 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688484}
-
Yasmin authored
Bug: 992355 Change-Id: Iddb778995efaab12cd0ad87b18d5a2096f019c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755992 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#688483}
-
Nicolas Ouellet-payeur authored
Previously, if a CL only modified annotations.xml, CQ wouldn't run check_network_annotations because the file doesn't appear in the dependency tree for shipped_binaries. This CL adds annotations.xml to shipped_binaries, solving that issue. TESTED=Created a dependent CL that updates only annotations.xml and checked that it fails on CQ: https://chromium-review.googlesource.com/c/chromium/src/+/1758433 Change-Id: Ib33099df057f1cef882c46858862ea5fca5b91e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757297Reviewed-by:Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#688482}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c013580..9781db33 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie918523e6aa3655ad6248d97e0dfcbffb49dca55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762167Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688481}
-
Marina Ciocea authored
This reverts commit d7878194. Reason for revert: [Sheriff] blink_platform_unittests fails on Cast Audio Linux bot. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/50660 Original change's description: > Make UTF16RagelIterator::operator*() to use DCHECK() instead of CHECK() > > This patch changes |UTF16RagelIterator::operator*()| to use |DCHECK()| instead > of |CHECK()| for improving performance because this function is called many > times as number of characters in the page. > > In text heavy page, I observe 12% speed up. > > Change-Id: I5febb53f0f096b3bd76e6330a70b6464b9cb4758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760846 > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688476} TBR=yosin@chromium.org,eae@chromium.org,drott@chromium.org Change-Id: If3d54ab8ae171d55be5f989c3e7d4fccf254d9fa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761279Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/939b6b1f1c56..428149962b00 git log 939b6b1f1c56..428149962b00 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 perezju@chromium.org [Telemetry] Encode tags in test result entries as dicts Created with: gclient setdep -r src/third_party/catapult@428149962b00 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:966835 Change-Id: I77c3ac1d11d0d4924ba4a0708ac6c07c0607983e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761633Reviewed-by:
-
Emilio Cobos Álvarez authored
Bug: 994910,994305 Change-Id: I452263ac86f7b584b8be5792902833e6cb52643a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757021 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#688478}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0b52b570853..93d4c10ffccc git log a0b52b570853..93d4c10ffccc --date=short --no-merges --format='%ad %ae %s' 2019-08-20 kthelgason@webrtc.org Declare references as constant in the metal renderers. 2019-08-20 nisse@webrtc.org RTCError as return type for PeerConnectionInterface::SetConfiguration 2019-08-20 qingsi@webrtc.org Sanitize the address field of peer-reflexive remote candidates. 2019-08-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 21d23ea5..5a34954f (688221:688384) 2019-08-19 steveanton@webrtc.org Remove jeroendb@webrtc.org from OWNERS Created with: gclient setdep -r src/third_party/webrtc@93d4c10ffccc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:968161,chromium:None,chromium:None Change-Id: Ifa8e5e4b9e1a2ed70dfe51f83b029f15a99c38e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761704Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |UTF16RagelIterator::operator*()| to use |DCHECK()| instead of |CHECK()| for improving performance because this function is called many times as number of characters in the page. In text heavy page, I observe 12% speed up. Change-Id: I5febb53f0f096b3bd76e6330a70b6464b9cb4758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760846 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#688476}
-
chrome://flagsEdward Jung authored
On changing an experiment setting, the focus switches to the restart button rather than the next experiment. Focusing away from the restart button takes you back to the experiment list where you just were and not at the top of the page. Bug: 957389 Change-Id: Ia784d6954e9b151f24812d3e51e04ea3530ad395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739927Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#688475}
-
Mohamed Abdelhalim authored
This CL is part of a series of CLs to remove any remaining logic inside NavigationHandleImpl. Bug: 916537 Change-Id: I03c88ff27ea6c05d8aec5a99a07a0ef919670efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751983 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#688474}
-
Mark Brand authored
Many existing typemaps don't use fully-qualified typenames, and rely on the undocumented namespacing of the generated code. This breaks the generated code for the generic mojo LPM fuzzer that's currently under development, which has different namespacing. This CL updates all typemaps files to use fully qualified typenames as per the documentation. Change-Id: I8b8fe9e99369728a2a6e521c92e79f4a52fbce15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742227 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#688473}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I4f60e40748696de54ed1925aa397cfdcb218edce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760584 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66a25cd28ef..d07afa7409e5 Created with: gclient setdep -r src-internal@d07afa7409e5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Id7700a9a6307af0ef98337bc70fa9cf790baffda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761703Reviewed-by:
-
Hiroki Nakagawa authored
This enables to pass the following test when PlzDedicatedWorker is enabled: $ browser_tests --gtest_filter=ExtensionWebRequestApiTest.WebRequestTypes Also, this adds test cases for shared workers in the test. Notable points of this CL are as follows: - This CL introduces the "creator render frame" concept. This is the frame that is directly starting a dedicated/shared worker. This can be nullptr if the worker is nested. This is used for creating URLLoaderFactoryBundle and ResourceRequest::render_frame_id (see below). - Calling ContentBrowserClient::WillCreateURLLoaderFactory() allows to route the requests via webRequest API. See WorkerScriptFetchInitiator::CreateScriptLoader() etc. - ResourceRequest::render_frame_id set in WorkerScriptFetchInitiator::Start() is necessary for checking if the requests are issued from an appropriate frame in the ExtensionWebRequestApiTest.WebRequestTypes test. We still need to add test cases for nested dedicated workers and subresource requests on workers. A separate CL will cover them. Change-Id: Id0ae7472b1dd535c513b9d0409ef175ef66b9b7e Bug: 990707 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738606 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#688470}
-
Marina Ciocea authored
This reverts commit 3db81a0e. Reason for revert: breaks generate_build_files step on Mac ASan 64 Builder Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/89573 Original change's description: > Reland "Better success detection for pw change" > > This is a reland of 3ea87442 > > Turns off the tests for Mac Asan, which seems to be the only build > breaking according to the flakiness dashboard [1]. Apparently, the whole > test is not picked up on that builder. > > Also fixes a typo in onCompleted_, which looks unrelated to the > breakage. > > TBR=olsen@chromium.org,xiyuan@chromium.org > > [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PasswordChangeAuthenticatorUnitTest > > Original change's description: > > Better success detection for pw change > > > > Only slightly improves success detection at this stage, > > by adding Azure support - Ping and Okta are still pretty > > lacking - but makes room in the code for better success > > detection, and adds a unit test. > > > > Bug: 930109 > > Change-Id: I59a173095301f7c641031f79cb3a6c946c5efc09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754013 > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Lutz Justen <ljusten@chromium.org> > > Commit-Queue: A Olsen <olsen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#688173} > > Bug: 930109 > Change-Id: Ie10ba06e86afa94f852dcac65bdc3b0519248d0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761591 > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Auto-Submit: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688461} TBR=xiyuan@chromium.org,ljusten@chromium.org,olsen@chromium.org Change-Id: I244dfea4ca838c57bbca18b985d6143f7023d0e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761273Reviewed-by:
-
Chih-Yu Huang authored
Originally, we set a timeout for flush that starts at calling VEA::Flush() and ends at flush callback is called. However, we don't know how many pending frames in VEA when we call VEA::Flush(). The delay may vary a lot due to the number of pending frames. This CL changed to set timeout of each BitstreamBufferReady() call. We could verify the time usage of each encoded bitstream buffer, and the time period between the last bitstream buffer is returned and the flush callback is called. It makes the unittest more robust. BUG=chromium:979497 TEST=run video.EncodeAccelH2642160PI420 on celes Change-Id: Ie52c9378397598aba5855d75553f7aef269bb4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720122 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688468}
-
Juan Antonio Navarro Perez authored
It appears these tests aren't running anywhere. The main test runner script does not work (fails with exception). Last changes to these files were from three years ago. Bug: 921000 Change-Id: I84dfebb24584a687d157394a6ceca707652c13c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760301Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#688467}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0803a22a..5c013580 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4d3f9ea91358e8e39e3f8fcb30c7f10d355b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760424Reviewed-by:
-
Scott Violet authored
GetRedirectDistanceForURL() is no longer used. BUG=none TEST=none Change-Id: Ia47669629a160dab79f6d872fd96c7d6e09baa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761493 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#688465}
-
Christian Dullweber authored
To correctly apply content settings, we need to know the top_frame_origin any time cookies are used. Currently we only have site_for_cookies, which is empty in third_party frames. Bug: 988398 Change-Id: Icb724aaaf89c244aa7aebdbaceb1f9a8c3c3ec91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731900 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#688464}
-
Juan Antonio Navarro Perez authored
We want to be able to import from core module in tools/perf without bringing the whole of Telemetry as a dependency. As a first step, for scripts that really need it we add near the top: from core import path_util path_util.AddTelemetryToPath() Alternatively, top level benchmark runner scripts can just import: from chrome_telemetry_build import chromium_config which *will* implicitly add to sys.path Telemetry and all its required dependencies. The implicit dependency to Telemetry in "core" will be removed on a follow up CL. Bug: 981349 Change-Id: I900366d1849341d079b45ae4201a2c6e9d1c9044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760218Reviewed-by:Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
Stephen Nusko authored
This improves readability, and in a future CL when I add received_packets() to allow counting of all packets (not just test ones) makes the function names meaningful. Also follow the C++ style guide and declare structs before functions. Change-Id: Id2f9cc41e0cbe49fb8162c9b979ae1744b1a53a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760949 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#688462}
-
A Olsen authored
This is a reland of 3ea87442 Turns off the tests for Mac Asan, which seems to be the only build breaking according to the flakiness dashboard [1]. Apparently, the whole test is not picked up on that builder. Also fixes a typo in onCompleted_, which looks unrelated to the breakage. TBR=olsen@chromium.org,xiyuan@chromium.org [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PasswordChangeAuthenticatorUnitTest Original change's description: > Better success detection for pw change > > Only slightly improves success detection at this stage, > by adding Azure support - Ping and Okta are still pretty > lacking - but makes room in the code for better success > detection, and adds a unit test. > > Bug: 930109 > Change-Id: I59a173095301f7c641031f79cb3a6c946c5efc09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754013 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688173} Bug: 930109 Change-Id: Ie10ba06e86afa94f852dcac65bdc3b0519248d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761591 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#688461}
-
Joel Hockey authored
Contain all FilesApp foreground access to the background object to the FileManager class. This simplifies a lot of the externs dependencies and I think it provides a cleaner API. Change-Id: I96716d0c53d538a90adfb04f9f54ce6cd7d72568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761880Reviewed-by:
-
Yi Su authored
Bug: 991608 Change-Id: If185af4f57f6c065373f494387121895b0dbe461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760728 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688459}
-
Mohamed Amir Yosef authored
The feature hasn't launched yet, and hence I am extending the expiry of enable-sync-uss-bookmarks flag to be at M80 Change-Id: I6223298095f58cee0cbe0c0cf1c8638309258643 Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761268 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I089547a07eb26a1e7ffb509499348390f6d1f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761700Reviewed-by:
-
Alex Ilin authored
User can hit ANR on NTP because Chrome wants to display a Signin promo. Signin promo requires a list of Android accounts on a device to display the user name and the profile picture. The promo view is built synchronously meaning that the UI thread may be blocked waiting for a list of accounts. The list of accounts is requested through the AccountManagerFacade that maintains the accounts cache. As soon as this cache is populated, it's safe to synchronously request the list of accounts. This CL adds an additional check to SignInPromo to not build the promo view until the cache is populated. The AccountsChangeObserver will notify the SignInPromo when the cache is built. Bug: 971618 Change-Id: I3e719bd16ceb077933de410e403d6f4692cf4578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710575Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688456}
-
Marc Treib authored
This flag should get removed soon (see bug), but let's keep it around until that actually happens. Bug: 990745 Change-Id: Ibaf96e78ebcb959ae6bcc44d71e3debced233405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760964 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/978eb0dc16f8..f66a25cd28ef Created with: gclient setdep -r src-internal@f66a25cd28ef The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:954450,chromium:956776 Change-Id: I6bdb036890005bb6b58eaad065892aaa5f049364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761699Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: Id9eae41b435aca6ce97a2fa5317d63e5b0d52d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734210Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#688453}
-
Oleg Davydov authored
We see in statistics that for some reason force-installed extensions stuck in CREATED stage. Generally it should never happen, since these extensions should immediately be moved to PENDING stage (or reported as failed). Unfortunately, we weren't able to reproduce it locally. To have the problem more localized we need to split CREATED->PENDING transition into substages. Bug: 989526 Change-Id: I4a3f1601dea67c0a75cec1c1ebcf07536ef8704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729252Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#688452}
-
