- 26 Aug, 2020 40 commits
-
-
Reilly Grant authored
This wrapper around BluetoothAdapterFactory is only used by WebBluetoothServiceImpl in order to support swapping out the BluetoothAdapter implementation during tests. Other Chromium code should not use it. Bug: 1116938 Change-Id: I9db8ec16f1d4647a557369f8698ccbbb120093fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373448 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#801859}
-
Shimi Zhang authored
Bug: 1105933b Change-Id: I293b77d7f0ddcb1d0aaefaf3de6e09fbe5594f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377068Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#801858}
-
David Black authored
No longer needed given evolution of feature requirements. Bug: 1112469 Change-Id: Ic31d2a02fcc624ddc101447f68089cfff9bd2660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377535Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801857}
-
Antonio Gomes authored
... and use WTF::Bind instead. Note that calls were within the same thread, so WTF::CrossThreadBindOnce were not needed. BUG=787252 R=guidou@chromium.org Change-Id: I9e3b5c7a28cbf9d2479c65e90c86cc758f63f564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364211 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801856}
-
Nazerke authored
As a tabmodel needs to be deprecated, this CL moves all CRWWebStateObserver functions into a web state list metrics browser agent and omnibox geolocation tab helper created here to move them out of TabModel. Bug: 1050116,1045575 Change-Id: I9b0f14c6fc89b5d7304a2cd2e5b5bd0af44838b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289856 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#801855}
-
Chris Cunningham authored
Measure interface usage by constructor calls. Bug: 1121462 Change-Id: Ibdac55925d918bf86ec5f01b7046b8c54b4671ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374506 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#801854}
-
Robert Ma authored
similar to https://crrev.com/c/2376484, without being limited to wpt-importer. Manually checked and adjusted the change. Fixed: 1115767 Change-Id: I54426b19dab75e5e5150220cae3afa7e2d165a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377111 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#801853}
-
Regan Hsu authored
* Moves PhoneHubManager to PhoneHubManagerImpl. * PhoneHubManagerImpl and FakePhoneHubManager are now derived classes. * FakePhoneHubManager will be used by the debug UI to be added in a later CL. Bug: 1106937 Change-Id: Iee1c6b4b787f36a7a50eb83fcd1ae1e626f7eecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375740Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801852}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4f8bdaf473fb..320c6c87b2ed 2020-08-26 enga@chromium.org Revert "Skip TextureSubresourceTest.MipmapLevelsTest on Vulkan w/ validation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I132ce7837e6ea3c6dfde2db17186771d664b2ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801851}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/91c0477b4332..c75c42807634 2020-08-26 hta@webrtc.org Fix current_direction() when stopping_ but not stopped_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:980879 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I02a0016fc621324be6273c0950c58e3295595776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378173Reviewed-by:
-
ckitagawa authored
Record if the early check for a paint preview returns false. This allows us to compute the overall success/failure ratio for all attempts to show a paint preview. Bug: 1109991 Change-Id: I6fdb3611d5182b64b628185017298a50b05dc311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377988Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Change-Id: Ifd31d6dd6f68ea67a4af0d432c7e0564039ace2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377984Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#801848}
-
Mohamed Heikal authored
removing the custom package in system_webview_shell_apk_resources broke compiling the shell with a different package name. Readd as a stop gap measure. Bug: 1121790 Change-Id: Ib73cae4bf39f0eb6af1ded6b1a292daea5936634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377429 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801847}
-
Peter Kasting authored
* Width was set wrong due to swapped conditional. * Height should always be fixed at one line, even if the name is long. Bug: 1112286,1112455 Change-Id: I677e52a0ef0b84f85382c4f6ae4899c6e42a9b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376550 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#801846}
-
Weilun Shi authored
Remove pretty-print and validate format comments in all xmls under histograms_xml/. Update their comments as well. Change-Id: Ifd3ceddb3e649bb3c28ffe6d8dc32b8a979a8b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376670 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Owen Min authored
This flag is introduced with https://codereview.chromium.org/250383004 as a way to disable the feature. Give that the feature has been launched for many years, we probably don't need this anymore. And it gives user a way to escape component cloud policy on desktop. Bug: 1119515 Change-Id: Icefcdc2ea49d9b25dbb535616befef427a53ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364960Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801844}
-
Jia Li authored
- Service launch/termination/crash: makes the implementation of `ServiceConnection` to observe and log these events. - Model loading/evaluation result/latency: directly log measurements from the ML Service. Bug: 1108337 Change-Id: I021c82a2a9b2aadec9402b392b82cb18d6076083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362337 Commit-Queue: Jia Li <jiakl@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801843}
-
Yusuf Sengul authored
Bug: 1119466 Change-Id: Iba472f30a4e5f9625f85a94d1a8e1d67999961cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363216Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#801842}
-
Alexander Dunaev authored
This is a follow-up to [1] where it had been noted that the JavascriptAppModalEventBlockerX11 does not depend on anything X11 and should be renamed. This CL only renames one class. No changes to any logic are intended. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2366745 Change-Id: I711abba94bef47d17f14e401be6ef7af2a272eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377485 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b4b787f0. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 461d94a8 "Never re-use the layout result from the fieldset contents wrapper." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-cascade NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia02d8e35b219f64621dbe0f9e33e4725904b0dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377426Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801840}
-
David Morejon authored
This is an automated transformation using https://github.com/Ecosystem-Infra/web-test-transformer. The tool verifies its transformations, all of these files run successfully after transformation. See the tool output: https://gist.github.com/dmorejon/8383b6b532b13b0446d3398d8bc13593 This commit is the raw tool changes. There might be some stylistic changes to be made manually. Bug: 1120356, 936364 Change-Id: Ia5ba295bf83312d4951e548cf0d078ff1d4506f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368851Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#801839}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/622558b02e1a..1f48854dae26 2020-08-26 capn@google.com Refactor image extent retrieval 2020-08-26 capn@google.com Refactor image view extent retrieval 2020-08-26 capn@google.com Refactor image query instructions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iea7788d582d7e134425b46167f9d4a0076be51ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378170Reviewed-by:
-
Scott Violet authored
Currently navigations triggered from the embedder use a navigation type of LINK. LINK navigations (mostly) result in processing intents. This is not always desirable (for example, the SRP shouldn't trigger intents). This patch adds the ability to disable Intent processing. I went with a function to disable vs an explicit setter as I don't think we need support for an absolute 'true' case. By that I mean if I did add a function like setIntentProcessingEnabled(boolean value), the implication is 'true' means intent processing always happens. In code that isn't the case though, for example, a same host navigation may not trigger intent resolution. As we don't need the ability to force intent processing, I'm avoiding it for now. BUG=1119365 TEST=covered by android tests Change-Id: Ib374c1d61ce0795654a677b1ff29128f39c75bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369516Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801837}
-
Scott Violet authored
This gives the core stability metrics. BUG=1120537 TEST=covered by weblayer_browsertests Change-Id: I22e99959dacb9b9593af02cea70088d449e604a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376565Reviewed-by:
-
Omer Katz authored
Change-Id: Ia475d5bd55bbf621c26c782c25d40b861a9de817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376821 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#801835}
-
Gavin Williams authored
This change guarantees the USB printer config and the print job notfications only use the OffTheRecord(OTR) profile to open System Web Apps(SWA) in Guest mode. There is an existing check (https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/browser.cc;l=471) that only OTR guest profiles are allowed to open SWAs. Change-Id: I78aef11b2d2cb8377f17ecd90f494828119ddf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372909Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#801834}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f786caa5d60..09ec5ae5729e 2020-08-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-26 dburger@chromium.org Don't blow up when fsi config has no applicable models. 2020-08-26 engeg@google.com chromeos_config.py: fix typeo 2020-08-25 pprabhu@chromium.org Update test platform OWNERS 2020-08-25 kevinruvalcaba@google.com Added support for histogram creation. 2020-08-25 mmortensen@google.com contrib scripts: Change from prodaccess to gcert. 2020-08-25 pprabhu@chromium.org cbuildbot: Bump skylab tool version 2020-08-25 mmortensen@google.com query_build_logs: Change from prodaccess to gcert. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iefae62b0ce0d17ec3f668a69fc745d8757397db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378189Reviewed-by:
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1121520 Change-Id: I8902f847eea98a129ee50822fee5e893d6310f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377006Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#801832}
-
Avi Drissman authored
The OOM death tests used an allocation value of MAX_LONG minus 12k. The problem with that value is that, on systems like the Mac DTKs that have 16k VM pages, that gets rounded up and wraps. Therefore, abstract it into “subtract three pages”. Bug: 1121749 Change-Id: I6c519200cbd848c095b741d78f51317ea6ef18b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376887 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801831}
-
Matt Menke authored
The NetLogViewer automatically resolves "net_error" fields to net::Error errors, but does do that for "error". I believe this will require a followup CL to update where the NetLogViewer's DNS tab gets network error string from. Fixed: 1122054 Change-Id: Ifd74a988999d6142634f412e73929f568af536ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375602 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801830}
-
Chong Gu authored
This will add ~20 minutes of bot time and ~2 minutes of run time per build. The bots required to run these tests have been approved in crbug.com/1100546 Bug: 1058255 Change-Id: I542bce2dae6b8d0c84d50d8b595044445c31f406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377306 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#801829}
-
Linkun Chen authored
To hide internal folder names. Test: build locally with internal change Bug: b/165815398 Merge-With: eureka-internal/442206 Change-Id: Ibb17c47f37c796d2513ad1b6dfd52a282903bddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373289Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801828}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e23bb2ed..46f5bd5e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6120f4baa4d74393235fb1aecc5b8b2226361ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801827}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb9ee39c41d4..f60cabfb25c4 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/CSSWorkspaceBinding.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I50b1279828bdd88bc077c5cb79ec7eb92ff059e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378190Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7023f47299aa..0fdfdcf61cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic987c90c981da679d5d0a34316dabfb3f45fcef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378086Reviewed-by:
-
Peng Huang authored
Bug: 1034840,1122020 Change-Id: Ia2dceed245c16b66d35b513f614656a27acde076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377231 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#801824}
-
Brandon Wylie authored
This reverts commit c4aceb16. Reason for revert: ContactsPicker tests failing on android-bfcache-rel see crbug.com/1122069 Original change's description: > Move Contacts Picker to //components/browser_ui/contacts_picker > > Bug: 1016938 > Change-Id: Ib3a86b4a3e3c0356c292ce55291ef0487e94c5ae > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325272 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801610} TBR=dcheng@chromium.org,finnur@chromium.org,estade@chromium.org,tedchoc@chromium.org,wfh@chromium.org,lazzzis@google.com Change-Id: Ie79da9732fafd575886793b15fc6b1bcf908d9cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378268Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801823}
-
Amr Aboelkher authored
This reverts commit 3bc91ccc. Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329 Original change's description: > [Perfect Negotiation] Surface session descriptions at the right time. > > This fixes another timing related issue that blocks Perfect Negotiation. > > Before this CL, current/pending local/remote description attributes do > blocking-invokes on the webrtc thread, fetching the most up-to-date > states. This can prematurely expose the result of "in-parallel" > operations that have not surfaced yet, such as: > - setLocalDescription > - setRemoteDescription > - addIceCandidate > > This CL fixes that by copying the SDP states when any of these > operations complete on the WebRTC thread and carry them over in the > PostTask to the main thread. Here, we store these snapshots in > "internal slots" (variables living on the main thread). With this CL, > reading SDP attributes from RTCPeerConnection is non-blocking and > spec-compliant. > > WPT test coverage added for the exact timing of SLD/SRD and other test > expectations are updated. addIceCandidate updating the SDP is already > covered by old WPTs. > > Bug: chromium:1110347 > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801798} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#801822}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95c5b87ad1a3..ee3d26b3cdc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,amraboelkher@google.com Change-Id: I36b0ee36306f65fd58bc14f2e2b4645dd86dd5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
The code previously added an IME guard but it was removed when moving this into blink and the showing/hiding of the virtual keyboard was done on the HandlingInputState object itself. (via change https://chromium-review.googlesource.com/c/chromium/src/+/2212805). he IME guard prevents intermediate changes when handling an event. This was problematic for TinyIME because the text input mode changed between the processing of the event which caused the virtual keyboard to be dismissed. This change makes the code behave exactly the same before the move to blink. It can't be merged into M85 due to that branch only having part of the changes. So if it needs to go there it will need to be written separately. BUG=1121179 Change-Id: Ida425dedd240a3c2e36b458d45f04433c6d31963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373363 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801820}
-
