- 09 Jan, 2013 40 commits
-
-
ccameron@chromium.org authored
> Revert 175753 > > Add a pass/fail test to verify that GPU memory usage doesn't grow beyond an acceptable level when using CSS (managed memory) and WebGL (unmanaged memory). > > > > BUG=135525 > > > > Review URL: https://chromiumcodereview.appspot.com/11667030 > > This is causing linux debug compilation failures > > TBR=ccameron@chromium.org > Review URL: https://codereview.chromium.org/11826022 > Only revert the use of kForceGpuMemAvailableMb flag. TBR=ricow@chromium.org Review URL: https://chromiumcodereview.appspot.com/11826030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175913 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
. Expose TableHeader::kHorizontalPadding so that it can be used in calculating preferred width of a column. . Make TableHeader::OnMousePressed return false if not the left mouse button. This lets context menus on an ancestor work. . Exposes couple of methods on TableView used by TaskManager. . Fixes sizes in TableView. . Turns on grouping in table example. BUG=none TEST=none R=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/11827007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175912 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
reattaching multiple tabs we wouldn't repaint the whole tabstrip. The fix is to key off the selection model rather than the dragged property since the dragged property is updated after animations complete. BUG=167886 TEST=see bug R=ben@chromium.org Review URL: https://codereview.chromium.org/11830009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175911 0039d316-1c4b-4281-b951-d872f2087c98
-
beaudoin@chromium.org authored
This patch ensures SearchTabHelper no longer relies on the hardcoded "espv" parameter. Depends on: https://codereview.chromium.org/11552020/ https://codereview.chromium.org/11576044/ BUG=161602 Review URL: https://chromiumcodereview.appspot.com/11585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175910 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
This was added awhile back particularly for testing with IMEs. Simulating these events is done in the browser, but that support is going away soon. We could switch to simulating these events in ChromeDriver itself, but I don't see a strong case for doing so right now, so we're dropping support. If the user attempts to set chrome.nativeEvents to true, they will receive an error. We ignore the normal nativeEvents capability and always report to the user that we are using native events, since the normal way we simulate events is close enough to OS-level events. BUG=none Review URL: https://chromiumcodereview.appspot.com/11818029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175909 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Include sequence number in RootWindow's name so that we can tell in which root window a window is in. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11825015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175908 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
This is in preparation of componentizing VisitedLink implementation and be shared with Android WebView. * Added VisitedLinkDelegate which HistoryService implements. * Removed VisitedLinkMasterFactory and have HistoryService directly own VisitedLinkMaster. * Introduce URLIterator interface for DeleteURLs. Last committed in https://src.chromium.org/viewvc/chrome?view=rev&revision=175186 Reverted in https://src.chromium.org/viewvc/chrome?view=rev&revision=175217 due to memory leaks. Before this patch, VisitedLink was a ProfileKeyedService and some using HistoryService did not create VisitedLink at all. After this patch, VisitedLink is created and owned directly by HistoryService, so they are now created for some tests depending on which HistoryService constructor is used. First version was leaking URLEnumerator in HistoryService::RebuildTable which was doing manual ref counting (AddRef/Release) calls. Some tests do not start the background thread at all, so URLEnumerator::OnComplete is never called to delete itself. Fixed by properly ref-counting URLEnumerator with scoped_refptr in this path. BUG=168716 Review URL: https://chromiumcodereview.appspot.com/11573060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175906 0039d316-1c4b-4281-b951-d872f2087c98
-
miket@chromium.org authored
This work fell out of a notification API change where I finally figured out that the EventNotifier wasn't the best way to send events back to the caller. We're now using a more standard Event scheme (which, in my defense, might not have existed back when AREN was conceived). Dead code eliminated. BUG=164249 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11636050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175905 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
The nexes are still built so we can run SRPC tests. BUG=154443 TEST=manual Review URL: https://chromiumcodereview.appspot.com/11783036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175904 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
Makes ServerBoundCertService::RequestHandle a real class which handles cancellation on destruction, instead of being just a void* handle. BUG=167705 Review URL: https://chromiumcodereview.appspot.com/11689002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175902 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
BUG=none TEST=any NaCl test on Linux Review URL: https://codereview.chromium.org/11819022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175901 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=168602 TEST=existing unittests Review URL: https://codereview.chromium.org/11786006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175900 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/11649054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175899 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
<webview>: BrowserPlugin methods are not defined immediately after the shadow object is appended to the shadow root BUG=169038 Test=manually Review URL: https://chromiumcodereview.appspot.com/11820029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175897 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
Step got dropped in python refactor. Adding it back. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11829034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175896 0039d316-1c4b-4281-b951-d872f2087c98
-
rmsousa@chromium.org authored
NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11818011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175895 0039d316-1c4b-4281-b951-d872f2087c98
-
craigdh@chromium.org authored
BUG=167331 TEST=run_tests.py -v -e -n 2 Review URL: https://codereview.chromium.org/11801016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175894 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Also, don't mark a test as finished until the top frame stopped loading. BUG=111316 R=marja@chromium.org Review URL: https://chromiumcodereview.appspot.com/11830020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175893 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
With the context checking DCHECK, ash_unittests and unit_tests now run on chromeos. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11801027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175892 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
This generates grd files from the three strings.xml files, as part of translating the strings.xml strings. This also adds empty translation files (xtb files) so that the grd files can be successfully built even before real translations are available. BUG=165551 Review URL: https://chromiumcodereview.appspot.com/11829009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175891 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content. > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content. > Review URL: https://codereview.chromium.org/11783038 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/11818036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175890 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
This CL adds a help center link to the infobar which is displayed when a NaCl app doesn't support the user's architecture. R=jvoung@chromium.org,sehr@chromium.org (code), cstefansen (URL) BUG= http://code.google.com/p/chromium/issues/detail?id=168607 Review URL: https://chromiumcodereview.appspot.com/11593020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175889 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
Apparently the problem is in non-media code. See http://crbug.com/166528 > Disable Http/MediaTest.VideoBearWavPcm/0 to stop ASAN failures. > > BUG=169031 > TBR=scherkus@chromium.org > > Review URL: https://codereview.chromium.org/11817021 TBR=acolwell@chromium.org Review URL: https://codereview.chromium.org/11821035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175888 0039d316-1c4b-4281-b951-d872f2087c98
-
kristianm@chromium.org authored
It is always false and not planned to be supported BUG= Review URL: https://chromiumcodereview.appspot.com/11785011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175887 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
TBR=tonyg CC=sullivan Review URL: https://codereview.chromium.org/11778070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175886 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
bb_tests was not passing in the path to adb to adb_logcat_monitor.py, which broke the command. R=boliu@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11827031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175885 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
For textures, delay allocating until the first setPixels or beginSetPixels. This allows us to do a combined async allocation/upload in beginSetPixels. BUG=161337 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173875 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174035 Review URL: https://chromiumcodereview.appspot.com/11622008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175884 0039d316-1c4b-4281-b951-d872f2087c98
-
wxjg68@motorola.com authored
DEPS rules to make visitedlink independent of chrome/browser except chrome/browser/[api, common] BUG=none Review URL: https://chromiumcodereview.appspot.com/11746027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175883 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Touch-events targetted to the root-window can be handled. This can happen when, for example, an event handler is installed on the Env, or the RootWindow, which takes some action based on the touch event. BUG=chrome-os-partner:17053 Review URL: https://codereview.chromium.org/11833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175882 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11824012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175881 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175880 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
The python unittest failed to run setUpClass/tearDownClass because of python version is 2.6 in pyauto bots. This CL makes a workaround to fix this issue. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11830030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175879 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@chromium.org authored
TBR=noel TEST= BUG= Review URL: https://chromiumcodereview.appspot.com/11820028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175878 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
This moves thread pool related code out of the tile manager and into a new RasterWorkerPool class. This doesn't change the behavior of the tile manager in any way it just separates tile management logic from the thread handling logic, which results in a significant cleanup of the tile manager. BUG=155209 TEST=manual Review URL: https://chromiumcodereview.appspot.com/11593030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175877 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
In order to facilitate the move to MessageCenterNotificationManager, we need to be able to determine when message_center.gyp is being included in the build. This change defines ENABLE_MESSAGE_CENTER which can be used for conditional compilation. r=stevenjb@chromium.org TBR=ben@chromium.org BUG=168605 Review URL: https://chromiumcodereview.appspot.com/11791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175876 0039d316-1c4b-4281-b951-d872f2087c98
-
pilgrim@chromium.org authored
Fix the last of the #includes and OVERRIDEs in preparation for removing WebKitPlatformSupport upstream. Review URL: https://chromiumcodereview.appspot.com/11821025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175875 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=168648 Review URL: https://chromiumcodereview.appspot.com/11734009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175874 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
callbacks for methods without any parameters, and it wasn't showing properties for objects within arrays. Review URL: https://codereview.chromium.org/11823033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175873 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
The existing code: choose the newer items, the new code: choose the older items I wrote this existing code, but I was wrong. BUG=165768 TEST=message_center_unittests passed Review URL: https://chromiumcodereview.appspot.com/11827010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175872 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
This change appears to be breaking the ChromeOS(x86) and ChromeOS(amd64) bots. http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11010 > Clean up: remove unnecessary if-branches on initialization of the a11y prefs. > > According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements. > > BUG=none > TEST=launch ChromeOS, and login. > > Review URL: https://chromiumcodereview.appspot.com/11820018 TBR=yoshiki@chromium.org Review URL: https://codereview.chromium.org/11817029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175871 0039d316-1c4b-4281-b951-d872f2087c98
-