GitLab

Make the Linux implementation of FontRenderParams force full
hinting (along with disabling subpixel rendering and
positioning) when antialiasing is disabled. Cairo also
forces full hinting in this case.

BUG=396239

Review URL: https://codereview.chromium.org/417003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285462 0039d316-1c4b-4281-b951-d872f2087c98

I hit this building views_examples_exe on Mac with TOOLKIT_VIEWS=1.

error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]

Added in r264669.

BUG=NONE
TEST=NONE
TBR=sadrul@chromium.org,hshi@chromium.org

Review URL: https://codereview.chromium.org/413303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285461 0039d316-1c4b-4281-b951-d872f2087c98

The CL:

 * Add rotation property to the Viewport class.
 * Update the rotation property by the TouchHandler class.
 * Reset Viewport properties when changing the image.

BUG=390695
TEST=on link
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/416023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285460 0039d316-1c4b-4281-b951-d872f2087c98

PrintPreviewPdfGeneratedBrowserTest now properly reads from |std::cin| removing an edge case where |std::cin.eof()| is false, but |input.empty()| is true. The test also properly exits and doesn't wait for SIGKILL anymore.
BUG=388517

Review URL: https://codereview.chromium.org/414623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285459 0039d316-1c4b-4281-b951-d872f2087c98

They were previously enabled in shared_library builds for historical reasons.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Previous attemps failed due to:
- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/420593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397242

Review URL: https://codereview.chromium.org/419603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285457 0039d316-1c4b-4281-b951-d872f2087c98

Tested:
* Search for "qrty.com" repeatedly.  Verify that when you type "q", a search for "qrty.com" does not get inline autocompleted.  This is the same as the behavior before this changelist.  Without the Classify() code, this suppression of the inline autocompletion does not happen.
* Check speed.  Search for "testing 1", "testing 2", ... "testing 13", ...  i.e., create a lot of searches starting with "t".  Restart browser.  Open seven blank new tabs and two separate tabs of about:histograms.  In each blank tab, type "t"; don't hit return.  Reload one of the histograms tabs.  Compare the Omnibox.ProviderTime.Search histogram in the  non-reloaded histograms tab with the reloaded histograms tab.
  - in current chrome (before this patch), I see a difference in the laggy section of the histogram.  In my testing, I see 7 new entries in the 129-204ms bucket.  Ugh.
  - in chrome built with this patch, I see a difference in the 13-21ms bucket; no different in higher buckets.

BUG=393956, 262263

Review URL: https://codereview.chromium.org/412063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285456 0039d316-1c4b-4281-b951-d872f2087c98

Added a default timeout interval (8s) to Cast API. Will expose to callers in a followup CL. 8s seconds was selected (rather arbitrarily) to match cloudview.sender.ChannelService.CHANNEL_CREATION_TIMEOUT_ from the extension.
 
Miscellaneous minor doc fixes, and lint-friendly cleanups.

BUG=335221
R=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/393023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285455 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285454 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285453 0039d316-1c4b-4281-b951-d872f2087c98

another attempt at https://codereview.chromium.org/408063002/ to try fixing
the iOS Simulator:URLFixerTest failures writing to DIR_TEST_DATA.

R=nyquist@chromium.org
TBR=brettw@chromium.org, nyquist@chromium.org, sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/411253010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285451 0039d316-1c4b-4281-b951-d872f2087c98

Chrome OS requires app_locale_strings for font configuration information,
so it needs to be part of the .pak file for extensions_unittests.

BUG=397245
TEST=build extensions_unittests with chromeos=1, it doesn't crash on start

Review URL: https://codereview.chromium.org/418133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285450 0039d316-1c4b-4281-b951-d872f2087c98

Add a trace event to MemoryPressureListener::NotifyMemoryPressure to enable
tracking of whether any jank is caused by dealing with memory pressure
notifications.

BUG=397026

Review URL: https://codereview.chromium.org/413233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285449 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix for the following situation: If we have no skewport,
then in operator++ we call advance phase after we process all visible
tiles, however because the skewport yields no tiles, we immediately
skip to the eventually bin, since the soon iterator construction
was in operator++ instead of advance phase.

The reason this passed unittests is that there was a second bug in
which we would process the eventually rect without ignoring the soon
rect, which caused the same tiles to show up.

This patch fixes both bugs. The first one is fixed by moving tiling
data iterator construction to be in advancephase in all cases. 
The second bug changes the iterator to iterate around the soon
rect instead of the visible rect.

R=reveman

Review URL: https://codereview.chromium.org/413053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=219446
R=satorux@chromium.org,dbeam@chromium.org,asvitkine@chromium.org

satorux@:   c/b/chromeos/preferences.cc
dbeam@:     c/b/resources/options
            c/b/ui/webui/options
asvitkine@: actions.xml

Review URL: https://codereview.chromium.org/393023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285447 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/418723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395354

Review URL: https://codereview.chromium.org/416153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349162
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/418943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285441 0039d316-1c4b-4281-b951-d872f2087c98

For IndexedDB files in third_party/leveldatabase:

1. "git cl lint" now runs with no warnings.
2. "git cl format" makes no changes.

BUG=381456

Review URL: https://codereview.chromium.org/416633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285440 0039d316-1c4b-4281-b951-d872f2087c98

Adding UMAs to count the number of bytes that did not go through Flywheel as the result of a bypass event.

DataReductionProxy.BypassedBytes.NotBypassed
DataReductionProxy.BypassedBytes.SSL
DataReductionProxy.BypassedBytes.LocalBypassRules
DataReductionProxy.BypassedBytes.ShortAll
DataReductionProxy.BypassedBytes.ShortTriggeringRequest
DataReductionProxy.BypassedBytes.ShortAudioVideo
DataReductionProxy.BypassedBytes.MediumAll
DataReductionProxy.BypassedBytes.MediumTriggeringRequest
DataReductionProxy.BypassedBytes.LongAll
DataReductionProxy.BypassedBytes.LongTriggeringRequest
DataReductionProxy.BypassedBytes.MissingViaHeader4xx
DataReductionProxy.BypassedBytes.MissingViaHeaderOther
DataReductionProxy.BypassedBytes.Malformed407
DataReductionProxy.BypassedBytes.Status500HttpInternalServerError
DataReductionProxy.BypassedBytes.Status502HttpBadGateway
DataReductionProxy.BypassedBytes.ServiceUnavailable
DataReductionProxy.BypassedBytes.NetworkErrorOther

BUG=381416, 384369

Review URL: https://codereview.chromium.org/390533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285439 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/415273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285438 0039d316-1c4b-4281-b951-d872f2087c98

Block in a loop if we get a specific failure on a particular bot.
See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference.

Timeout raise attempted at https://codereview.chromium.org/410353004/ so
that there will be time to attach a debugger.

R=brettw@chromium.org
BUG=340422

Review URL: https://codereview.chromium.org/411223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285437 0039d316-1c4b-4281-b951-d872f2087c98

Blink should make use of blink_resources.grd for the inline resources of inspector.
This removes the dependency upon using xxd.py which embeds these resources as strings.

Part 1: https://crrev.com/401233003
Part 3: https://crrev.com/402033002

BUG=312586

Review URL: https://codereview.chromium.org/403273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285436 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that recursedeps by itself doesn't really work properly on the
bots, and so we need to change things in gclient and the bot scripts
before we can use recursedeps for this. Reverting this change in the
meantime to avoid confusion.

TBR=eseidel@chromium.org, cmp@chromium.org
BUG=395862

Review URL: https://codereview.chromium.org/420613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285435 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise,

[5f88f5f5...]d:\src\cr\src>out\release\gn gen out_gn
ERROR at //third_party/boringssl/BUILD.gn:58:7: Undefined variable for +=.
      defines += [ "OPENSSL_NO_ASM" ]
      ^------
I don't have something with this name in scope now.

on Windows.

TBR=brettw@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/412413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285433 0039d316-1c4b-4281-b951-d872f2087c98

of this feature.

TBR=darin

Review URL: https://codereview.chromium.org/356713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285432 0039d316-1c4b-4281-b951-d872f2087c98

The frame shouldn't be modified by the aggregator, or else it will be broken if GetEligibleFrame is called again.
Also modify ScopedPtrVector::const_iterator to make it const-correct.

BUG=

Review URL: https://codereview.chromium.org/417843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285431 0039d316-1c4b-4281-b951-d872f2087c98

Should be okay now, according to my local testing (see crbug.com/389666,
etc.; crrev.com/285139 also fixed a use-after-free that would be picked
up by this test on Debug builds).

> Revert 283562 "Mojo: Enable mojo_shell_tests on Windows (on the ..."
>
> Blech: Stuff fails. Shockingly.
> http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/27268/steps/mojo_shell_tests/logs/stdio
>
> > Mojo: Enable mojo_shell_tests on Windows (on the bots).
> >
> > R=sky@chromium.org
> >
> > Review URL: https://codereview.chromium.org/398023002
>
> TBR=viettrungluu@chromium.org
>
> Review URL: https://codereview.chromium.org/398253002

TBR=viettrungluu@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/413263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285430 0039d316-1c4b-4281-b951-d872f2087c98

This CL doesn't yet include any emulation of network
characteristics (latency, bandwidth, etc.). I'm going to
implement it in a separate CL.

BUG=394067
R=rmsousa@chromium.org, ttuttle@chromium.org
TBR=ttuttle@chromium.org (DEPS on net in remoting/test)

Review URL: https://codereview.chromium.org/394883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285429 0039d316-1c4b-4281-b951-d872f2087c98

LocalWriteClosure only had a raw pointer to a ChainedBlobWriter which
was held by a scoped_refptr in IndexedDBBackingStore::Transaction. If
the transaction was deleted before writeBlobToFileOnIOThread was called
then a crash would ensue. Converted raw ptr to scoped_refptr prevents this.

BUG=395650

Review URL: https://codereview.chromium.org/417573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396779

Review URL: https://codereview.chromium.org/417853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285427 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/418993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285426 0039d316-1c4b-4281-b951-d872f2087c98

Add a new struct that encapsulates the parameters used to
initialize FontRenderParams.

Also remove all the existing FontRenderParams functions in
favor of a single GetFontRenderParams() function that takes
a FontRenderParamsQuery.

BUG=395313,396659
TBR=boliu@chromium.org

Review URL: https://codereview.chromium.org/413003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364243,396970

Review URL: https://codereview.chromium.org/415013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285424 0039d316-1c4b-4281-b951-d872f2087c98

During signin, when ChromeOS requests refresh token, get
signin scoped device_id from SigninClient and pass it to GaiaAuthFetcher.

BUG=382968
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/382983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285422 0039d316-1c4b-4281-b951-d872f2087c98

Tests use //net so a message loop is required.

BUG=395358

Review URL: https://codereview.chromium.org/411393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285419 0039d316-1c4b-4281-b951-d872f2087c98

This change puts nexe information in the parameters for starting a NaCl
plugin instead of sending that information over SRPC. This may remove the
need for that IPC round trip entirely; perhaps we could report load failure
as part of the RPCs for starting sel_ldr or performing StartModule().

nacl_defines.gypi as added as a dependency in components/components_tests.gyp
because nacl_process_host.h now includes
"native_client/src/public/nacl_file_info.h", which requires nacl_defines.

BUG=333950
R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285028

Review URL: https://codereview.chromium.org/332463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285418 0039d316-1c4b-4281-b951-d872f2087c98

This was only used by the background mode manager, and didn't actually
do what it needed. Now background mode manager doesn't use this so it
can be removed.

BUG=361637

Review URL: https://codereview.chromium.org/417843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285417 0039d316-1c4b-4281-b951-d872f2087c98

This feature has been available on Windows and Mac for some time, but
was never made available on ChromeOS.

BUG=371642

Review URL: https://codereview.chromium.org/407073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285416 0039d316-1c4b-4281-b951-d872f2087c98

Modifies the sync fake server so it derives the IDs for client-tagged
items based on their model type and unique client tag.

This fixes a race where two clients could simultaneously commit two
client-tagged items with version == 0, and the two committed items would
be assigned different IDs.  The correct behavior, and that of the real
sync server, is to assign the same IDs to items that have the same
client tags.

BUG=396859

Review URL: https://codereview.chromium.org/414953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285415 0039d316-1c4b-4281-b951-d872f2087c98