- 07 Mar, 2019 40 commits
-
-
Dave Tapuska authored
Chrome currently fails these tests and it will be enabled in a followup patch. The intent of this change is to add the wpt tests and bring the code closer to the proposed specification. BUG=348877 Change-Id: Ie9894c588b2cfe040be97905617b05c5b49fc4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479576 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638586}
-
Tanja Gornak authored
Currently fcm channel and subscription to topics use same enum in order to track their state. This Cl introduces separate enum for the Subscription channel state tracking. Bug: 801985, 878446 Change-Id: If5a4781fdd2e12b8d94245375a1480e237248321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505441Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#638585}
-
behdad authored
Bug: chromium:938514 Change-Id: I85231184360c8040f5bd78d0775aa634452de25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504044 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638584}
-
Monica Salama authored
Log native code's resident pages. Use the data for visualization and analysis. This work will help in assessing code ordering and will give insight on how to improve it. Bug: 933377 Change-Id: If93f7c07f74111e5a5bb50567453cc9b202219df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482976 Commit-Queue: Monica Salama <msalama@google.com> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638583}
-
Marc Treib authored
Previously, the auth error handling logic existed twice, depending on whether the initial setup was finished or not. This CL deduplicates the code. This causes two small behavior differences: 1) Before, a TWO_FACTOR auth error was treated as "okay" if first-time setup was incomplete, but treated as an error otherwise. That just seems like an oversight. 2) Before, if there was an auth error while we were also missing the Sync confirmation, we'd show a "missing confirmation" message. Now we'll show "auth error" instead. This CL also relaxes the nullable-restrictions on output params: |status_label|, |link_label| and |action_type| can now all independently be null or not. Bug: 911153 Change-Id: Ic2e5174c2596114725f6816d4f385ebf5c50ece6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507872 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#638582}
-
Ben Kelly authored
Previously the Response mime type was never set when reading from a Cache. This resulted in empty string blob.type values and could also prevent code cache from being generated if a script Response was put back into a Cache. This CL makes us at least generate a mime type from the current content-type header. This is a partial solution since the mime type should technically be frozen at initial Response construction time even if the content-type header is later changed. To support that we will need to explicitly store a mime type on disk in the cache. This will be done later in crbug.com/938939. Bug: 937963,938939 Change-Id: Iabfe3909ff35957501ef33132af2a0c1f70c5c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506213 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#638581}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141e92bdd2cc..5b257f91fc81 Created with: gclient setdep -r src-internal@5b257f91fc81 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:939049 TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Iecfb3aaee8590497b26d22ddfce778b75dcab986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638580}
-
Anna Malova authored
When loading a dynamic module from dex we need to create ClassLoader in advance as part of warmup without loading a module. See also: http://crrev.com/c/1479331 Bug: 924118 Change-Id: Ib7e7250eec8fe9c7f2ce27abe1c031f6dec8d270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506513 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638579}
-
Tamer Tas authored
This CL creates the src side configuration for a V8 waterfall bot. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: 883629 Change-Id: Ia3afccfd8aff1035d0ac0c5ac425d951f0f20c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508514 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#638578}
-
Marc Treib authored
This adds a bit more detail on most model types, and removes comments for deprecated types. Bug: none Change-Id: Ia5434dc89e91a9572a25793ccc9bf8e905723463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506075 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638577}
-
Lowell Manners authored
This CL merges OnRequestCompleted's logic into OnTokenRequestCompleted. There wasn't enough logic to warrant a separate method. Bug: 933109 Change-Id: I2074518187f6078ae2d5c22935aa8a4e911837fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505498 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638576}
-
Sigurdur Asgeirsson authored
As of https://chromium-review.googlesource.com/c/1425042, content/ no longer provides forwarding for the ResourceCoordinator instrumentation interfaces. This was a step in a larger refactoring, but had the effect of orphaning the instrumentation in all but the chrome/browser embedder. This in turn led to a memory regression in the Android WebView. This CL makes the initialization and the usage of the instrumentation interfaces conditional on a runtime flag, which is only set by the ChromeContentRendererClient. This is still an intermediate state in the refactoring, as the interfaces in question will be moved and simplified. Bug: 926426 Change-Id: Ia640f544b536bf86d53e853de6178aeaf9c9b6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496303 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#638575}
-
dstockwell authored
* Adjusts size/location of icons and focus/hover/active states. * Makes viewer-toolbar-dropdown use a single paper-button to avoid overlapping focus/ripple. * Removes focus when a dropdown is cancelled by pointer events. Spec: go/pdf-icon-states-spec Impl: go/pdf-icon-states-impl Bug: 902646 Change-Id: If3bee9f86c8fa9f50537c8ff3cc4e3a9011172eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508014 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638574}
-
Elly Fong-Jones authored
This flag (& the code it guards) will be dead by the end of 2020, so around M88. Bug: None Change-Id: Icece1bf07e1d4c7976f68054a156cc0daf50b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505993 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638573}
-
Sylvain Defresne authored
The method should return an AccountInfo even if some of the information is missing (i.e. has not been fetched by AccountFetcherService yet) as the tests usually do not set extended information on AccountInfo. Bug: 926204 Change-Id: Iba9fafa25914618eefd09310cf91739159373895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503456Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638572}
-
Rune Lillesveen authored
There is no spec saying this should happen. Neither Gecko nor WebKit does this, and it breaks devtools UX. We still need to stop propagation into UA shadow trees to avoid text-decoration applying to media controls, for instance. Bug: 938193 Change-Id: I21895cb36b0d0bf2b39b42c000d3cf5ceb4255f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508097Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638571}
-
Mohamed Amir Yosef authored
PasswordSyncBridge works under the assumption that it knows all entries in the LoginDatabase, therefore any AddLoginSync() should return exactly one change. This doesn't look to be the case. This CL is relaxing that assumptionfor now till the underlying issue is discovered. Bug: 939302 Change-Id: Ic0f6a11c439f29314149a39cbbd91288e1d909a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508093 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638570}
-
G. Silva authored
Bug: 935711 Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: G. Silva <gfaus@chromium.org> Cr-Commit-Position: refs/heads/master@{#638569}
-
Matthew Cary authored
This is needed by automated tools like third_party/catapult/devil to examine the application details of a bundle. Bug: 931269 Change-Id: I000bd53d444390778657e12a4d64ca0e06f38aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477022Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638568}
-
Bryan McQuade authored
Change-Id: I81602ca1ddae82456fecc5a14e98f844093405bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506001 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#638567}
-
Ulan Degenbaev authored
Bug: 938937 Change-Id: I7326f03b28d50a826552c8b1335989daa7ed0f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506078Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638566}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/579cf621f3dc..aa9d6ad09d0d git log 579cf621f3dc..aa9d6ad09d0d --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cwallez@chromium.org Only build "common" on supported systems Created with: gclient setdep -r src/third_party/dawn@aa9d6ad09d0d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ifac156af40540ae6df026c3ff1f47c7ba6f3500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638565}
-
Alexandre Frechette authored
Bug: 902354, 872096 Change-Id: I34307383106d14fa123a9a93063869e1a7fc734d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500433 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638564}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/310f45e6d446..141e92bdd2cc Created with: gclient setdep -r src-internal@141e92bdd2cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I5936100165e618e04300c4875aaddf1a1530e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508493Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638563}
-
dstockwell authored
Time taken to load Web Assembly module causes the test to timeout. Bug: 920684 Change-Id: I6d16428cf8716e8d4203523a55dcd2b2fbfe50b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508015 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638562}
-
Hans Wennborg authored
This reverts commit 78d6b995. Reason for revert: This broke the coverage builds, see e.g. https://ci.chromium.org/p/chromium/builders/ci/ToTLinuxCoverage/6258 which fails with: "/bin/sh: 1: ../../build/toolchain/clang_code_coverage_wrapper.py--target-os=linux: not found" I guess there's a missing space before --target-os. Could this have been found in testing? Original change's description: > Use the wrapper script in all coverage builds. > > Previously the wrapper script would only be used for coverage builds > that required selective instrumentation of specific files. Now it > will also be used for any coverage builds. > > Since the script's job is to remove flags from files that shouldn't > have them the default_coverage config now adds to cflags even in a > CQ build. > > Bug: 918215 > Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638321} TBR=stgao@chromium.org,dpranke@chromium.org,robertocn@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org,sajjadm@google.com Change-Id: I8a945239dadc84d5e1c55a94ee84e34f413e54d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508457Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#638561}
-
Michael Hablich authored
This is a roll-back to V8 7.4.288. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: Ia8f8d42dbdeb270b72ffa21399257552628b062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508095Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638560}
-
Mohamed Abdelhalim authored
Remove unused includes and members from NavigationHandleImpl. Change-Id: I8aca71e2d8044623ca88c9c166616d31172e357c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505436Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Cr-Commit-Position: refs/heads/master@{#638559}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc1308550f58..c0eace27e740 git log cc1308550f58..c0eace27e740 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 taylori@google.com perfetto-ui: Show time with units Created with: gclient setdep -r src/third_party/perfetto@c0eace27e740 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iacf960e98218dbb88e76ffbbf9ee90756938d296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638558}
-
Takuto Ikuta authored
Header generating action needs to be in public_deps Bug: 931596 Change-Id: Ie69a72a1ab22d839f337e9a3cb7cf105fec43163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508472 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638557}
-
Anna Malova authored
Bug: 924118 Change-Id: I4a2420ba610a7e47cc4ca3ec90eef825081a0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479331Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#638556}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 689d7721. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" ab40da96 "Isolation: Remove isolation if we have non-svg replaced content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib6bf6d90b468c369584d691af024594fd9066ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508033Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638555}
-
Caio Lima authored
Create interface URLCheckerClient to request server and check URL. Create SafeSearchURLCheckerClient to check url using safesearch. Leave only the synchronous logic in URLChecker. BUG=934444 Change-Id: I53106ead0a478227960b49faa27a5d5c9d5c982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479971 Commit-Queue: Caio Lima <caiol@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638554}
-
Leszek Swirski authored
This is a reland of 96c748b0 Robustified the flaky test by using TestingPlatformSupportWithMockScheduler to run the scheduler until exhaustion (fun fact, seems that the live version of the script streaming wasn't being tested by this unit test :/ ) Original change's description: > [blink] Remove old script streamer thread > > The script streamer thread has now been replaced with posting tasks to > the scheduler, so remove the flag picking between the two options and > the dedicated streaming thread itself. > > Also, remove the streaming task re-posting now that the blocking/ > non-blocking worker pools are merged. > > Bug: 874080 > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638031} TBR=mlippautz@chromium.org,holte@chromium.org,haraken@chromium.org,kinuko@chromium.org Bug: 874080 Change-Id: I5be59d64fc2d6074094ce57cf884bcd0bdffd3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507874Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#638553}
-
Maxim Kolosovskiy authored
[Password Generation] Button titles should be crowdsourced only if AutofillFieldMetadata experiment is enabled. Bug: 910546 Change-Id: If09ec89ded92f21a733b4f22b9e456f8e3365109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508252 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#638552}
-
Colin Blundell authored
This CL eliminates FakeAccountFetcherService, which provides no functionality over AccountFetcherService following recent changes. The TestImageDecoder class that was contained in fake_account_fetcher_service.* is retained, as it has usage in the codebase. It looks like that usage could potentially be replaced by usage of FakeImageDecoder, but that project is orthogonal to the project of eliminating FakeAccountFetcherService. TBR=droger@chromium.org Bug: 935998 Change-Id: I4eed6e8f4b3a9474076eeed27e7641cd88b25458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503331Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638551}
-
Christopher Lam authored
Bug: 938695 Change-Id: I7c67ffb827e483a253d92ad98d90e7e02a5c1d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507295 Auto-Submit: calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#638550}
-
Morten Stenshorne authored
https://chromium-review.googlesource.com/c/chromium/src/+/1496304 made a skia change and rebaselined most test expectations, but not those specific to LayoutNG. TBR=kojii@chromium.org,reed@google.com Bug: skia:8793 Change-Id: I675bb9449be7e8793c692ce7fb132b61b42fafed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508099Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#638549}
-
Gauthier Ambard authored
This CL groups the methods related to NativeContent in CRWWebControler. Bug: 938255 Change-Id: I4d375f6c156e0ef39a135542c17f542c5d37d6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506072 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638548}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcb547de1a5c..310f45e6d446 Created with: gclient setdep -r src-internal@310f45e6d446 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Ia33f26eff636df5b76b71f0618dddeffcb113faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638547}
-