GitLab

Instead, we now use optional fields in EntitySpecifics.  Because the tag numbers remain
the same, this is a wire-format compatible change.

This incurs a (#datatypes * sizeof(void*))*#sync_items memory cost, due to storing extra pointers.  In practice, for a typical account on windows this amounts to < 200k, and the static init cost is believed to be greater.

Note - upcoming features in protobufs may let us eliminate this extra memory overhead.

Also: The testserver tests were broken on ToT due to a bug in _SaveEntry's saving of mtime which is fixed in this patch.

TBR=yoz@chromium.org
TBR=mnissler@chromium.org
TBR=pkasting@chromium.org
TBR=georgey@chromium.org

BUG=94992, 94925


Review URL: http://codereview.chromium.org/9460047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124912 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124910 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7920: (ncbray) Add validation caching interface.
r7921: (jvoung) Change pnacl-nmf "open" calls to "DriverOpen".
r7922: (bradnelson) Passing more information to untrusted crash handlers.
r7923: (bradnelson) Revert 7922 - Passing more information to untrusted crash handlers.
r7924: (bradnelson) Exception handling: Unset the x86 direction flag for untrusted code
r7925: (bradnelson) Revert r7924, which was committed with the wrong description
r7926: (jvoung) bump chrome rev in nacl
r7928: (bradnelson) Passing more information to untrusted crash handlers (a retry of r7922)
r7929: (jvoung) Augment pnacl error-checking test to check that the temp files are cleaned
r7930: (mseaborn) Fix presubmit errors on mmap_test.cc
r7931: (mcgrathr) Link sel_ldr as PIE under Gyp
r7932: (robertm) Update trusted arm TC
r7934: (sehr) Second attempt at SelLdrLauncher refactoring
r7935: (robertm) Add a new scons variabe "pnacl_stop_with_pexe" which will prevent pnacl from
r7936: (robertm) Update arm trusted TC with additional packages to support recent chrome builds
r7937: (mseaborn) mmap: Fix PROT_NONE fill within a 64k page for end-of-file mappings
r7938: (thakis) Remove debug output from nacl_syscall_handlers_gen.py.
r7939: (mseaborn) mmap_test: Fix test failure under ASan
r7940: (jvoung) Remove extra extern "C" that was in callconv_case_by_case test.
r7941: (thakis) Let build_nexe print nothing in the happy case.
r7942: (mseaborn) Debug stub: Extend test to work on x86-32
r7943: (pdox) Add libelf to the PNaCl build.
r7944: (bradchen) whitespace change to trigger build.
r7945: (pdox) PNaCl libelf build: Add more supplemental header files and patches for compiling on Mac.
r7946: (pdox) Minor tweaks to libelf to get it building on Windows.

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/9597001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124909 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9582035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124907 0039d316-1c4b-4281-b951-d872f2087c98

Generalizes suppression in media::AudioFileReader::Read

BUG=112450
TEST=Valgrind goes green
TBR=scherkus@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9594010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124905 0039d316-1c4b-4281-b951-d872f2087c98

Generalize Valgrind / Webkit suppression for Histogram11BucketIndex

BUG=116475
TEST=Valgrind goes green
TBR=wjmaclean@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9597008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124904 0039d316-1c4b-4281-b951-d872f2087c98

The fixes: (1) make sure the popup shows up in login screen, (2) align the popup to the edge of the screen.

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9596002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124903 0039d316-1c4b-4281-b951-d872f2087c98

Remove outdated suppression for GpuProcessHostUIShim

BUG=73828
TEST=Valgrind stays green
TBR=nduca@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9578007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124902 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for GpuProcessHost::GetForClient.

BUG=116744
TEST=Valgrind goes green
TBR=fischman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9578006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9585012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124900 0039d316-1c4b-4281-b951-d872f2087c98

This has been shown to occur in the wild. At the moment users in this situation will simply get a failure to load or persist cookies (though cookies will work within the current session). After this change, users will see their Cookie database wiped out and reinitialized, but loading and persisting should work going forward.

A histogram tracks how often this scenario is detected - it should probably spike as this is rolled out to new channels and then taper off (hopefully approaching 0).

This is a minimal version with the hopes of being eligible for patching into M18. The preferred long-term version is here: http://codereview.chromium.org/9567022/

TBR=shess
BUG=111376
TEST=unit_tests --gtest_filter=SQLitePersistentCookieStoreTest.TestInvalidMetaTableRecovery

Review URL: http://codereview.chromium.org/9602001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=29215
TEST=Existing browser tests that call API functions with omitted parameters. Still need to add browser tests and possibly some unit tests


Review URL: http://codereview.chromium.org/9317072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116607
TEST=


Review URL: http://codereview.chromium.org/9580027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124892 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9572036

TBR=tedvessenes@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9597005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124891 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9572036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124890 0039d316-1c4b-4281-b951-d872f2087c98

This is a good idea since otherwise clicking URL can navigate you away from the page, and lose your capture data.

Also fixed a CSS class naming to match our style better.


Review URL: http://codereview.chromium.org/9580034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=rch@chromium.org


Review URL: http://codereview.chromium.org/9594006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124888 0039d316-1c4b-4281-b951-d872f2087c98

R=eroman@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9572034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124887 0039d316-1c4b-4281-b951-d872f2087c98

spdy 3 framer changes.
Review URL: https://chromiumcodereview.appspot.com/9582034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124886 0039d316-1c4b-4281-b951-d872f2087c98

One was unused so I removed it.

CID_COUNT=2
CID=103376,103377
TEST=none
BUG=none
R=groby

Review URL: https://chromiumcodereview.appspot.com/9433059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124885 0039d316-1c4b-4281-b951-d872f2087c98

R=cpu@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9580037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124884 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=2
CID=103366,103367
TEST=none
BUG=none
R=groby

Review URL: https://chromiumcodereview.appspot.com/9429066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124883 0039d316-1c4b-4281-b951-d872f2087c98

R=tim@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9572039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124882 0039d316-1c4b-4281-b951-d872f2087c98

|type| was never passed in to ReadValue().

CID_COUNT=1
CID=103427
BUG=none
TEST=none
R=asvitkine

Review URL: https://chromiumcodereview.appspot.com/9601001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124881 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=103438
TEST=none
BUG=none
R=groby

Review URL: https://chromiumcodereview.appspot.com/9596001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108171


Review URL: http://codereview.chromium.org/9581042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124879 0039d316-1c4b-4281-b951-d872f2087c98

Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.

BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124660

Review URL: http://codereview.chromium.org/9447090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124878 0039d316-1c4b-4281-b951-d872f2087c98

R=michaeln@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9572037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124877 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9583035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124876 0039d316-1c4b-4281-b951-d872f2087c98

This is the combined version of the following CLs:
http://codereview.chromium.org/9428025/
http://codereview.chromium.org/9500007/
http://codereview.chromium.org/9535002/

BUG=112651
TEST=

Review URL: https://chromiumcodereview.appspot.com/9586018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111674
TEST=Install 2 external extensions. Check popup bubble on installation.


Review URL: http://codereview.chromium.org/9372091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9585036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124873 0039d316-1c4b-4281-b951-d872f2087c98

Insert the history page into uber, redirect history menu command and urls to the uber
page.  Also included in this CL:
* Use localized strings for frame URLs in uber.html.
* Turn off uppercase on page titles per latest mocks.
* Re-order page titles per latest mocks. Reflected order in code for readability.

BUG=116447
TEST=Exercise history in uber page, invoking from menu commands.
Review URL: https://chromiumcodereview.appspot.com/9582032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124872 0039d316-1c4b-4281-b951-d872f2087c98

Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress.

TBR=cpu

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124813

Review URL: http://codereview.chromium.org/9549020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124871 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=1
CID=103433
TEST=none
BUG=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/9583033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124870 0039d316-1c4b-4281-b951-d872f2087c98

R=joaodasilva@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/9584043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116138


Review URL: http://codereview.chromium.org/9583020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116239
TEST=Open a system modal dialog, lock and unlock the screen. The system modal dialog should get focus back.

Review URL: https://chromiumcodereview.appspot.com/9568045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124867 0039d316-1c4b-4281-b951-d872f2087c98