- 24 Apr, 2020 40 commits
-
-
Matt Falkenhagen authored
For conveniently changing a single header without using get_stream and then update_raw_headers. set_header "https://example.com/main.js" "cache-control" "max-age=10" Example: Change-Id: Iab0c5c0c0d307cbd2f0cd1139877aca9c56216d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164367Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#762504}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1dafb8d..9935cf7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I781b106f961b4fc120675befc8cb36ec5e16d7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164768Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762503}
-
Christoph Schwering authored
Matching filled fields with profiles is expensive and grows quadratically in the number of profiles and form fields. With this CL, type matching and voting is omitted if #fields * (#profiles + #credit-cards) >= 5000. BUG=1060011 Change-Id: I40b71d07c115334e1cc4a9f90f6d15671f135b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160936Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#762502}
-
Ali Juma authored
This CL converts WebStatePolicyDecider::ShouldAllowResponse from returning a decision to instead taking a callback that it calls with a decision. This CL also changes the decision type from a bool to a PolicyDecision, making it consistent with ShouldAllowRequest. These changes are needed for implementing Safe Browsing on iOS. We need to make ShouldAllowResponse asynchronous since we need to be able to wait to receive a Safe Browsing decision before deciding whether to allow a navigation response. We need to change the decision type to a PolicyDecision in order to indicate that we want to cancel a navigation and also show an error page. Change-Id: I0353132f49768b98900df5122dd9fd59f68d7c98 Bug: 1073546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153575 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#762501}
-
Elly Fong-Jones authored
This method changes whether a button is enabled. It can/should be used instead of overriding IsDialogButtonEnabled(). Bug: 1011446 Change-Id: I733eb90639c74013aae9f764606a9c746eaddb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165851 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#762500}
-
Avery Musbach authored
These videos show those bounds in red, with and without the present CL: WITHOUT: https://photos.app.goo.gl/VxLUSbqtM7o8W9Xt6 WITH: https://photos.app.goo.gl/ZS1Y3ixMToYRZUm58 Notice that in the "WITHOUT" video, the bounds change after a fraction of a second. That really is accurate (and is fixed in the present CL)! Test: manual Change-Id: I4443b295d1efecce373defca9169867e0157b792 Fixed: 1073667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165576Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#762499}
-
Natalie Chouinard authored
This reverts commit ee96764b. Reason for revert: Suspected cause of network_service_out_of_process_content_browsertests failures across several bots. Original change's description: > Reland browser test to exercise DoH against external servers > > The core part of the change was previously reviewed in: > https://chromium-review.googlesource.com/c/chromium/src/+/1961006 > > However, the change was reverted due to failures in > network_service_out_of_process_components_browsertests > on Android (crbug/1038953). This change fixes those failures, > and also includes a minor merge for //net/dns/dns_util.cc. > > The trybots don't run the failing Android tests, so I verified > manually on an Android emulator by running: > components_browsertests --disable-features=NetworkServiceInProcess > > This reverts commit 9338addd. > > Bug: 1032710 > Change-Id: I27f783c9f4bdd74e2bc3446bffd5ecff0a08f98f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079652 > Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762206} TBR=jam@chromium.org,ericorth@chromium.org,kaustubhag@chromium.org Change-Id: Icbc51e276d0cfcd14a5291c44a5132d73e97a4b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032710, 1074453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165860Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#762498}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I338d455d733df2b561fbae9b3edb90d303170377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164751 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#762497}
-
Dan Harrington authored
The internals page now gets some data for Feedv2, though not everything works yet. As part of this, I decided to make collecting and passing debug data for internals more explicit instead of relying on setting and reading prefs in various places. Reland: This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2142732 The only change is to fix the type annotation in feed_internals.js Tbr: dcheng@chromium.org,rockot@google.com,iwells@chromium.org,dpapad@chromium.org Bug: 1044139 Change-Id: Idba678e83295e0f09d5a7e2bab96ebb03d457442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164692Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#762496}
-
Piotr Bialecki authored
Corresponding spec draft PR: https://github.com/immersive-web/anchors/pull/40 Additionally, correctly handle cases where the app could try and access properties of already-deleted anchor. Change-Id: I309bd168a7d5715fec79e927512bdb721d1fd31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159928Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#762495}
-
Natalie Chouinard authored
Test is flaky on Marshmallow Tablet Tester TBR=boliu@chromium.org Bug: 1074438 Change-Id: Id1458cd6fd88b5d322e03fdf8dec1ad9f06add0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165858Reviewed-by:
-
Haiyang Pan authored
(Added No-Try to release resources for L CQ) No-Try: true Bug: 1032336 Change-Id: I800429e0c1ea29f7a12ad0a2f9707ea1ac162e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165709 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#762493}
-
Annie Sullivan authored
Change-Id: I6ece6128f0e6da015cb983eb3c3e17bd1b316337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163149 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#762492}
-
Dave Tapuska authored
WebInputEvent::Type and WebTouchPoint::State are adjusted in this change. This allows us to alias this enumeration to a mojo defined type that will come in another CL. No functional changes in this CL, largely completed via sed. Change-Id: I57ad12e89aeba5a0d7e780abe0c627a0e1bc3876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160859 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#762491}
-
Rohit Rao authored
While we started development in earlier milestones, these policies are first enabled by default in M84. BYPASS_POLICY_COMPATIBILITY_CHECK=Policy was not enabled on iOS until M84. BUG=1073975 Change-Id: Ife99258ee580059b396dd0d17ca6217c6fa0c13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164687Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#762490}
-
Nasko Oskov authored
The WebUI NTP must be committed and rendered in a WebUI process. Currently, that is not the case because it is considered as part of the instant process (used for the current version of local NTP). This CL changes the implementation to no longer put the WebUI NTP page as part of the instant process, which ensures it commits in its own WebUI process. Bug: 1073956 Change-Id: Ie3011374981584fa68d04bd42a29eed3d20781f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163433 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#762489}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7940f55966a0..76b3969cd89a git log 7940f55966a0..76b3969cd89a --date=short --first-parent --format='%ad %ae %s' 2020-04-24 tvanderlippe@chromium.org Update README regarding rolling of dependencies Created with: gclient setdep -r src/third_party/devtools-frontend/src@76b3969cd89a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2e0218806c4156a18bbc5539fa5e8dee3fc511c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762488}
-
dpapad authored
This function attached a parameter to help URLs on ChromeOS which could potentially display different help content based an a CrOS device's board info. This is not relevant after the OS/Browser settings split, since device specific settings no longer reside in chrome://settings. Bug: None Change-Id: I574a56ef9c36d0d05b75d448951371d7b352352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165847 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762487}
-
Ian Clelland authored
This reverts commit 3cb9d56a. Reason for revert: Removing extra-long tests from the test suite to get the compile time down to something reasonable. Original change's description: > Revert "Structured Headers: Include all public tests" > > This reverts commit 068d6078. > > Reason for revert: Causes compile to hang for https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder > > Original change's description: > > Structured Headers: Include all public tests > > > > This imports all of the tests from the public test repository at > > https://github.com/httpwg/structured-header-tests, which have been > > automatically converted from JSON to C++ unit tests. > > > > Tests which were already present in structured_headers_unittest.cc > > have been removed from that file, to avoid needless redundancy. > > > > Bug: 1069790 > > Change-Id: I05536c36cb66c7dda43aab2f6c5ae77961120a6a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146237 > > Commit-Queue: Ian Clelland <iclelland@chromium.org> > > Reviewed-by: Asanka Herath <asanka@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#759015} > > TBR=iclelland@chromium.org,asanka@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1069790 > Change-Id: I398e00aaa9903872475f8c5cb5f2513f99e38b69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159370 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761024} TBR=iclelland@chromium.org,asanka@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069790 Change-Id: Ia0a66c1a864c40df637c3d0b18b864a4effad844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161414Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
We issue Page.frameRequestedNavigation for any navigation initiated by the frame. However, when this navigation is intended for another page, for example opening a new tab, it is important to differentiate from the navigation in the frame itself. Bug: 1073211 Change-Id: I3024abd194bd2bae87dfb6855611f53a979e02a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159762 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#762485}
-
Martin Kreichgauer authored
On Windows, some Bluetooth adapters do not support advertisements. When discovering such an adapter, treat Bluetooth as unavailable during a caBLEv1 request. caBLEv1 relies on the client broadcasting an advertisement, and there isn't much use in trying that if the adapter doesn't support it. For requests where caBLE is the only permissible transport in the allow list but Bluetooth is deemed unavailable, the WebAuthn UI automatically advances to the "Your device doesn't support this type of security key error screen". Bug: 1069140 Change-Id: Ib7e45ec3c8dbc57f8bb6d1923678c7183e85d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161904 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#762484}
-
Jazz Xu authored
Bug: 1057301 Change-Id: Idda7aa88e16bbf2caf3a55bca1d0017979a3243b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159866Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762483}
-
Caitlin Fischer authored
This test was disabled for flakiness; however, over 500 attempts to reproduce the sync-related flakes were unsuccessful. We suspect that the underlying problem has now been resolved. See crrev/c/2150232 to view the attempts and the bug for more details. Bug: 1071110 Change-Id: Ib2364be94c17dc7c70b06950113594254e256287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165845 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#762482}
-
Yicheng Li authored
Extend the expiration date for UMA metric Fingerprint.Unlock.MatchIgnoredDueToPowerButtonPress since the team decided that this is going to be helpful for future devices. This was introduced to verify that the fix for the race condition between power button press and fingerprint match on Nocturne works. BUG=b:148979792 TEST=none Change-Id: Ie784d5876b027df227a8df057d521fac6e9a5545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163953 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#762481}
-
Maciek Slusarczyk authored
ChromeOS.SAML.InSessionPasswordChangeEvent tracks usage of in-session password change flow for SAML users. Extending its validity by 6 months to collect additional data as the featute is still being tested and next phase of implementation is pending. Bug: 1066024 Change-Id: I1a689dc3a4388e7a8d0ac2ce37dec672fe3e9415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162875Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#762480}
-
Lei Zhang authored
The |kSelection| enum value is only available for systems running X11. Bug: 676224 Change-Id: Icdd99c86712d6127a6ae81e74d17b189073e11ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163637Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#762479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e320eb3f979..efe0c6ebec56 Created with: gclient setdep -r src-internal@efe0c6ebec56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042017,chromium:1067050 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I344df6725d8f216dd590878b3844971ac1d476ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165427Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762478}
-
Devlin Cronin authored
ExtensionFunction::Error can now take a std::string, so std::move() a bunch of strings to avoid unnecessary copies. Bug: None Change-Id: I0f295554b659890bee81c233aa46a40cd559c6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161316 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#762477}
-
Navid Zolghadr authored
The expected behavior on this test seems to be a hack as it implicitly captures mouse to the object and still sends the mouseup/pointerup to the object when down happened on the object even though up is happening outside of the object. This seems to resolving compat issues on embedded flash objects. Change-Id: Ibd888a989dbcf5e6ff08b35569903967edc957e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160142 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#762476}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I0ca695f1d63c59cff6d5b2d24cafc65fdcf83ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164509 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#762475}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Ifb0585f520cde43e15d61e566bf92778dafec5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164892 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762474}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I17ab2b1126d7f9ec167074fa4c435e026d7748a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164638 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#762473}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/975526b601af..016ec06f4b68 git log 975526b601af..016ec06f4b68 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 bsheedy@chromium.org [Telemetry] Add android-chromium-monochrome browser Created with: gclient setdep -r src/third_party/catapult@016ec06f4b68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1073267 Tbr: nuskos@google.com Change-Id: I80182d7bd3240a6f86e64ed8eaa3d953184632e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165426Reviewed-by:
-
Vladimir Levin authored
This patch does a few things: - Hoists the lifecycle update from IsFocusableStyle into a separate function, IsFocusableStyleAfterUpdate - Uses the new function in Is{Keyboard,Mouse}Focusable - Uses IsFocusableStyle in AX focus check, to eliminate repeated code and to ensure we're using up to date layout objects if available - Finally, forces a layout tree update in the native focus action. This fixes the test which is removed from expectations. R=aleventhal@chromium.org, futhark@chromium.org, chrishtr@chromium.org Change-Id: Ie72bd1efaa71ea0f5b6de8cdd3aaf83ae350adb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157677Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762471}
-
Mohamed Heikal authored
Expectations are always checked when available and written to the $android_configuration_failure_dir. The renamed flag only controls whether the build fails as well. Also do not pass failure files all the way from the top level targets (eg: monochrome_public_apk). Bug: 1073104 Change-Id: I6142201ea3e5d3d9187f6604fbab6481ab620f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159930 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#762470}
-
Jana Grill authored
The device policy will control the permission for using ADB sideloading for a device. It currently has three possible values, 0 (disallow), 1 (disallow with powerwash) and 2 (allow for affiliated users) and is of type int-enum to allow future extensions. Apart from this policy the behavior per-user is controlled by the corresponding user policy. The functionality for managed ADB sideloading is currently hidden behind a feature flag. This CL only contains the initial definition of the policy. Bug: 1053907 Change-Id: Idfc53130c057a2f399ec2b74d931ce136e94ecf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162849Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#762469}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Ifc03c7f5f12f52e2ba57c5b18cdc4f6ee78174e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164639 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762468}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5a86ca60e542..ab1a2f623160 git log 5a86ca60e542..ab1a2f623160 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 5ab1f36a38aa..f42c698d784a (8 commits) Created with: gclient setdep -r src/third_party/angle@ab1a2f623160 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I9cf337f21159b4e56ddd0b8eb9af296d44439f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165428Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/52d34b4c6599..1b5733274640 git log 52d34b4c6599..1b5733274640 --date=short --first-parent --format='%ad %ae %s' 2020-04-24 johnkslang@users.noreply.github.com Note about Build Status. Created with: gclient setdep -r src/third_party/glslang/src@1b5733274640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: Ia0efd0005bf561b9cb01594055506940f716707a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165430Reviewed-by:
-
Istiaque Ahmed authored
ExtensionFunctionDeleteTraits was removed in commit a2aef2ea (https://chromium-review.googlesource.com/c/chromium/src/+/1718990), but the friend specification stayed around. This CL removes it. Bug: None Test: Easy cleanup, no behavior changes expected. Change-Id: Ieebfbb320d7efc69d3fe607e7fdd1991e689d93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164566 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762465}
-
