- 13 Aug, 2020 1 commit
-
-
Michael Thiessen authored
EditUrlSuggestionUnitTest was leaking native clipboard state that was causing other clipboard tests to fail. Test grouping on M vs R revealed this dependency locally, but not on the bots. Change-Id: I98bed04aae3fa69dc82bb7a74856c37d75b6106a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353389Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#797482}
-
- 12 Aug, 2020 39 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c95b589112f3..652124c372e5 2020-08-12 bsalomon@google.com sk_gpu_test::MakeTextureProxyFromData -> MakeTextureProxyViewFromData 2020-08-12 johnstiles@google.com Add `GrProcessor::onDumpInfo` for subclass info dumps. 2020-08-12 johnstiles@google.com Reland "Guard dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." 2020-08-12 brianosman@google.com Unit tests for runtime effect SkSL errors found later in compilation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ia182b56ff61c3eb0852134c7207253979662835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797481}
-
Nick Diego Yamane authored
R=sky@chromium.org Bug: None Change-Id: Ie3ce9e126def94576b078c27063048917948b299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353111 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797480}
-
Peter Boström authored
This is more readable to me (after using it twice) and you don't need to remember how to spell ui::DIALOG_BUTTON_CANCEL. It also removes Set{Accept,Cancel}Callback by making these callbacks part of Add{Ok,Cancel}Button(). Bug: 1106422 Change-Id: I208b80c041616ac506e4b77913a7bb6150c200dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351370 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
Joe DeBlasio authored
This CL updates the illustrations for the lookalike safety tip on Desktop. It now looks like this: https://drive.google.com/file/d/1IPugu1WucRKymM3lCGvCW0SU83joNFxu/view Fixed: 1111358 Change-Id: I90dcba0bb6cecc1d9fb08de0cce1377e5972a69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353060 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#797478}
-
Vasiliy Telezhnikov authored
Both with SurfaceTexture and AImageReader we get only one FrameAvailable callback before we call UpdateTexImage. This causes the problem when we released buffer to codec in early rendering, but dropped the frame later. In this case we did not called UpdateTexImage for that frame and will not received OnFrameAvailable for next one causing WaitForFrameAvailable to timeout. This CL adds UpdateTexImage call after WaitForFrameAvailable in RenderToTextureOwnerBackBuffer in case we're already waiting for frame. Bug: 1113203 Change-Id: I32e703d07df94f7170795077773a30b4578c1a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339495 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#797477}
-
Yusuf Sengul authored
Adds the logic that handshakes with the service control manager and runs the process as a service. Bug: 1101590 Change-Id: Id0825d3ea5bbfccb17147740eda26bff04367037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329045Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#797476}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..fac64cf60aa2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45e6b6bccc3c0082bbbc16aa19c827d9d1ac5091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351397Reviewed-by:
-
Carlos IL authored
IDNs triggered a DCHECK when elision experiments were enables, due to a search in GetSimplifiedDomainBounds trying to search for the punycode version of the URL in a string containing the unicode version. This fix is a pre-requirement for fixing elision for RTL URLs. Bug: 1114286, 1101472 Change-Id: I433bc4cac2e31b6056e154025f0c5b8c5c0726a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350022Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#797474}
-
Dan Harrington authored
Bug: 1044139 Change-Id: If241abe46b91d8fa63706d0262a8c7c3f1b56a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353027 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797473}
-
Rachel Carpenter authored
This means on the first 3 launcher opens, the suggestion chip for whats new will be seen. It previously only showed up once. Bug: b/161755085 Change-Id: Ie9b475a57b1571873b98b1e80f329831eee71b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351344Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797472}
-
Yuly Novikov authored
Bug: 1115721 Change-Id: I2293535744d9f7894865bd32b9ed9fb4a84a33f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353551Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797471}
-
zhaoyangli authored
Since some beta version of Xcode 12, XCTest result can report XCTest runner app crash as a failed test in log. In this CL, log parser reports this failure as "BUILD_INTERRUPTED" which fits into the existing logic to handle test process crash in test runner scripts. Bug: 1115232 Change-Id: Icebdb5456005b2473e5ed8af683487ac532cda3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350442Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797470}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5276639d2789..cc958e0e8703 2020-08-12 jmadill@chromium.org Remove D3D9 configs from perf tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ia3e7842e94c866c1c6f299ac32a1cbc7dcd3fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351384Reviewed-by:
-
Nektarios Paisios authored
Every AXObject in Blink has not only a pointer to each one of its children, but also a pointer to its parent. Under some circomstances the pointer to the object's parent was not set. One case of this was when inline text boxes were forcefully loaded by calling the AXObject::LoadInlineTextBoxes method. Another case was when continuations were involved. The former was done for testing. Unit tests were added for both of the above situations which ensure that a large number of the public tree walking methods on AXObject work correctly. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I375a10552d8cd91f8d54a9d35e75b0c9f8278059 Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344468 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797468}
-
Jun Kokatsu authored
This change modifies tests in a way that test won't be blocked by Trusted Types mitigation on WebUI. Also disabled Trusted Types mitigations in some WebUI pages due to usage of Polymer. Bug: 41905 Change-Id: I85c60066672e896032599d674b7bac35e38ccb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341800 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797467}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5192b234de64..409802afddc8 2020-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I27c03bf22b9ba5add61b61bba25bfbe2182fa1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353357Reviewed-by:
-
Anne Lim authored
Change-Id: Ida6f0d6babda680d3618e9ba226eda154020126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352624Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#797465}
-
Robert Ogden authored
This fails because the ScopedFeature list was being destroyed before the test was fully done. Bug: 1078965 Change-Id: I57d4c01bc4bcc10a8377e4abac5f5b65f9ea9859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351168Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#797464}
-
My Nguyen authored
Adding the first bit of the input page according to design at http://go/cros-lang-settings-ux slide 23. Current view: http://screen/K4xO3C4FXaz Bug: 1113439 Change-Id: Ic2c5e3d1e095e5080bc2409a1c3aafe89a147fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345933 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Change-Id: I5587dff4225c4341ed80fa107cedf71b10f73e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353331 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#797462}
-
Claude van der Merwe authored
removeWebUIListener expects a WebUIListener argument, but strings were being passed. This CL 1. Adds variables to keep track of created WebUIListener types so they can be removed with removeWebUIListener in cups_printers_entry_manager.js 2. Uses addWebUIListener from WebUIListenerBehavior for automatic WebUIListener removal in cups_printers.js Change-Id: I86da8dda6bf03e3ce83c38a3e63825ff4335f1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350335 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797461}
-
Claude van der Merwe authored
Bug: 1045266 Change-Id: I0217bf03b82683b1f4d0a08e0342f8c9b2de43eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340408 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
-
Dale Curtis authored
Verified to work on Beta4. In overlay mode video looks great for both HDR and 8-bit content. When we drop out of overlays and we're using the validating cmd decoder HDR gets copied to non-HDR and looks wrong. When using the passthrough cmd decoder, we just get black frames. Remaining TODOs: - Figure out how to get HDR displaying correctly out of overlay mode. - Figure out difference between validating and passthrough cmd decoder. - Skip reinitialize for config changes if possible. - Still needs --no-sandbox until https://crrev.com/c/2346852 lands. - Jank at playback startup for HDR content. https://crbug.com/1115333 - Playback hangs when starting with a seek. https://crbug.com/1115334 Bug: 1103432 Change-Id: I7d5860a49eee3856fec380eac8e78fdac798c117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290923Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797459}
-
Evan Stade authored
For example, typing "cats" searches for cats. Works from URL bar or command line. Bug: none Change-Id: Icd609ca4183398254d886d392570216eeca82d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353059 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Dana Fried authored
See attached bug for the problem statement and some of the rationale for this change. Handles a case where we are not going into immersive mode, but also going fullscreen in a way that the default key to restore the browser is not ESC (as it is for media, etc.) but F11/Fullscreen. In this edge case, on ChromeOS, the message - "Press [F11] to exit full screen" - is displayed and announced to the screen reader. The message uses the default accelerator (which is still F11 on ChromeOS). This could be confusing to users on Chromebooks where there are no physical function keys but there are media keys, one of which is the fullscreen key. We cannot just change the default accelerator to Fullscreen however since the media key is translated to a function key at a lower level; there is no "fullscreen" key as far as Chrome is concerned. To handle this, on ChromeOS only, we substitute the name of the key - "Fullscreen" - for the name of the accelerator. Bug: 1110468 Change-Id: Id0764f3eb68c8dc49baf5cbe156cbd22e66362d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347962Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#797457}
-
Ben Pastene authored
Will update simple_chrome_workflow.md on the CrOS-side of the world in a follow-up. Bug: 937821 Change-Id: I006dde1fcab5ad4a0fc48a5b5f8440a554da1bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350540 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797456}
-
Mustaq Ahmed authored
Bug: 1113758 Change-Id: I955a8031913e6acf1fe3c5b878e819a2d4a38fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350560 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#797455}
-
Becca Hughes authored
If the Media History database is unrecoverable then we should delete it and start again. Change-Id: I76552537eeec315f66168abbf47c947ee37ecd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305192Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797454}
-
Tom Anderson authored
XTest/XRecord include XInput, so we need to get rid of those too if we want to get rid of the macros etc that XInput provides. Depends on WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/180773 BUG=1066670 R=nickdiego,sky Change-Id: Id3b3cb61196cf10bc47976957d8b290877020d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327373 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#797453}
-
Matt Jones authored
Bug: 1113325 TBR: peconn@chromium.org Change-Id: If61582b64343cdfa6de5f1c152c7d239696e16c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353409Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797452}
-
Mugdha Lakhani authored
This adds PrerenderTabHelper for WebLayer, which is a WebContentsObserver, and adds logic to create it when TabImpl is created. Some unreachable code has been removed from Chrome's PrerenderTabHelper as well. Bug: 1096088, 1106294 Change-Id: Ifa567096d9901a465104efd955d872ebfc1b4e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343038 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#797451}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I1ae7fac0faa66a2c4e727f2ac44517118df15c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352524Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797450}
-
Lijin Shen authored
Extend to M92 Bug: NONE Change-Id: I0e2ee3f83ebc6e0e553010ca997ee1493b7dba59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351717 Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
-
Garrett Beaty authored
Change-Id: Ic7a6f8d983dba91c4e43f279b112b33fbfc7836c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353017 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#797448}
-
Alex Turner authored
Converts FontMatchingMetrics::PublishIdentifiabilityMetrics() from using the IdentifiabilityDigestHelper to using IdentifiableTokens. Also adds IdentifiableSurface::FromTypeAndToken() to enable use of a Token as the input digest. Finally, reuses the IdentifiabilityMetricBuilder to improve performance. Bug: 1102934 Change-Id: I9b05581f56bfd1205db0086e46cbd5a54e013ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321776Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797447}
-
My Nguyen authored
Update os_languages_page_v2 according to spec at http://go/cros-lang-settings-ux slide 11. Languages menu functions and tests are mostly copied from os_languages_page Current view: http://screen/vZFDtvSXXD9 Note: Both OS search strings and regular OS settings strings haven't received UX writing review yet so they are translateable false and no screenshots are required. Bug: 1113439 Change-Id: I0146ad0e485187171829d08076e9956d6ae281fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345930Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Donn Denman authored
Adds @google.com to the contextual-search-eng address in flag-metadata.json. Change-Id: Ia5f0329543c339a7e4aaa21ac2f051a326b39c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353130 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797445}
-
Ali Juma authored
The network context used for Safe Browsing on iOS currently sends an empty UA string. This CL sets the UA string to the browser's UA string, matching the behavior on other platforms. Bug: 11156263 Change-Id: I73eac07c4fa3d7b2418abfe3d8e4526c0c3b51da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353113Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#797444}
-
Dan Harrington authored
Changes merged: https://chromium.googlesource.com/feed/+/c80d3c49fa92f00c05130106b29d5b49a735ac97 Change-Id: I7d676b458cc1d8e32aa2db104e0e81591d7a32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353011 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797443}
-
