- 26 Jan, 2019 39 commits
-
-
Tetsui Ohkubo authored
In NotificationViewMD, users can disable a notification from inline settings. When "Done" button is clicked, ToggleInlineSettings() might call DisableNotification() to apply the setting. After DisableNotification is called, there's no guarantee that the notification view still exists. Therefore, it's better to call the method at the end of ToggleInlineSettings. In this case, 1. DisableNotification() triggers animation in UnifiedMessageListView 2. PreferredSizeChanged() cancels the animation and deletes all removed notifications. 3. As |this| is already null, it crashes by use-after-free. So calling DisableNotification() at the end is also important to make the animation work properly. This is M72 ReleaseBlock-Stable. TEST=NotificationViewMDTest.TestDeleteOnDisableNotification BUG=924922 Change-Id: I25d2d345b146b28d935f597d4e851f7caebac5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436282Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#626306}
-
Dan Beam (slow until 1/29) authored
This reverts commit 340e6008. Reason for revert: this was just on the off chance WebUI Dark Mode made it in M73. It's probably not going to, but either way: no longer need this temporary change in. Original change's description: > WebUI Dark Mode: force user manager and print preview into light mode > > This is in the unlikely event that dark mode actually makes it in 73. > These UIs are not ready yet. > > R=dpapad@chromium.org > BUG=883049 > > Change-Id: Iaa79feadd8d341c4b730a9a6598f42c756070613 > Reviewed-on: https://chromium-review.googlesource.com/c/1435517 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625843} TBR=dbeam@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883049 Change-Id: I31278716430d53b1181de4da5044d158aaf33473 Reviewed-on: https://chromium-review.googlesource.com/c/1437746Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626305}
-
Chris Palmer authored
Give an example of a trivial grammar. Tweak some wording. Add some internal links. Bug: None Change-Id: I28e5fd06906f347dde558fe08b02221ba075189a Reviewed-on: https://chromium-review.googlesource.com/c/1437896 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626304}
-
Dan Beam authored
R=aee@chromium.org BUG=883049 Change-Id: I59f447ca7e21e7b2e8db4f8686e0739e8e68eaf7 Reviewed-on: https://chromium-review.googlesource.com/c/1437579Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626303}
-
Takuto Ikuta authored
This change extracts param data related struct only used in mojom cc files to another header file, params-data.h. And only mojom cc files include params-data.h. By extracting structs, this CL reduces total size of included files from compiles including mojom headers. This CL reduces total size of generated header files when building chrome. mojom-shared.h: 9576659 -> 6343886 mojom-shared-internal.h: 7552016 -> 3053172 And this helped to reduce compile time. e.g. obj/content/browser/browser/navigation_url_loader_impl.o: 25.6s -> 22.7s in Z840 Linux chrome build time on 24C/48T Z840 Linux reduced from 3478.5s to 3385.5s. Bug: 922875 Change-Id: I0e233e6046f9b47d6386ea24ea911da638b6aa69 Reviewed-on: https://chromium-review.googlesource.com/c/1436286 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#626302}
-
Stefan Zager authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g-pdQdSR0HI/LY6lcGKOCgAJ Bug: 827639 Change-Id: I4f99a90794badc546bfda7e9af1aeb5d4f0a09bd Reviewed-on: https://chromium-review.googlesource.com/c/1437497 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626301}
-
Miguel Casas authored
This CL reenables the pixel tests disabled in crrev.com/c/1436081 since the reference images should have been regenerated by now. Bug: 922218 Change-Id: Ic0f0d054e92be935041a41812507d062a166ae8d Reviewed-on: https://chromium-review.googlesource.com/c/1437777 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626300}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a8c86c2b674e..b600f15d3895 git log a8c86c2b674e..b600f15d3895 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 thestig@chromium.org Remove optional parameter from CFWL_Edit::SetText(). 2019-01-25 thestig@chromium.org Add destructors for CFWL_Edit subclasses. 2019-01-25 thestig@chromium.org Make CFWL_Barcode's status an enum. 2019-01-25 thestig@chromium.org Add BC_LAST to enum BC_TYPE. Created with: gclient setdep -r src/third_party/pdfium@b600f15d3895 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0ef35efd072cb2c447034d8d8b0c6866c4b8e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/1437724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626299}
-
Xiaohui Chen authored
* Remove old feature flag and commandline params * Update first_run to use the new assistant flag Bug: b:120553209 Test: locally build and run Change-Id: Id1ad774fbf4adbdff12b37ad93c3b4851f3c2d27 Reviewed-on: https://chromium-review.googlesource.com/c/1436149 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#626298}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4420ef0c7306..fe9504cfbd59 Created with: gclient setdep -r src-internal@fe9504cfbd59 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia67512d91015bf760bc7f57b8b3b46eb79e9ef20 Reviewed-on: https://chromium-review.googlesource.com/c/1437854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626297}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from signin_view_controller.cc and uses IdentityManager instead of it. Bug: 922780 Change-Id: I3bfa8dcfa8cc3722868b9726526357c1c7a9f223 Reviewed-on: https://chromium-review.googlesource.com/c/1436618Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#626296}
-
Weidong Guo authored
Bug: 779687 Change-Id: Iac2ee692d25aa811353749ad5aa77eb01f5e9d3e Reviewed-on: https://chromium-review.googlesource.com/c/1437199 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Erik Jensen authored
Most code doesn't care to distinguish between an error and cancelation, as both abort the transfer. The few places that do care (e.g., the code that decides whether to show an error to the user) can explicitly check the type. This also allows cancellation to be easily propagated through the error path from the source, instead of requiring a secondary cancellation path. Bug: 679313 Change-Id: I3c90ff55e7a58043535244a9d92cfc9e6814a4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1437657 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#626294}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6a2348535c9..fad5c773f7b6 git log f6a2348535c9..fad5c773f7b6 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 brianosman@google.com Convert DM's -r JSON parsing to SkJSON Created with: gclient setdep -r src/third_party/skia@fad5c773f7b6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I61843c42714cedbd88396fe16876e9091eac8fb3 Reviewed-on: https://chromium-review.googlesource.com/c/1437855Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db34d87aff44..eb2767b2eb24 git log db34d87aff44..eb2767b2eb24 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@eb2767b2eb24 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I22e5432f3ebf087a62cf679177df7b5f2b62e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/1437722Reviewed-by:
-
Caleb Rouleau authored
This is part of the work to finish up the One Build Bot Step migration to make all of the performance tests use testing/scripts/run_performance_tests.py, both gtest perf tests and Telemetry tests. Isolates for these tests are configured in gn_isolate_map.pyl. Those tests can be run in two contexts: 1. Performance waterfall testing. This is configured by src/tools/perf/core/perf_data_generator.py 2. CQ/smoke testing. This is configured by test_suites.pyl This changelist places flags always needed by the isolate into gn_isolate_map.pyl, and it places flags that can vary when an isolate is used in different contexts into perf_data_generator.py and test_suites.pyl. run_performance_tests.py requires the --non-telemetry=true flag for non-telemetry tests so it knows how to run them. Therefore, that flag needs to be in gn_isolate_map.pyl because if it isn't passed in then the isolate cannot run. Furthermore, it is non-optional and doesn't change in different contexts. --migrated-test=true flag is always needed since all the tests are migrated now. I will remove it in the next changelist and make this behavior the default. --gtest-benchmark-name can vary by context. For example the command_buffer_perftests isolate should be named passthrough_command_buffer_perftests when you pass it in '--use-cmd-decoder=passthrough' but it should be called validating_command_buffer_perftests when you pass it in '--use-cmd-decoder=validating'. This change is needed before https://chromium-review.googlesource.com/c/chromium/src/+/1423840 TEST=running python tools/mb/mb.py run -m chromium.perf -b "linux-builder-perf" -j 40 //out/Default tracing_perftests -- --isolated-script-test-output=$CTEMP/tracing/output.json --isolated-script-test-perf-output=$CTEMP/tracing/perf.json BUG=757933, 920002, 739863 Change-Id: Idd63445951c9d63a41fe0537c351d95ab03da8b9 Reviewed-on: https://chromium-review.googlesource.com/c/1436559Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#626291}
-
Pavol Marko authored
If the primary profile is not manged, the kDevToolsAvailability pref will default to 0 (allow, except for in force-installed extensions). This matters *only* if there's a secondary profile with a more liberal kDevToolsAvailabilityPref, because the primary profile's value would be more retrictive then. Only evaluate the primary profile's value if it is really managed. secondary profile with force-installed extensions. Set DeveloperToolsAvailability policy in the secondary profile's policy to 1 (allowed) and ensure that developer tools are usable in force-installed extensions. Bug: 924973 Test: manual -- sign-in with an unmanaged primary profile and a managed Change-Id: I1328a70664af759231ebc19bdb51a7ff1c193783 Reviewed-on: https://chromium-review.googlesource.com/c/1434316Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626290}
-
Yao Xiao authored
General testing idea: For a network request, we store a token in stash. And after a fixed period of time sufficient for the download to finish, if there are any, we validate the token in the stash to see if the network request was issued and finished successfully. In the case of <a download> where the decision of download can be made before resource fetching, the server sets the token immediately. In the case of navigation to a download, the server will stream a response over 1 seconds and set the token at the end only when the socket has been connected. So it is able to detect any download cancellation while fetching the resource. Bug: 539938 Change-Id: I734c8cc18d1f761f16646c6b859a6b731ab40ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1422667 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#626289}
-
chrome://flagsRobert Liao authored
BUG=873026 Change-Id: Ie0a4503a08d8f58a98bfaac619c4500debdf5d38 Reviewed-on: https://chromium-review.googlesource.com/c/1437523Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#626288}
-
Eric Orth authored
Added HostResolverSource::LOCAL_ONLY setting to only allow local (eg cache and HOSTS) resolution through the newer API. This will replace the old ResolveFromCache() method (which was poorly named as it could do other non-cache local sources). Also turned |allow_cached_response| into |cache_usage| that adds a third |STALE_ALLOWED| option. Setting this will replace the old ResolveStaleFromCache() method, except that it doesn't do cache-only unless also paired with LOCAL_ONLY. EntryStaleness works a bit differently in the new API. Before it was returned iff ResolveStaleFromCache() was used (and set to a default non-stale value if the result doesn't come from the cache). Now it gets set on the ResolveHostRequest object iff the result came from cache (even if |STALE_ALLOWED| is not set). More consistent and more reasonable for the newer pattern of results being on-demand through Get*() methods rather that an out parameter. Bug: 922699 Change-Id: Ia5c55beaf3c3c931a9503bb80e0b95f3334c5266 Reviewed-on: https://chromium-review.googlesource.com/c/1423577 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#626287}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/19ec8ef577ff..1b0dd7244802 git log 19ec8ef577ff..1b0dd7244802 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 jflat@chromium.org Add samus-kernelnext to internal release boards Created with: gclient setdep -r src/third_party/chromite@1b0dd7244802 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic412f1df6d57728930e1b7b15884ad3453d80e24 Reviewed-on: https://chromium-review.googlesource.com/c/1436765Reviewed-by:
-
Nico Weber authored
Makes clang package ~7% smaller and lets the tot and upload bots cycle ~7% faster. Since we don't use either of these features, let's disable them. Bug: 925145 Change-Id: I2570531caca6ca38173da35b8d4a76a925b31044 Reviewed-on: https://chromium-review.googlesource.com/c/1437255Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626285}
-
Brandon Jones authored
Bug: 916299 Change-Id: I533f0f9847892cdf2cdd5c49f9c7ba957c391298 Reviewed-on: https://chromium-review.googlesource.com/c/1437524 Commit-Queue: Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#626284}
-
Xiaohui Chen authored
The settings ui should only show when feature is enabled. Also hide the "delete" button for now per ux request. Bug: b:123254533 Test: locally build and run Change-Id: Ice44a9888b2d02f901206518967aea2d7bdb43a4 Reviewed-on: https://chromium-review.googlesource.com/c/1434755Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#626283}
-
Aaron Colwell authored
Removes some redundant code that appears to have been as accidentally introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1409551 Change-Id: I784b6cb91f788dfc2e2c8bd3b1e888e8b54699b2 Reviewed-on: https://chromium-review.googlesource.com/c/1433144Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626282}
-
Martin Kreichgauer authored
This turns on both features by default. They are slated to launch fully via Finch in M72. Also removes the obsolete flag for testing the Windows WebAuthn API integration with an incompatible API version. Bug: 897741,898718 Change-Id: I90b6d68331e74befb807aa7bc18e72ed253dc779 Reviewed-on: https://chromium-review.googlesource.com/c/1435760 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#626281}
-
Daniel Rubery authored
Add //chrome/browser/safe_browsing to the allow_circular_includes_from list for //chrome/browser/ui, and //chrome/browser/extensions. A real solution would involve rather substantial refactoring of the Safe Browsing code base. So do this to prevent build instability in the meantime. Bug: 919683, 925153 Change-Id: Iff0c9d0c67098c6255217721b55a390999e65737 Reviewed-on: https://chromium-review.googlesource.com/c/1436035 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#626280}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/578e24839231..a8c86c2b674e git log 578e24839231..a8c86c2b674e --date=short --no-merges --format='%ad %ae %s' 2019-01-25 tsepez@chromium.org Delete "NULL terminator" CFXA_Node property/attribute records. Created with: gclient setdep -r src/third_party/pdfium@a8c86c2b674e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I815a46fd300522dec7aa1f7c40db9f57519ce059 Reviewed-on: https://chromium-review.googlesource.com/c/1437814Reviewed-by:
-
Daniel Cheng authored
They are never displayed, and it ends up requiring a bunch of null checks elsewhere in the layout code. Bug: 578349 Change-Id: I318c86c27200e5ea270c077d9e458dcdaa7e4b3a Reviewed-on: https://chromium-review.googlesource.com/c/1431872 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit c6df4d27. Reason for revert: Broke Fuchsia browsertests. Bug: 925574 Original change's description: > [Fuchsia] Implement extra headers support in NavigationController. > > This implements setting and using the |headers| data in > LoadUrlParams. A new test fixture is added to ensure the extra headers > are properly received by the test server. > > Bug: 923598 > Change-Id: I59a44c886f1853bbc631ae016b0655dd1d4d539b > Reviewed-on: https://chromium-review.googlesource.com/c/1427565 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625912} TBR=wez@chromium.org,kmarshall@chromium.org,fdegans@chromium.org Change-Id: I82c9a5dead06edd58553a0999b708c6cc8b8dfd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923598 Reviewed-on: https://chromium-review.googlesource.com/c/1437914Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#626277}
-
Lukasz Anforowicz authored
Bug: 925035 Change-Id: I2966cb89faa5a2c3db593f522b6cc8f50f064ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1434754Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#626276}
-
Andreas Butler authored
This change removes transaction error-tracking for IndexedDBCursor error cases in which the cursor has been closed. Closing a cursor involves nulling out the transaction associated with it, so attempting to track the number of errors on the transaction after cursor close was causing a null dereference. Bug: https://crbug.com/925235 Change-Id: Ia0b854bca327f875d0f31f606cd636799f880137 Reviewed-on: https://chromium-review.googlesource.com/c/1437261 Commit-Queue: Andreas Butler <andreasbutler@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#626275}
-
Dan Beam authored
R=hcarmona@chromium.org BUG=925278 Change-Id: Ia5c5f4770609a3794737732188312b5da4ebc43a Reviewed-on: https://chromium-review.googlesource.com/c/1437272 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#626274}
-
Aaron Leventhal authored
Once an HTML validation alert appears, do not remove the errormessage relation until the form control becomes valid. The disappearance of the validation alert is a timeout for the convenience of sighted users, but does not indicate whether the error message still applies. Bug: 924996 Change-Id: Icb43dba7bb29f64fb7f4814dc86cb56c24ed33c9 Reviewed-on: https://chromium-review.googlesource.com/c/1434796Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#626273}
-
David Black authored
Previously, it was possible to switch active sessions via hotkey and keep Assistant open from the primary profile. In this case, LibAssistant would not be running so interactions with Assistant would fail, but the desired UX is to close Assistant completely in this case. To address this, we associate the Assistant window with the active user. The window manager will appropriately close the window in response to profile changes. Bug: b:121223805 Change-Id: I9253cd58aa90e97645513e1b640ec3c7f8d77ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1385850 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#626272}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager, this CL replaces all uses of ATS with IdentityManager's ones in chrome_password_protection_service_unittest.cc. TEST: All tests of ChromePasswordProtectionServiceTest should work well. Bug: 922768 Change-Id: I551403c7d7c4333b1246fe4b5b933c12783637e7 Reviewed-on: https://chromium-review.googlesource.com/c/1433259Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#626271}
-
Mustafa Emre Acer authored
Testing four site both in the main profile and incognito is slow and causing test timeouts. Separate the tests. Bug: 923917 Change-Id: I2f93b0a200dd0c811fa66681afc4ef6da9f81aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1427619Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626270}
-
danakj authored
Have RenderWidget clear itself as the MainThreadEventQueue client when it is closing, in OnClose(). The queue already deals with trying to handle an event when the client is gone. However, it does not deal with the fact that when not handling the event it must still run the mojo reply callback or suffer the wrath of a DCHECK. RenderWidget does deal with this fact already. But instead of dealing with this callback behaviour at multiple levels, have the handle methods return a boolean back up to Dispatch(), where if it gets false it can run HandledEvent() with the failure args from a single place. Remove the closing early outs for MainThreadEventQueue methods in RenderWidget. R=bokan@chromium.org Change-Id: I0f836ed4df801ce470afb10894c9c3caa70c5711 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1435520Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#626269}
-
Xing Liu authored
This CL converts download notification to use new builder API which support general notification metric recording, including: Mobile.SystemNotification.Action.Click Mobile.SystemNotification.Content.Click Mobile.SystemNotification.Dismiss TBR=dtrainor@chromium.org Bug: 898269 Change-Id: I0a0634d9fc4bc52da2258e54dca0de7cdd3d4f09 Reviewed-on: https://chromium-review.googlesource.com/c/1433137 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626268}
-
- 25 Jan, 2019 1 commit
-
-
Paul Miller authored
WebUINavigationThrottle blocks WebUI (chrome://...) pages from loading non-WebUI pages in subframes. When a renderer navigates to a WebUI page, a "WebUI bindings" bit is set in that renderer's ChildProcessSecurityPolicyImpl::SecurityState, and it remains for the lifetime of the renderer process. WebUINavigationThrottles are created for renderers with this bit set. In multi-process mode, navigating away from the WebUI page creates a fresh renderer with a fresh SecurityState, so subsequent non-WebUI pages are again able to load non-WebUI subframes. In single-process mode, the WebUI bit remains. After visiting a WebUI page, iframes on all other pages will be broken until Chrome is restarted. This breaks Android WebView as well, since WebView uses single-process on old Android versions and low-memory devices. It breaks CTS because testOnSafeBrowsingHit loads chrome://safe-browsing/match?type=malware, which sets the bit, and then testShouldOverrideUrlLoadingOnCreateWindow tries to use an iframe. Fix this by not creating a WebUINavigationThrottle in single-process mode. BUG=924799 Change-Id: I5a61f45dc065681f0e6b97e0b205e804edbd7402 Reviewed-on: https://chromium-review.googlesource.com/c/1432953 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
-
