Commits · 458740641ebac37b37ab0b57b5a69db87718072c · eriksson monteiro / tangled

21 Jan, 2020 40 commits

[Sync:Sharing] Pass failed commit items to bridge. · 45874064

vitaliii authored Jan 21, 2020

We want to propagate failed commit item errors all the way from server
to bridge. This is second step. Propagate failed commit items from
ClientTagBasedModelTypeProcessor to the bridge.

Bug: 1034923
Change-Id: I4fe5d4448ed337b6ab14e04a749765053b62b249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010774
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733572}

45874064

Added a check against a race condition that would cause a request to... · 230cba31

Andy Paicu authored Jan 21, 2020

... be removed before the bubble is shown.

The exact conditions that trigger the race condition are unknown, I've
not been able to reproduce the issue reliably enough to investigate.

It appears that before `ShowBubble` gets to run, something happens that
calls `FinalizeBubble` which removes the request. It happens so rarely
that the DCHECK we have in place has not surfaced the issue.

Bug: 1041222
Change-Id: I0413fa70c77f2a24e17646b21d40ad9fa1cec69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000754
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733571}

230cba31

Roll src-internal 08a04042c18c..73a7576e7efb (2 commits) · 370a551e

chromium-internal-autoroll authored Jan 21, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08a04042c18c..73a7576e7efb


Created with:
  gclient setdep -r src-internal@73a7576e7efb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1042208
Tbr: jbudorick@google.com
Change-Id: I8102e451f8d28cfe503157360e28641a2a218415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011860Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733570}

370a551e

Update timeout and split slow COOP WPTs · 8f72ef6c

Pâris MEULEMAN authored Jan 21, 2020

This updates the timeout to long and splits into smaller tests the
flaky COOP web-platform tests.

reland of crrev.com/c/2003172 with proper expectations.

Bug: 1042199, 1043401
Change-Id: I7edfaaa520ed6c8fd2974d6c7622fb79c8316089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007821
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733569}

8f72ef6c

[ios] Try to avoid crash on null context during navigation · dc7f6fcf

David Jean authored Jan 21, 2020

Add a missing null check on context.
Also changed navigation not to check state to determine if commit has
already happened, since the state machine being uncertain, state not
being 'commit' doesn't mean commit has not been called before.

Bug: 1041368
Change-Id: I6f77c2137e30c46b8180f35e584833cd57f8f7db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003134Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733568}

dc7f6fcf

[Passwords] PasswordSaveManager::MoveCredentialsToAccountStore() · 3c1f9e2d

Mohamed Amir Yosef authored Jan 21, 2020

This patch introduces the method
PasswordSaveManager::MoveCredentialsToAccountStore()
and provide an implementation for the
MultiStorePasswordSaveManager.

Bug: 1032992
Change-Id: Ib6fee5f7bb0dae53a2a5b6372f4299200c80778c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962067
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733567}

3c1f9e2d

Roll src/third_party/angle 845a09b8241e..8075d3edde6c (1 commits) · 957b28f8

chromium-autoroll authored Jan 21, 2020

https://chromium.googlesource.com/angle/angle.git/+log/845a09b8241e..8075d3edde6c

git log 845a09b8241e..8075d3edde6c --date=short --first-parent --format='%ad %ae %s'
2020-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 41a96d15fd99..ac02c61ffc63 (16 commits)

Created with:
gclient setdep -r src/third_party/angle@8075d3edde6c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: timvp@google.com
Change-Id: I755d8637ddf73fb8fbc53621cd3e3c5f7d1864cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011450Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733566}

957b28f8

[ios] Fix name of UIKit framework · e7c231f5

Sylvain Defresne authored Jan 21, 2020

The next roll of gn expects the extension to use the correct case
(.framework) so fix the incorrect spelling of UIKit.framework in
components/cronet.

Bug: None
Change-Id: I839de0eafebd694542f9901f2ad805a2cf8cabca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011841
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733565}

e7c231f5

Revert "Fix NetworkContextConfigurationBrowserTest.DnsCacheIsolation flake." · 6113c487

Matt Menke authored Jan 21, 2020

This reverts commit 1dd7e2a7.

Reason for revert: STill flaky.  Reverting both CLs.
NOTRY=true

Original change's description:
> Fix NetworkContextConfigurationBrowserTest.DnsCacheIsolation flake.
> 
> The test makes sure that HostCache entries aren't shared between
> NetworkContexts. To do this, it does a DNS lookup in one NetworkContext,
> which succeeds, and then cache-only DNS lookups in other NetworkContexts,
> which should fail. At the end of the test, it does a cache-only lookup
> in the first NetworkContext, which should succeed. It's generally best
> to do this at the end of the test, since it makes sure that entries
> aren't only usable once, or somesuch. Unfortunately, sometimes the
> DNS cache entry is timing out before the last lookup. To fix that,
> this CL moves the final cache-only lookup to be right after the
> initial lookup that populates the cache.
> 
> This does mean the test can still flakily pass, however, flaky successes
> are more tolerable than flaky failures, and the test currently passes
> often enough, even with the flake, that I think we can live with it.
> 
> Bug: 1043084
> Change-Id: Ibdcf77e7775943e18c21a9ddd2cd3d5bf127c248
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008058
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733036}

TBR=mmenke@chromium.org,ericorth@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1043084
Change-Id: Ia4bffaad8793e7f660807c39d8e0cdfa95d8766b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012080Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733564}

6113c487

[AW] DevUI: show launcher icon for DevTools for prestable channels · 4f250a0f

Hazem Ashmawy authored Jan 21, 2020

- Show launcher icon for Standalone WebView and Trichrome WebView
  prestable channels (dev and canary) but not for Monochrome.

- The GN flag still has to be enabled for local builds to show the icon
  since they have `android_channel=default`.

- Use a different activity-alias for Monochrome which is disabled by
  default i.e the launcher icon for monochrome is disabled by default
  and the GN arg will not show the icon for monochrome till
  crrev.com/c/2000724 is merged.

Bug: 1026062
Test: Set android_channel="dev", verify standalone WebView and TrichromeWebView show the icon
Test: Set android_channel="dev", verify Monochrome does not show the icon
Test: Set android_channel="default", verify no WebView icons show up
Change-Id: Icd218fac086aa940bca61f2ac6ef3ceea76cf0db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993817Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733563}

4f250a0f

Roll src/third_party/webrtc 1a68679e65af..73aa2de3d761 (2 commits) · 6f5fd00a

chromium-autoroll authored Jan 21, 2020

https://webrtc.googlesource.com/src.git/+log/1a68679e65af..73aa2de3d761

git log 1a68679e65af..73aa2de3d761 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 mbonadei@webrtc.org Split android_junit_tests and move targets in the right package.
2020-01-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2a6702f0..4c751358 (733412:733512)

Created with:
gclient setdep -r src/third_party/webrtc@73aa2de3d761

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I6f7ef2e57e90b3d42f0da61561a534ea79f5e35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011451Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733562}

6f5fd00a

Revert "Remove shared ownership of CrostiniRestarter" · bce3872b

Thiemo Nagel authored Jan 21, 2020

This reverts commit 2711d4f7.

Reason for revert:

It looks like this is breaking a lot of tests.

https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36735

Deterministic failure: CrostiniInstallerTest.InstallerErrorWhileConfiguring (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnComponentLoaded (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnConciergeStarted (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerCreated (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerMounted (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerSetup (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnContainerStarted (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnDiskImageCreated (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnMountEvent (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnMountEventWithError (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnSshKeysFetched (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortOnVmStarted (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.AbortThenStopVm (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.RestartMultipleThenUninstall (status CRASH)
Deterministic failure: CrostiniManagerRestartTest.RestartThenUninstall (status CRASH)

Original change's description:
> Remove shared ownership of CrostiniRestarter
> 
> It seems to be possible for shared references to CrostiniRestarter to
> outlive CrostiniManager. Since all of CrostiniRestarter assumes that
> CrostiniManager still exists, this can cause crashes. Switch
> CrostiniRestarter to being exclusivly owned by CrostiniManager and
> handing out weak pointers to callbacks.
> 
> Bug: 1040797
> Change-Id: Ib65c79c7c81111aad88435b3c95da0c64226e791
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996112
> Reviewed-by: Nic Hollingum <hollingum@google.com>
> Commit-Queue: Fergus Dall <sidereal@google.com>
> Cr-Commit-Position: refs/heads/master@{#733496}

TBR=sidereal@google.com,hollingum@google.com,davidmunro@google.com

Change-Id: Ic7f8db4dee861105dd10d7959d94ebbf0a5279b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011922Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733561}

bce3872b

Implement set_permission() in testdriver-vendor.js. · 0ccf8759

Raphael Kubo da Costa authored Jan 21, 2020

Use internals.setPermission() to make test_driver.set_permission() work with
content_shell and consequently Chromium's CI system. The ChromeDriver
implementation has been available for several months now, so this was the
last piece of the puzzle preventing us from overriding permissions in tests
and exporting more of them to web-platform-tests.

Convert a few existing tests to it to show it works.

Bug: 1030663
Change-Id: I66189896a3889a4ef34058c8100ddff75923c306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002873
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733560}

0ccf8759

Filter recent files from disk source by specified file_type. · 14a30c26

Naoki Fukino authored Jan 21, 2020

Based on the given |file_type|, GetRecentFiles to disk sources should
filtered result.
File types of the files inside disk sources will be guessed by file
extensions (inside net::GetMimeTypeFromFile()).

Bug: 1040049
Test: Ran unit_tests
Change-Id: I7ae9c5b71bbc2fc25016149fdf8e8a98d6b1b5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011592
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733559}

14a30c26

Reland "Fix 0,0-0x0 turning into PaintOp::kUnsetRect." · ef2cc102

Thiemo Nagel authored Jan 21, 2020

This reverts commit 0fde9a92.

Reason for revert: Test breakage in 
* virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi.html
* virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi.html

at https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29

Original change's description:
> Revert "Fix 0,0-0x0 turning into PaintOp::kUnsetRect."
> 
> This reverts commit 0156c949.
> 
> Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly.
> 
> Original change's description:
> > Fix 0,0-0x0 turning into PaintOp::kUnsetRect.
> >
> > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early
> > return prevents the effect_bounds_stack_.back() update in a
> > ConversionContext::UpdateEffectBounds call. This results in keeping default
> > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect.
> >
> > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for
> > details). Application of this patch fixes the lagging print preview.
> >
> > R=fmalita@chromium.org, samans@chromium.org
> >
> > Bug: 918240
> > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958
> > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#714293}
> 
> Bug: 918240
> Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733491}

TBR=wangxianzhu@chromium.org,pdr@chromium.org,dbessonov@yandex-team.ru

Change-Id: If99b75af33c3a00f64eec91b4c711879f3665ce0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011843Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733558}

ef2cc102

Roll src/third_party/dawn 0fee6ccc2e6e..f2ed2482a449 (1 commits) · 8294a64a

chromium-autoroll authored Jan 21, 2020

https://dawn.googlesource.com/dawn.git/+log/0fee6ccc2e6e..f2ed2482a449

git log 0fee6ccc2e6e..f2ed2482a449 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 cwallez@chromium.org Reorder wgpu::BackendType to match webgpu.h

Created with:
gclient setdep -r src/third_party/dawn@f2ed2482a449

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I0db157191236ca75077dfdf2ab122dbfe3356674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011449Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733557}

8294a64a

Import wpt@06fca46aa29eabc2ba2f50667acdf250f9261948 · 0c44cdec

Chromium WPT Sync authored Jan 21, 2020

Using wpt-import in Chromium c9d4207d.
With Chromium commits locally applied on WPT:
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ieb254fd9e1cac234fdf4b2ef99a111c0fbd60c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011661Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733556}

0c44cdec

Enable V8ConcurrentInlining fieldtrial for ios and webview · 38669f86

Maya Lekova authored Jan 21, 2020

Also reorder the experiments so that Enabled is first and gets tested
by the perf bots and the waterfall.

Fixes the field trial config as required for cl/285382195

Bug: chromium:1031988
Change-Id: I824a4ef052d694e790e8261377ff920ea49ef2f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010843Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733555}

38669f86

Roll src-internal d53a082f1e62..08a04042c18c (1 commits) · 20de4c19

chromium-internal-autoroll authored Jan 21, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d53a082f1e62..08a04042c18c


Created with:
  gclient setdep -r src-internal@08a04042c18c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I697fafe210400222161ff5906f2818567d9c3a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011447Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733554}

20de4c19

[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/ui/activity_services · e32055d4

Sylvain Defresne authored Jan 21, 2020

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=pkl@chromium.org

Bug: 1042208
Change-Id: Ie8a877a9f2a073e891ce7da50d6d517756a7c5da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010766
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733553}

e32055d4

Label responds to theme change · 02f98476

Eric Willigers authored Jan 21, 2020

Previously, Label would only update colors in response to theme changes
if the text_style was STYLE_PRIMARY.

CustomTabBarView now uses CONTEXT_LABEL for the title and the origin.
As the origin has STYLE_SECONDARY, this causes the origin to be faded
relative to the title.

Screen shots before and after:
https://docs.google.com/document/d/1YRuzw0Bh9IyjmbtwBa0NpwNvu7ttbMM8mdRF0K3YWzc/edit?usp=sharing

Bug: 1033298
Change-Id: Iff4dbc7dfe611cd4c3a38da0b39fc790dae29bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010757
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733552}

02f98476

[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/ui/authentication · 37cf4fd9

Sylvain Defresne authored Jan 21, 2020

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=msarda@chromium.org

Bug: 1042208
Change-Id: I0c94aaa09f0e3c9b949e76f001fda36c8aa0b7ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007462
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733551}

37cf4fd9

Update V8 to version 8.1.231. · b7c80160

v8-ci-autoroll-builder authored Jan 21, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bf7181f7..056f1769

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I24fc4ef32eb973dd3a2a6fd98a1c9ff432389d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011660Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733550}

b7c80160

[ios] Allow use of chrome_browser_provider_forward.h from provider · 7490a086

Sylvain Defresne authored Jan 21, 2020

The provider are not permitted to have dependency on //ios/chrome,
however they were able to forward-declare ChromeBrowserProvider so
they ended up with indirect dependency.

To allow moving the class to the global namespace, allow them to
include the forwarding header since this does not increase the
amount of "bad" dependency.

This is a reland of https://crrev.com/c/2010796 with the correct
path (sorry for the spam).

Bug: 1042208, 1043657
Change-Id: I9abe0f492ab1ff86ca095dc22beb437459e8e239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010984
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733549}

7490a086

Reland "[base] Migrate PostTaskAndReplyWithResult to OnceCallbacks" · 0c53a6fc

Jan Wilken Dörrie authored Jan 21, 2020

This reverts commit 28376809.

Reason for revert: This change addresses the compilation error.

Original change's description:
> Revert "[base] Migrate PostTaskAndReplyWithResult to OnceCallbacks"
>
> This reverts commit 0593d72b.
>
> Reason for revert: Compiles failing, examples:
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1791
> https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/148062
>
> Looks mostly like ifdefed callsites that weren't migrated.
>
> Original change's description:
> > [base] Migrate PostTaskAndReplyWithResult to OnceCallbacks
> >
> > This change migrates users of base::PostTaskAndReplyWithResult to
> > use base::OnceCallbacks. This allows removing the CallbackType template
> > from the API, making sure future users are required to use OnceCallbacks.
> >
> > TBR=danakj
> >
> > Bug: 714018
> > Change-Id: I8453c351e406a98fc8b9fddce2637331fdbbf5c4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965664
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#732403}
>
> TBR=lambroslambrou@chromium.org,danakj@chromium.org,jdoerrie@chromium.org
>
> Change-Id: I9a417e1d289c750f5ce5e1f43972bf09c0b23e4f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 714018
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004968
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732414}

TBR=lambroslambrou@chromium.org,danakj@chromium.org,lgrey@chromium.org,jdoerrie@chromium.org

Change-Id: I7cfc4ef768e4020e4d87300f7e8b57cdfff05fb3
Bug: 714018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005028Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733548}

0c53a6fc

SharedWorker: Support dynamic import with 'module' type on SharedWorker · 8fe78d47

Eriko Kurimoto authored Jan 21, 2020

This change is still behind the flag.

Bug: 824646
Change-Id: I8a82c9b1fe499c4cf8ba182c308054c5dc9e5d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009598
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733547}

8fe78d47

[quickview] Avoid race conditions · 286540be

Isabella Scalzi authored Jan 21, 2020

As mentioned in CL:2010236 we should avoid race conditions when
setting file tasks of an entry.

Only save tasks for an entry once the Quick View content panel
has been successfully updated.

Test: covered by existing tests
Bug: 1038799
Change-Id: I46697284d9d0690aa66a760a27da3b82caef5b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011584Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733546}

286540be

Update WebRTC Junit tests binaries. · 76ec04ef

Mirko Bonadei authored Jan 21, 2020

The old binary will be removed in favor of binaries that don't violate
package boundaries.

Bug: webrtc:11289
Change-Id: I338dc11a98dbe3c7c892b056aa9f82069280c02a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010981Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733545}

76ec04ef

[quickview] Add a check-select helper function · b2a6bf9c

Rachel Sugrono authored Jan 21, 2020

Add a helper that opens Quick View in check-select mode.
This helper verifies that the given file names matches the
selected files.

Bug: 1038799
Change-Id: I5915404725adf6a75c82a193362caa1dd1426990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011587
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733544}

b2a6bf9c

Roll src/third_party/skia 992e227af7f1..e07936314c2b (1 commits) · c9d4207d

chromium-autoroll authored Jan 21, 2020

https://skia.googlesource.com/skia.git/+log/992e227af7f1..e07936314c2b

git log 992e227af7f1..e07936314c2b --date=short --first-parent --format='%ad %ae %s'
2020-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 579c59400f86..845a09b8241e (4 commits)

Created with:
gclient setdep -r src/third_party/skia@e07936314c2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I0fd9c5f39d6d80bf926432df031d2c0d603e4725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010055Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733543}

c9d4207d

service worker: Add ServiceWorkerRegistry::CreateNewRegistration() · bc69651f

Kenichi Ishibashi authored Jan 21, 2020

The purpose of this change is to have a single point of creating
ServiceWorkerRegistration. This way,
* We can hide NewRegistrationId() inside ServiceWorkerRegistry.
  This is useful because we plan to move id management into the
  Storage Service and we don't want to expose it other than
  ServiceWorkerRegistry.
* ServiceWorkerRegistry can track all live registrations. In
  subsequent CLs we plan to hook ServiceWorkerRegistration creation
  so that ServiceWorkerRegistry can detect if the registration is
  stored or not.

Bug: 1039200
Change-Id: Ieeeb4c3b156488de8fe6a527515ec23998c5ea3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010599
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733542}

bc69651f

media/gpu/v4l2: avoid unneeded NativePixmapHandle copy · 8c919071

Alexandre Courbot authored Jan 21, 2020

Avoid creating a NativePixmapHandle now that we have one ready to be
used. This code was a remainder from the time where we passed dmabuf FDs
to CreateGLImage().

BUG=b:146842214
TEST=E2E video playback in Chromium working on Kukui and Kevin.

Change-Id: Icf54bacc0d62d9ca74d69174227ec7a1511aa4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010589
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733541}

8c919071

Roll src-internal dc9588f19d70..d53a082f1e62 (1 commits) · 56145505

chromium-internal-autoroll authored Jan 21, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc9588f19d70..d53a082f1e62


Created with:
  gclient setdep -r src-internal@d53a082f1e62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I1fa2a0f610d97371eb781970185d55de49a5dfa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011600Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733540}

56145505

media/gpu/v4l2vda: fix EGL image size · 35632d04

Alexandre Courbot authored Jan 21, 2020

The size of the EGL image is supposed to be the visible size, while the
buffer itself shall be imported with its own coded size and stride.

Before crrev.com/c/1982499, we did not pass any size information with
the buffer, so as a workaround the size was set to the coded size and
the buffer imported with its coded size into the GPU or DC, which
resulted in visible green lines on the right or lower end of the image
when coded_size != visible_size.

Now that we are importing the buffer using a NativePixmapHandle, we can
set the EGL image to be the correct visible size.

BUG=b:141579960
TEST=240p h.264 video plays in Youtube web without visible green line on
Hana.

Change-Id: Ia7631998b7e47c5f8d1001b26e5a154fdffebcb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010588
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733539}

35632d04

More logging in InstallServiceWorkItemImpl to track down update failures. · 1f7eb063

Greg Thompson authored Jan 21, 2020

BUG=1023080
R=ganesh@chromium.org

Change-Id: I4fd2e2c2fc7365f1977221e99993cea870d587be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007766
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733538}

1f7eb063

[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/sync · 2318d680

Sylvain Defresne authored Jan 21, 2020

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=mastiz@chromium.org

Bug: 1042208
Change-Id: If00ecce091d5f71b8d55e7197d71b5ed75e70727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007641
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733537}

2318d680

Roll src/third_party/skia 71b8b765a231..992e227af7f1 (1 commits) · f637d465

chromium-autoroll authored Jan 21, 2020

https://skia.googlesource.com/skia.git/+log/71b8b765a231..992e227af7f1

git log 71b8b765a231..992e227af7f1 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6c56a01a..4c751358 (270 commits)

Created with:
gclient setdep -r src/third_party/skia@992e227af7f1

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: Ib61686a1744b9c3ff81787282d5fa728b1446230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011366Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733536}

f637d465

[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/language · 38983536

Sylvain Defresne authored Jan 21, 2020

Instead of forward declaring ChromeBrowserState in the ios
namespace, use a header. This will allow moving the class
to the global namespace without having to change all the
forward declaration at the same time.

This CL was uploaded by git cl split.

R=dvallet@chromium.org

Bug: 1042208
Change-Id: Ic014ac6c3dc2cdaec2cbf7a088a32d7d6ce529f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007423
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733535}

38983536

Changing the return type of FFTFrame::RealData() · 6fa56d84

Imranur Rahman authored Jan 21, 2020

and FFTFrame::ImagData().

FFTFrame::RealData() and FFTFrame::ImagData() previously
return raw float* to the underlying arrays. But only the FFTFrame
knows the how long the arrays are. Now we are returning the
AudioFloatArray, so the caller can check lengths appropriately.

Bug: 966128
Change-Id: I3829eaea1fcc15c4c4dabf706716ba38c7c7e278
Signed-off-by: Imranur Rahman <i.rahman@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844914Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733534}

6fa56d84

Updated flag expiration milestones · 98daac09

Shakti Sahu authored Jan 21, 2020

Updated flag expiration milestones for two experiments
1 - download-auto-resumption-native
2 - enable-new-download-backend

Change-Id: If5ab4573e06843767f8387e5cea95d218dc84ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008625Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733533}

98daac09