GitLab

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3/flexbox/repaint-rtl-column.html

Mark it as failing on Yosemite and pass everywhere else.

R=ojan@chromium.org
BUG=520167

Review URL: https://codereview.chromium.org/1294853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyClippingToContext is equally "stateful", so the two entrypoints
does not seem warranted.
Fold applyClippingToContext into applyStatefulResource and then rename
it to prepareEffect (to match mask and filter). Similarly rename
postApplyStatefulResource to finishEffect.

Review URL: https://codereview.chromium.org/1308223003

git-svn-id: svn://svn.chromium.org/blink/trunk@201262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames |isBlock(Node*)| to |isEnclosingBlock(Node*)| to make
meaning of function cleaner for improving readability.

This is follow up patch of http://crrev.com/1309903003, which introduces
|enclosingNodeOfType()|, which uses |isBlock()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525286

git-svn-id: svn://svn.chromium.org/blink/trunk@201260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion

I plan to merge this to the M46 branch ASAP.

R=esprehn@chromium.org,yoav@yoav.ws
BUG=475104

Review URL: https://codereview.chromium.org/1314923005

git-svn-id: svn://svn.chromium.org/blink/trunk@201259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Switch keypad and auto repeat booleans to use enum flags. Space was reserved
for them; this just brings PlatformKeyboardEvent more inline with
WebInputEvent.

BUG=524626

Review URL: https://codereview.chromium.org/1311233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524387

Review URL: https://codereview.chromium.org/1310863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521900

Review URL: https://codereview.chromium.org/1315703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix TestExpectations lint error after http://src.chromium.org/viewvc/blink?view=revision&revision=201246

BUG=524248
TBR=mnaganov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1316863003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutSVGResourceClipper::tryPathOnlyClipping contains the code to
emit the path - if one is successfully built. For the sake of layering,
push this out into the caller (SVGClipPainter) instead.

Also replace uses of clipperResource().isEmpty() with hasClipper(),
rename objectBoundingBox referenceBox (to better match the Masking spec
terminology) and rename the tryPathOnlyClipping to asPath.

Review URL: https://codereview.chromium.org/1308983007

git-svn-id: svn://svn.chromium.org/blink/trunk@201254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace the runtime feature OverlayFullscreenVideo by
ForceOverlayFullscreenVideo. A previous change allows WebMediaPlayer
to decide whether to do overlay video, so this is no longer needed. The
replacement allows the feature to be forced on for layout tests.

BUG=511376
TEST=virtual/android/fullscreen layout tests, manual

Review URL: https://codereview.chromium.org/1311763004

git-svn-id: svn://svn.chromium.org/blink/trunk@201253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The AbsoluteClipRects are now precomputed as part of
the compositing update step as this is the only
consumer of them (more precisely overlap testing).
Added some ASSERTs to ensure we compute them at
the right time and we don't hold onto stale values.

BUG=515970

Review URL: https://codereview.chromium.org/1316173002

git-svn-id: svn://svn.chromium.org/blink/trunk@201252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525031

Review URL: https://codereview.chromium.org/1315713003

git-svn-id: svn://svn.chromium.org/blink/trunk@201251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522865

Review URL: https://codereview.chromium.org/1312883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
May be causing win failures, see http://crbug.com/524248#50

Original issue's description:
> Fix reftest crash logs
> 
> This patch fixes a long-standing bug where crashing reftests would not
> show some crash logs on the layout tests results page.
> 
> single_test_runner.py has an optimization to not run reftests when
> the base test crashes. This optimization accidentally failed to write
> crash logs (done through write_test_result(...)) as well. This patch
> fixes this bug and adds a small test.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201147

TBR=dpranke@chromium.org,joelo@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1318813005

git-svn-id: svn://svn.chromium.org/blink/trunk@201249 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTTP headers are byte strings, so anything outside of
ASCII needs to be explicitly encoded one way or another.

BUG=429569

Review URL: https://codereview.chromium.org/836823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When testing all three mixed content types in one test, the test was
flaky because DevTools received requestWillBeSent events in different
orders. Instead of making sure that the requests are always sent in the
same order, this CL splits up the test into 3 separate tests, one for
each mixed content type, with common code in
resources/mixed-content-type-test.js.

BUG=523500

Review URL: https://codereview.chromium.org/1303033004

git-svn-id: svn://svn.chromium.org/blink/trunk@201247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let's see, whether would it help webkit_tests to complete.

BUG=524248

git-svn-id: svn://svn.chromium.org/blink/trunk@201246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And remove obsolete error messages.

3rd of 3 patches:
1. Add errors and prepare tests. (https://codereview.chromium.org/1293593003/)
2. Wire up the chooser on the Chrome side. (https://codereview.chromium.org/1286063002/)
3. This patch.

BUG=500989

Review URL: https://codereview.chromium.org/1284143006

git-svn-id: svn://svn.chromium.org/blink/trunk@201245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Doing so results in assertion failure because the document lifecycle does not
allow rewinding from InPaintForSlimmingPaintV2 back to LayoutClean.

Skipping compositing update should be fine since SPv2 doesn't rely on old world
compositing anyway.

BUG=524879

Review URL: https://codereview.chromium.org/1312363003

git-svn-id: svn://svn.chromium.org/blink/trunk@201244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1313633003

git-svn-id: svn://svn.chromium.org/blink/trunk@201243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DrawingBuffer is not deleted until all mailboxes are released.

BUG=524139

Review URL: https://codereview.chromium.org/1316143002

git-svn-id: svn://svn.chromium.org/blink/trunk@201241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt

BUG=422670

git-svn-id: svn://svn.chromium.org/blink/trunk@201238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=bungeman@chromium.org
BUG=525050

Review URL: https://codereview.chromium.org/1307223006

git-svn-id: svn://svn.chromium.org/blink/trunk@201237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is needed as a prerequisite to making "visual viewport scrolls first"
the default. Scrolling the page before setting scale means that the layout
viewport is the only one that could scroll.

Note, this is patching 2 tests I missed in my original patch:
http://crrev.com/1301523006

BUG=443724
TBR=majidvp@chromium.org

Review URL: https://codereview.chromium.org/1317003002

git-svn-id: svn://svn.chromium.org/blink/trunk@201236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521764

git-svn-id: svn://svn.chromium.org/blink/trunk@201235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Developers are expressing confusion when passing invalid service names,
sometimes because they pass an invalid UUID that nearly looks correct.
Explain more explicitly in the error message what is accepted.

BUG=491441

Review URL: https://codereview.chromium.org/1315443007

git-svn-id: svn://svn.chromium.org/blink/trunk@201234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/YKVnS429hns

BUG=412331
NOTRY=true

Review URL: https://codereview.chromium.org/1315103002

git-svn-id: svn://svn.chromium.org/blink/trunk@201233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Centralize deferred commit conditions. (patchset #1 id:1 of https://codereview.chromium.org/1300043003/ )

Reason for revert:
Perf regression due to an error. willInsertBody is actually before the body is available which means the check for body() in this patch would not succeed and we'd end up not resuming commits until we finished parsing if all sheets were done loading before we got to the <body>.

BUG=524172

Original issue's description:
> Centralize deferred commit conditions.
> 
> Instead of having many callbacks that implicitly have conditions for when the
> blink frame pipeline should run, have a function on Document that checks them
> explicitly and make WebViewImpl call it.
> 
> This will allow checking if iframes are ready to begin running their lifecycle
> phases when iterating the frame tree in ::beginFrame and ::layout().
> 
> BUG=521692
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200783

TBR=ojan@chromium.org,dglazkov@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692

Review URL: https://codereview.chromium.org/1317883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521764
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/1313353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the requirement for the caller of a BackgroundSync
manager method to be either a service worker or a controlled client.
Now, uncontrolled clients are also able to access the manager, and Blink
informs the browser whether a registration request came from a Service
Worker or not. (Service Workers are still required to have at least one
active window client in order to register sync events; this is enforced
in the browser).

This is part 1 of a three-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003 (this patch)
Part 2: https://codereview.chromium.org/1316743002
Part 3: https://codereview.chromium.org/1314453003

BUG=518884

Review URL: https://codereview.chromium.org/1309393003

git-svn-id: svn://svn.chromium.org/blink/trunk@201230 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=bungeman@chromium.org
BUG=525050

Review URL: https://codereview.chromium.org/1313733009

git-svn-id: svn://svn.chromium.org/blink/trunk@201229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201202

BUG=524859
TBR=trchen@chromium.org

Review URL: https://codereview.chromium.org/1317863002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- domactivate-sets-underlying-click-event-as-handled.html (Issue 520173)
- audionode-disconnect-audioparam.html (Issue 525065)

NOTRY=true
TBR=mnaganov
BUG=520173, 525065

Review URL: https://codereview.chromium.org/1308263003

git-svn-id: svn://svn.chromium.org/blink/trunk@201227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=bungeman@chromium.org
BUG=524623

Review URL: https://codereview.chromium.org/1315133002

git-svn-id: svn://svn.chromium.org/blink/trunk@201226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Other attributes have already been using V8's named property interceptor.
Window is only an exception.  Let's use it for Window, too.

This CL intentionally changes the look-up behavior.
Sample code:
  iframe = document.createElement('iframe');
  iframe.name = 'alert';
  document.body.appendChild(iframe);
Before:
  window.alert => iframe with the name 'alert'
After:
  window.alert => built-in alert function

According to the spec, (non-named, regular) attributes/methods must have priority over named properties.

See "The named property visibility algorithm" at
http://heycam.github.io/webidl/#indexed-and-named-properties
The order of look-up for non-[OverrideBuiltins] interfaces (including Window) must be:
  1. Own properties.
  2. Properties from the prototype chain.
  3. Named properties.

The Intent-to-Implement-and-Ship is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlmsE3fDCNg

BUG=43394,516274

Review URL: https://codereview.chromium.org/1121703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=johnme
BUG=

Review URL: https://codereview.chromium.org/1311673008

git-svn-id: svn://svn.chromium.org/blink/trunk@201224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a fix for the data race in GCInfoAtBase::index.
The GCInfo is defined as static local and this causes race while
allocating new objects. This CL reduces the initialization time by
using function pointer to get the class name instead of string parsing.

BUG=524237

Review URL: https://codereview.chromium.org/1312963002

git-svn-id: svn://svn.chromium.org/blink/trunk@201223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201181

BUG=518347
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1320633003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SegmentedSubstring::{m_length,m_data} was declared public.
This CL makes them private and adds public accessors to them.

BUG=None
TESTS=Refactoring only. Shouldn't change any behaviour.

Review URL: https://codereview.chromium.org/1317693006

git-svn-id: svn://svn.chromium.org/blink/trunk@201221 bbb929c8-8fbe-4397-9dbb-9b2b20218538