GitLab

BUG=168909
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11783062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176011 0039d316-1c4b-4281-b951-d872f2087c98

- Move the step creation lines to the parent script.  The biggest
  advantage of this is the full step is properly printed, starting
  with the exact shell line used to run the test suite.

- Rename some steps into c++ style.

BUG=168894
NOTRY=true

Review URL: https://codereview.chromium.org/11817033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176010 0039d316-1c4b-4281-b951-d872f2087c98

Also add some per-file owners to the common_param_traits.cc, since it's a
highly security-sensitive area.

BUG=168923
Review URL: https://codereview.chromium.org/11826002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176009 0039d316-1c4b-4281-b951-d872f2087c98

We still don't honor the too-short delays (this CL actually makes us
more aggressive about not honoring them), but I've lowered the limit
to 1 minute, and we emit a warning to the console instead of erroring,
and we emit this warning even in dev mode since people were getting
surprised by the difference in behavior between dev and release.

I've also moved the frequency description into the create()
documentation from the chrome.alarms summary, at joemarini's request.

And I fixed the eventPages example to work with trunk Chrome.

BUG=168519,159879

Review URL: https://chromiumcodereview.appspot.com/11818010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
BUG=167187
TBR=shess

Review URL: https://chromiumcodereview.appspot.com/11819042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176003 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11835002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176002 0039d316-1c4b-4281-b951-d872f2087c98

Macbook pros using Intel graphic chips are using the synchronous
readback path. This path is using point sampling and shows
noticiable scaling artifacts.

Changing this to bilinear to match asynchronous	case.

BUG=168917


Review URL: https://chromiumcodereview.appspot.com/11826036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176001 0039d316-1c4b-4281-b951-d872f2087c98

This patch updates these icons and changes icon for move dragging type from MOVE to GRABBING.

BUG=137982


Review URL: https://chromiumcodereview.appspot.com/11823017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176000 0039d316-1c4b-4281-b951-d872f2087c98

R=jschuh@chromium.org
BUG=167187


Review URL: https://chromiumcodereview.appspot.com/11778076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175999 0039d316-1c4b-4281-b951-d872f2087c98

This is to stop people accidentally using the ERROR macro for other uses,
e.g. VLOG(ERROR) is not meaningful.

BUG=

Review URL: https://chromiumcodereview.appspot.com/11669010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175998 0039d316-1c4b-4281-b951-d872f2087c98

R=jschuh@chromium.org
BUG=167187


Review URL: https://chromiumcodereview.appspot.com/11823040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175997 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the class PinchZoomViewport to (1) move it out of layer_tree_host_impl.* and (2) convert it to Chromium style.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11829006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175996 0039d316-1c4b-4281-b951-d872f2087c98

When a RenderView is swapped out, it navigates to a swapped-out url
(swappedout://), and thus corrupts the paint content of the actual view. To fix
this issue, prevent a swapped-out RenderView from painting. Also, make sure the
screenshot is taken in the browser side before the RenderViewHost is swapped
out.

BUG=160668

Review URL: https://codereview.chromium.org/11776010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
BUG=167187
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/11833015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175994 0039d316-1c4b-4281-b951-d872f2087c98

For the purpose of updating <webview>'s name attribute, RenderViews report back to the browser process when window.name is mutated. It turns out this hurts Sunspider performance.

This patch introduces a renderer preference that avoids the IPC in regular RenderViews.

BUG=169028
Test=BrowserPluginHostTest.*, Sunspider

Review URL: https://codereview.chromium.org/11833016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175993 0039d316-1c4b-4281-b951-d872f2087c98

around. Both only occurred when the active tab width differs from
inactive tab width (lots-o-tabs).
. ResizeLayoutTabs() had an optimization that avoided doing anything
  if the width of the first tab hasn't changed. Problems is if the
  first tab is active and inactive tabs have a smaller width than
  active tabs than the width won't have changed but we still need to
  layout. I removed the optimization.
. If selecting a tab triggers a bounds change the coordinates used by
  tab dragging would be wrong (because they extract them from the
  event, which is in the original coordinates).
. Needed to tweak rtl code.

BUG=140747
TEST=see bug, but make sure no weird behavior with tab selection/dragging on
windows/chrome-os.
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11821036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175991 0039d316-1c4b-4281-b951-d872f2087c98

message_box_active_ is no longer used, and ironically is causing a
crash.

BUG=169059
TEST=none
R=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11833020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11818035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175989 0039d316-1c4b-4281-b951-d872f2087c98

The special-case handling for displaying the host desktop at 1:1
in high-DPI added in r174845 incorrectly handles mapping of the
clip rect from DIPs to client plugin output coordinates.

This CL re-names the various size and scale members to make a
clearer distinction between DIP, device and (client plugin) view
coordinates, and corrects the clip rect logic.

BUG=163228,168440
TEST=Connect high-DPI client to Chromoting host, switch to Original Size, and configure host to be larger than the client. Scroll around the host desktop and verify that all contents update correctly, e.g. while a video is played in a maximized window.

Review URL: https://chromiumcodereview.appspot.com/11782016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175988 0039d316-1c4b-4281-b951-d872f2087c98

By using uint32, we have bugs on 64-bit platforms: callers passing in a size_t, will have their size truncated, potentially allocating a smaller
chunk than requested. There are a few places this happens, including on the
receiving ends of IPCs(!)

However, coversely, other callers of the API might directly assign the
memory chunk's length to uint32, leading to a different possible truncation
problem. This is guaraded against by limiting operations internally to
std::numeric_limits<uint32_t> in size for now.

There's some minor cascade effects that make the CL look larger than it is.

BUG=164678
Review URL: https://codereview.chromium.org/11446048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175987 0039d316-1c4b-4281-b951-d872f2087c98

Currently if we try to activate on a carrier like Sprint, which does not use any activation process, we'll not be able to via the UI. In fact, we'll end up using the Verizon activation process which will completely fail. This CL fixes that.
Additionally, this CL also fixes the issue that once the details page is up, the connection state data (and the corresponding state of the various buttons on the page) is not updated as the network updates itself. This affects celluar but also WiFi.

R=gspencer@chromium.org
BUG=chrome-os-partner:14111


Review URL: https://chromiumcodereview.appspot.com/11829015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175984 0039d316-1c4b-4281-b951-d872f2087c98

Also makes the presence of the checkboxes in WebUI be based on
ProfileShortcutManager::IsFeatureEnabled().

BUG=162026,168196
TEST=Edit a profile that has a desktop shortcut. The WebUI should should a delete checkbox that should work as expected. Edit a profile without a shortcut and the checkbox should still be the create one.

Review URL: https://chromiumcodereview.appspot.com/11633041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175983 0039d316-1c4b-4281-b951-d872f2087c98

We use TestResult.GetAllBroken to identify and retry tests.
However, this list is empty if a test times out (and the device is
responsive). In this case we should propagate the timed_out info to the
final result, which will report a STEP_FAILURE based on this
information.

Ex. bad run:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6093/steps/sandbox_linux_unittests/logs/stdio

BUG=169064
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11833017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175982 0039d316-1c4b-4281-b951-d872f2087c98

Just a little cleanup and some extra checks.

R=danakj@chromium.org
BUG=155209


Review URL: https://chromiumcodereview.appspot.com/11827036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175981 0039d316-1c4b-4281-b951-d872f2087c98

be null.

This is causing these crashes
https://code.google.com/p/chromium/issues/detail?id=169129

BUG=169129,168890
TEST=crashes be gone
Review URL: https://codereview.chromium.org/11834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175980 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175979 0039d316-1c4b-4281-b951-d872f2087c98

Mostly disable c4267, but a couple that seem safe to me.

R=jschuh@chromium.org
BUG=167187

Review URL: https://chromiumcodereview.appspot.com/11819038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175978 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11823036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175977 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=102&rev=175797
http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/moz/report.html?history=70&rev=175789


BUG=169043


Review URL: https://chromiumcodereview.appspot.com/11783068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100845


Review URL: https://chromiumcodereview.appspot.com/11783045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175975 0039d316-1c4b-4281-b951-d872f2087c98

Switch to using a load method that allows us to distinguish
between frames to ensure we only update the loading progress bar
on main frame loads.  Also, clears the progress when starting a load
to nofity the user earlier of a change.

BUG=168368


Review URL: https://chromiumcodereview.appspot.com/11825007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175974 0039d316-1c4b-4281-b951-d872f2087c98

This is causing asserts in single-thread-proxy. We will want
to enable this independant of the renderer and command-line flag.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11829033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175973 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11827035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175972 0039d316-1c4b-4281-b951-d872f2087c98

Revert 175890: actually, looks like we want this to also help move chromeos webui pages out of src/chrome.
> Revert 175822
> 
> After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> 
> > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> > Review URL: https://codereview.chromium.org/11783038
> 
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/11818036

TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11819050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175971 0039d316-1c4b-4281-b951-d872f2087c98

They are running as part of content_browsertests on gpu bots now.

BUG=111506
TEST=gpu bots
Review URL: https://codereview.chromium.org/11783078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175970 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11828026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175969 0039d316-1c4b-4281-b951-d872f2087c98

Move the Chrome Variations HTTP header helper file into c/b/metrics/variations, and fix up lock behavior a bit.

Specifically:
  (1) Reduces the duration for which the lock is held when appending HTTP headers.
  (2) Adds a debug assertion that the lock is correctly held when calling UpdateVariationIDsHeaderValue().

BUG=none

Review URL: https://chromiumcodereview.appspot.com/11821019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175967 0039d316-1c4b-4281-b951-d872f2087c98

The callback function of chrome.tabs.create is called once the tab is created, not when it is loaded.

If runTests() is called, it would open a tab for URL about:blank and once that is created, run the tests. The tests may call navigateAndWait which performs a navigation and waits for the completion. The chrome.tabs.onUpdated listener could be triggered by the completion of loading about:blank, however. Not by the completion of loading the URL which navigateAndWait tried to load. With this change, we wait until about:blank is fully loaded until we start executing any tests.

BUG=112155


Review URL: https://chromiumcodereview.appspot.com/11645021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175966 0039d316-1c4b-4281-b951-d872f2087c98

(which can be reused when WebDataService is broken up).

TBR=ben@chromium.org (for gyp changes)
TEST=No visible change
BUG=166488



Review URL: https://chromiumcodereview.appspot.com/11761016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175965 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11828029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175963 0039d316-1c4b-4281-b951-d872f2087c98