GitLab

This CL removes the Activity Log UI. I will be replacing it with an extension once the chrome.activityLogPrivate API is complete.

The only code changes in this CL are for code deletion.

BUG=241672

Review URL: https://chromiumcodereview.appspot.com/15812004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202959 0039d316-1c4b-4281-b951-d872f2087c98

able to override it. But there is already functionality in internals.settings to
to that.

BUG=231643

Review URL: https://chromiumcodereview.appspot.com/15898003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202958 0039d316-1c4b-4281-b951-d872f2087c98

Remove "--hsts-hosts" so we don't have to maintain it during upcoming changes to the TransportSecurityState data structures and JSON format.

The "--hsts-hosts" feature is likely unused, is redundant with net-internals,  and is dangerous since it fails silently.  Also it exposes the internal JSON format to the user.

BUG=156152
R=rsleevi,palmer

Review URL: https://chromiumcodereview.appspot.com/15711007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202957 0039d316-1c4b-4281-b951-d872f2087c98

When sync receives DISABLED_BY_ADMIN from server PSS stops SyncBackendHost and 
disables sync by settings DisabledByAdmin pref. This prevents sync from 
connecting to server in the future. The way to reenable sync is to sign out and 
sign in again.
In future milestone we will implement retry logic that will periodically 
(once a day) try to connect to sync server to see if sync is still disabled.

BUG=178417

Review URL: https://chromiumcodereview.appspot.com/14655009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202956 0039d316-1c4b-4281-b951-d872f2087c98

Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.

Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.

Add a new --enable-stats-collection-bindings to activate said object.

Example usage in telemtry:
with browser.Create() as b:
  b.tabs[0].Navigate("http://www.google.com")
  b.tabs[0].WaitForDocumentReadyStateToBeComplete()
  print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202620

Review URL: https://chromiumcodereview.appspot.com/12389073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131333,159026,222296
TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/16193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202954 0039d316-1c4b-4281-b951-d872f2087c98

This is pretty much the same as existing Pepper Socket API.  Since the
original code for socket is in chrome_content_browser_client.h for
crossing chrome-content boundary, it's moved to the new file
pepper_util.cc, so that PepperCrxFileSystemMessageFilter can access
directory inside chrome space.

BUG=240865

Review URL: https://chromiumcodereview.appspot.com/15521002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202951 0039d316-1c4b-4281-b951-d872f2087c98

Adding additional containers in the media test directory (all generated from bear.ogv using avconv).

BUG=235108
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/16034004

Patch from John Rummell <jrummell@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202950 0039d316-1c4b-4281-b951-d872f2087c98

Previously we chrome trace and atrace is exclusive. Sometimes this is
inconvenient.

BUG=244501

Review URL: https://chromiumcodereview.appspot.com/15892014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202949 0039d316-1c4b-4281-b951-d872f2087c98

These two dialogs host web contents modal dialogs on their WebContents,
so they need to implement the WebContentsModalDialogManagerDelegate
and WebContentsModalDialogHost interfaces to provide dialog host view
and positioning.

BUG=244173

Review URL: https://chromiumcodereview.appspot.com/15879007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202948 0039d316-1c4b-4281-b951-d872f2087c98

R=vandebo@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/15742010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202946 0039d316-1c4b-4281-b951-d872f2087c98

Based on chrome/browser/profiles/OWNERS.

BUG=227219
R=erg@chromium.org, mirandac@chromium.org, rlp@chromium.org

Review URL: https://codereview.chromium.org/16114006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202945 0039d316-1c4b-4281-b951-d872f2087c98

Switch to NSStrings; NSNumbers may be tagged pointers.

BUG=244703
TEST=Mac 64 tester goes green

Review URL: https://chromiumcodereview.appspot.com/15690016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/16161003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202943 0039d316-1c4b-4281-b951-d872f2087c98

If the main thread is unblocked and we access this function on the impl thread,
we're in a racy situation. This should be an error.

BUG=235188

Review URL: https://chromiumcodereview.appspot.com/14179022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202942 0039d316-1c4b-4281-b951-d872f2087c98

Pulls the call to open a new user's first window out of the ProfileManager and
into the UI layer that called for the creation of the new user. This improves
code layering (ProfileManager shouldn't have to know about the host desktop type)
and allows us to communicate errors during user creation (also
partially added here, although most errors aren't yet captured).

BUG=153864, 243379
TEST=existing unit tests

Review URL: https://chromiumcodereview.appspot.com/15734006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202939 0039d316-1c4b-4281-b951-d872f2087c98

When a user of the spelling service right-clicks on a misspelled word and 
selects 'Add to dictionary', the SpellingMenuObserver notifies spelling service
feedback sender. This feedback will be used to improve spellcheck suggestions 
from spelling service.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15736012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238418

Review URL: https://chromiumcodereview.appspot.com/14646034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202937 0039d316-1c4b-4281-b951-d872f2087c98

+remove separators in creation dialogs.

TBR=derat@chromium.org, nkostylev@chromium.org, oshima@chromium.org

NOTRY=true
Because of changes in binaries.
BUG=229762

Review URL: https://codereview.chromium.org/16103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202934 0039d316-1c4b-4281-b951-d872f2087c98

Like the previous Blink roll of 151349:151373, this breaks WebViewInteractiveTest.PopupPositioningMoved on the Mac.


TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15797008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202933 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/16082003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202931 0039d316-1c4b-4281-b951-d872f2087c98

TBR=lambroslambrou@chromium.org
BUG=244562

Review URL: https://codereview.chromium.org/15827007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202930 0039d316-1c4b-4281-b951-d872f2087c98

MacOS and Linux are currently not supported. This will come in a later CL.

BUG=242540

Review URL: https://chromiumcodereview.appspot.com/15738013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202929 0039d316-1c4b-4281-b951-d872f2087c98

This change causes us to not process any headers unless they are correctly
terminated with a \r\n\r\n sequence.

BUG=244260

Review URL: https://chromiumcodereview.appspot.com/15688012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202927 0039d316-1c4b-4281-b951-d872f2087c98

Before, if a custom auth extension is given through the --auth-ext-path flag,
the manifest is loaded from the browser resource rather than the overriden
path. We want to load the manifest from the given path instead. 
Also change ComponentLoader::AddOrReplace to return an empty string on failure
for consistency with other ComponentLoader functions.

BUG=239212
TEST=on cros device with custom telemetry auth extension

Review URL: https://chromiumcodereview.appspot.com/15937003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202926 0039d316-1c4b-4281-b951-d872f2087c98

A dangerous download can be accepted by the user or rejected. If
rejected, the downloaded file used to be deleted. This change adds
DownloadItem::AcquireFileAndDeleteDownload() which allows the caller to
acquire the dangerous file.

The intended consumer of this feature is SafeBrowsing where the caller
may want to acquire a dangerous file that's being discarded for the
purpose of further analysis.

Also change the logic during shutdown to no longer delete dangerous
downloads, but to cancel them.

TBR=rdsmith
BUG=244604

Review URL: https://chromiumcodereview.appspot.com/14947007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16026006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202920 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151394&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/15881007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202919 0039d316-1c4b-4281-b951-d872f2087c98

* Parent classes in alphabetical order.
* Overrides as private as possible, and in same order as parent classes.  We
  also keep the .cc file order matching the .h file.
* Remove AlwaysDrawText() entirely as it was never called.  This also means we
  can remove |force_draw_text_|.
* Inline SetImage(), SetTooltipText(), StartLabelAnimation(), PauseAnimation(),
  and UnpauseAnimation() into their lone callers.  Inline AnimationOnClick()
  into OnClick() since the two were always called together.
* Remove the scoped_ptr<> on |slide_animator_| and initialize it in the
  constructor, instead of the first time we want to animate.
* Eliminate |font_color_| since it was never used.  (We will eventually use the
  color the parent supplies us, so the constructor arg sticks around.)
* Separate out three other members that will be going away in the future.  Put
  the other ones into some sort of hopefully-logical order.
* DISALLOW_IMPLICIT_CONSTRUCTORS -> DISALLOW_COPY_AND_ASSIGN.

The changes in the .cc file are basically just deleting and reordering code,
plus "->" to "." conversions for |slide_animator_|.  I avoided doing any other
cleanup/rewriting, to keep this change "basically mechanical".

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/15732018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202917 0039d316-1c4b-4281-b951-d872f2087c98

* Eliminte the distinction between "item to item padding" and "item to edge
  padding" because the two values are always equal.
* Don't bother supporting "height 0 = use preferred height" in
  location_bar_layout.*, since only one caller uses it at this point and it's
  easier to understand the code by just making it explicit.
* Switch to using a views::Painter for the popup mode background as well,
  instead of explicitly drawing the images.  This will make it easy to switch
  both modes to ninebox painting in the future.
* Try to reorder code in order to declare variables as close to their use as
  possible, and in the order that they're accessed.
* Visible change: Instead of assuming the edit always has 1 px. of "internal
  space", calculate the correct conditions for which that's true.  This results
  in the OmniboxViewViews text moving right by 1 px. in the LTR case.

BUG=231005,239902
TEST=With "views textfield" on, address bar text moves 1 px. right
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16025004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202916 0039d316-1c4b-4281-b951-d872f2087c98

This should solve the flakiness we've been seeing.

BUG=236102

Review URL: https://chromiumcodereview.appspot.com/15688006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:271
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/16155004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202914 0039d316-1c4b-4281-b951-d872f2087c98

CryptoModulePasswordDialogView uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c107 
Trigger with debug code in Patch Set 1. 

BUG=166075
TEST=Crtypo module password dialog does not have an extra border. 
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/15859013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202912 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r191582.

R=danno@chromium.org
BUG=225325

Review URL: https://chromiumcodereview.appspot.com/15951011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202911 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r201447. SetOpacity() was hooked up backwards; I got confused
while reading the GTK+ code. However, if the "255 -" is simply removed, menus
stop showing. It looks like the menu system is still calling SetOpacity(0).

BUG=none
TBR=sidharthms@google.com,sky@chromium.org

Review URL: https://codereview.chromium.org/16189008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202910 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202908 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yfriedman@chromium.org
BUG=239595

Review URL: https://codereview.chromium.org/16176003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202907 0039d316-1c4b-4281-b951-d872f2087c98