GitLab

When merging, if we're given specifics that correspond to the local
guid, we try to access specifics object for the local guid in
|all_data_|. The problem with this, is that there isn't always an entry
there if reconcile has not happened yet. This only happens when the
initial sync round trip finishes before metadata loads from disk, but
this race is happening to users, see the bug.

The fix could be to check that |all_data_| actually contains an entry
for the local guid, but it really doesn't matter. Local data completely
cleared when sync is disabled, so reconcile will always create a local
entry with a fresh time stamp around the time merge is called. There's
no reason to complicate the logic inside of merge for no real benefit,
so I've simply removed the set_last_updated_timestamp call.

BUG=668938

Review-Url: https://codereview.chromium.org/2536043002
Cr-Commit-Position: refs/heads/master@{#435011}

BUG=668541
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536873002
Cr-Commit-Position: refs/heads/master@{#435010}

This patch avoids updating layout tree in
AXNodeObject::determineAccessibilityRole().

Element::isFocusable() requires styles to be updated. However, when
layout code calls determineAccessibilityRole(), updating layout tree
should be avoided since it may destroy the calling object.

This patch replaces it to supportsFocus(), since the main purpose is
to give elements with tabIndex explicitly set get some role.

This is a speculative fix.

BUG=590369, 647602, 665168

Review-Url: https://codereview.chromium.org/2532023002
Cr-Commit-Position: refs/heads/master@{#435009}

The DCHECK is invalid because we can have a render surface between the
target of scroll parent and scroll child.

BUG=663499
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537053002
Cr-Commit-Position: refs/heads/master@{#435008}

The omnibox visibility timer should not be active during a page load; it
should be started only after loading finishes.

BUG=641508
TEST=Viewed a page that takes 10s to load; omnibox stays visible.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2534963002
Cr-Commit-Position: refs/heads/master@{#435007}

kPolicyVerificationKeyHash is the only possible value anyways (outside
of tests).

BUG=none

Review-Url: https://codereview.chromium.org/2537643003
Cr-Commit-Position: refs/heads/master@{#435006}

Introduces the ThreadSafeAssociatedInterfacePtrProvider class that
provides functionalities similar to the content::ThreadSafeSender.
You create it with a ChannelProxy and you can then retrieve
ThreadSafeInterfacePtr's from it that you can call methods on from any
thread and even before the actual channel is connected.

BUG=668317

Review-Url: https://codereview.chromium.org/2522333002
Cr-Commit-Position: refs/heads/master@{#435005}

Moves ivars to implementation files and moves the objc_property_releaser
include into implementation file, so that code built with  ARC can
depend on it.

BUG=None

Review-Url: https://codereview.chromium.org/2536073003
Cr-Commit-Position: refs/heads/master@{#435004}

No one is using it.

R=jochen@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2537753002
Cr-Commit-Position: refs/heads/master@{#435003}

This change updates ink drop ripples (especially, flood fill ripple) to
handle host view's size change to update their layer size. The main
change is that the flood fill ripple gets insets instead of bounds to
make it relative to the host's bounds. If a ripple is in progress, it
will snap to its final size immediately.

Ink drop highlight is still using a workaround to handle resize and will
be fixed in a follow-up CL.

BUG=666175
TEST=manual

Review-Url: https://codereview.chromium.org/2533053002
Cr-Commit-Position: refs/heads/master@{#435002}

Merge internal change: 139108411

R=rch@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2518063007
Cr-Commit-Position: refs/heads/master@{#435001}

Add a new test target gl_unittests_ozonex that runs with
--ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with
both Ozone headless and Ozone X11.

The test requires an X server to be running on the bot. The mb.py script
is modified to look for GN arg use_ozone=true and runtime flag
--ozone-platform=x11. In this case, it runs the test using xvfb.

Original commit crrev.com/2493063003 was reverted due to
crbug.com/665895. There was no dependency on xdisplaycheck by the new
test target that needs it. This caused problems during the isolate step
when xdisplaycheck wasn't found.

BUG=664570

Review-Url: https://codereview.chromium.org/2509033006
Cr-Commit-Position: refs/heads/master@{#435000}

https://skia.googlesource.com/skia.git/+log/c51c18fd7837..e4cd00699167

$ git log c51c18fd7..e4cd00699 --date=short --no-merges --format='%ad %ae %s'
2016-11-29 dskiba Make GrMemoryPool play nice with bucketing allocators.

BUG=651872

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2536203002
Cr-Commit-Position: refs/heads/master@{#434999}

It appears that the the log error was dropped when the default mode enum
was added in change https://codereview.chromium.org/2475443004. Add a test
to ensure that it doesn't get dropped again.

BUG=667799

Review-Url: https://codereview.chromium.org/2536563003
Cr-Commit-Position: refs/heads/master@{#434998}

This removes the prefetch_results and reuse_instant_search_base_page parameters.

BUG=627483

Review-Url: https://codereview.chromium.org/2526753002
Cr-Commit-Position: refs/heads/master@{#434997}

The name of variable was causing no end of confusion about when it should be
passed into the various install* methods for origin trials, and when a dummy
object should be passed instead. Renamed to the more sensible 'instanceObject',
as a counterpart to 'interfaceObject' and 'prototypeObject', and now only
instantiate it when necessary (in Window and WorkerGlobalScope blocks).

Review-Url: https://codereview.chromium.org/2532213002
Cr-Commit-Position: refs/heads/master@{#434996}

Currently, the only time limitation on push message processing is the
service worker default timeout of 5 minutes. 99% of push messages are
processed in under 1 minute, so we want to reduce the timeout so that
outliers don't begin to rely on the long processing available.

BUG=646783

Review-Url: https://codereview.chromium.org/2506393003
Cr-Commit-Position: refs/heads/master@{#434995}

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2532133003
Cr-Commit-Position: refs/heads/master@{#434994}

BUG=669420

R=anthonyvd@chromium.org, bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2538753002
Cr-Commit-Position: refs/heads/master@{#434993}

This CL lands server change 139914335 by diannahu.

BUG=488484

Review-Url: https://codereview.chromium.org/2535013002
Cr-Commit-Position: refs/heads/master@{#434992}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/928e6b56..d656dfb5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540723002
Cr-Commit-Position: refs/heads/master@{#434991}

This CL ensures that the ArcSessionManager is alive during the whole
each ArcService's life time, by merging two class initialization
list in ArcSessionManager and ArcServiceLauncher.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.

Review-Url: https://codereview.chromium.org/2531543003
Cr-Commit-Position: refs/heads/master@{#434990}

Introduces a new "ios_launchscreen_assets_target" GN variable to select which
target provides assets for the launchscreen.

BUG=665966,666732

Review-Url: https://codereview.chromium.org/2537443002
Cr-Commit-Position: refs/heads/master@{#434989}

Path::apply doesn't pass a point along for the PathElementCloseSubpath
command. This would yield the wrong orientation on the last marker-mid
on the path (see crbug.com/633012#c1 for an example.)
Use m_subpathStart where needed instead.

BUG=633012

Review-Url: https://codereview.chromium.org/2539763002
Cr-Commit-Position: refs/heads/master@{#434988}

Make the updateFromPathElement "closure" a simple thunk-style function,
to make it a little less unwieldy. Also pass PathElement& rather than
PathElement*.

BUG=633012,450368

Review-Url: https://codereview.chromium.org/2540513005
Cr-Commit-Position: refs/heads/master@{#434987}

This patch updates W3CImportExpectations in order to import
the css-ui-3/ test suite.

40 new tests are imported on the following folder:
imported/csswg-test/css-ui-3/

27 pass and 13 are marked as failure on TestExpectations file.

BUG=669473

Review-Url: https://codereview.chromium.org/2539753002
Cr-Commit-Position: refs/heads/master@{#434986}

iOS doesn't yet have any delegate method that fires when we have
finished loading all the tiles on the NTP. Without that, it's not
possible to reliably output metrics for tile types. Adding this (after
NUM_RECORDED_TILE_TYPES) will let us proceed with the conversion to
metrics::RecordPageImpression() in the meantime.

BUG=669090

Review-Url: https://codereview.chromium.org/2539473002
Cr-Commit-Position: refs/heads/master@{#434985}

https://skia.googlesource.com/skia.git/+log/cb4feeb7dbbe..c51c18fd7837

$ git log cb4feeb7d..c51c18fd7 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 mtklein use fma() in accumulate
2016-11-28 reed don't support converting from alpha to non-alpha
2016-11-28 mtklein SkNx_abi is unused.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2535013003
Cr-Commit-Position: refs/heads/master@{#434984}

Revert of Stub out Skia AVX and HSW opts. (patchset #1 id:1 of https://codereview.chromium.org/2512093003/ )

Reason for revert:
Now that we're guarding against ucrt\math.h in Skia and that's rolled into Chromium, it's as good a time as ever to try turning back on Skia's AVX+ code at head.  (I intend to just leave it stubbed out like this in M56.)

Original issue's description:
> Stub out Skia AVX and HSW opts.
>
> This is hopefully temporary while we mull better options.
>
> BUG=666707
>
> Committed: https://crrev.com/2ea76e2274404af7e53cc4bb5d212b22856ee455
> Cr-Commit-Position: refs/heads/master@{#433407}

TBR=brucedawson@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666707

Review-Url: https://codereview.chromium.org/2539453003
Cr-Commit-Position: refs/heads/master@{#434983}

including:
 - capturing partial stdout for failed shards
 - removing vestigial fifo support
 - removing on-device results parsing

BUG=646223

Review-Url: https://codereview.chromium.org/2514943002
Cr-Commit-Position: refs/heads/master@{#434982}

[ RUN      ] AutofillManagerTest.CreditCardSavedWhenAutocompleteOff
../../components/autofill/core/browser/autofill_manager_unittest.cc:3695: Failure
Actual function call count doesn't match EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _))...
         Expected: to be called once
	            Actual: never called - unsatisfied and active

BUG=666704
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2540673002
Cr-Commit-Position: refs/heads/master@{#434981}

Removed 8dp padding from the right side of the date label in the system
menu that was left over from non-md.

BUG=669221

Review-Url: https://codereview.chromium.org/2537033002
Cr-Commit-Position: refs/heads/master@{#434980}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2ef8719e..928e6b56

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2537793002
Cr-Commit-Position: refs/heads/master@{#434979}

The LinkLoader code assumes all link preloads will have lowercased
'as' values. This is not the case for preloads coming in via the preload
scanner.

This patch fixes that issue and adds a unit test that reproduces this
failure.

BUG=664744

Review-Url: https://codereview.chromium.org/2496343002
Cr-Commit-Position: refs/heads/master@{#434978}

SharedBuffer::getAsBytes returns false on failure, but XHR, the only caller,
calls it in a situation where it never fails.

BUG=None
R=tyoshino@chromium.org, hiroshige@chromium.org

Review-Url: https://codereview.chromium.org/2530323002
Cr-Commit-Position: refs/heads/master@{#434977}

The above mentioned function used a VisiblePosition to track
|startOfParagraphToMove|, which is wrong as VPs can't persist through
DOM mutations. This patch uses RelocatablePosition instead.

BUG=668765
TEST=webkit_unit_tests --gtest_filter=DeleteSelectionCommandTest.deleteListFromTable

Review-Url: https://codereview.chromium.org/2534783002
Cr-Commit-Position: refs/heads/master@{#434976}

PasswordReuseDetector is class for detecting password reuse. It consumes passwords from PassworStore, builds password index and then it can be used for detecting of password reuse by calling method CheckReuse().

This class is not created anywhere in production code yet. It will be done in next CLs.

BUG=657041

Review-Url: https://codereview.chromium.org/2525593002
Cr-Commit-Position: refs/heads/master@{#434975}

https://skia.googlesource.com/skia.git/+log/99ab92b5958a..cb4feeb7dbbe

$ git log 99ab92b59..cb4feeb7d --date=short --no-merges --format='%ad %ae %s'
2016-11-28 borenet [nobuildbot] Win GCE bots

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2536563004
Cr-Commit-Position: refs/heads/master@{#434974}

BUG=658242

Review-Url: https://codereview.chromium.org/2527383002
Cr-Commit-Position: refs/heads/master@{#434973}

Reland of After detach, there's no document to notify parsing is finished. (patchset #1 id:1 of https://codereview.chromium.org/2538473004/ )

Reason for revert:
Reland, probably innocuous for crbug.com/669435

Original issue's description:
> Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )
>
> Reason for revert:
> Speculative revert for crbug.com/669435
>
> Original issue's description:
> > After detach, there's no document to notify parsing is finished.
> >
> > HTMLViewSourceParser was tripping the DCHECK in
> > DocumentParser::document when it recieved the last bytes of the
> > document it was parsing after it was detached.
> >
> > BUG=664915
> >
> > Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> > Cr-Commit-Position: refs/heads/master@{#434937}
>
> TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664915
>
> Committed: https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129
> Cr-Commit-Position: refs/heads/master@{#434954}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2535233002
Cr-Commit-Position: refs/heads/master@{#434972}