- 04 Mar, 2015 40 commits
-
-
dconnelly authored
Depends on https://codereview.chromium.org/901493003/ BUG=448011 Review URL: https://codereview.chromium.org/878743007 Cr-Commit-Position: refs/heads/master@{#319084}
-
boliu authored
Test is racy by design, and testing this properly is not worth the effort required to add the proper hooks into initialization. BUG= Review URL: https://codereview.chromium.org/971103003 Cr-Commit-Position: refs/heads/master@{#319083}
-
gunsch authored
Double-revert seems to have deleted the fixes: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/9ufqvcvv_DU R=lcwu@chromium.org,servolk@chromium.org BUG=None Review URL: https://codereview.chromium.org/979913002 Cr-Commit-Position: refs/heads/master@{#319082}
-
chrome://extensionsrdevlin.cronin authored
Make the chrome://extensions page use chrome.developerPrivate API to select a file path and load an unpacked extension. Also add tests for the api function, and convert it to a UIThreadExtensionFunction. BUG=461039 Review URL: https://codereview.chromium.org/979453002 Cr-Commit-Position: refs/heads/master@{#319081}
-
brettw authored
Reland of https://codereview.chromium.org/961323004 TBR=dpranke Review URL: https://codereview.chromium.org/969173002 Cr-Commit-Position: refs/heads/master@{#319080}
-
gunsch authored
R=lcwu@chromium.org,halliwell@chromium.org BUG=internal b/19559717 Review URL: https://codereview.chromium.org/977443002 Cr-Commit-Position: refs/heads/master@{#319079}
-
gunsch authored
R=lcwu@chromium.org,servolk@chromium.org,tsepez@chromium.org BUG= Review URL: https://codereview.chromium.org/971913002 Cr-Commit-Position: refs/heads/master@{#319078}
-
bzanotti authored
FakeSigninManager::SignOut was never updated to clear the account id on SignOut. This result in calls to FakeSigninManager::IsAuthenticated returning true after even after a SignOut. BUG= Review URL: https://codereview.chromium.org/980583003 Cr-Commit-Position: refs/heads/master@{#319077}
-
avi authored
BUG=463458 TEST=crashes go away Review URL: https://codereview.chromium.org/976903003 Cr-Commit-Position: refs/heads/master@{#319076}
-
jam authored
The test method to find the generated protobuf python files needed to be updated. Also I copied a bunch of test files to the product dir. DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.ApiAuthCodeFetch/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.AutoEnrollment/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.PolicyFetch/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Registration/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Unregistration/1 ComponentCloudPolicyTest.FetchExtensionPolicy ComponentCloudPolicyTest.InstallNewExtension ComponentCloudPolicyTest.SignOutAndBackIn ComponentCloudPolicyTest.UpdateExtensionPolicy CloudPolicyTest.FetchoPlicy CloudPolicyTest.InvalidatePolicy BUG=463180 Review URL: https://codereview.chromium.org/979643002 Cr-Commit-Position: refs/heads/master@{#319075}
-
Paweł Hajdan, Jr authored
BUG=460949 R=jochen@chromium.org Review URL: https://codereview.chromium.org/970903005 Cr-Commit-Position: refs/heads/master@{#319074}
-
machenbach authored
Summary of changes available at: https://chromium.googlesource.com/chromium/deps/icu/+log/db16fd8..eda9e75 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/977043004 Cr-Commit-Position: refs/heads/master@{#319073}
-
Paweł Hajdan, Jr authored
BUG=460949 R=jochen@chromium.org Review URL: https://codereview.chromium.org/977593007 Cr-Commit-Position: refs/heads/master@{#319072}
-
sdefresne authored
Delegate to the embedder the decision to filter URLs to add to the history through the HistoryClient defaulting to registering all URLs (in the base class implementation but also when there is no HistoryClient during tests). BUG=390953 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/971423002 Cr-Commit-Position: refs/heads/master@{#319071}
-
blundell authored
This CL is a companion to https://codereview.chromium.org/945423002, and will allow a server app to serve apps that were uploaded to the Mojo bucket in GS from Chromium without having to know anything about these apps in particular. Review URL: https://codereview.chromium.org/956593003 Cr-Commit-Position: refs/heads/master@{#319070}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/20c53c8..96cd5bb TBR=samli@chromium.org Review URL: https://codereview.chromium.org/969913003 Cr-Commit-Position: refs/heads/master@{#319069}
-
tobiasjs authored
onFailure is only invoked when the render frame has been destroyed, but it is not really useful to distinguish onComplete from onFailure in that case. This also addresses the feedback that we received from API Council. This is a resubmit of CL 943633003 BUG=459539, 457184 Review URL: https://codereview.chromium.org/974483002 Cr-Commit-Position: refs/heads/master@{#319068}
-
hanxi authored
- Introduce WebUIInjectionHost class and plumb InjectionHost interface to replace Extension in script injection system in the render. - Store InjectionHost in ScriptInjection to avoid constructing InjectionHost objects everywhere. BUG=459234 Review URL: https://codereview.chromium.org/934763003 Cr-Commit-Position: refs/heads/master@{#319067}
-
vabr authored
This CL adds default values to config parameters for running the Python tests of password manager. It also corrects a typo (parrallel -> parallel). R=engedy@chromium.org BUG=463504 Review URL: https://codereview.chromium.org/977043003 Cr-Commit-Position: refs/heads/master@{#319066}
-
Paweł Hajdan, Jr authored
BUG=460949 R=primiano@chromium.org Review URL: https://codereview.chromium.org/964873005 Cr-Commit-Position: refs/heads/master@{#319065}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#319064}
-
pfeldman authored
BUG=463892 TBR=dgozman Review URL: https://codereview.chromium.org/979793002 Cr-Commit-Position: refs/heads/master@{#319063}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01e2ba6e..9ff21de5 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/982523002 Cr-Commit-Position: refs/heads/master@{#319062}
-
mnaganov authored
When a script modifies page source of a non-committed page, we need to notify clients, so they can update the URL bar to avoid confusion. New logic since the last attempt (https://codereview.chromium.org/924833003/): distinguish between a "vanilla" WebView state (basically, a newly created WebView, where no loading attempts have been made) and an "attempted to navigate" state. In the "vanilla" state, don't fire synthesized page loading events to avoid confusing clients. This is safe, as WebView is guaranteed to be on a blank page. Implementation note: we detect navigation attempts using didStartProvisionalLoadForFrame WebContentsObserver event on the Java side. As for popups AwWebContentsObserver gets re-attached from the original popup WebView to the one provided by the client, notifications issued inbetween can be missed on the Java side. To work around this, we assume that WebViews opened as popups can never be in "vanilla" state (as they are anyway opened as a result of navigation). BUG=458569,462213 TBR=davidben@chromium.org,tedchoc@chromium.org Review URL: https://codereview.chromium.org/970883002 Cr-Commit-Position: refs/heads/master@{#319061}
-
rijubrata.bhaumik authored
TEST= http://jsfiddle.net/73v8rmex/3/ (manual) BUG=336424 Review URL: https://codereview.chromium.org/754963006 Cr-Commit-Position: refs/heads/master@{#319060}
-
kcwu authored
Note this CL depends on s5p-mfc kernel driver fix https://chromium.googlesource.com/chromiumos/third_party/kernel/+/090b79f, which is available since 6840.0.0 Otherwise exynos chromeos will crash. BUG=chromium:449920 TEST=apprtc loopback with resolution 640x354 on peach pit; run run video_VideoSanity Review URL: https://codereview.chromium.org/972063002 Cr-Commit-Position: refs/heads/master@{#319059}
-
dzhioev authored
In case when GN output dir is inside src/, GN uses pathes relative to src/ directory that start with // (//out/Release/gen). But python interprets such pathes as relative to /. BUG=459230 Review URL: https://codereview.chromium.org/973873003 Cr-Commit-Position: refs/heads/master@{#319058}
-
yawano authored
Summary of changes available at: https://chromium.googlesource.com/chromiumos/platform/system_api/+log/01a9492..c5bdf10 BUG=413541 TEST=none Review URL: https://codereview.chromium.org/977593006 Cr-Commit-Position: refs/heads/master@{#319057}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/327fcc4..20c53c8 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/974913005 Cr-Commit-Position: refs/heads/master@{#319056}
-
treib authored
Followup to https://codereview.chromium.org/850283003. BUG=397951 Review URL: https://codereview.chromium.org/968183002 Cr-Commit-Position: refs/heads/master@{#319055}
-
shiva.jm authored
BUG= Review URL: https://codereview.chromium.org/974243002 Cr-Commit-Position: refs/heads/master@{#319054}
-
finnur authored
BUG=463854 NOTRY=true TBR=rkc Review URL: https://codereview.chromium.org/971613003 Cr-Commit-Position: refs/heads/master@{#319053}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b317635..327fcc4 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/976033002 Cr-Commit-Position: refs/heads/master@{#319052}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea02c333..01e2ba6e Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/966723005 Cr-Commit-Position: refs/heads/master@{#319051}
-
aberent authored
TBR=jamesr@chromium.org BUG=463852 Review URL: https://codereview.chromium.org/982513002 Cr-Commit-Position: refs/heads/master@{#319050}
-
carlosk authored
This CL adapts several test classes with changes due now that the IPCS for beforeUnload ack and renderer navigation requests are not one and the same anymore. BUG=440266 Review URL: https://codereview.chromium.org/953503002 Cr-Commit-Position: refs/heads/master@{#319049}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/467060f..b317635 TBR=samli@chromium.org Review URL: https://codereview.chromium.org/982503002 Cr-Commit-Position: refs/heads/master@{#319048}
-
hirono authored
Previously the thumbnail metadata is obtained as a part of old metadata. The CL adds thumbnailMetadataItem to GalleryItem, and remove old metadata models from Gallery. BUG=410766 TEST=None Review URL: https://codereview.chromium.org/976713004 Cr-Commit-Position: refs/heads/master@{#319047}
-
finnur authored
Revert of Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #1 id:1 of https://codereview.chromium.org/981473003/) Reason for revert: Hmmm... My revert did not fix the test, so I'm undoing it. :/ Original issue's description: > Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/) > > Reason for revert: > Audio tests started failing consistently in the next build after this was checked in. See: > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762 > > Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem. > > Error: > [ RUN ] AudioRecorderTest.BasicRecordAndStop > ../../components/audio_modem/audio_recorder_unittest.cc:203: Failure > Value of: IsRecording() > Actual: false > Expected: true > ../../components/audio_modem/audio_recorder_unittest.cc:208: Failure > Value of: IsRecording() > Actual: false > Expected: true > ../../components/audio_modem/audio_recorder_unittest.cc:213: Failure > Value of: IsRecording() > Actual: false > Expected: true > [ FAILED ] AudioRecorderTest.BasicRecordAndStop (1292 ms) > > Original issue's description: > > Chromecast: Play audio streams not supported by CMA via default renderer > > > > For Chromecast we want to choose which media renderer to use based on > > the types of input content streams. We will use CMA media renderer for > > media types that are supported by our hardware (H264, AAC, etc) and > > will use the default media renderer for audio streams other than AAC > > or Vorbis. This will allow us support software decoding of FLAC and > > Opus via the default Chrome audio path. > > > > BUG=457959 > > > > Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276 > > Cr-Commit-Position: refs/heads/master@{#318941} > > TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=457959 > > Committed: https://crrev.com/ee687fd9c6c2bc41642cd8b65de87fe548a3cf75 > Cr-Commit-Position: refs/heads/master@{#319033} TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457959 Review URL: https://codereview.chromium.org/967933003 Cr-Commit-Position: refs/heads/master@{#319046}
-
benwells authored
These are flaky on various platforms for app windows; outerBounds is preferred. BUG=453707 Review URL: https://codereview.chromium.org/976563002 Cr-Commit-Position: refs/heads/master@{#319045}
-