- 15 Apr, 2020 40 commits
-
-
Xinghui Lu authored
The original intention is to use this field for authentication. But we decided to set the header instead, so this field is now used for debugging purpose only. In this CL, deprecate this field in the RTLookupRequest protocol, but keep displaying the field in chrome://safe-browsing page. Bug: 1061266 Change-Id: I485c8ee60a9d96ede936ab662219966e25abdb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146798 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759469}
-
Karandeep Bhatia authored
This CL attempts to remove some possible sources of flakiness in the declarative net request browsertests by removing all calls to content::RunAllTasksUntilIdle() and replacing them with more deterministic waiting logic. Also re-enable the tests disabled in r758084. Also, enforce that RulesetManager only has a single test observer at a time. BUG=1069665 Change-Id: I29c646d85322195894d2786fbf01fb7c10842cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146335 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759468}
-
Shelley Vohr authored
Fixes an issue whereby some edit commands were not being sent to the focused WebContents. This fixes the issue by adding the malfunctioning commands to RenderFrameHostDelegate and then calling them that way. Bug: 1067284 Change-Id: I6a325ff57bb93b64f483385d8b13945486152346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135187 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#759467}
-
Liquan (Max) Gu authored
Before: In order for a TWA to be found as a payment app for an app-store billing method, the TWA: * cannot be a sideloaded one. * must be installed from the same app store of the billing method. After: The TWA does not have to satisfy the above-mentioned requirements. Change: * remove the checking of the TWA installer. * move "isInTWA" into #findAppStoreBillingApp() * these requirements have to be satisfied for a TWA to be found as a payment app: - the merchant is not requesting shipping or contact delegation. - the merchant requests the supported App store billing methods - the TWA is a payment app - the TWA can handle the requested billing methods Bug: 1069489 Change-Id: I6fa1dee5efb35ac8d89eca6f042d974591a63fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147016 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759466}
-
Tibor Goldschwendt authored
On customized NTPs we don't show a doodle since the doodle may not jibe well with the custom background. Before this CL, if a doodle was available we showed a bouncing ball animation - the flower. And, upon clicking the flower, we temporarily set the NTP to the default theme showing the doodle. However, it turned out that the flower causes a significant amount of CPU usage and it is unclear whether users understand the flower lets them peek the doodle. Therefore, this CL removes the flower. Fixed: 1046786 Change-Id: If236a3fc4be4f7ef2cf9deebad1d579103902c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151318 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759465}
-
tby authored
This adds the skeleton of a new search provider and result type for settings search results in the launcher. This has no logic yet, and returns no results. The next CL will integrate the provider with the settings service to provide results. Bug: 1068851 Change-Id: Ic11c7142d25116b990affea87c15539b0b842fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142890Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#759464}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from TimezoneInfo request. Bug: chromium:1041153 Change-Id: Icadc8d1461e8b0b34b14a5cc3d7c48682889280f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148656Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759463}
-
Karandeep Bhatia authored
This key decides whether the ruleset is enabled by default. On extension load, if the set of enabled rulesets, exceeds the rules count limit, not all rulesets will be enabled and a warning is raised. We don't raise a hard error in this case to maintain forward compatibility. Rulesets specified earlier in the manifest will be given priority for being evaluated if not all rulesets can be enabled due to the rules limit. This is a breaking change to the API schema, however it's ok since the API is only on Beta and doesn't have significant usage. In the future, extension functions will be introduced to allow the extensions to dynamically toggle the set of enabled rulesets. BUG=754526 Change-Id: Iff075b142cabb67a75fe58298f9bf7da71a37045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141204 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759462}
-
Sharon Yang authored
CastMediaBlocker and CastMediaPlaybackOptions have logic that is applicable to other parts of Chromium. To use these classes, they have been moved to components/media_control and made generic. Bug: 1057860 Change-Id: I3210af669a3c39711eda41999b7303f6df518d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127416 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759461}
-
Shelley Vohr authored
This CL converts a deprecated Callback into a OnceCallback, since the callback is passed to other threads which always bind as OnceCallback. Electron patches into this functionality and this will make it easier for us to do so. Change-Id: I490a750661f41462ab8eab59e8f3a7a74e1256e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138564 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759460}
-
Czirkos Zoltan authored
Previously, when using --headless --print-to-pdf, three params were given to the PrintToPDF request: .SetDisplayHeaderFooter(true) .SetPrintBackground(true) .SetPreferCSSPageSize(true) Background and page size can be controlled by CSS, however displaying header and footer cannot. This patch adds a new command line flag --print-to-pdf-no-header, which lets the user hide the header and footer when using --print-to-pdf in --headless mode: .SetDisplayHeaderFooter( ...from command line... ) .SetPrintBackground(true) .SetPreferCSSPageSize(true) So now --print-to-pdf=output.pdf uses header and footer, --print-to-pdf=output.pdf --print-to-pdf-no-headers hides them. Bug: 1069477 Change-Id: Idf000ec44446079bfc30a453eccd2fbc7e923e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144140Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759459}
-
Alexander Cooper authored
When previously splitting xr_device_service into a test/internal interface, one usage within mock_xr_device_hook_base was missed. This change adds a test-specific method for that class as well. This change also exposes an "internal" function that the test functions may call. This is necessary because when xr_test_utils is moved to content/public/test, xr_device_service will not be able to depend on it; however, the reverse dependency (xr_test_utils depending on xr_device_service) is allowed. Bug: 1031622 Change-Id: Iec2efde6b620fc9ce336f3e0d6472410c9156621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151467 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd0ce7c933dc..66792cf7d6a9 Created with: gclient setdep -r src-internal@66792cf7d6a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071177 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I76381a8e7392ed6aede6191920e6d83c410f7b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759457}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It fixed issues in os_languages_page/ folder that break semi-automatic Polymer3 migration. These changes include adding missing #cr_define_end comments to JS file which were missing them, as well as making sure that files which use cr.define() include the entire file's content within the cr.define() call, since this is required by Polymer3 conversion tools. Bug: 1045266 Change-Id: I1d6f05c1e2f0f29dc816a81187b091361883061f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147918 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759456}
-
Scott Violet authored
The current ordering makes it seem as though removed_request_headers_ can be modified during the start phase, when it can only be modified during the redirect phase. This patch reorder things to make it clear removed_request_headers_ is only applicable to redirect headers. BUG=none TEST=none Change-Id: If840fc0c06c8b9a56dd8f96a8f8899c3ffb81a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151314Reviewed-by:
-
Scott Violet authored
bottomContentOffsetY is rather confusing, and the comment was some what misleading. It appears unused, so removing. BUG=none TEST=none Change-Id: I0bfa74c77ac040be6d60da3a00dfad1bbef96ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148272Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759454}
-
Nathan Zabriskie authored
RasterImplementation currently has no API for uploading textures directly from CPU memory. The need for an intermediate texture incurs unnecessary copies which decrease performance, especially in repeated use cases. This CL adds one option for uploading a texture stored in CPU memory directly to a shared image mailbox. Bug: 1063725 Change-Id: Iaf0ce530650913cd38f17ade3160b5129e96f0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141068Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759453}
-
Ilya Sherman authored
There was some confusion in cl/305406043 around what should be used in JavaScript. R=chromium-metrics-reviews@google.com Bug: None Change-Id: Id31be2c24bd552ff29c734350feb22ddea41ae24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148163 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#759452}
-
Ali Juma authored
This makes SafeBrowsingService expose a method for creating SafeBrowsingUrlCheckerImpls rather than exposing direct access to the Safe Browsing database, and makes SafeBrowsingTabHelper use SafeBrowsingUrlCheckerImpl rather than raw database access. Using SafeBrowsingUrlCheckerImpl aligns iOS with other platforms, allowing us to share logic for querying the database, handling redirects, and keeping track of the state of outstanding database queries. This will also make it easier to reuse existing logic for real-time lookups. Removing direct access to the database from SafeBrowsingService will also simplify creating a FakeSafeBrowsingService for tests, which will be done in a follow-up. Change-Id: Ib02fc25b0201a4866649268d03112bf685be21df Bug: 1049340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128569 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759451}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ac25c44cbe8..9e1e913c81cd git log 8ac25c44cbe8..9e1e913c81cd --date=short --first-parent --format='%ad %ae %s' 2020-04-15 michaelludwig@google.com Add rect subtraction utility function+tests 2020-04-15 jvanverth@google.com Allow to Metal to build with Xcode 10 again. 2020-04-15 mtklein@google.com start on operand refactoring 2020-04-15 tdenniston@google.com [svg] Fix translate() with no ty specified. 2020-04-15 jlavrova@google.com MinIntrinsicWidth should ignore placeholders Created with: gclient setdep -r src/third_party/skia@9e1e913c81cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I9a407fb504b04d3b5327edffc50e85a180fcb2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759450}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f64a3e1686e..4c0a21a0882d git log 9f64a3e1686e..4c0a21a0882d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 changhaohan@chromium.org Rename boolean "closingTag" and "elementCloseTag" to "isClosingTag" Created with: gclient setdep -r src/third_party/devtools-frontend/src@4c0a21a0882d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I664ffa56778688261c402cfe67146bade6ef5323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151625Reviewed-by:
-
Ilya Sherman authored
Exception: If you want a specific reviewer's expertise, it's fine to send the CL directly to that reviewer. This helps us to load-balance incoming code reviews. R=gab@chromium.org Bug: none Change-Id: I70d77c8575bf59953f5cc53f0fd6d951e35597ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150972 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759448}
-
Nigel Tao authored
The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: Id5c48bb59665d129ec829d9dd447ceac61aa6f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147531Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759447}
-
Darren Shen authored
Normally, when showing the keyboard, we have to reduce the viewport size of every window, so that the window contents are not obscured by the keyboard. This is called "overscrolling". When showing the "sticky" a11y keyboard however, the keyboard is considered "locked": all windows will resize accordingly. This naturally reduces the viewport size, so there's no need to do overscrolling again. During the mash project, we accidentally missed this case, so windows are resized AND overscrolled, which causes the contents to shrink twice in some scenarios. Bug: 1030481 Change-Id: Ic62c483e4918cd692d47887d511772183208293e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148897Reviewed-by:
-
Sam Bowen authored
* Don't require an action status, as it's not required in the spec. * Add an override for duration type to allow time values so validator doesn't delete it. * Set live details before checking whether they are there. * Check the URL values for interaction type instead of string. All of the example media feed items are fetched with these changes. Change-Id: I891afc2d1f6650a164f28a402b30ce248be5aa4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149906 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759445}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It fixed issues in device_page/ folder that break semi-automatic Polymer3 migration. These changes include adding missing #cr_define_end comments to JS file which were missing them, as well as making sure that files which use cr.define() include the entire file's content within the cr.define() call, since this is required by Polymer3 conversion tools. Bug: 1045266 Change-Id: I8d465859939ab57150afbe4a08e18371190470a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145054 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b9ebe017027a..51591a540007 git log b9ebe017027a..51591a540007 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 fmayer@google.com Merge "Protect CPU watchdog against short reads." 2020-04-15 fmayer@google.com Merge "Add heapprofd CPU guardrail." 2020-04-15 fmayer@google.com Merge "Keep cache of abspc -> Frame in HeapTracker." Created with: gclient setdep -r src/third_party/perfetto@51591a540007 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iea5c9c89d0a1ab1a8407db3f327272471cec17f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151080Reviewed-by:
-
Archana Simha authored
Bug: 1064741 Change-Id: Ibb6f81e2a513eccdc4690fa88011b2903406541d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146078Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b774f178..7b94cdc5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30b171f40b4831c416059b6de998c189eefe121f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151526Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759441}
-
Clark DuVall authored
These will be needed to componentize LocalSharedObjectsContainer, which will be needed to eventually componentize TabSpecificContentSettings. We will need these to be shared with WebLayer. There is a minor change in FileSystemHelper to pass in the FileSystemType kFileSystemTypeSyncable which was only used when extensions is enabled. Bug: 1070825 Change-Id: I4560fda5f5362f7cee80e5538717fe6037a3a6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149911Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759440}
-
Devlin Cronin authored
Rename ActionInfo::GetAnyActionInfo() to GetExtensionActionInfo(). The former was just a placeholder while we made callers agnostic about the type of action retrieved. Bug: 893373 Tbr: tommycli@chromium.org (mechanical naming-only change in location_bar) Change-Id: Ibe685d34baa269dff37d1bd06134d1ce167c186b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143492 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759439}
-
Ben Goldberger authored
Bug: 1047029 Change-Id: Ifff35b91cf6f5ce4b3b62527b461165c28944522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135009Reviewed-by:
-
Nigel Tao authored
JSONReader is the public facing API. JSONParser is the private implementation. Follow-up work may experiment with using a different implementation. We'd still like to keep those tests. Also add some more test code to the Decode4ByteUtf8Char test. We now look for the 4 specific UTF-8 bytes, not just that parsing succeeded. Bug: 1069271 Change-Id: I3adcd27a6f7230122a191fc832e1a87442760ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150527 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759437}
-
Clark DuVall authored
This is used by ContentSettingsAgentImpl to query for storage permissions in the browser process. Bug: 1065537 Change-Id: Idd8176bf801c6636559304c6d23ce6c6b1237405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145257 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#759436}
-
Kevin Babbitt authored
The Microsoft Edge team has reports of a null dereference crash showing up in automated usage testing. The symptom is that, while responding to a UIA Navigate call, we check to see whether the navigated-from element is the child of a fragment root. We come across an entry in the fragment root map from the element's HWND to a null fragment root pointer, dereference that null pointer, and crash. It's not expected that we'll ever have such an entry - the map is supposed to map HWNDs to non-null fragment roots. From the crash data we have, the exact sequence of calls leading up to this scenario is unclear, but I was able to reproduce one way it can occur and captured it in a unit test. The fix for the issue is, when looking up an entry in the map, use unordered_map::find() rather than operator[], the latter of which will create an entry if one doesn't exist. Bug: 1071185 Change-Id: I5f04188e849ffc0969762d870b80603d4b7e15b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148850Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759435}
-
Alex Danilo authored
Text display with selection mode active should be blue and 14px size. Moves the non files-ng 'color' property to only apply when needed. Adds a files-ng selector for the check-select class to set the 'color' and 'font-size' properties. Bug: 1068079 Change-Id: Id0d332e6bca42c5176ce8424d4faa9ca066e0fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150314Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#759434}
-
Hailey Wang authored
Add a more throughout browsertest in addition to the basic browsertest. Bug: 1059341 Change-Id: I0c1b5facf5d77914777462f69083070c01a2ad03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149634 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#759433}
-
Adrienne Walker authored
The two important changes here are: (1) Call DeleteBlobsInObjectStore before RemoveRange If RemoveRange is called first, then DeleteBlobsInObjectStore cannot find all of the blobs to add to the external change map, and thus CollectBlobFilesToRemove will have nothing to remove. (2) Exclude the BlobEntryKey index from RemoveRange If this is removed in ClearObjectStore, then CollectBlobFilesToRemove will not be able to find the blobs (and their numbers) when decoding the external objects. These entries will be individually removed in CollectBlobFilesToRemove. Bug: 488851 Change-Id: I8dc9cd0208054d482006718ab42c439cf5f79382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148847 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#759432}
-
Oriol Brufau authored
When finding the intrinsic sizes of a grid container, track sizing functions that contain percentages would be indefinite, and thus should be treated as 'auto'. This is done in GridTrackSizingAlgorithm::CalculateGridTrackSize, but there was an early return if the grid container had size containment. Then, instead of being treated as 'auto', the track sizing function used to just resolve the percentage against 0. Additionally, a track sizing function of '1fr' is supposed to be treated as 'minmax(auto, 1fr)', since only max track sizing functions can be flexible. This fixup was also skipped, though this didn't affect the final result. This patch fixes these problems by removing the early return and adding some asserts. BUG=1069310 TEST=external/wpt/css/css-contain/contain-size-grid-003.html TEST=external/wpt/css/css-contain/contain-size-grid-004.html Change-Id: I1b8d8645a3fdf6c697c503184b35cc8cd12925a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144019 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759431}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a5bce96e8c2..8ec11b831293 git log 4a5bce96e8c2..8ec11b831293 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 danilchap@webrtc.org Do not register generic frame descriptor v1 in integration tests 2020-04-15 tommi@webrtc.org Reland of the test portion of: Created with: gclient setdep -r src/third_party/webrtc@8ec11b831293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie67d2bb353b5a7a75cc988e54603acd9c5969389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151078Reviewed-by:
-
