GitLab

This reverts commit 2c1a1650.

Reason for revert: This is still flaking.

Original change's description:
> Fix flakiness in AutomationApiTest.DesktopHitTestIframe
> 
> At least one issue was that the loadComplete event was sometimes being
> received on a frame with an empty url.
> 
> Bug: 808343,622387
> Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce
> Reviewed-on: https://chromium-review.googlesource.com/938495
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540097}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: If3a4f36c64d2a2d2be04d7d520082344edcc1290
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808343, 622387
Reviewed-on: https://chromium-review.googlesource.com/944768Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540356}

Needed for instantiating these pages with a custom shared page state
class in upcoming rendering benchmarks.

Bug: 760553
Change-Id: Idecad59778f1c7cd729f90bf9e67e67b8e538f9b
Reviewed-on: https://chromium-review.googlesource.com/942310Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540355}

Adds pyserial 3.4 to the .vpython file. This is currently only used
by the VR motion-to-photon latency test.

Bug: 812428
Change-Id: I56644689177394dfdba727be41bdf792386e0f2e
Reviewed-on: https://chromium-review.googlesource.com/943923Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540354}

Starting with gvr 1.13, GVR ignores the screen rotation and always
delivers poses as though the phone was in portrait orientation.
This CL applies the proper rotation to gvr-provided poses to account
for the screen rotation.

Bug: 817889
Change-Id: Ie705046439775b2a34d30b177db6191414acaa10
Reviewed-on: https://chromium-review.googlesource.com/944006
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540353}

Bug: 790648
Change-Id: I09bb0711c9a82ba5ca06ed64392288e04b87b4d6
Reviewed-on: https://chromium-review.googlesource.com/944707Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540352}

Bug: 783500
Change-Id: I9374ea004a0f776939c00279948ea5c1a21bc74f
Reviewed-on: https://chromium-review.googlesource.com/942320Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540351}

Bug: 790648
Change-Id: I2b24cb5c0baec19416d844ce95601dab69671b1a
Reviewed-on: https://chromium-review.googlesource.com/944567Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540350}

In some cases, at least when starting as a scheduled task, Windows
subprocesses are started with a very low priority. Therefore, force
normal process priority when starting a subprocess.

R=dpranke@chromium.org

Change-Id: Ib9e8f9bb1f6d06cffeeab3694508df9e755f8a19
Reviewed-on: https://chromium-review.googlesource.com/941229Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#540349}

Mac C++ compiler is not able to convert a base::ListValue
unique pointer object to a base::Value unique pointer object.

R=dpranke@chromium.org

Change-Id: I07072578bd432c1a6ea13ca9757c75c3da37107c
Reviewed-on: https://chromium-review.googlesource.com/941208Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#540348}

Deprecate Net.QuicSession.PublicResetAddressMismatch which is not in use due to https://codereview.chromium.org/294823002.

Change-Id: I9c51936f69fde5abd6b60de9ab1614607213f97a
Reviewed-on: https://chromium-review.googlesource.com/942239Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540347}

This CL changed the return type of
|URLLoaderFactoryGetter::GetNetworkFactory()| to
|scoped_refptr<SharedURLLoaderFactory>| in an effort to reduce the
usage of raw pointers.

The returned |SharedURLLoaderFactory| is basically a wrapper around
|URLLoaderFactoryGetter|, which holds a reference to
|URLLoaderFactoryGetter| and handles reconnection after crash.

It's safe to use the wrapper after the storage partition has gone, in
which case the url requests will be silently dropped.

Bug: 796425
Change-Id: Ie89b7f8933bc6e1c274cf42bc6bd2265c50c37d4
Reviewed-on: https://chromium-review.googlesource.com/935284
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540346}

Bug: 690696

Change-Id: I0ea4ad248a47ff29238344fdea6d1e7beb906743
Reviewed-on: https://chromium-review.googlesource.com/944050Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540345}

Add gstatic.cn to the Google certificate pin list.

TBR=nharper@chromium.org

Change-Id: I8a99c6a9c98c6b2f38b83050972a700953bb886b
Reviewed-on: https://chromium-review.googlesource.com/943824Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540344}

Bug: 776877, 790761
Change-Id: Ia64b43faaf21368eb44fbc85b1320c593291ad8a
Reviewed-on: https://chromium-review.googlesource.com/944259
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540343}

This is a reland of d13a7e92.

Safe to land; bad service deploy caused the original notification.

Original change's description:
> Add Windows Release CI builders to milo
>
> Adds the compile builder, and the tester.
>
> Bug: 790710, 790644
> Change-Id: I83de37258aadc8d8e79cde3c32baca9d7d994c98
> Reviewed-on: https://chromium-review.googlesource.com/940431
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540314}

Bug: 790710, 790644
Change-Id: Ia7d91fc3be49f7c0dbe32c8ac4424fb3ce71b124
Reviewed-on: https://chromium-review.googlesource.com/944727Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540342}

Keep them tagged as scoped_refptr. Returning a raw pointer sort of
works, but because some refcounts have already been acquired in the
process, we're relying on at least one of those refcounts sticking
around long enough for the raw pointer to be cashed in.

LoginHandler is rather a mess and really should get rewritten (move
UI/IO hop within //content, surface out of WebContentsDelegate,
get rid of NotificationRegistrar and ref-counting), but in the
meantime fix up this local issue.

Tagging with https://crbug.com/814334 in case it's related, but I
don't think it is. (This isn't turning an owned raw pointer to a
scoped_refptr. It's turning a quasi-borrowed raw pointer to a
scoped_refptr.)

Bug: 814334
Change-Id: I542799c20f7453b76f46c1cfad582a8de833a684
Reviewed-on: https://chromium-review.googlesource.com/940021
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540341}

Adds a flag (--cast-app-background-color) that changes the background
color used when displaying web apps. This color is often shown briefly
before Chromium renders a web app.

Bug: internal b/70181260
Test: use flag on ATV
Change-Id: I3bc0989aeabbf639116c1b30fffb11f66b56c4cd
Reviewed-on: https://chromium-review.googlesource.com/897466
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540340}

changes:
According to the design doc: go/cros-persistent-window-bounds, add UMA
for recording the number of windows restored for persistent window
restore in multi-display scenario.

Bug: 805046
Test: tested on device, checked chrome://histograms and added test coverage
Change-Id: I4f8c815c1b88dd605a02b509b27311d567998da1
Reviewed-on: https://chromium-review.googlesource.com/942186Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#540339}

When we're using a button to trigger tab switches, we don't want the
description or icon hinting at switching, since the main suggestion
won't switch in this state.

In addition to these tiny changes, it adds a new icon for the button,
per the UI spec.

Bug: 780835
Change-Id: I01d0c913292852e6ecaf569c1feecccbebd0646d
Reviewed-on: https://chromium-review.googlesource.com/943831
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540338}

Bug: 817653
Change-Id: I29fed9cfc734439aa4a97cf591dafc440232de12
Reviewed-on: https://chromium-review.googlesource.com/943938Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540337}

Bug: None
Change-Id: Ie31654577b2270f83380b06f753bb48f2740a289
Reviewed-on: https://chromium-review.googlesource.com/943344Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540336}

Bug: 816826
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I56839874977fb0563b556e198a5252f4d5937ed7
Reviewed-on: https://chromium-review.googlesource.com/941971Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540335}

If, on a non-secure page, the user edits an INPUT TYPE=FILE field by
selecting a file, send a signal to the browser that a form field has
been edited. This will result in the "Not Secure" string in the
security chip for the page.

Change-Id: I80528eba22a6e590d98d81c7e26389705a340833
Reviewed-on: https://chromium-review.googlesource.com/850588Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540334}

If we evict a surface before the previous CompositorFrame activates with it
as a fallback, then we will attempt to add an invalid reference and we may
end up with missing surfaces in surface aggregator. This CL combats the issue
by avoiding evicting frames during resize.

We will still only update the primary surface ID if the tab is not hidden,
and we will clear the fallback surface ID if the tab is hidden.

Bug: 813157, 672962
TBR: samans@chromium.org
Change-Id: I9f35ef24597f0bc88e139b23a2994e8b32abbc70
Reviewed-on: https://chromium-review.googlesource.com/938678Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#539639}
Reviewed-on: https://chromium-review.googlesource.com/943725Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540333}

This category is only exists in two files. It doesn't have a strong reason to
exist and appear as an option in tracing.

Bug: 817616
Change-Id: Icdbe89b67e5a32b1e3a994f246cf769df0261df1
Reviewed-on: https://chromium-review.googlesource.com/942191Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540332}

Fully migrate PointerEventFactory to WebPointerEvent
by removing the last API that was expecting
WebMouseEvent.

Bug: 814471
Change-Id: Id4bebab1eefae842f7e368e0e2b328127f65e43f
Reviewed-on: https://chromium-review.googlesource.com/929861Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540331}

Launch bug: crbug.com/758005
Finch config: cl/187340325, cl/187517800

Change-Id: Ib47934856cc50d90dd71a2fea7e5a31fb9b02eb5
Reviewed-on: https://chromium-review.googlesource.com/940197Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540330}

Bug=None

Change-Id: Ic321c7b366891fba569b2a96d50f9293ee507a25
Reviewed-on: https://chromium-review.googlesource.com/941590
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540329}

This CL adds the initial count for download files.

The metric is recorded when Android code loaded the history database
records.

Bug: 817220
Change-Id: I571ecbca2aacc3a2be863cdf36310b32569fabe1
Reviewed-on: https://chromium-review.googlesource.com/941519
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540328}

Bug: 705114
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3f092caca160715854324acf58590c18e65a7281
Reviewed-on: https://chromium-review.googlesource.com/922940
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540327}

The icon represents download state (not started, in progress, success,
error).

UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_0

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3ab857e8f1ab6b615102aa704c3b848072f88ff7
Reviewed-on: https://chromium-review.googlesource.com/944504
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540326}

Also restores missing metric on pre-ui-refresh NTP, and adds action items to
first user action recorder.

Bug: 805635
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75581d1e7fbee2b80fc7cbbea3ac82f4e5dbb64f
Reviewed-on: https://chromium-review.googlesource.com/941361
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540325}

This extracts the logic for categorizing network errors as retry-able proxy errors to proxy_fallback.cc.

It is a bit awkward to have a single function in this file, however it serves as a good place to document general proxy fallback behaviors, and the more logic from proxy fallback could be moved here in the future.

Bug: 817052
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic6356c4de3012c41a4bc91feb1e71b5586330fa0
Reviewed-on: https://chromium-review.googlesource.com/940626Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540324}

Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I57c1ec0fbb6ec96164376d63c3cb5cfc30b5a610
Reviewed-on: https://chromium-review.googlesource.com/943402Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540323}

This CL adds a nullptr check for NavigationController in
LoginHandler::Observe().

Bug: 817968
Change-Id: I08d9de516f7d3e788e644c38173ecb969ef8cb58
Reviewed-on: https://chromium-review.googlesource.com/944255Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540322}

This reverts commit d13a7e92.

Reason for revert: Invalid config

Original change's description:
> Add Windows Release CI builders to milo
> 
> Adds the compile builder, and the tester.
> 
> Bug: 790710, 790644
> Change-Id: I83de37258aadc8d8e79cde3c32baca9d7d994c98
> Reviewed-on: https://chromium-review.googlesource.com/940431
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540314}

TBR=hinoka@chromium.org,nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org

Change-Id: Ic6c39527288cc97f06fad1846cb5f6596b213563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 790710, 790644
Reviewed-on: https://chromium-review.googlesource.com/944607Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540321}

Results of diagnose_bloat:
StaticInitializersCount
        -2 count count
MonochromePublic.apk_Breakdown (-19,164 bytes)
       -84 bytes Native resources (no l10n) size
    -2,301 bytes Zip Overhead
       +87 bytes Non-compiled Android resources size
   -12,400 bytes Native code size
        -4 bytes Package metadata size
    -5,806 bytes Java code size
    +1,344 bytes Compiled Android resources size
MonochromePublic.apk_Specifics
   -34,572 bytes normalized apk size
   -12,400 bytes main lib size
   -15,408 bytes main dex size

Bug: 785118, 764446
Change-Id: I645134b61ef818a547a4eae239c067758d06fcf4
Reviewed-on: https://chromium-review.googlesource.com/943942
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540320}

Bug: None
Change-Id: I12ed377d2cbab940a9f45a5d71777144166f69d8
Reviewed-on: https://chromium-review.googlesource.com/943931Reviewed-by: Meggin Kearney <mkearney@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540319}

Roll in the most recent version of:
testharness.js, testdriver.js, idlharness.js and webidl2.js

Some baselines are adjusted accordingly (mostly due to
https://github.com/w3c/web-platform-tests/pull/9051).

Bug: 685854
Change-Id: Ic74431ad0bbbc13e0c9ab2fa8bb4701f69806d32
Reviewed-on: https://chromium-review.googlesource.com/941915Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540318}

histogram. Also rename the enums to be readable, as per the histogram
team's advice.

BUG=815241

Change-Id: Ic4a15efed46f367b2500ef5e553645323355020a
Reviewed-on: https://chromium-review.googlesource.com/944262
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540317}