- 25 Jan, 2019 40 commits
-
-
Stephen Nusko authored
This deadlock situation is not reproducable and we don't have any understanding of how perfetto would add a task to the scheduler's sequence manager rather then the task manager. We suspect that this is no longer an issue. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=839073 Change-Id: Id56e2f3bed30e29abb0c05e668ef9abbafda909f Reviewed-on: https://chromium-review.googlesource.com/c/1433771 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#626156}
-
Mike West authored
Rather than blindly assigning "nested-document", we ought to examine the state of the frame's owner to determine whether it might potentially end up executing as a plugin, and report the value in the header accordingly. Bug: 860510 Change-Id: I78291d8209382fbd325f4d8e72b24c6444fe25b6 Reviewed-on: https://chromium-review.googlesource.com/c/1432955 Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#626155}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/59b1ed4a60fc..59d756e530c5 git log 59b1ed4a60fc..59d756e530c5 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 geofflang@chromium.org Vulkan: Add a test for scissored depth and stencil clears. Created with: gclient setdep -r src/third_party/angle@59d756e530c5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I6f0124bb79e82c6fd08aa392b903462c0bccf28e Reviewed-on: https://chromium-review.googlesource.com/c/1437005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626154}
-
Sebastien Marchand authored
This also adds it to the whitelist used in third_party/blink/renderer/DEPS Gab/Francois, I've used your refactoring script for this, the rule is: matches = re.compile(r'(\n *[^/\n][^/\n]*(base::DoNothing|base::NullCallback)\b[^*])', re.DOTALL).findall(content) if not matches: return False updated_content = refactor_lib.AddInclude(file_path, content, "base/bind_helpers.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) TBR=gab@chromium.org Change-Id: I33e347d3000efd43d567ecf0cc025614ff9cfeed Reviewed-on: https://chromium-review.googlesource.com/c/1437335 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#626153}
-
Patrick Monette authored
It is unknown when, but an update to Windows 10 changed the name of Windows Defender to Windows Defender Antivirus. Bug: 682286 Change-Id: I3202896859fd3018d276dc1f30f1704e67c6d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/1432092Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#626152}
-
Hidehiko Abe authored
This is to address the comment https://chromium-review.googlesource.com/c/aosp/platform/external/libchrome/+/1387893/2/components/timers/alarm_timer_chromeos.h#45 Instead of just upstreaming it, which exposes a method unused in Chromium, this CL introduces Create() factory method and drops the code to fallback in case of timerfd_create failure. Now, a caller should check whether Create() returns null or not. In case of null, to keep the previous behavior, the caller can create an instance of the parent class. Along with the change, in order to run unittest for the class without capability CAP_WAKE_ALARM, this CL also introduces CreateForTesting(). We used to test just fall-back code paths. In addition, this CL fixes the FD leak on destruction. BUG=None TEST=Build and run components_unittests --gtest_filter=AlarmTimerTest*. Run try. Change-Id: Ieb9660335120565ccff7f192d7a8192ca1e59ebc Reviewed-on: https://chromium-review.googlesource.com/c/1411356Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626151}
-
Fabrice de Gans-Riberi authored
The Fuchsia platform now properly sets errno EOPNOTSUPP when invoking setsockopt with IP_MULTICAST_IF. This ignores the error to unblock the Fuchsia SDK roll. Bug: 924792 Change-Id: Icf6b430d5c22f9c5b7302f74b662592db65f13b7 Reviewed-on: https://chromium-review.googlesource.com/c/1435978Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#626150}
-
John Delaney authored
Record counts for number of ad frames that have a display:none style set. Record the pixel dimensions of the ad frames. These numbers will be useful to identify cutoff points for visible advertisements. Most AdsPageLoadObserver metrics are skewed low. With some UKM and manual verification, it was seen this is at least in part due to counting very small frames (e.g. 1 pixel by 1 pixel) and counting frames which are not displayed to users. These metrics are necessary to filter out these frames in the future. Because display: none is tied to frame elements not having content views, and all frame views are removed in a same process navigation, we also need to plumb ReadyToCommitNavigation to the PLM observers so we are not reporting frames that were visible during the page's lifetime as display: none. Bug: 924357 Change-Id: I2fa4126e5d7b26459d8250399980736441ffee37 Reviewed-on: https://chromium-review.googlesource.com/c/1431713 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#626149}
-
Matthew Jones authored
Native pages do not have a URL in the omnibox by default. In these cases we shouldn't show the edit-url suggestion. The side effect of this is text in the omnibox being erased while typing a url. Bug: 925350 Change-Id: I3783ca598aa289a0ece268b54cd21c52036b7de7 Reviewed-on: https://chromium-review.googlesource.com/c/1437177Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626148}
-
Yusuf Ozuysal authored
Uses ThumbnailCache's DecompressThumbnailFromFile to read, decompress and return tab thumbnails on the Java side. Change-Id: Ia3905cf2f3aa859318897db0fcb2d1b489a7827a Reviewed-on: https://chromium-review.googlesource.com/c/1423702Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#626147}
-
Matt Menke authored
This reverts commit 5fe5e428. Reason for revert: CL that broke the tests was reverted. Original change's description: > Disable two flaky NetworkContextConfiguration browser tests > > TBR: mmenke@chromium.org > Bug: 922876 > Change-Id: I7aa180a67d2d8cae122b4472df80659914912b81 > Reviewed-on: https://chromium-review.googlesource.com/c/1417756 > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Auto-Submit: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623727} TBR=rockot@google.com,mmenke@chromium.org,iclelland@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922876 Change-Id: Ic436c92a89e6ed8bb7f25d7f9e80ed4a31c2d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/1437256Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626146}
-
Xianzhu Wang authored
I added the tests to understand WeakIdentifieryMap behavior, e.g. whether the map entry will be automatically removed when the object is garbage collected, etc. The tests look also helpful for others. Also simplify WeakIdentifierMap by removing the non-garbage-collecting version which didn't look working. I tried that in test and the compiler reported error requiring the type to be garbage collected. Change-Id: Ic3f8d99d19d526d1a7a8e3940cf2e117323b9c20 Reviewed-on: https://chromium-review.googlesource.com/c/1435536 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626145}
-
gogerald authored
Instantiate these instances when needed since the flow can be short, especially when the intent is from Chrome, like abort on onboard screen or failed to get scripts or do not accept the script. Bug: 806868 Change-Id: Ib72e90a72bd8539376e54ec0a6615a14bade0568 Reviewed-on: https://chromium-review.googlesource.com/c/1430520 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626144}
-
Becky Zhou authored
Bug: 924877 Change-Id: Iacc7dbca1c2166cc9219ebaa4153ab0e52546053 Reviewed-on: https://chromium-review.googlesource.com/c/1435494Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626143}
-
stkhapugin@chromium.org authored
These methods are only implemented and used by OmniboxViewViews, so they are removed from the base class. Bug: 329527 Change-Id: I47bb17b9f51bc623383525181128c7ec5c3e8c40 Reviewed-on: https://chromium-review.googlesource.com/c/1429986 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626142}
-
Sadrul Habib Chowdhury authored
It is possible for the presentation-feedback for a frame to arrive in the display compositor after the client has stopped requesting begin-frames. In such cases, the CompositorFrameSinkSupport turns on the needs-begin-frames flag, so that it can send a begin-frame to the client carrying the presentation-feedback for the last frame. After this begin-frame is sent, the needs-begin-frame flag needs to be reset in the client's CompositorFrameSinkSupport. BUG=916572 Change-Id: Ic935521c364c98dad6d4f9523de71647ed72a71f Reviewed-on: https://chromium-review.googlesource.com/c/1433554Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#626141}
-
Lukasz Anforowicz authored
Bug: 919144, 925035, 910287, 915721, 915721 Change-Id: Ie25c906e1f558ae805b82867d79b0d26eba89cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1435915 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626140}
-
Steven Bennetts authored
I am removing NetworkHandler dependencies from network_icon.cc to simplify the pending migration to mojo APIs in //ash. This fixes a use-of-uninitialized-value error found in asan tests. Original CL: f2cb8dc3 Bug: 923444 Change-Id: Id9405fc9882a84752343fda165871f38e45f224d Reviewed-on: https://chromium-review.googlesource.com/c/1436188 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#626139}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03e626851265..bc26fdabb612 Created with: gclient setdep -r src-internal@bc26fdabb612 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If61bbed7dec8fee3f624b30163cc26cb30d3a437 Reviewed-on: https://chromium-review.googlesource.com/c/1437003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626138}
-
Carlos IL authored
Change-Id: Ia1722e9c601d7a87ab4a9e628c830d660d54f5d2 Reviewed-on: https://chromium-review.googlesource.com/c/1434078Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#626137}
-
Sky Malice authored
Fixes image loading for <=N clients, see commit https://chromium.googlesource.com/feed/+/029530fe8ad7bebd98725ded9e371b9f7fc3f76b +66,344 bytes main lib size +495,764 bytes main dex size +803,483 bytes normalized apk size +310,138 bytes APK size +890,181 bytes Estimated installed size (Android Go) +2,313,024 bytes Estimated installed size InstallBreakdown (+2,311,410 bytes): +3,006 bytes unwind_cfi (dev and canary only) size +2,706 bytes Non-compiled Android resources size +66,344 bytes Native code size +597 bytes Package metadata size +2,220,841 bytes Java code size +17,916 bytes Compiled Android resources size +2,523 entries fields +3,557 entries methods +808 entries types +1,794 entries strings Specifics: InstallSize: Dex: Change-Id: I9c87884e6e01ab5fd58ce342566bf571dff20c7e Reviewed-on: https://chromium-review.googlesource.com/c/1432678Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#626136}
-
Brian White authored
Bug: 923083 Change-Id: I235c694827c90f10693bbf04da314fa77ee15023 Reviewed-on: https://chromium-review.googlesource.com/c/1435497Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#626135}
-
Andrew Grieve authored
When changing GN arg "use_signing_keys", rebuilding would not result in a resigned apk. Change fixes this by removing use of md5_check. Using md5_check is generally only advantageous when one or more inputs are from outside of the out/ directory, and thus can change when checkout out different branches. Inputs to apkbuilder.py are entirely from within the out/ directory (except for the script itself, which doesn't change much). Change-Id: Ic93d559cc2fffb2fabe8af7152038be76f1e71c0 Reviewed-on: https://chromium-review.googlesource.com/c/1435677Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#626134}
-
Nick Harper authored
This is a partial revert of https://codereview.chromium.org/2109303002, since QuicStreamFactory being an SSLConfigService::Observer was only needed for Channel ID and Token Binding support so that if the Channel ID or Token Binding ID changed, connections using the old IDs would be torn down. Change-Id: I69a78e6841378cd279091b7f6b05c3f2c22cbf78 Reviewed-on: https://chromium-review.googlesource.com/c/1435620 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#626133}
-
James Cook authored
Bug: none Change-Id: Ie7988b2eaae114aa961c9beca5d23a0071753bec Reviewed-on: https://chromium-review.googlesource.com/c/1435820 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#626132}
-
Theresa authored
BUG=925277 Change-Id: I98f26b6625f399110624b0580ff191f7d55a40fa Reviewed-on: https://chromium-review.googlesource.com/c/1437337Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#626131}
-
Miguel Casas authored
crrev.com/c/1412856 disabled tests those two tests for Mac. This CL does the first part of rebaselining those: - Marks the pixel test as failing without platform condition - Increases the revision in the pixel_test_pages.py Bug: 922218 Change-Id: Ic27f6a04b1362df820f0abb648b9c23699aa0fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1436081Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#626130}
-
Xiaocheng Hu authored
The function is dead for pretty long time. So this CL removes it. Bug: 924616 Change-Id: I33d0d377add5f6ada2a4e25fab6d086561874d86 Reviewed-on: https://chromium-review.googlesource.com/c/1436674 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626129}
-
Xiaocheng Hu authored
As discussed, it's not worthy to support legacy layout with bidi caret affinity. Hence, this patch removes the support. Bug: 925192 Change-Id: Ie01927432c1fa446e37424a3cd71d59fad088207 Reviewed-on: https://chromium-review.googlesource.com/c/1436356Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626128}
-
Morten Stenshorne authored
Stronger typing to assert that we know what we're doing. Change-Id: I1412dd12f34a2bc0310c4f057575cbbe84267f08 Reviewed-on: https://chromium-review.googlesource.com/c/1437154Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626127}
-
Elly Fong-Jones authored
This reverts commit 7c4d49a6. Reason for revert: broke "Google Chrome Mac": https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/40824 Original change's description: > Reland "mac: roll to 10.13 SDK" > > This is a reland of d86a6561 > > Original change's description: > > mac: roll to 10.13 SDK > > > > This change causes the default hermetic SDK to be version 10.13 (aka Xcode 9.3). > > This also bumps the minimum build host version to 10.13.2, since that > > is the earliest version on which Xcode 9.3 runs. > > > > Bug: 780980 > > Change-Id: I6da3f7d3a060a22d71d5ee18bb88f51d5aedb0a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1394742 > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#620032} > > Bug: 780980 > Change-Id: Iea403cc2dcbfc56ce54a6ad72ca4d2729b520fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/1436942 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626106} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: I3d16cd8185d4b96932ee5b9c140c60c47f80bee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780980 Reviewed-on: https://chromium-review.googlesource.com/c/1437259Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626126}
-
Weidong Guo authored
Bug: 854836 Change-Id: Ifecd33e89ce96a7f4314ed70d2d3df1f5dc03ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1434286Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626125}
-
Matthew Jones authored
This patch changes WebappActivity to use the status bar theming methods in the parent ChromeActivity rather than directly calling the api compat method. As a result, webapps will have status bar theming logic consistent with other chrome activities. The overrides now ignore incoming theme colors in favor of it's own brand color. Bug: 801474 Change-Id: I1f21de0465aea5262ea30d1912153461f71e41bc Reviewed-on: https://chromium-review.googlesource.com/c/1435914Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626124}
-
Elly Fong-Jones authored
This change deletes --mhtml-generator-option and the logic that was gated on it. Bug: 912131 Change-Id: Ic7700caa6b7ba35c70b2c92fc92afe501cd1e7d5 Reviewed-on: https://chromium-review.googlesource.com/c/1427465Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#626123}
-
Nate Fischer authored
No change to logic, just a refactor. This swaps out hardcoded string literals for the newly added ABI constants for a few scripts in chromium. This updates pydeps for the scripts this transitively affects, which conveniently includes the pydeps files which previously blocked a catapult autoroll. Bug: 922854, 925237, 924778 Test: vpython android_webview/tools/run_cts_test.py Test: vpython build/android/list_class_verification_failures_test.py Change-Id: I9c754809f00606bad19120e869d5c7f47b8dba02 Reviewed-on: https://chromium-review.googlesource.com/c/1436876Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626122}
-
chrome://bookmarksNicolas Ouellet-payeur authored
8px => 12px to match the mocks. Change-Id: I801542001f7c2d73da62e47870c856509097fda4 Reviewed-on: https://chromium-review.googlesource.com/c/1425479 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626121}
-
Anatoliy Potapchuk authored
In the condition when the device is disabled by policy it was referencing a yet uninitialized LoginScreenClient leading to SYSSEGV and boot/login loop in Chromebooks. Bug: 884127 Change-Id: If99d945777e56cbc1299f5094afd32cee1872f3a Reviewed-on: https://chromium-review.googlesource.com/c/1435436 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#626120}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/8e8f250422663106d478f6927beefba289a95b37..6c1b376e1d502eff365028fe054115f1b46d19b5 The following commits have Chromium bugs associated: 823effe97 Revert "Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos" de3c1f69c Fix header file for _byteswap_ulong and _byteswap_uint64 from MSVC CRT 35771ff8a Fix protos_len size in SSL_set_alpn_protos and SSL_CTX_set_alpn_protos Bug: 879657, 893460 Change-Id: I2305e6588719ffb1ddf31e3c40df8bc4aecb8c29 Reviewed-on: https://chromium-review.googlesource.com/c/1436397 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#626119}
-
Leonardo Padilha authored
This information will be used to collect metrics on events that trigger status reports. We need to know whether the call to schedule a report was successful or not. Bug: 919132 Change-Id: If0be7c5d7d11a686707a1a20a2a6d6ad519a31ba Reviewed-on: https://chromium-review.googlesource.com/c/1418272Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#626118}
-
Avi Drissman authored
BUG=913314 Change-Id: I01de2642638dde55945f41dfa58da41a30b2c095 Reviewed-on: https://chromium-review.googlesource.com/c/1435957 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#626117}
-