GitLab

Bug: 926235
Change-Id: I2a19192aa63aad43245074f81a4dfba36356f9bf
Reviewed-on: https://chromium-review.googlesource.com/c/1487958Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635376}

This reverts commit aac0ce22.

Reason for revert: The devtools flakes introduced by running the tracing process as a sandboxed service, should be addressed by https://chromium-review.googlesource.com/c/chromium/src/+/1483354

Original change's description:
> Reland "Tracing: Move the tracing service in-process again to figure out test flakes"
> 
> This reverts commit 8b42fd6c.
> 
> Reason for revert: Flakes https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGI0MmZkNmM5MmZiNjY2MWNmYzNlOTIzNWM4NmYwMjU2MjZkZjA4ZQw
> 
> Original change's description:
> > Revert "Tracing: Move the tracing service in-process again to figure out test flakes"
> > 
> > This reverts commit 6b27bca8.
> > 
> > Reason for revert: Should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1474309/
> > 
> > Original change's description:
> > > Tracing: Move the tracing service in-process again to figure out test flakes
> > > 
> > > Effectively temporarily reverting https://chromium-review.googlesource.com/c/chromium/src/+/1412016
> > > 
> > > Bug: 914579, 929142
> > > Change-Id: I443e41fee17f6f09ca5cf5c243dbf330bafef6f8
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1456871
> > > Commit-Queue: oysteine <oysteine@chromium.org>
> > > Reviewed-by: ssid <ssid@chromium.org>
> > > Reviewed-by: Alexei Filippov <alph@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#629738}
> > 
> > TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 914579, 929142
> > Change-Id: I9585a500916c0d90b16901572823a3c7c14bbbbb
> > Reviewed-on: https://chromium-review.googlesource.com/c/1477877
> > Reviewed-by: oysteine <oysteine@chromium.org>
> > Reviewed-by: ssid <ssid@chromium.org>
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#634229}
> 
> TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org
> 
> Change-Id: I87f62967a2a0006b3b2f7a8c91bd44a26306643d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 914579, 929142
> Reviewed-on: https://chromium-review.googlesource.com/c/1483250
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634677}

TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 914579, 929142
Change-Id: I4728f2009ade1b329961f70a76dd5b0a78c8ad83
Reviewed-on: https://chromium-review.googlesource.com/c/1488061Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635375}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ide799ea0ef6e242d166e010c1b1a0c850736c759
Reviewed-on: https://chromium-review.googlesource.com/c/1487120Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635374}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bb5b647cd02..1771900dac6d


Created with:
  gclient setdep -r src-internal@1771900dac6d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I36aa3f520b231f00587bf83e293c9e48c3260117
Reviewed-on: https://chromium-review.googlesource.com/c/1487119Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635373}

Crostini.Backup: enum histogram for backup result
Crostini.BackupTimeSuccess: timing histogram for success
Crostini.BackupTimeFailure: timing histogram for failure
Crostini.Restore: enum histogram for restore result
Crostini.RestoreTimeSuccess: timing histogram for success
Crostini.RestoreTimeFailure: timing histogram for failure

Bug: 933951
Change-Id: I71214b016c477dbb9647ef246feb9b18cfd62075
Reviewed-on: https://chromium-review.googlesource.com/c/1480299
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635372}

Move the zcr_secure_output interface into its own files. This
change only moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: If0860eb11d72aedcc3b6c98ad70313584e42bc94
Reviewed-on: https://chromium-review.googlesource.com/c/1481064
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635371}

The feature has been enabled by default more than 2 releases.

Change-Id: Ic32874d433520721f17903d5f2c7cddddbd38bec
Reviewed-on: https://chromium-review.googlesource.com/c/1487844Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635370}

It looks like flinging + MediaPlayer renderer can get us into situations
which cause us to use normal demuxing instead of MediaPlayer. This is
likely due to flinging not returning MediaResource::Type::URL. To fix
this, rely on |demuxer_detected_hls_| flag in addition to the type.

BUG=935755
TEST=none
R=tguilbert

Change-Id: I634c140f63942f08d1407abe5ff5d49a16d9db67
Reviewed-on: https://chromium-review.googlesource.com/c/1488069
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635369}

Feed libraries add some new methods to track spinners in general and
zero state, this CL is for adding UMA for those APIs.

Bug:924739

Change-Id: I09a86e08b18c0db17a6fc66c9a5d91a37684ca8a
Reviewed-on: https://chromium-review.googlesource.com/c/1486683
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635368}

This used to work, maybe something I added broke it or maybe something
lower level changed.

Test: manual
Bug: 935774
Change-Id: If36350e2a9cdfaef08b249ffed96562b4193fac0
Reviewed-on: https://chromium-review.googlesource.com/c/1488036Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635367}

Remove unused net log type and add more net logs to help monitor the experiment of race stale dns on connection.

Change-Id: I7d68922489a73c902ed322206ea75715fb2f27b3
Reviewed-on: https://chromium-review.googlesource.com/c/1487889Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635366}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d13a3a7aff05..2afcf22ad184


git log d13a3a7aff05..2afcf22ad184 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 brucedawson@chromium.org Check for impossible date ranges


Created with:
  gclient setdep -r src/third_party/depot_tools@2afcf22ad184

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ic17d67c5d5d6039cd6648811a7492f65d888356c
Reviewed-on: https://chromium-review.googlesource.com/c/1487137Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635365}

This change exposes the same trace events as used on Android for VR to
Windows. This will help to unblock perf tests and start to help basic
perf investigation from chrome://tracing.

Bug: 865084
Change-Id: If4f8cf0b3b435d70416c93436437f658843d6cc0
Reviewed-on: https://chromium-review.googlesource.com/c/1479858Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635364}

https://chromium.googlesource.com/catapult.git/+log/85a76645b4e4..ca34240a5b2c


git log 85a76645b4e4..ca34240a5b2c --date=short --no-merges --format='%ad %ae %s'
2019-02-25 crouleau@chromium.org Change default bug prefix to chromium.
2019-02-25 simonhatch@chromium.org Pinpoint - Whitelist chromevr bots in UI.


Created with:
  gclient setdep -r src/third_party/catapult@ca34240a5b2c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:934652,chromium:935615
TBR=sullivan@chromium.org

Change-Id: I0289800facccb115018eb272fdc4b2ac717520fe
Reviewed-on: https://chromium-review.googlesource.com/c/1487117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635363}

https://chromium.googlesource.com/angle/angle.git/+log/fe14b2e503a5..0546b5380780


git log fe14b2e503a5..0546b5380780 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 ynovikov@chromium.org Revert "Vulkan:Adding custom pool allocator"
2019-02-25 jmadill@chromium.org Add third_party/googletest to .gitignore.


Created with:
  gclient setdep -r src/third_party/angle@0546b5380780

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I77b99c039edaa04695a466e9d5c48d268eb68893
Reviewed-on: https://chromium-review.googlesource.com/c/1487961Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635362}

Bug: 930553
Change-Id: I7342022f1a6ee7e839cdcd9ac4d22f0b6b250383
Reviewed-on: https://chromium-review.googlesource.com/c/1465557Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Auto-Submit: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635361}

1. Let VideoOverlayFactory carry an unique ID
|overlay_id| that identifies itself.
2. The VideoFrame that created for hole punching
purpose carries such |overlay_id| which will be available
in OverlayStrategyUnderlayCast. There it identifies
the origin of the DrawQuad that was created for hole
punching purpose.

One purpose of this change (and follow-ups) is to allow the
[Chromecast]CMA pipeline to support multiple simultaneous
video streams.

Because the video streams are pushed directly into the video decoder
via CMA and each video decoder instance pushes the video into a
hardware overlay plane, the compositor doesn't know which video hole
quad is associated with a specific hardware overlay plane, so the
compositor (via the overlay strategy cast) doesn't know how to set
the geometry of a specific hardware overlay plane. The |overlay_id|
plumbed here is to identify the video decoder that's associated with
video hole quad.

Another purpose of this change (and follow-ups) is to replace direct
call back of the hardware overlay plane with mojo, so the corresponding
code can be moved out of browser process without issue.


Bug: 925450
Test: Prints out |overlay_id| at
OverlayStrategyUnderlayCast::Attempt(...) to verify
|overlay_id| does arrive.

Change-Id: I09f2b340f929c4d7718351e17a572b582447e4fe
Reviewed-on: https://chromium-review.googlesource.com/c/1428319Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635360}

The old code would avoid emitting this callback if the previous QueryBufferUsage call had returned
0 buffer usage, even if events are now in the process of being streamed out. Specifically
this happens with Perfetto for some layout tests as the QueryBufferUsage is immediately issued
after StartTracing, and returns a result before any data has been logged (or at least before enough
data has been logged to fill up any pages in the Shared Memory Buffers), i.e. returning 0 buffer
usage, hence failing the test expectations.

We now emit the emit with a 0% buffer usage, in this particular case.

R=caseq@chromium.org
BUG=839084

Change-Id: I43e3ea9429c66907929e4babe2ba6d5936790607
Reviewed-on: https://chromium-review.googlesource.com/c/1487880
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635359}

R=jbroman@chromium.org
CC=blink-reviews-onion-soup@chromium.org

BUG=891908

Change-Id: I3c3a32a7cccc50c1b8d4038b0a8559c15910b782
Reviewed-on: https://chromium-review.googlesource.com/c/1483174
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635358}

Some tests like base_unittests don't actually need fontconfig initialized, so it
saves a bit of time to omit the call to FcInit().  Luckily, in all cases,
FcInit() is already called everywhere FontConfig is needed.

BUG=None
R=thakis,derat

Change-Id: I5ccad01e252499b2137d67004482f3a3652484b5
Reviewed-on: https://chromium-review.googlesource.com/c/1487186
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635357}

We ran into a user machine with AMD GPU that reports NV12 overlay cap.
This is a total surprise and we never tested overlays on non-Intel GPUs.

To be safe, let's turn off overlay support on all except Intel GPUs.

BUG=931399
TEST=manual
R=sunnyps@chromium.org,piman@chromium.org

Change-Id: I4e6edd558ac09679cc911c584a100655e99c59d0
Reviewed-on: https://chromium-review.googlesource.com/c/1487474
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635356}

Migrate usage of base::Bind with one-time callbacks to base::BindOnce.

Bug: 755477
Change-Id: I926a43df96e96105083fb90f2330cdf3063d9fe2
Reviewed-on: https://chromium-review.googlesource.com/c/1485840
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635355}

https://chromium-review.googlesource.com/c/1486876 got most but
not all instances of this.

If this breaks some chrome os build that's not tested by the CQ,
please add `&& (target_os != "chromeos" || that_arg != bad_value)`
to the conjunction in the gn file instead of reverting.

Bug: 926235
Change-Id: Ibc551260fe8c75181f88dd61195486a02fa9d88f
Reviewed-on: https://chromium-review.googlesource.com/c/1487368
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635354}

BUG CAUSE:  When the fix flow prompt is dismissed, we intend to cleanup the memory
by calling delete this. However, chrome_autofill_client tries to call the
destructor of the unique pointer pointing to the deleted object resulting in a crash.

PROPOSED SOLUTION:
Since the fix flow objects are responsible for maintaining their lifecycle.
i.e. Delete themselves when the prompt is dismissed, we can change them to be local
raw pointers.

Bug: 929437
Change-Id: I539569dc32fbe6d0e4f535a57a2e2871e573a87c
Reviewed-on: https://chromium-review.googlesource.com/c/1468582Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635353}

A PRE_ test is intended to set up state for a future test. e.g. PRE_X is run
right before test X, and has no meaning in and of itself.

Prior to my changes in
https://chromium-review.googlesource.com/c/chromium/src/+/1450754, a failure in
PRE_X would cause the test launcher to crash. Afterwards, a failure would:
  * mark the test PRE_X as "FAILURE" in the results dictionary
  * mark the test X as "SKIPPED" in the results dictionary.

The chromium test recipe would then attempt to rerun the failure PRE_X, and skip
the test X. But the test launcher doesn't even know how to run the test PRE_X by
itself -- it can only run the test PRE_X as a precursor to test X. There are two bugs:

* A failure in PRE_X should be marked as a failure in X. It doesn't make sense
  to return a status for PRE_X, which is not even a test, and cannot be rerun.
* The status "SKIPPED" has conflated semantics. It is also used to mean -- the
  test was not run and was not intended to be run. Ignore it.

This CL changes failures in PRE_X to mark test X as "FAILURE".

Bug: 872042
Change-Id: I266af0f2f4794938c723819850b204d2bb766a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1487952
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635352}

- Fall back to platform API if resources have been purged from the
  ResourceFetcher cache and we can't retrieve the CachedMetadata sender.

Bug: chromium:719172
Change-Id: I5a9be7332d87fe941331a4542351c518b83e6c85
Reviewed-on: https://chromium-review.googlesource.com/c/1478261Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635351}

Add chrome.runtime.onConnectNative event for extensions/apps that
allows a native application to initiate a connection to them.

The current proposal is to use this event on Chrome OS only.

This CL only adds a definition for the event and wiring up till the
extensions::MessageService class in the browser. No code triggers this
code path yet, so no behavior changes are expected.

BUG=chromium:898746
TEST=manual

Change-Id: I3c67a11d45f141c0d9b8e4855b22196a3c289ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1343002Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635350}

Rename MULTIPLE_DISPLAY_STATE_DUAL_MIRROR to
MULTIPLE_DISPLAY_STATE_MULTI_MIRROR since we now support mirroring
2+ displays by default.

Bug: 774795
Change-Id: I0274bb2f6a8f48fbefb37dc18eec43ac4f7908a8
Reviewed-on: https://chromium-review.googlesource.com/c/1443735Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635349}

ExtensionWebRequestEventRouter::DispatchEventToListeners passes an incorrect
value for |crosses_incognito| to WebRequestEvents::GetFilteredDict. This cases
two bugs:

- Split mode extensions never see the initiaor if both the normal and incognito
browser contexts are active.

- Spanning mode extensions don't see the initiator from requests from the normal
browsing context if both the normal and incognito browser contexts are active
and the extension isn't enabled in incognito.

Fix this by correcting the value of |crosses_incognito| and adding regression
tests.

BUG=934398

Change-Id: I9252a95e20bc097cc798db8713764bdcc94e4e32
Reviewed-on: https://chromium-review.googlesource.com/c/1485027Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635348}

When sending a message with WebRtcDataStreamAdapter, the adapter would
immediately call Send on the underlying webrtc::DataChannelInterface and
invoke the done callback. As a result, any code that tried to use the
done callback to determine when to queue the next message would end up
overrunning the WebRTC send buffer, causing the connection to drop.

This commit changes WebRtcDataStreamAdapter so it monitors the data
channel buffer and waits for the previous message to makes its way down
to the SCTP layer before sending the next message and calling its done
callback.

Bug: 679313
Change-Id: Ibb1cf8f7a0806e80d97e0dfd0632707711228e14
Reviewed-on: https://chromium-review.googlesource.com/c/1483932
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635347}

* Let the DnD nested message loop allow nested tasks, since that's what other
  platforms do.
* Distinguish "source" and "last" drag operations and return the one the API
  comments say we should return.

I made both of these changes speculatively while trying to determine why various
DnD tests are failing on Mac.  These changes don't fix the failures but seem
like they ought to be more in line with other platforms.  I would appreciate a
more knowledgeable set of eyes.

Bug: none
Change-Id: I223190ecce4371616e27eeebf4b693a65083d310
Reviewed-on: https://chromium-review.googlesource.com/c/1483935Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635346}

This adds a boolean to SearchResultMetadata, notify_visibility_change,
which indicates that the Result in question is interested in being
notified when it is shown/hidden on screen.

Add a method to AppListController, OnSearchResultVisibilityChanged,
which is used to send this notification, and implement it
appropriately in AppListController and the Chrome side, also, sending
through to a new method ChromeSearchResult::OnVisibilityChanged .

Also, importantly, override OnShown and OnHidden in
SearchResult.*View, and implement correct notifications for the
results in SearchResultTileItemListView (but not others so far).

Bug: 911427
Change-Id: I2fbfa0e410d83fb0e3feec246a816f5735eddfa2
Reviewed-on: https://chromium-review.googlesource.com/c/1477456
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635345}

We used to allow listing a couple of display modes that have
the same size as that of the native mode, even though the display
configurator will always choose the native mode as the best mode
for that size, regardless of the user choice.
This lead to user confusion, when they attempt to set the resolution
of their external display with a mode with a higher refresh rate
(e.g. 75 Hz) while the native mode has the same size but with lower
refresh rate (e.g. 60 Hz). The native mode will always be the one
selected, not what the user wanted.

BUG=931799
TEST=Expanded tests

Change-Id: I6c2391a259a26f7d77facafeaf5b336906600ea4
Reviewed-on: https://chromium-review.googlesource.com/c/1487696Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635344}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/967b98310a63..8bb5b647cd02


Created with:
  gclient setdep -r src-internal@8bb5b647cd02

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iea9ca06c118f52b9b2d94d3f52dc4a6ab24ddaca
Reviewed-on: https://chromium-review.googlesource.com/c/1487138Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635343}

This change exposes a few more UIA properties through GetPropertyValue.

- Added function: IsWebContent to ax_platform_node_delegate to allow
AXPlatformNodeWin::IsUIAControl to have different implementations
between web content and non web content.
- Moved AXPlatformNodeWin::ShouldHaveReadonlyStateByDefault to
ax_role_properties so it could be used by ViewAXPlatformNodeDelegate

Relevant unit tests have been added for each of the new properties.

Bug: 844149
Change-Id: I70603a6346dda6a15f5d9917762ed3ab1579682a
Reviewed-on: https://chromium-review.googlesource.com/c/1480814
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635342}

Subtitle never get cleaned up when loading a video.
Remove all tracks from previous video before loading new ones.

Bug: 909963
Change-Id: I7cf35b2c31db8eab3f99877a51f0401606cbc12a
Reviewed-on: https://chromium-review.googlesource.com/c/1478451Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635341}

Bug: 930912
Change-Id: I5b3b0ac945359b2e7bab860d4be31d2985cd9453
Reviewed-on: https://chromium-review.googlesource.com/c/1487849
Commit-Queue: Travis Skare <skare@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635340}

Relaxed use_cups rules to just require a copy of libCUPS to allow
fuzzing.

Bug: chromium:831914
Test: ran fuzz test
Change-Id: I190eab4f7de3bbb4d096a39cabb4bb7fb9e3de3b
Reviewed-on: https://chromium-review.googlesource.com/c/1479899Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635339}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc3897b5f585..002ef361cabc


git log fc3897b5f585..002ef361cabc --date=short --no-merges --format='%ad %ae %s'
2019-02-25 jbolz@nvidia.com Add validation for SPV_NV_cooperative_matrix (#2404)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@002ef361cabc

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ifa2f5ceedc9a854ca8c8eaee08a2230532a1291b
Reviewed-on: https://chromium-review.googlesource.com/c/1487139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635338}

This reverts commit 3dc09a0d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 635263 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vM2RjMDlhMGQ1OTQzOWEwODY3ZWJkNTBhYjY3ODQ2OTFlMTI0NTBlYQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/10723

Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6

Sample Flaky Test: http/tests/devtools/application-panel/storage-view-reports-quota-and-clear.js

Original change's description:
> [DevTools] Application>Clear Site Data: stop service worker when unregistering it
> 
> We should stop the service worker before unregistering it.
> 
> Originally, clicking "Clear site data" will unregister the service worker. In
> Application>Service Workers, the service worker's tab title is marked as
> "deleted", but its "status" says it's still running.
> 
> Bug: 894783
> Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/1480725
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#635263}

Change-Id: I8f08b6b9a63cc6ea516d2c0b988423fb5f16c2f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894783
Reviewed-on: https://chromium-review.googlesource.com/c/1488153
Cr-Commit-Position: refs/heads/master@{#635337}