- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610452567-9a68a195870106cae6c4ac4841f20ff7b185cdf9.profdata to chrome-mac-master-1610474333-6e9ea86fde1168dfc05bd82ef581aacfe157db52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieda6bb22f231441732a039a974cd411a59a8770b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842690}
-
John Lee authored
By moving the `direction: rtl` CSS to an internal div, direction-dependent CSS properties like margin are no longer affected by the direction and can be used to correctly space out the host element. Bug: 1164840 Change-Id: I4d2c7d02284fe0b8a9593ea48ffd65fd9969d83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622657 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842689}
-
Yulun Wu authored
Bug: 1139478 Change-Id: Ie9179fc42d59def83910475e93ef93c5eef3b496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622761 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842688}
-
Shuran Huang authored
This is to support SameParty for document.cookie queries. IsolationInfo has fields origin, top_frame_origin and site_for_cookies, is typically the same for all subresource requests made in the context of the same frame. Bug: 1136102 Change-Id: Id43ca760150adca28862e42f6e22fe4953cf9164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582608 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842687}
-
Dave Tapuska authored
Convert UnfreezableFrameMsg_Delete to a navigation control message. Move the FrameDeleteIntention to mojo and add a callback for testing that a frame is deleted. This is possible because associated channel messages are not currently frozen. Do not perform the disconnect on main frame remotes as those will be owned by the view itself. BUG=993189 Change-Id: Icaab6d2d2ea47e9dc9b66fd269ff14274f617c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533520Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81b3d28a..16b9bbbd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1dca01c7ab7ca6d38a0ea021ea3e0d9874bc0986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624698Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842685}
-
David Bertoni authored
This CL removes ExtensionsClient::ExtensionAPIEnabledInExtensionServiceWorkers() and its overloads. Bug: 1165397 Change-Id: I8a5bd861c81ec57f1f3d1c9fe8780d904bb48332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623894Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842684}
-
Ken Rockot authored
This is in preparation for use of JS modules within the tests. They share some library code with external bluetooth WPT, and that code will soon use JS modules. Bug: 1004256 Change-Id: I0817dde4216fa43287cde2788edf5c324cf47fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622578 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#842683}
-
Charlie Hu authored
This CL removes the comma separator support in allow attribute parsing. Bug: 1062400 Change-Id: Ib1c481b492903384a0413f221474ec7703e6f0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600388 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Josiah K authored
Gate "Zoomed in screen follows keyboard focus" toggle in Chrome OS Accessibility settings behind feature flag MagnifierPanningImprovements. (following crbug.com/1144947, hide toggle in M89) Feature off: https://screenshot.googleplex.com/8wTtrRRQCC4XNx5 Feature on: https://screenshot.googleplex.com/7RaUNBhcpQsgBeC AX-Relnotes: N/A. Fixed: 1165650 Change-Id: I8286f977a6099cdc31e82b536d09e5c291aac637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622716 Auto-Submit: Josiah Krutz <josiahk@google.com> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#842681}
-
Austin Sullivan authored
This overload of IDBRequest::EnqueueResponse was only used for devtools, which no longer uses it as of [1]. The implementation of this method was removed here [2]. [1] https://crbug.com/992958 [2] https://crrev.com/c/2563872 Bug: N/A Change-Id: Iacf15ee27b7505c7fba44d00f675a38bf7125f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621954 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#842680}
-
Sonny Sasaka authored
This lets Googler users who report issues related to Nearby Share or Phone Hub to attach Bluetooth logs. Bug: b:177249078 Change-Id: Ib35ed5cb6d1a20421d5772a0b2a63b2553599e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622523 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842679}
-
Ryan Daum authored
* Backspace, tab, and delete are special in that they are characters, but non-printable. * This catches them and passes them through as non-printable class characters, so they are properly handled by blink. Bug: internal b/174869138 Test: manual with wayland_webview_client Change-Id: I2e33c602fbe6c85f0998717541d2f5fca0b48a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625207Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#842678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/767ed2f6b642..d0102e007e70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com,dfried@google.com Change-Id: I60efa1ffacb568a47b32bde6682878129e68db89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842677}
-
Findit authored
This reverts commit 107694e1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 842561 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEwNzY5NGUxOGZlZTE1MGEwODczNDc3Y2M4NGJmYzVmZGFkMmM5NjMM Sample Failed Build: https://ci.chromium.org/b/8858284128460739264 Sample Failed Step: content_unittests Original change's description: > [conversions] Use base 10 encoding for impression and conversion data > > What: > No longer parse impressiondata as hex, or use hex when sending > conversion reports. > > Why: > This causes needless conversions for developers, as raised on > https://github.com/WICG/conversion-measurement-api/issues/60 > > Note that the conversions database stores imp and conversion data as > strings currently because they are represented as hex. These can > be converted to strings now, but this is left as a followup. > > Bug: 1163599 > Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842561} Change-Id: I811167ec2b72a1a2d0fd9f12931ffc2dd2c85f08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625608 Cr-Commit-Position: refs/heads/master@{#842676}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e59aac750e..c60dda78e4ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9a568d84fb9dac1eb46860774cf45305a320a68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622805Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59b0ce20d3e5..f6b414c57847 2021-01-12 gavinmak@google.com Add client not configured message to gclient validate and flatten If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:732733 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3e4c07db24080d701e882b57d73700c06f265fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625232Reviewed-by:
-
Ben Kelly authored
Bug: 1165799,1150991 Change-Id: I8b47aa1f87ea022b8813fa1d097174854797e4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623954Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#842673}
-
Stephanie Kim authored
Bug: 1149606 Change-Id: I8ce5bebd005eaca969f02417974103899a15bc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622580Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#842672}
-
Josiah K authored
Adds Magnifier panning improvements feature and flag to gate magnifier panning improvements, such as new Magnifier mouse panning modes, and Magnifier Chrome OS Settings. AX-Relnotes: N/A. Bug: 1144947 Change-Id: I962e647477b9267f405ed693795ba00a765b01a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623713 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
-
Stephen Chenney authored
We would still like to track these until Paint Holding Cross Origin is well and truly launched. Fixed: 1156203 Change-Id: Id85cb3cc280bf681161a877ed797ffa06ba43cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622998 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842670}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610452567-fdff272b709a6fb84edf0325fafb43e63f345a7e.profdata to chrome-linux-master-1610474333-25cc4688b5885ba387e87620f7adfe156a967401.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I31916253bb6ccd9ceae912445c19751b1aba4e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625427Reviewed-by:
-
Miriam Polzer authored
Bug: 1151987 Change-Id: I14dcbeed057904f093694d57be5755ef8737af7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600908 Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
Yulun Wu authored
Bug: 1139477 Change-Id: I8901748651f62b2894a0c8b3f4e46bed6ddc6c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612207Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842667}
-
Kevin McNee authored
Several mime_handler_view tests have a copy of the test extension id. We now use the common constant. Bug: None Change-Id: If9c08f486698a1c32fc9c2871a379e474589a2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624771 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#842666}
-
Trevor Perrier authored
This CL enables selecting the app and translate target languages in the new detailed language settings on Android. This feature is all behind a release flag. Both settings preferences use the added LanguageItemPreference which launches the existing AddLanguageFragment on tap to select a language. Languages options in the AddLanguageFragment are filtered based on what the language will be used for. setTargetLanguage is added to the TranslateBridge. The Advanced Settings section is implemented as an Expandable Preference Group. Currently the only preference that works in the advanced section is the Target Language. Screenshots can be found here: https://crbug.com/1127531#c5 Bug: 1127531 Change-Id: I18707df2e3736920d1e7a4102b55863b99eb21e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593923 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842665}
-
Vladimir Levin authored
This patch extends the previous early out to ensure that we skip doing work for post-layout observers in post-lifecycle. Previously the early out only skipped non-post-layout observers in post-layout. R=szager@chromium.org, chrishtr@chromium.org Bug: 1165803 Change-Id: I639354ef603fc1aa25598816f6ef2bb8852f1fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625128Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842664}
-
Xing Liu authored
This reverts commit 3c5bfcbb. Reason for revert: Release build bot is still failing. https://bugs.chromium.org/p/chromium/issues/detail?id=1165869 https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1731 Original change's description: > Reland "Read later: Fix crash and check URL scheme when adding a reading list." > > This reverts commit abd87a46. > > Diff: > > 1. Use @RequiresRestart for test BookmarkBridgeTest.testAddToReadingList. > > 2. Add a logging in EmptyReadingListManager.Add. > > Notices still can't repro the test failure with batch test script. > > Bug: 1157808,1163225 > Change-Id: I4774d7f3468a6aac07dcde167fd8649d7b1e8d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622890 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842237} TBR=dtrainor@chromium.org,xingliu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib282f1fd2aaaab2739c6cf96d25f257d35b511e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157808 Bug: 1163225 Bug: 1165869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625276 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842663}
-
Jeffrey Young authored
Stop manual layout of Ambient mode. Use layout manager to position photo view and Ambient Assistant view. BUG=b/163170162 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I91b52e6e84e6a844ed13fe1c50d1e9389454e8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611024Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842662}
-
Daniel Hosseinian authored
Keywords are shown a little differently than other property values. Given that the string is expected to be a long list, wrap the property value instead of ellipsing. Screenshot: https://imgur.com/a/GC1hHCx Bug: 93619 Change-Id: I450cdc70067e8a23052ee09c1ce5312a9832f7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623711 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
David Roger authored
Change-Id: I7549fbdcb7e37ba59a791119523ea1b8f250c3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624730 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842660}
-
Joel Riley authored
This came up in our team's testing, that it is confusing that the user's reading speed isn't remembered if they activate STS on different Chrome tabs for instance. If STS is hard reset (deactivating feature or reboot), its ok to restore system default speech rate. AX-Relnotes: Select-to-speak will now retain user selected reading speed across sessions, unless Select-to-speak is deactivated or otherwise hard restarts (from reboot, restart, etc). Bug: 1165823 Change-Id: Ia2e456fac2854133714e41c5341cde0ace54ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623839Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#842659}
-
Wen Fan authored
Update page most visited info when there is no custom link When you Toggle Most visited sites (InstantService::ToggleMostVisitedOrCustomLinks), the change will not be notified to the page if there is no custom link. The add shortcut button status will not be correct. Bug: 1161688 Change-Id: Ia18355afc4686aa881d5c0c57b8a7e8bb97925de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612334 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842658}
-
Xing Liu authored
For snackbars that don't have action buttons, currently talkback will read out "Added to reading list. null. Options available near bottom of the screen". We should check whether content description for the action button is null when generating the accessibility string. Bug: 1164726 Change-Id: Iac7b286a442ce4be01323f686dfc558be56cf33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622735 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#842657}
-
Łukasz Anforowicz authored
This reverts commit bbc4b0fe. Reason for revert: Gathered sufficient diagnostics - DwoC reports can be found in https://crbug.com/1164906 Original change's description: > Adding DumpWithoutCrashing if StartLoad happens in an MHTML. > > MHTML documents should never trigger HTML requests. Let's double-check > this with an explicit DumpWithoutCrashing added in this CL. > > Bug: 1151438 > Change-Id: I7a518308d85d58cb15deeec579df2f1c41e6abb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597028 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838787} TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151438 Change-Id: I202fc1fdc6972ae6b028d4e89b4d827663d3e06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624532Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842656}
-
Tommy Martino authored
This adds a helper function that platforms can use to determine if the current site's URL should prevent the Link to Text feature from being offered. This will be called in a follow-up by platform-specific code that enables/disables the option. For the time being, we expect the number of sites affected to be very small and will reevaluate if the list gets longer than ~a dozen. Eventually we'd like to make this more dynamic (possibly delivering the URLs and regexes from a server), but this version is meant to get a very quick spot fix out the door. Bug: 1157981 Change-Id: I1785459b298d93528415d8735aaa01c4d7a7769e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587432Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842655}
-
Ionel Popescu authored
This CL removes the hover effects for controls on Android since it isn't really applicable for touch screen devices. In the future we could further refine the behavior for desktop that have touch support to differentiate based on the available pointing devices, but since we haven't received any feedback I will not update the behavior for now. Bug: 1160076 Change-Id: Id1fe4b9e2c9dfc226c7183584cc44fa23df76661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622840Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842654}
-
Dana Fried authored
LayoutManagerBase::GetAvailableSize(host, child) will now do the following: - as before, if the cached layout is still valid since the last call to Layout(), it will return the available size of |child| in |host|'s layout - if the layout has been invalidated since the last call to Layout(), a new cached layout for |host| is calculated, which will be used in the next call to Layout() assuming the layout is not invalidated again This gives us two guarantees we did not have before: 1. instead of returning [no bounds], a correct size bound will almost always be returned 2. a safeguard is in place to ensure that we don't get a stale value during |host|'s layout calculation - in fact, we no longer allow the method to be called during |host|'s layout calculation (it will DCHECK()) In general it is legal to call GetAvailableSize() during |child|'s Layout() - which happens after |host|'s layout is committed - but not during, for example, a FlexRule computation. It doesn't make sense for a FlexRule (or similar) to call GetAvailableSize() because it already receives a size bound from the caller. This also fixes a potential issue (related to crbug.com/1041614) which could result in a view calling layout code in response to certain types of widget setup (among other possible situations) before the layout's child data is updated, resulting in a DCHECK() or crash in the layout manager. (For at least the short term an example crash can be found here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8858322112097966752/+/steps/unit_tests__with_patch_/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.HasTitleAndTwoButtons__status_CRASH_/0) Change-Id: I3e491c3cb7a648867597ecf830fe52d11f483419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622720 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842653}
-
Daniel Hosseinian authored
Polish the properties dialog to gracefully handle long values. Per UX guidance, set the max width of values to 300px and ellipse the rest by default. "Keywords" will later override the CSS to wrap instead of ellipsing. Screenshot: https://imgur.com/a/wD5sMrt Bug: 93619 Change-Id: Iab80a500c596447da8648871e2105b1b649d64f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622581 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Ben Pastene authored
The builder was duplicated on chromium.memory with: https://chromium-review.googlesource.com/c/chromium/src/+/2615132 This deletes the old builder now that the new one is running green: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr Bug: 1137496 Change-Id: Id7c6a1a520671124d4618b9d30dd12cb68b0ee97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615665Reviewed-by:
-
